Web ant97 2022 03 01 #19430
Merged
Web ant97 2022 03 01 #19430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o version 2022-03-01
#18460) * Carry fwd Microsoft.CertificateRegistration and Microsoft.DomainRegistration RPs to Api-version 2022-03-01 * Add x-ms-enum for array of inline enums. Fix reference to older api version for common defs * Add examples for App Service Certificate orders * Add suppressions back * Add examples for Microsoft.DomainRegistration RP * Fixes from prettier * Remove unused example
…bled site properties to CommonDefinitions (#18627) * Added vnet realted site properties to common definitions * removed tab Co-authored-by: Tanay Bhartia <tanaybhartia@microsoft.com>
* Add Ftp/Remote debug properties to Ase network config * Switched changes to the right file * Add Networking config to hosting environment creates * Added some of the missing examples * Remove disallowed properties from example Ase GET response * Adjusted responses from other gets * Added a bunch more examples * Added other missing examples for Ase. * Added more missing examples for Ase. * fixed formatting * Edit some examples, add back privatelink apis and try to supress the errors for missing examples. * Fix suppress spelling and fix prettier * Added missing privatelink examples since suppressing did not work
* add bring your own backend operations * add missing files * fix json formattin * validation fixes * fix * fix more validation * fix ids * fix model validation * fix descriptions * fix environmentName description * change to 202 * revert change to 202
* fix DUPLICATE_PARAMETER * prettier * fix OBJECT_ADDITIONAL_PROPERTIES * fix random sub in examples * add optional hostname param to customHostnameSites RT and add examples * move changes from 2021 api version to 2022 * move examples to 2022 * Revert "add optional hostname param to customHostnameSites RT and add examples" This reverts commit 7fc318e. * remove examples from 2021 * fix lintDiff * prettier fix * model validation fix * suppress model validation in readme Co-authored-by: Elle Tojaroon <patojaro@microsoft.com>
* [Microsoft.Web] Add CustomDnsSuffixConfiguration to AppServiceEnvironments * Add examples * Fix style issues * Add customdnssuffix to custom-words * Add CustomDnsSuffixConfiguration to AppServiceEnvironment definition * Address remaining model validation errors * Adjusted networking configuration definitions * Addressed Arm review feedback Co-authored-by: Jarod Aerts <jarodaerts@microsoft.com>
* Added DeploymentStatus API specs and examples * change status to enum, rm extra dot * suppress missing examples for now * rm id from List Deployment Slot examples * rm location, and rename deploymentId in GetSiteDeploymentStatus examples * change model as string to true, add 202 operations for DeploymentStatus ops to spec * rename operationId to deploymentStatusId, undo deploymentId rename * add long running op, as per linter Co-authored-by: Shubham Dhond <shdhond@microsoft.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com>
* add publicNetworkAccess property in site for swagger * add suppression to fix Model Validation CI * Add allowed values in the description
* Add documentation for Hosting Environment Maintenance Control * Update example file name * Make UpgradePreference non-nullable * Correct indentation to 2 spaces * Fix upgradePreference indentation * Address swagger feedback. Add enums with descriptions. * Move testNotification to request body. Update description text * Fix testNotification * Fix example * Replace TestNotification parameter with TestUpgradeNotification API * Rename to TestUpgradeAvailableNotification
* Added Initial Operations and some definitions * Adding additional objects to support Logic Apps operations * Updated path and parameters to match testing * Prettier Fixes * oav validat-example fixes * Github validation fixes * Prettier * Updated examples and paths * Prettier * Revert "Prettier" This reverts commit da090ad. * Prettier * Fixed model validation errors * Filled in nextLinkName values * Fixing swagger lintdiff errors * added x-ms-long-running to async calls
|
Hi, @naveedaz Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
Click detail for error messages. Exception contact vsswagger@microsoft.com or https://aka.ms/swaggersupport. |
️⚠️SDK Track2 Validation: 63 Warnings warning [Detail]
- The following tags are being changed in this PR
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.0.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.1.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.2.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.3.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.4.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.5.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.6.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.7.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.8.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.9.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.10.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.11.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.12.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.13.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.14.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.15.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.16.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.17.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.18.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.19.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.20.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.21.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.22.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.23.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.24.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.25.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.26.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.27.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.28.suppress which is deprecated and will be removed in the future." |
|
| "readme":"web/resource-manager/readme.md", "tag":"package-2022-03", "details":"Using directive.29.suppress which is deprecated and will be removed in the future." |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @naveedaz, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Jun 13, 2022
Closed
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Trying rerun the CI to see why fail in SemanticValidation. Do we have owner from AppServicePlans.json and WebApps.json? Here is 2 customer issue that likely caused by incorrect/incomplete swagger. Checking if we can at least add the "addition" one into 2022-03-01. One is on AppServicePlans, which only adds a property (that might be missing from swagger but exists in backend). Another one is on WebApps, seems fixing an incorrect swagger (that involved breaking change review, but apparently customer not able to do that). |
|
cross-version breaking changes already approved in PR #18460 |
* Adds numberOfWorkers to app service plan * Add suppression for missing ASP examples
This was referenced Jun 16, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…Definitions.json (#19507) * Removed conflicting resource definition and added reference to CommonDefinitions.json * Updated resource to have workflow version
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
weidongxu-microsoft
approved these changes
Jun 21, 2022
|
@naveedaz, @weidongxu-microsoft -- What's your rough estimate on when we'll get this merged, are we looking at this week or into July? @naveedaz -- It looks like this new API version renames the RP's (web/sites to WebApps). Does this mean the package and method names will change on the client SDKs? |
|
Error in ModelValidation would require either adding examples, or suppression in readme. @alexkarcher-msft for verify whether the pagination with POST would require POST or GET in {nextLink} query. |
* Updated nextLink object to be correctly tagged * Adding value placeholder * Updated SKU to remove conflict * Updated x-ms-enum * Added missing model * Adding more missing models
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
weidongxu-microsoft
added
the
Approved-OkToMerge
This was referenced Jun 24, 2022
Closed
Closed
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.