Update automation rules alert trigger swagger #19388

dosiso · 2022-06-09T07:22:11Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. April 22.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. July 22.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-06-09T07:22:14Z

Hi, @dosiso Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-workflow-bot · 2022-06-09T07:22:14Z

Hi, @dosiso Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2022-06-09T07:22:15Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
- securityinsights/resource-manager/readme.md tag:package-preview-2022-07
Linted configuring files (Based on target branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
- securityinsights/resource-manager/readme.md tag:package-preview-2022-07

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ R3017 - GuidUsage	Guid used in model definition 'ManualTriggerRequestBody' for property 'tenantId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L1046
⚠️ R3017 - GuidUsage	Guid used in model definition 'PlaybookActionProperties' for property 'tenantId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L1062
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isEnabled Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L954
⚠️ R4000 - ParameterDescriptionRequired	'incidentIdentifier' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L246
⚠️ R4000 - ParameterDescriptionRequired	'requestBody' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L252
⚠️ R4021 - DescriptionAndTitleMissing	'AutomationRule' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L306
⚠️ R4021 - DescriptionAndTitleMissing	'order' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L332
⚠️ R4021 - DescriptionAndTitleMissing	'AutomationRulePropertyArrayChangedConditionSupportedArrayType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L428
⚠️ R4021 - DescriptionAndTitleMissing	'AutomationRulePropertyArrayChangedConditionSupportedChangeType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L460
⚠️ R4021 - DescriptionAndTitleMissing	'AutomationRulePropertyArrayChangedValuesCondition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L477
⚠️ R4021 - DescriptionAndTitleMissing	'AutomationRulePropertyChangedConditionSupportedChangedType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L488
⚠️ R4021 - DescriptionAndTitleMissing	'AutomationRulePropertyChangedConditionSupportedPropertyType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L510
⚠️ R4021 - DescriptionAndTitleMissing	'AutomationRulePropertyConditionSupportedOperator' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L537
⚠️ R4021 - DescriptionAndTitleMissing	'AutomationRulePropertyValuesChangedCondition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L877
⚠️ R4021 - DescriptionAndTitleMissing	'propertyValues' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L889
⚠️ R4021 - DescriptionAndTitleMissing	'AutomationRulePropertyValuesCondition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L897
⚠️ R4021 - DescriptionAndTitleMissing	'propertyValues' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L906
⚠️ R4021 - DescriptionAndTitleMissing	'AutomationRulesList' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L931
⚠️ R4021 - DescriptionAndTitleMissing	'value' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L934
⚠️ R4021 - DescriptionAndTitleMissing	'nextLink' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L940
⚠️ R4021 - DescriptionAndTitleMissing	'ConditionType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L982
⚠️ R4021 - DescriptionAndTitleMissing	'IncidentPropertiesAction' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L1009
⚠️ R4021 - DescriptionAndTitleMissing	'ManualTriggerRequestBody' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L1043
⚠️ R4021 - DescriptionAndTitleMissing	'tenantId' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L1046
⚠️ R4021 - DescriptionAndTitleMissing	'logicAppsResourceId' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L1050
⚠️ R4021 - DescriptionAndTitleMissing	'PlaybookActionProperties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L1055
⚠️ R4021 - DescriptionAndTitleMissing	'triggersOn' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L1120
⚠️ R4021 - DescriptionAndTitleMissing	'triggersWhen' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.SecurityInsights/preview/2022-07-01-preview/AutomationRules.json#L1142

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.9.5)
- current:preview/2022-07-01-preview/AutomationRules.json compared with base:stable/2021-10-01/AutomationRules.json
- current:preview/2022-07-01-preview/AutomationRules.json compared with base:preview/2022-06-01-preview/AutomationRules.json

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

securityinsights/resource-manager/readme.md#package-preview-2022-07

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-06-09T07:22:15Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️⚠️SDK Breaking Change Tracking warning [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-go-track2 - armsecurityinsights - 2.0.0-beta.2
⚠️azure-sdk-for-python-track2 - track2_azure-mgmt-securityinsight - 1.0.0b2

+	Model EntityAnalytics no longer has parameter is_enabled

⚠️azure-sdk-for-js - @azure/arm-securityinsight - 1.0.0-beta.4

+	Removed Enum KnownEnum12
+	Removed Enum KnownProvisioningState
+	Removed Enum KnownSkuKind
+	Type Alias EntityAnalytics no longer has parameter isEnabled
+	Type Alias Watchlist no longer has parameter provisioningState
+	Type Alias Watchlist no longer has parameter sasUri

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs] Generate from 65065ef295c9ec296b26e31a7a1fd95975cc7d42. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed

️❌ azure-sdk-for-go failed [Detail]

❌Failed [Logs] Generate from 65065ef295c9ec296b26e31a7a1fd95975cc7d42. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
cmderr	[generator automation] [AUTOREST] FATAL: swagger-document/compose - FAILED
cmderr	[generator automation] [AUTOREST] FATAL: Error: '$.definitions.Sku.description' has incompatible values (---
cmderr	[generator automation] [AUTOREST] The resource model definition representing SKU
cmderr	[generator automation] [AUTOREST] , ---
cmderr	[generator automation] [AUTOREST] The pricing tier of the solution
cmderr	[generator automation] [AUTOREST] ).
cmderr	[generator automation] [AUTOREST]   Error: '$.definitions.Sku.description' has incompatible values (---
cmderr	[generator automation] [AUTOREST] The resource model definition representing SKU
cmderr	[generator automation] [AUTOREST] , ---
cmderr	[generator automation] [AUTOREST] The pricing tier of the solution
cmderr	[generator automation] [AUTOREST] ).
cmderr	[generator automation] [ERROR] total 1 error(s):
cmderr	[generator automation] [ERROR] failed to execute autorest: autorest error with arguments '--use=@microsoft.azure/autorest.go@2.1.187, --go, --verbose, --go-sdk-folder=., --use-onever, --version=2.0.4421, --go.license-header=MICROSOFT_MIT_NO_VERSION, --enum-prefix, --tag=package-preview-2022-01, --metadata-output-folder=/mnt/vss/_work/1/s/azure-sdk-for-go_tmp/generation-metadata-1654759726/package-preview-2022-01, ../../../../../azure-rest-api-specs/specification/securityinsights/resource-manager/readme.md':
cmderr	[generator automation] [ERROR] exit status 1
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation
warn	Skip package processing as generation is failed

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 65065ef295c9ec296b26e31a7a1fd95975cc7d42. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armsecurityinsights [View full logs] [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `AutomationRulePropertyConditionSupportedPropertyAlertAnalyticRuleIDs`
info	[Changelog] - New const `TriggersOnAlerts`
info	[Changelog] - New field `DataCollectionRuleImmutableID` in struct `DataConnectorConnectBody`
info	[Changelog] - New field `OutputStream` in struct `DataConnectorConnectBody`
info	[Changelog] - New field `DataCollectionEndpoint` in struct `DataConnectorConnectBody`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 3 additive change(s).

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 65065ef295c9ec296b26e31a7a1fd95975cc7d42. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.

️✔️track2_azure-mgmt-securityinsight [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group SecurityMLAnalyticsSettingsOperations
info	[Changelog]   - Model DataConnectorConnectBody has a new parameter data_collection_endpoint
info	[Changelog]   - Model DataConnectorConnectBody has a new parameter data_collection_rule_immutable_id
info	[Changelog]   - Model DataConnectorConnectBody has a new parameter output_stream
info	[Changelog]   - Model EntityAnalytics has a new parameter entity_providers
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model EntityAnalytics no longer has parameter is_enabled

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs] Generate from 65065ef295c9ec296b26e31a7a1fd95975cc7d42. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] npm WARN deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-securityinsight [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-securityinsight-1.0.0-beta.4.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group SecurityMLAnalyticsSettings
info	[Changelog]   - Added Interface AutomationRulePropertyArrayChangedValuesCondition
info	[Changelog]   - Added Interface AutomationRulePropertyValuesChangedCondition
info	[Changelog]   - Added Interface GetInsightsErrorKind
info	[Changelog]   - Added Interface SecurityMLAnalyticsSettingsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface SecurityMLAnalyticsSettingsDataSource
info	[Changelog]   - Added Interface SecurityMLAnalyticsSettingsDeleteOptionalParams
info	[Changelog]   - Added Interface SecurityMLAnalyticsSettingsGetOptionalParams
info	[Changelog]   - Added Interface SecurityMLAnalyticsSettingsList
info	[Changelog]   - Added Interface SecurityMLAnalyticsSettingsListNextOptionalParams
info	[Changelog]   - Added Interface SecurityMLAnalyticsSettingsListOptionalParams
info	[Changelog]   - Added Type Alias AnomalySecurityMLAnalyticsSettings
info	[Changelog]   - Added Type Alias AnomalyTimelineItem
info	[Changelog]   - Added Type Alias AutomationRulePropertyArrayChangedConditionSupportedArrayType
info	[Changelog]   - Added Type Alias AutomationRulePropertyArrayChangedConditionSupportedChangeType
info	[Changelog]   - Added Type Alias AutomationRulePropertyChangedConditionSupportedChangedType
info	[Changelog]   - Added Type Alias AutomationRulePropertyChangedConditionSupportedPropertyType
info	[Changelog]   - Added Type Alias EntityProviders
info	[Changelog]   - Added Type Alias Enum13
info	[Changelog]   - Added Type Alias GetInsightsError
info	[Changelog]   - Added Type Alias PropertyArrayChangedConditionProperties
info	[Changelog]   - Added Type Alias PropertyChangedConditionProperties
info	[Changelog]   - Added Type Alias SecurityMLAnalyticsSetting
info	[Changelog]   - Added Type Alias SecurityMLAnalyticsSettingsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias SecurityMLAnalyticsSettingsGetResponse
info	[Changelog]   - Added Type Alias SecurityMLAnalyticsSettingsKind
info	[Changelog]   - Added Type Alias SecurityMLAnalyticsSettingsListNextResponse
info	[Changelog]   - Added Type Alias SecurityMLAnalyticsSettingsListResponse
info	[Changelog]   - Added Type Alias SecurityMLAnalyticsSettingUnion
info	[Changelog]   - Added Type Alias SettingsStatus
info	[Changelog]   - Interface DataConnectorConnectBody has a new optional parameter dataCollectionEndpoint
info	[Changelog]   - Interface DataConnectorConnectBody has a new optional parameter dataCollectionRuleImmutableId
info	[Changelog]   - Interface DataConnectorConnectBody has a new optional parameter outputStream
info	[Changelog]   - Class SecurityInsights has a new parameter securityMLAnalyticsSettings
info	[Changelog]   - Type Alias EntityAnalytics has a new parameter entityProviders
info	[Changelog]   - Added Enum KnownAutomationRulePropertyArrayChangedConditionSupportedArrayType
info	[Changelog]   - Added Enum KnownAutomationRulePropertyArrayChangedConditionSupportedChangeType
info	[Changelog]   - Added Enum KnownAutomationRulePropertyChangedConditionSupportedChangedType
info	[Changelog]   - Added Enum KnownAutomationRulePropertyChangedConditionSupportedPropertyType
info	[Changelog]   - Added Enum KnownEntityProviders
info	[Changelog]   - Added Enum KnownEnum13
info	[Changelog]   - Added Enum KnownGetInsightsError
info	[Changelog]   - Added Enum KnownSecurityMLAnalyticsSettingsKind
info	[Changelog]   - Added Enum KnownSettingsStatus
info	[Changelog]   - Enum KnownAutomationRulePropertyConditionSupportedProperty has a new value AlertAnalyticRuleIds
info	[Changelog]   - Enum KnownConditionType has a new value PropertyArrayChanged
info	[Changelog]   - Enum KnownConditionType has a new value PropertyChanged
info	[Changelog]   - Enum KnownEntityTimelineKind has a new value Anomaly
info	[Changelog]   - Enum KnownTriggersOn has a new value Alerts
info	[Changelog]   - Enum KnownTriggersWhen has a new value Updated
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Type Alias EntityAnalytics no longer has parameter isEnabled
info	[Changelog]   - Type Alias Watchlist no longer has parameter sasUri
info	[Changelog]   - Type Alias Watchlist no longer has parameter provisioningState
info	[Changelog]   - Removed Enum KnownEnum12
info	[Changelog]   - Removed Enum KnownProvisioningState
info	[Changelog]   - Removed Enum KnownSkuKind

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 65065ef295c9ec296b26e31a7a1fd95975cc7d42. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

️✔️azure-resourcemanager-securityinsights [View full logs] [Preview SDK Changes]

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from 65065ef295c9ec296b26e31a7a1fd95975cc7d42. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️securityinsights [View full logs] [Preview Schema Changes]

️❌ azure-powershell failed [Detail]

❌Failed [Logs] Generate from 65065ef295c9ec296b26e31a7a1fd95975cc7d42. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

❌Az.securityinsights [View full logs] [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-06-09T07:22:16Z

Hi, @dosiso your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

openapi-workflow-bot · 2022-06-09T07:22:16Z

Hi, @dosiso your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

raosuhas · 2022-06-10T00:57:22Z

Please set the checkmarks correctly on the PR. This is not a new api version. This is an update to an existing version and does not need armreview

dosiso · 2022-06-10T09:15:22Z

Please set the checkmarks correctly on the PR. This is not a new api version. This is an update to an existing version and does not need armreview

@raosuhas
This PR is headed to an aggregative development branch for the release of a new API version (2022-07-01-preview), in which all PRs are being reviewed by ARM. We do this to make the review process more manageable as we have many changes across different teams. This is the way we have been working with ARM for all versions.

raosuhas · 2022-06-10T21:03:12Z

Please set the checkmarks correctly on the PR. This is not a new api version. This is an update to an existing version and does not need armreview

@raosuhas This PR is headed to an aggregative development branch for the release of a new API version (2022-07-01-preview), in which all PRs are being reviewed by ARM. We do this to make the review process more manageable as we have many changes across different teams. This is the way we have been working with ARM for all versions.

Signing off. Can you please add this info in the PR going forward ?

dosiso · 2022-06-11T08:44:39Z

@dw511214992 can we move forward with merging this PR if no additional issues exist?

* Adds base for updating Microsoft.SecurityInsights from version preview/2022-06-01-preview to version 2022-07-01-preview * Updates readme * Updates API version in new specs and examples * Added Nic entity type and IoT Device properties to EntityTypes.json (#19391) * added Nic entity type + modified IoTDevice props * updated GetIoTDeviceEntity example fields * ran prettier Co-authored-by: Natanel Mizrahi <natanel.mizrahi@gmail.com> * Update automation rules alert trigger swagger (#19388) Co-authored-by: nmizrahi6 <100570740+nmizrahi6@users.noreply.github.com> Co-authored-by: Natanel Mizrahi <natanel.mizrahi@gmail.com> Co-authored-by: Dor Siso <60354892+dosiso@users.noreply.github.com>

Update automation rules alert trigger swagger

0698a8c

openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 9, 2022

This was referenced Jun 9, 2022

[AutoPR armsecurityinsights] Update automation rules alert trigger swagger azure-sdk/azure-sdk-for-go#1382

Closed

[AutoPR track2_azure-mgmt-securityinsight] Update automation rules alert trigger swagger azure-sdk/azure-sdk-for-python#555

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Jun 9, 2022

dosiso marked this pull request as ready for review June 9, 2022 07:34

openapi-assignment-bot bot assigned dw511214992 Jun 9, 2022

azure-sdk mentioned this pull request Jun 9, 2022

[AutoPR @azure/arm-securityinsight] Update automation rules alert trigger swagger azure-sdk/azure-sdk-for-js#802

Closed

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Jun 9, 2022

dosegal requested a review from ityankel June 9, 2022 07:57

raosuhas removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 10, 2022

openapi-workflow-bot bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 10, 2022

raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 10, 2022

openapi-workflow-bot bot removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 10, 2022

dw511214992 approved these changes Jun 14, 2022

View reviewed changes

dw511214992 merged commit 6747583 into Azure:dev-Sentinel-2022-07-01-preview Jun 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update automation rules alert trigger swagger #19388

Update automation rules alert trigger swagger #19388

dosiso commented Jun 9, 2022 •

edited

Loading

openapi-workflow-bot bot commented Jun 9, 2022

openapi-workflow-bot bot commented Jun 9, 2022

openapi-pipeline-app bot commented Jun 9, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jun 9, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Jun 9, 2022

openapi-workflow-bot bot commented Jun 9, 2022

raosuhas commented Jun 10, 2022

dosiso commented Jun 10, 2022

raosuhas commented Jun 10, 2022

dosiso commented Jun 11, 2022

Update automation rules alert trigger swagger #19388

Update automation rules alert trigger swagger #19388

Conversation

dosiso commented Jun 9, 2022 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jun 9, 2022

openapi-workflow-bot bot commented Jun 9, 2022

openapi-pipeline-app bot commented Jun 9, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jun 9, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Jun 9, 2022

openapi-workflow-bot bot commented Jun 9, 2022

raosuhas commented Jun 10, 2022

dosiso commented Jun 10, 2022

raosuhas commented Jun 10, 2022

dosiso commented Jun 11, 2022

dosiso commented Jun 9, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jun 9, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jun 9, 2022 •

edited

Loading