Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET snapshot-Changed CopyCompletionError enum name #19227

Conversation

haagha
Copy link
Member

@haagha haagha commented May 25, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @haagha Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 25, 2022

    Swagger Validation Report

    ️⌛BreakingChange pending [Detail]
    ️⌛LintDiff pending [Detail]
    ️⌛Avocado pending [Detail]
    ️⌛ModelValidation pending [Detail]
    ️⌛SemanticValidation pending [Detail]
    ️⌛Cross-Version Breaking Changes pending [Detail]
    ️⌛SDK Track2 Validation pending [Detail]
    ️⌛PrettierCheck pending [Detail]
    ️⌛SpellCheck pending [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 25, 2022

    Swagger Generation Artifacts

    ️⌛ApiDocPreview pending [Detail]
    ️⚠️SDK Breaking Change Tracking warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-java warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-js failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-go-track2 failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-resource-manager-schemas warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-powershell failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @haagha haagha merged commit 9e39aae into Azure:diskrp-2022-03-02 May 25, 2022
    ArcturusZhang pushed a commit that referenced this pull request May 30, 2022
    * new version folder
    
    * new version folder
    
    * sync with diskRP 2021-12-01 changes
    
    * Update creationData description  (#18050)
    
    * Update diskRPCommon.json
    
    * Update diskRPCommon.json
    
    * adding SecurityProfile in DiskRestorePointProperties (#18826)
    
    * add cross-tenant feature (#18718)
    
    * add cross-tenant feature
    
    * fix filename typo
    
    * prettier
    
    * Swagger changes for PremiumV2 in DiskRP (#18786)
    
    * Swagger changes for PremiumV2 in DiskRP
    
    * Added new property copyCompletionError
    
    * Updated description for new property copyCompletionError
    
    * Added the type as object for CopyCompletionError
    
    * Addressed comment to update the description for CopySourceNotFound
    
    Co-authored-by: akashpargat <akashpargat@microsoft.com>
    
    * Add new Azure Compute Gallery image ids to ImageDiskReference for PutDisk Support in 2022-03-02 Api Version (#18868)
    
    * new sig ids for put disk 2022-03-02
    
    * fix errors and add example path
    
    * extra space
    
    * remove required id
    
    * prettify common
    
    Co-authored-by: Jerry Chan <jerch@microsoft.com>
    
    * Feature/cplat 2022 03 02 (#18945)
    
    * add cross-tenant feature
    
    * fix filename typo
    
    * prettier
    
    * add federatedClientId to diskEncryptionSetUpdateProperties
    
    * New ApI Version
    
    * Readme changes
    
    * adding SecurityProfile in DiskRestorePointProperties (#18826)
    
    * add cross-tenant feature (#18718)
    
    * add cross-tenant feature
    
    * fix filename typo
    
    * prettier
    
    * Swagger changes for PremiumV2 in DiskRP (#18786)
    
    * Swagger changes for PremiumV2 in DiskRP
    
    * Added new property copyCompletionError
    
    * Updated description for new property copyCompletionError
    
    * Added the type as object for CopyCompletionError
    
    * Addressed comment to update the description for CopySourceNotFound
    
    Co-authored-by: akashpargat <akashpargat@microsoft.com>
    
    * Add new Azure Compute Gallery image ids to ImageDiskReference for PutDisk Support in 2022-03-02 Api Version (#18868)
    
    * new sig ids for put disk 2022-03-02
    
    * fix errors and add example path
    
    * extra space
    
    * remove required id
    
    * prettify common
    
    Co-authored-by: Jerry Chan <jerch@microsoft.com>
    
    * Feature/cplat 2022 03 02 (#18945)
    
    * add cross-tenant feature
    
    * fix filename typo
    
    * prettier
    
    * add federatedClientId to diskEncryptionSetUpdateProperties
    
    * GET snapshot-Changed CopyCompletionError enum name (#19160)
    
    Co-authored-by: Karan Manish Thakkar <kathakkar@microsoft.com>
    
    * move UserAssignedIdentities to common.json to fix duplicate definition
    
    * update readme with gallery 2022-01-03
    
    * sync with past updates
    
    * update with description for object
    
    * fix readme
    
    * GET snapshot-Changed CopyCompletionError enum name (#19227)
    
    Co-authored-by: Karan Manish Thakkar <kathakkar@microsoft.com>
    
    * fixing readme.md
    
    * fix vmss userAssignedIdentities duplicate definition
    
    Co-authored-by: Theodore Chang <thchan@microsoft.com>
    Co-authored-by: anshulsolanki21 <73930854+anshulsolanki21@users.noreply.github.com>
    Co-authored-by: parkhyukjun89 <hyupar@microsoft.com>
    Co-authored-by: Akash Pargat <akashpargat@yahoo.com>
    Co-authored-by: akashpargat <akashpargat@microsoft.com>
    Co-authored-by: jerryc3 <48365571+jerryc3@users.noreply.github.com>
    Co-authored-by: Jerry Chan <jerch@microsoft.com>
    Co-authored-by: Karan Manish Thakkar <kkaran.thakkar@gmail.com>
    Co-authored-by: Karan Manish Thakkar <kathakkar@microsoft.com>
    Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants