Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Making Application Gateway rule priority a required field" #19101

Merged
merged 1 commit into from
May 17, 2022
Merged

Revert "Making Application Gateway rule priority a required field" #19101

merged 1 commit into from
May 17, 2022

Conversation

vinaymundada27
Copy link
Contributor

Reverts #19007

'Priority' field cannot be made required since Application Gateway V1 SKU and V2 SKU have the same api spec but V1 sku does not support this field and would break the V1 gateways. Only V2 sku needs to have the 'Priority' field as mandatory and there is no way to conditionally make the field optional/required based on the SKU. Hence reverting this change.

@openapi-workflow-bot
Copy link

Hi, @vinaymundada27 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 17, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L919
    ❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L955
    ❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L991
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L2542
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L2542
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewayOnDemandProbe' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1156
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewayBackendHealthOnDemand' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1194
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewayBackendHealth' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1207
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewayBackendHealthPool' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1219
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewayBackendHealthHttpSettings' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1235
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewayBackendHealthServer' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1251
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewaySku' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1283
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewaySku' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1283
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewaySslPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1324
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewaySslPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1324
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewayClientAuthConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1364
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewayClientAuthConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1364
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    ❌ R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2021-08-01/applicationGateway.json#L1373
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the Network label May 17, 2022
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 17, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armnetwork - 1.0.1
    ❌azure-sdk-for-js - @azure/arm-network - 28.0.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-08-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-05-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-03-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2021-02-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-11-01/network - v64.1.0
    ❌azure-sdk-for-go - network/mgmt/2020-08-01/network - v64.1.0
    +	Field `ExtendedLocation` of struct `VirtualNetworkGatewayPropertiesFormat` has been removed
+	Field `VirtualNetworkExtendedLocationResourceID` of struct `VirtualNetworkGatewayPropertiesFormat` has been removed
+	Type of `SubnetPropertiesFormat.PrivateEndpointNetworkPolicies` has been changed from `*string` to `VirtualNetworkPrivateEndpointNetworkPolicies`
+	Type of `SubnetPropertiesFormat.PrivateLinkServiceNetworkPolicies` has been changed from `*string` to `VirtualNetworkPrivateLinkServiceNetworkPolicies`
    ❌azure-sdk-for-go - network/mgmt/2020-07-01/network - v64.1.0
    +	Field `ExtendedLocation` of struct `VirtualNetworkGatewayPropertiesFormat` has been removed
+	Field `VirtualNetworkExtendedLocationResourceID` of struct `VirtualNetworkGatewayPropertiesFormat` has been removed
+	Type of `SubnetPropertiesFormat.PrivateEndpointNetworkPolicies` has been changed from `*string` to `VirtualNetworkPrivateEndpointNetworkPolicies`
+	Type of `SubnetPropertiesFormat.PrivateLinkServiceNetworkPolicies` has been changed from `*string` to `VirtualNetworkPrivateLinkServiceNetworkPolicies`
    ️✔️azure-sdk-for-go - network/mgmt/2020-06-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-05-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-04-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2020-03-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-12-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-11-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-09-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-08-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-07-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-06-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-04-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2019-02-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-12-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-11-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-10-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-08-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-07-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-06-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-04-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-02-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2018-01-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2017-11-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2017-10-01/network - v64.1.0
    ️✔️azure-sdk-for-go - network/mgmt/2015-06-15/network - v64.1.0
    ️✔️azure-sdk-for-go - preview/network/mgmt/2021-03-01-preview/network - v64.1.0
    ️✔️azure-sdk-for-go - preview/network/mgmt/2021-02-01-preview/network - v64.1.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-network - 20.0.0
    ️❌ azure-sdk-for-net-track2 failed [Detail]   
  
    • ❌Failed [Logs]Release - Generate from 6443eb2. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
command	pwsh ./eng/scripts/Automation-Sdk-Generate.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Automation-Sdk-Generate.ps1] �[91mWrite-Error: �[91mError occurred while generating code for Azure.ResourceManager.Network
cmderr	[Automation-Sdk-Generate.ps1] �[0m
    • ❌Azure.ResourceManager.Network        [View full logs]         [Release SDK Changes]      
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 6443eb2. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-network        [View full logs]         [Release SDK Changes]      
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 6443eb2. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
    • ️✔️azure-resourcemanager-network-generated        [View full logs]         [Release SDK Changes]      
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs]Release - Generate from 6443eb2. SDK Automation 14.0.0 
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️network/mgmt/2021-08-01/network        [View full logs]         [Release SDK Changes]      
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2021-05-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2021-03-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2021-02-01/network        [View full logs]       
            Only show 4 items here, please refer to log for details.
      info	[Changelog] - New field `ResourceGUID` in struct `PrivateLinkServiceProperties`
info	[Changelog] - New field `ProvisioningState` in struct `PrivateDNSZonePropertiesFormat`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
    • ️✔️network/mgmt/2020-11-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-08-01/network        [View full logs]       
            Only show 4 items here, please refer to log for details.
      info	[Changelog] - New field `Type` in struct `VirtualNetworkPeering`
info	[Changelog] - New field `VNetExtendedLocationResourceID` in struct `VirtualNetworkGatewayPropertiesFormat`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 35 additive change(s).
    • ️✔️network/mgmt/2020-07-01/network        [View full logs]       
            Only show 4 items here, please refer to log for details.
      info	[Changelog] - New field `PrivateLinkService` in struct `InterfacePropertiesFormat`
info	[Changelog] - New field `NicType` in struct `InterfacePropertiesFormat`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 27 additive change(s).
    • ️✔️network/mgmt/2020-06-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-05-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-04-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2020-03-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-12-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-11-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-09-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-08-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-07-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-06-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-04-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2019-02-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-12-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-11-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-10-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-08-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-07-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-06-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-04-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-02-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2018-01-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2017-11-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2017-10-01/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️network/mgmt/2015-06-15/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/network/mgmt/2021-03-01-preview/network        [View full logs]       
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/network/mgmt/2021-02-01-preview/network        [View full logs]       
      info	[Changelog] This is a new package
info	[Changelog]
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs]Release - Generate from 6443eb2. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armnetwork        [View full logs]         [Release SDK Changes]      
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 6443eb2. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh]  @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] WARN deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-network        [View full logs]         [Release SDK Changes]        Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group ConfigurationPolicyGroups
info	[Changelog]   - Added operation group ExpressRoutePortAuthorizations
info	[Changelog]   - Added operation FirewallPolicies.updateTags
info	[Changelog]   - Added Interface ConfigurationPolicyGroupsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface ConfigurationPolicyGroupsDeleteOptionalParams
info	[Changelog]   - Added Interface ConfigurationPolicyGroupsGetOptionalParams
info	[Changelog]   - Added Interface ConfigurationPolicyGroupsListByVpnServerConfigurationNextOptionalParams
info	[Changelog]   - Added Interface ConfigurationPolicyGroupsListByVpnServerConfigurationOptionalParams
info	[Changelog]   - Added Interface ExpressRoutePortAuthorizationListResult
info	[Changelog]   - Added Interface ExpressRoutePortAuthorizationsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface ExpressRoutePortAuthorizationsDeleteOptionalParams
info	[Changelog]   - Added Interface ExpressRoutePortAuthorizationsGetOptionalParams
info	[Changelog]   - Added Interface ExpressRoutePortAuthorizationsListNextOptionalParams
info	[Changelog]   - Added Interface ExpressRoutePortAuthorizationsListOptionalParams
info	[Changelog]   - Added Interface FirewallPoliciesUpdateTagsOptionalParams
info	[Changelog]   - Added Interface GatewayCustomBgpIpAddressIpConfiguration
info	[Changelog]   - Added Interface ListVpnServerConfigurationPolicyGroupsResult
info	[Changelog]   - Added Interface VpnServerConfigurationPolicyGroupMember
info	[Changelog]   - Added Type Alias ApplicationGatewayBackendSettings
info	[Changelog]   - Added Type Alias ApplicationGatewayListener
info	[Changelog]   - Added Type Alias ApplicationGatewayRoutingRule
info	[Changelog]   - Added Type Alias ConfigurationPolicyGroupsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias ConfigurationPolicyGroupsGetResponse
info	[Changelog]   - Added Type Alias ConfigurationPolicyGroupsListByVpnServerConfigurationNextResponse
info	[Changelog]   - Added Type Alias ConfigurationPolicyGroupsListByVpnServerConfigurationResponse
info	[Changelog]   - Added Type Alias ExpressRoutePortAuthorization
info	[Changelog]   - Added Type Alias ExpressRoutePortAuthorizationsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias ExpressRoutePortAuthorizationsGetResponse
info	[Changelog]   - Added Type Alias ExpressRoutePortAuthorizationsListNextResponse
info	[Changelog]   - Added Type Alias ExpressRoutePortAuthorizationsListResponse
info	[Changelog]   - Added Type Alias ExpressRoutePortAuthorizationUseStatus
info	[Changelog]   - Added Type Alias FirewallPoliciesUpdateTagsResponse
info	[Changelog]   - Added Type Alias FirewallPolicyIdpsQuerySortOrder
info	[Changelog]   - Added Type Alias FirewallPolicyIdpsSignatureDirection
info	[Changelog]   - Added Type Alias FirewallPolicyIdpsSignatureMode
info	[Changelog]   - Added Type Alias FirewallPolicyIdpsSignatureSeverity
info	[Changelog]   - Added Type Alias HubRoutingPreference
info	[Changelog]   - Added Type Alias LoadBalancerBackendAddressAdminState
info	[Changelog]   - Added Type Alias NetworkInterfaceAuxiliaryMode
info	[Changelog]   - Added Type Alias VpnPolicyMemberAttributeType
info	[Changelog]   - Added Type Alias VpnServerConfigurationPolicyGroup
info	[Changelog]   - Interface FirewallPolicyIntrusionDetectionConfiguration has a new optional parameter privateRanges
info	[Changelog]   - Interface LoadBalancerBackendAddress has a new optional parameter adminState
info	[Changelog]   - Interface NetworkManagementClientOptionalParams has a new optional parameter apiVersion
info	[Changelog]   - Class NetworkManagementClient has a new parameter apiVersion
info	[Changelog]   - Class NetworkManagementClient has a new parameter configurationPolicyGroups
info	[Changelog]   - Class NetworkManagementClient has a new parameter expressRoutePortAuthorizations
info	[Changelog]   - Type Alias ApplicationGateway has a new parameter backendSettingsCollection
info	[Changelog]   - Type Alias ApplicationGateway has a new parameter listeners
info	[Changelog]   - Type Alias ApplicationGateway has a new parameter routingRules
info	[Changelog]   - Type Alias ApplicationGatewayProbe has a new parameter pickHostNameFromBackendSettings
info	[Changelog]   - Type Alias BackendAddressPool has a new parameter drainPeriodInSeconds
info	[Changelog]   - Type Alias ExpressRouteCircuit has a new parameter authorizationKey
info	[Changelog]   - Type Alias NetworkInterface has a new parameter auxiliaryMode
info	[Changelog]   - Type Alias P2SConnectionConfiguration has a new parameter configurationPolicyGroupAssociations
info	[Changelog]   - Type Alias P2SConnectionConfiguration has a new parameter previousConfigurationPolicyGroupAssociations
info	[Changelog]   - Type Alias VirtualHub has a new parameter hubRoutingPreference
info	[Changelog]   - Type Alias VirtualNetworkGatewayConnection has a new parameter gatewayCustomBgpIpAddresses
info	[Changelog]   - Type Alias VirtualNetworkGatewayConnectionListEntity has a new parameter gatewayCustomBgpIpAddresses
info	[Changelog]   - Type Alias VpnServerConfiguration has a new parameter configurationPolicyGroups
info	[Changelog]   - Type Alias VpnSiteLinkConnection has a new parameter vpnGatewayCustomBgpAddresses
info	[Changelog]   - Added Enum KnownExpressRoutePortAuthorizationUseStatus
info	[Changelog]   - Added Enum KnownFirewallPolicyIdpsQuerySortOrder
info	[Changelog]   - Added Enum KnownHubRoutingPreference
info	[Changelog]   - Added Enum KnownLoadBalancerBackendAddressAdminState
info	[Changelog]   - Added Enum KnownNetworkInterfaceAuxiliaryMode
info	[Changelog]   - Added Enum KnownVpnPolicyMemberAttributeType
info	[Changelog]   - Enum KnownApplicationGatewayProtocol has a new value Tcp
info	[Changelog]   - Enum KnownApplicationGatewayProtocol has a new value Tls
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed Enum KnownOrderByOrder
info	[Changelog]   - Removed Enum KnownSingleQueryResultDirection
info	[Changelog]   - Removed Enum KnownSingleQueryResultMode
info	[Changelog]   - Removed Enum KnownSingleQueryResultSeverity
    ️⚠️ azure-resource-manager-schemas warning [Detail]   
  
    • ⚠️Warning [Logs]Release - Generate from 6443eb2. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
warn	Skip detect changed packages
    ️❌ azure-powershell failed [Detail]   
  
    • ❌Failed [Logs]Release - Generate from 6443eb2. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ❌Az.network        [View full logs]         [Release SDK Changes]      
    Posted by Swagger Pipeline | How to fix these errors?
          		
    
    
      

    
    


          

        
    

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
          
    
  
    
    
  
    

  
    
      
    
  This was referenced May 17, 2022

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    

    





    

      
    
  
        



    

      
    
  
          
    
  
    
    
  
    

  
    
      
    
    @azure-sdk
azure-sdk



    mentioned this pull request
    
      May 17, 2022
    

    


    
  


  
    
      
   Closed

  
    

    




  
    

    




    

      
    
  
      

    

  
    
  @weidongxu-microsoft


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

      

  
  Member


      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
    /azp run
    
          		
    
    
      

    
    


          

        
    

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
      

    

  
    
  @azure-pipelines


    


  
    

    
    
      
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

      



      

  
    

  
    
    

  
    

    


      
    

        

    
  
    
    
      
          
Azure Pipelines successfully started running 1 pipeline(s).
    
    
          		
    
    
      

    
    


          

        
    

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
          
    
  
    
    
  
    

  
    
      
    
    @azure-sdk
azure-sdk



    mentioned this pull request
    
      May 17, 2022
    

    


    
  


  
    
      
   Closed

  
    

    




  
    

    

  
    
  
    
    
  
    
  
    


        @weidongxu-microsoft
  weidongxu-microsoft



        merged commit 6443eb2
      into

      
  
    Azure:main
  


    May 17, 2022

  
    

    


    

  
    
  
    
    
  
    

  
    
      
    
  This was referenced May 17, 2022

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    

  
  



    





  
  
    
    
    
      

      
    



    
    

    
    
      
    
              
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  

    

      
    
    
    
  
    


    
  
              

    


      
    
  
    
    
    
    
  
    
    Reviewers
  
    

    


        
    
          

  
    @weidongxu-microsoft
  
    weidongxu-microsoft



          
            
              
            
          
          weidongxu-microsoft approved these changes

        
    
      
    
          

  
    @MikhailTryakhov
  
    MikhailTryakhov


                Awaiting requested review from MikhailTryakhov

      
    

      
    


    


    
    
  
    

      
  
    
    Assignees
  
    


        

      
    
        

  
    @lirenhe
  
    lirenhe
    

      
    
    



    


      

    
  


  
    
    Labels
  
    


    
    
      

    CI-BreakingChange-JavaScript

  

    Network



    


    


      

  
    
    
    
        
    
    Projects
  
    

        
    

    

    None yet




      
    


      

    
  
    
    
  
    
    Milestone
  
    

      No milestone


    


    
      
          

    
  
    
    
      
    
        
    
    
    Development
  
    


          


    Successfully merging this pull request may close these issues.
    


  


            
  
    

    

        
          

    

  
      
    
  
    
    
    
      3 participants
    
    
    
    
        
          @vinaymundada27 
        
          @weidongxu-microsoft 
        
          @lirenhe