Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove swagger-to-sdk in dataplane swagger except the azure-sdk-for-net-track2 #19000

Merged
merged 3 commits into from
May 24, 2022
Merged

remove swagger-to-sdk in dataplane swagger except the azure-sdk-for-net-track2 #19000

merged 3 commits into from
May 24, 2022

Conversation

dw511214992
Copy link
Member

@dw511214992 dw511214992 commented May 10, 2022 •
edited
Loading

The swagger-to-sdk config is used by sdk automation pipeline. However, previously sdk automation pipeline doesn't support dataplane sdk, and the existing readme.md and readme.language.md in dataplane sdk doesn't work. So I delete them in this PR to suppress the sdk automation pipeline error in dataplane swagger PR.

@dw511214992 dw511214992 requested a review from a team as a code owner May 10, 2022 08:45
@dw511214992 dw511214992 requested review from markweitzel and rysweet and removed request for a team May 10, 2022 08:45
@openapi-workflow-bot
Copy link

Hi, @dw511214992 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 10, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️❌LintDiff: 2 Errors, 0 Warnings failed [Detail] The following errors/warnings are introduced by current PR:
    Rule Message
    ❌ AutoRest exception "location":"specification/eventgrid/data-plane/readme.md",
    "tag":"default",
    "details":"swagger-document/individual/schema-validator - FAILED"
    ❌ AutoRest exception "location":"specification/eventgrid/data-plane/readme.md",
    "tag":"default",
    "details":"Error: [OperationAbortedException] Error occurred. Exiting."
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 10, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @dw511214992, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    mikekistler
    mikekistler approved these changes May 10, 2022
    View reviewed changes
    Copy link
    Member

    @mikekistler mikekistler left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks good! 👍

    @dw511214992 dw511214992 force-pushed the remove-swagger-to-sdk-in-dataplane-swagger branch from d5c50ec to 264b128 Compare May 18, 2022 07:13
    @dw511214992 dw511214992 changed the title remove swagger-to-sdk in dataplane swagger remove swagger-to-sdk in dataplane swagger except the azure-sdk-for-net-track2 May 18, 2022
    This was referenced May 18, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    dw511214992 and others added 2 commits May 23, 2022 15:33
    @dw511214992 dw511214992 merged commit 988d42e into main May 24, 2022
    This was referenced May 24, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    gargankit-microsoft pushed a commit that referenced this pull request May 26, 2022
    @dw511214992 @gargankit-microsoft
    remove swagger-to-sdk except azure-sdk-for-net-track2 (#19000)
    f1b62a2
    @dw511214992 dw511214992 mentioned this pull request Jul 4, 2022
    Closed
    @fengzhou-msft fengzhou-msft mentioned this pull request Sep 18, 2022
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @lmazuel lmazuel lmazuel approved these changes

    @mikekistler mikekistler mikekistler approved these changes

    @markweitzel markweitzel Awaiting requested review from markweitzel markweitzel is a code owner automatically assigned from Azure/api-stewardship-board

    @rysweet rysweet Awaiting requested review from rysweet rysweet is a code owner automatically assigned from Azure/api-stewardship-board

    @lirenhe lirenhe Awaiting requested review from lirenhe

    @akning-ms akning-ms Awaiting requested review from akning-ms

    @weidongxu-microsoft weidongxu-microsoft Awaiting requested review from weidongxu-microsoft

    @ShivangiReja ShivangiReja Awaiting requested review from ShivangiReja

    Assignees

    @dw511214992 dw511214992

    Labels
    Approved-LintDiff CI-FixRequiredOnFailure
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @dw511214992 @lmazuel @mikekistler @kristapratico @jianyexi