Migrate to net track2 for some resource-manager readmes #18996
Conversation
fengzhou-msft
requested review from
naveedaz,
JasonYang-MSFT,
jamestao,
ericshape,
v-Ajnava,
dsouzaarun,
damodaravadhani,
MikhailTryakhov,
heaths and
jlichwa
as code owners
Swagger Generation Artifacts
|
|
Hi @fengzhou-msft, this service has enabled Shift Left. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth. |
|
Hi, @fengzhou-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
| - repo: azure-sdk-for-net | ||
| - repo: azure-sdk-for-ruby | ||
| - repo: azure-sdk-for-net | ||
| after_scripts: | ||
| - bundle install && rake arm:regen_all_profiles['azure_mgmt_connectedvmware'] |
There was a problem hiding this comment.
This one is not supported by track 2 yet, just remove the duplicate setting which steals the after script that should belong to ruby.
There was a problem hiding this comment.
We do have a track 2 sdk\connectedvmwarevsphere\Azure.ResourceManager.ConnectedVMwarevSphere, though. Is this the same thing?
There was a problem hiding this comment.
You're right. I somehow missed that due to the different service directory naming.
* migrate to net track2 for some mgmt RPs * Update readme.md
For the dotnet SDKs that have released track 2 versions, change the swagger-to-sdk settings to only keep azure-sdk-for-net-track2.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.