Daorozco microsoft.authorization 2021 04 01 preview #18909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @dagoroz Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.7)] | new version | base version |
|---|---|---|
| authorization-AccessReviewCalls.json | 2021-03-01-preview(92ea9ee) | 2021-03-01-preview(main) |
️❌Breaking Change(Cross-Version): 15 Errors, 18 Warnings failed [Detail]
| compared swaggers (via Oad v0.9.7)] | new version | base version |
|---|---|---|
| authorization-RoleAssignmentsCalls.json | 2021-04-01-preview(92ea9ee) | 2015-07-01(main) |
| authorization-RoleAssignmentsCalls.json | 2021-04-01-preview(92ea9ee) | 2020-10-01-preview(main) |
| common-types.json | 2021-04-01-preview(92ea9ee) | 2020-10-01(main) |
| common-types.json | 2021-04-01-preview(92ea9ee) | 2020-10-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 29 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 27 Errors, 9 Warnings failed [Detail]
[must fix]The following errors/warnings are introduced by current PR:
Only 29 items are listed, please refer to log for more details.
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
The schema 'AccessReviewScheduleDefinition' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1050 |
|
|
The schema 'AccessReviewScheduleDefinitionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1076 |
|
|
The schema 'AccessReviewInstance' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1167 |
|
|
The schema 'AccessReviewInstanceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1193 |
|
|
The schema 'AccessReviewScheduleSettings' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1232 |
|
|
The schema 'AccessReviewDefaultSettings' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1284 |
|
|
The schema 'AccessReviewRecurrenceSettings' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1310 |
|
|
The schema 'AccessReviewRecurrencePattern' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1325 |
|
|
The schema 'AccessReviewRecurrenceRange' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1347 |
|
|
The schema 'AccessReviewScope' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1382 |
|
|
The schema 'AccessReviewReviewer' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1429 |
|
|
The schema 'AccessReviewDecision' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1451 |
|
|
The schema 'AccessReviewDecisionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1477 |
|
|
The schema 'AccessReviewDecisionResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1574 |
|
|
The schema 'AccessReviewDecisionIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1604 |
|
|
The schema 'AccessReviewDecisionUserIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1635 |
|
|
The schema 'AccessReviewDecisionServicePrincipalIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1655 |
|
|
The schema 'AccessReviewActorIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1675 |
|
|
The schema 'AccessReviewScheduleDefinitionListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1708 |
|
|
The schema 'AccessReviewInstanceListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1724 |
|
|
The schema 'AccessReviewDecisionListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1740 |
|
|
Missing identifier id in array item property Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1129 |
|
|
Missing identifier id in array item property Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1136 |
|
|
Missing identifier id in array item property Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1835 |
|
|
"location":"specification/authorization/resource-manager/readme.md", "tag":"package-preview-2021-04", "details":"swagger-document-override/md-override-loader - FAILED" |
|
|
"location":"specification/authorization/resource-manager/readme.md", "tag":"package-preview-2021-04", "details":"Error: Could not read 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/authorization/resource-manager/Microsoft.Authorization/preview/2021-04-01-preview/EligibleChildResources.json'." |
|
|
"location":"specification/authorization/resource-manager/readme.md", "tag":"package-preview-2021-04", "details":"swagger-document/loader - FAILED" |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetAccessReview Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L248 |
||
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetAccessReviews Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L288 |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetAccessReviews Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L710 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetAccessReviews Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L749 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetAccessReviews Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L795 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetAccessReview Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L842 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetAccessReviews Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L886 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetAccessReviews Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L939 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetAccessReviews Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L991 |
️❌Avocado: 2 Errors, 1 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The JSON file is not found but it is referenced from the readme file. readme: specification/authorization/resource-manager/readme.md json: Microsoft.Authorization/preview/2021-04-01-preview/RoleManagementPolicyAssignment.json |
|
The default tag does not contain all APIs in this RP. Please make sure the missing API swaggers are in the default tag. readme: specification/authorization/resource-manager/readme.md json: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json |
| The default tag contains multiple API versions swaggers. readme: specification/authorization/resource-manager/readme.md tag: specification/authorization/resource-manager/readme.md#tag-package-2022-04-01 |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 2 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"errorCode: AssertionError, errorMessage: ResourceType 'accessReviewScheduleDefinitions' should be deployed in 'West Central US' on apiVersion '2021-03-01'.: expected [ Array(20) ] to satisfy [Function]" |
|
"errorCode: AssertionError, errorMessage: ResourceType 'accessReviewScheduleDefinitions' should be deployed in 'West Central US' on apiVersion '2021-03-01'.: expected [ Array(20) ] to satisfy [Function]" |
️❌ModelValidation: 4 Errors, 0 Warnings failed [Detail]
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌PoliCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Click detail for error messages. Exception contact vsswagger@microsoft.com or https://aka.ms/swaggersupport. |
️⚠️SDK Track2 Validation: 4 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/92ea9ee9c18d775bfac46beeb00e89135bc056cc/specification/authorization/resource-manager/readme.md#tag-package-2021-03-01-preview-only">authorization/resource-manager/readme.md#package-2021-03-01-preview-only
- "https://github.com/Azure/azure-rest-api-specs/blob/92ea9ee9c18d775bfac46beeb00e89135bc056cc/specification/authorization/resource-manager/readme.md#tag-package-preview-2021-04">authorization/resource-manager/readme.md#package-preview-2021-04
- "https://github.com/Azure/azure-rest-api-specs/blob/92ea9ee9c18d775bfac46beeb00e89135bc056cc/specification/authorization/resource-manager/readme.md#tag-package-2021-04-01-preview-only">authorization/resource-manager/readme.md#package-2021-04-01-preview-only
- "https://github.com/Azure/azure-rest-api-specs/blob/92ea9ee9c18d775bfac46beeb00e89135bc056cc/specification/authorization/resource-manager/readme.md#tag-package-2021-04-01-preview">authorization/resource-manager/readme.md#package-2021-04-01-preview
| Rule | Message |
|---|---|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-04-01-preview-only", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-04-01-preview", "details":"Schema 'AccessReviewDecisionUserIdentity' has an allOf list with an empty object schema as a parent, removing it." |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-04-01-preview", "details":"Schema 'AccessReviewDecisionServicePrincipalIdentity' has an allOf list with an empty object schema as a parent, removing it." |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-04-01-preview", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-03-01-preview-only", "details":"Schema 'AccessReviewDecisionUserIdentity' has an allOf list with an empty object schema as a parent, removing it." |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-03-01-preview-only", "details":"Schema 'AccessReviewDecisionServicePrincipalIdentity' has an allOf list with an empty object schema as a parent, removing it." |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-03-01-preview-only", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
Swagger Generation Artifacts
|
|
Hi, @dagoroz your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
|
Hi @dagoroz, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced May 4, 2022
|
Justification for AVOCADO "NOT_LATEST_API_VERSION_IN_DEFAULT_TAG": Justification for Errors in AccessReviewCalls: Justification for cross version breaking change: |
|
@ruowan gentle ping |
|
@raosuhas thanks for approving. |
|
@raosuhas ping |
|
Hi, @dagoroz. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
added
the
…020-10-01-preview to version 2021-04-01-preview
dagoroz
force-pushed
the
daorozco-Microsoft.Authorization-2021-04-01-preview
branch
from
b9596ea
to
f89a70e
Compare
Generated ApiView
|
|
Hi @dagoroz, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
gerrytan
pushed a commit
to gerrytan/azure-rest-api-specs
that referenced
this pull request
Sep 6, 2024
gerrytan
added a commit
that referenced
this pull request
Sep 20, 2024
…o Terraform HCL (#30455) * New RP: Microsoft.AzureTerraform (ver=2023-07-01-preview) * prettier * remove x-ms-discriminator-value * readme.md: add `openapi-subtype` * Fix LintDiff failure * Result configuration type change from object to string * Remove properties: `subscriptionId` and `environment` * Change `errors` from list of string to list of `ErrorResponse` * Add operations endpoint * Update * Update * AzureTerraform RP: Sync the MS version with the private version * Terraform: Change `exportEerraform` endpoint to LRO (#18782) * terraform: Modify the `exportTerraform` RT to be LRO * Update * prettier * spell * CI validation * More CI issue fixes * typo * Add readme.go.md * typo * prettier * suppression * Update suppression * AzureTerrform: Remove the parallelism property (#18909) * exportTerraform: Change resourceId -> resourceIds; Add `maskSensitive`; Change `fullConfig` defaults (#19178) * exportTerraform: Change resourceId -> resourceIds; Add `maskSensitive`; Change `fullConfig` defaults * rename * rename * rename * Specify LRO model (#19401) * Add up the `resourceId` in `OperationStatus` model (#19450) * Add `uri` format (#19455) * Add format url * update * TypeSpec for Microsoft.AzureTerraform (#19390) * TypeSpec for Microsoft.AzureTerraform * Sorted swagger file, and added typespec generated with tsp-client * revert export.json in prep of merging * Sorted export.json for easy diff on future typespec -> swagger * Rerun swagger -> typespec conversion after merging latest RPSaaSMaster, updated namespace * tsp compile for TypeSpec -> swagger * Refactored typescript to minimise swagger diff * Spread ErrorResponse into OperationStatus model * Fixed enums, use doc decorator * Update exportTerraform path desc * Update doc for ExportResource model * LintDiff fix: remove unnecessary auth * Add resourceId prop to OperationStatus model, fixed char casing so they're consistent throughout * Made resourceId read only * Check `Swagger BreakingChange`: minimise diff on x-ms-enum * TypeSpec Validation fix: rename dir and add missing @doc * Upgrade/rp tsp 0.60 (#19551) -- applying only for specification/terraform * Revert accidental changes to cSpell.json while merging * Added tf files used for armstrong testing --------- Co-authored-by: magodo <wztdyl@sina.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Feature is already public, exposing versions to fix swagger KPI
Feature is already public, exposing versions to fix swagger KPI
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[x] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.