You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Applicability: ⚠️
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
Change to data plane APIs
Adding new properties
All removals
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
Adding a new service
Adding new API(s)
Adding a new API version
To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'Provider_GetAvailableStacks' Location: Microsoft.Web/stable/2019-08-01/Provider.json#L19
Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'Provider_GetAvailableStacksOnPrem' Location: Microsoft.Web/stable/2019-08-01/Provider.json#L99
Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'Provider_GetAvailableStacks' Location: Microsoft.Web/stable/2020-06-01/Provider.json#L19
Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'Provider_GetAvailableStacksOnPrem' Location: Microsoft.Web/stable/2020-06-01/Provider.json#L99
Hi @matanpa, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.
Would you double check the fix on description is OK for your RP?
Basically, the PR only correct the description e.g. from "Description for Get all apps for a subscription." to "Get all apps for a subscription."
Hi @weidongxu-microsoft ,
It'd be very difficult to go over all changes one by one, as there are ~5.4k changed lines.
However, the regex I used for the replacement is quite straightforward and I consider it safe -
search for: /"summary": "(.*)",([\n\r\s]+)"description": "Description for \1"/
replace with: "summary": "$1",$2"description": "$1"
i.e., whenever the description matches the summary exactly with the addition of a "Description for" prefix, remove the prefix.
This produced changes in 165 files, and on top of those I added 3 files that I verified manually (and had the same issue basically, only without having a summary prop altogether).
Bottom line - given that going through every changed line is impractical, I have enough confidence in the correctness of the change. Please let me know what you think.
Yes, I think your PR is correct. I just want the owner of these RPs (App, WebApp, etc.) be aware of the change. But if they do not reply for some time (may be a few more days), I will probably just go on with the merge.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
added
the
customer-reported
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.