Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Devices to add version preview/2022-04-30-preview #18743

Conversation

didact2401
Copy link
Contributor

@didact2401 didact2401 commented Apr 20, 2022

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @didact2401 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 20, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.9.6)] new version base version
    iothub.json 2022-04-30-preview(8827e4e) 2021-07-02(main)
    iothub.json 2022-04-30-preview(8827e4e) 2021-07-02-preview(main)
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 1 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-preview-2022-04-30 package-preview-2022-04-30(8827e4e) default(main)

    The following errors/warnings are introduced by current PR:

    Rule Message
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableRootCertificateV2
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L4582


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L3198
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L76
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Devices/IotHubs'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L320
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L361
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/IotHubStats'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L405
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/skus'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L449
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/eventHubEndpoints/{eventHubEndpointName}/ConsumerGroups'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L496
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/eventHubEndpoints/{eventHubEndpointName}/ConsumerGroups/{name}'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L550
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/jobs'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L726
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/jobs/{jobId}'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L773
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/quotaMetrics'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L824
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{iotHubName}/routingEndpointsHealth'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L871
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{iotHubName}/routing/routes/$testall'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L1017
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{iotHubName}/routing/routes/$testnew'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L1084
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/listkeys'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L1151
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/IotHubKeys/{keyName}/listkeys'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L1198
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/exportDevices'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L1249
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/importDevices'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L1302
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/certificates'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L1355
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/certificates/{certificateName}'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L1399
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/certificates/{certificateName}/generateVerificationCode'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L1565
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/certificates/{certificateName}/verify'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L1619
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{iotHubName}/failover'
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L1682
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L64
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L110
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L181
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L310
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L348
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L392
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2022-04-30-preview/iothub.json#L439
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'operations' could not be found in the namespace 'Microsoft.Devices' for api version '2022-04-30-preview'. The supported api-versions are '2015-08-15-preview,
    2016-02-03,
    2017-01-19,
    2017-07-01,
    2018-01-22,
    2018-04-01,
    2018-12-01-preview,
    2019-03-22-preview,
    2019-03-22,
    2019-07-01-preview,
    2019-11-04,
    2020-03-01,
    2020-04-01,
    2020-06-15,
    2020-07-10-preview,
    2020-08-01,
    2020-08-31-preview,
    2020-08-31,
    2021-02-01-preview,
    2021-03-03-preview,
    2021-03-31,
    2021-07-01-preview,
    2021-07-01,
    2021-07-02-preview,
    2021-07-02'."
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 2 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/8827e4e3f3ce528c8c690761b01fc561e96600c7/specification/iothub/resource-manager/readme.md#tag-package-preview-2022-04-30">iothub/resource-manager/readme.md#package-preview-2022-04-30
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ UnkownSecurityScheme "readme":"iothub/resource-manager/readme.md",
    "tag":"package-preview-2022-04-30",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ Modeler/MissingType "readme":"iothub/resource-manager/readme.md",
    "tag":"package-preview-2022-04-30",
    "details":"The schema 'components·11psznm·schemas·eventhubconsumergroupinfo·properties·properties·additionalproperties' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/iothub/resource-manager/Microsoft.Devices/preview/2022-04-30-preview/iothub.json#/components/schemas/components·11psznm·schemas·eventhubconsumergroupinfo·properties·properties·additionalproperties"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 20, 2022

    Swagger Generation Artifacts

    ️🔄ApiDocPreview inProgress [Detail]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go-track2 - armiothub - 0.6.0
    +	Type of `FallbackRouteProperties.Source` has been changed from `*RoutingSource` to `*FallbackRoutingSource`
    +	Type of `TestAllRoutesInput.RoutingSource` has been changed from `*RoutingSource` to `*TestRoutingSource`
    ️✔️azure-sdk-for-go - iothub/mgmt/2021-07-02/devices - v63.4.0
    ️✔️azure-sdk-for-go - iothub/mgmt/2021-03-31/devices - v63.4.0
    ️✔️azure-sdk-for-go - iothub/mgmt/2020-03-01/devices - v63.4.0
    ️✔️azure-sdk-for-go - iothub/mgmt/2018-04-01/devices - v63.4.0
    ️✔️azure-sdk-for-go - iothub/mgmt/2018-01-22/devices - v63.4.0
    ️✔️azure-sdk-for-go - iothub/mgmt/2017-07-01/devices - v63.4.0
    ️✔️azure-sdk-for-go - iothub/mgmt/2017-01-19/devices - v63.4.0
    ️✔️azure-sdk-for-go - iothub/mgmt/2016-02-03/devices - v63.4.0
    ️✔️azure-sdk-for-go - preview/iothub/mgmt/2021-03-03-preview/devices - v63.4.0
    ️✔️azure-sdk-for-go - preview/iothub/mgmt/2019-07-01-preview/devices - v63.4.0
    ️✔️azure-sdk-for-go - preview/iothub/mgmt/2019-03-22-preview/devices - v63.4.0
    ️✔️azure-sdk-for-go - preview/iothub/mgmt/2018-12-01-preview/devices - v63.4.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-iothub - 2.2.0
    ️🔄 azure-sdk-for-net inProgress [Detail]
    ️🔄 azure-sdk-for-python-track2 inProgress [Detail]
    ️🔄 azure-sdk-for-net-track2 inProgress [Detail]
    ️🔄 azure-sdk-for-java inProgress [Detail]
    ️🔄 azure-sdk-for-go inProgress [Detail]
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 852659eee54ad28764b5e2a22bd2b33a0f8da1c8. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armiothub [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `TestAllRoutesInput.RoutingSource` has been changed from `*RoutingSource` to `*TestRoutingSource`
      info	[Changelog] - Type of `FallbackRouteProperties.Source` has been changed from `*RoutingSource` to `*FallbackRoutingSource`
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `TestRoutingSourceDeviceConnectionStateEvents`
      info	[Changelog] - New const `TestRoutingSourceDeviceMessages`
      info	[Changelog] - New const `RoutingSourceMqttBrokerMessages`
      info	[Changelog] - New const `TestRoutingSourceDeviceJobLifecycleEvents`
      info	[Changelog] - New const `TestRoutingSourceDigitalTwinChangeEvents`
      info	[Changelog] - New const `TestRoutingSourceMqttBrokerMessages`
      info	[Changelog] - New const `RoutingSourceDigitalTwinChangeEvents`
      info	[Changelog] - New const `TestRoutingSourceInvalid`
      info	[Changelog] - New const `FallbackRoutingSourceDeviceMessages`
      info	[Changelog] - New const `TestRoutingSourceTwinChangeEvents`
      info	[Changelog] - New const `TestRoutingSourceDeviceLifecycleEvents`
      info	[Changelog] - New function `PropertiesDeviceStreams.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `PossibleFallbackRoutingSourceValues() []FallbackRoutingSource`
      info	[Changelog] - New function `EncryptionPropertiesDescription.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `PossibleTestRoutingSourceValues() []TestRoutingSource`
      info	[Changelog] - New struct `EncryptionPropertiesDescription`
      info	[Changelog] - New struct `KeyVaultKeyProperties`
      info	[Changelog] - New struct `PropertiesDeviceStreams`
      info	[Changelog] - New struct `RoutingCosmosDBSQLAPIProperties`
      info	[Changelog] - New field `DeviceStreams` in struct `Properties`
      info	[Changelog] - New field `Encryption` in struct `Properties`
      info	[Changelog] - New field `CosmosDBSQLCollections` in struct `RoutingEndpoints`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 25 additive change(s).
    ️🔄 azure-sdk-for-js inProgress [Detail]
    ️🔄 azure-resource-manager-schemas inProgress [Detail]
    ️🔄 azure-powershell inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @didact2401, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @didact2401
    Copy link
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @didact2401
    Copy link
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @didact2401
    Copy link
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @didact2401
    Copy link
    Contributor Author

    /azp run unifiedPipeline

    @weidongxu-microsoft
    Copy link
    Member

    @tadelesh on Go breaking

    .net can be ignored.

    @weidongxu-microsoft weidongxu-microsoft added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jul 28, 2022
    @weidongxu-microsoft
    Copy link
    Member

    weidongxu-microsoft commented Jul 28, 2022

    A few comments. LGTM.

    Pending on approval from Go SDK, and service rollout.

    @tadelesh
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

    @vighatke
    Copy link
    Contributor

    vighatke commented Aug 5, 2022

    /azp run

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 5, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Python track2_azure-mgmt-iothub Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    .Net Azure.ResourceManager.IotHub Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-iothub Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-iothub Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go-V2 resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.