NSP API changes #18531
Merged
NSP API changes #18531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @kaushal087 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Since operation 'NetworkSecurityPerimeters_CheckMembers' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L972 |
|
| Since operation 'NetworkSecurityPerimeters_Query' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1016 |
|
| OperationId should contain the verb: 'querynetworksecurityperimeter' in:'NetworkSecurityPerimeters_Query'. Consider updating the operationId Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1016 |
|
| OperationId should contain the verb: 'reconcile' in:'NspAccessRulesReconcile_Post'. Consider updating the operationId Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1075 |
|
| 'memberDestinations' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1511 |
|
| 'MemberDestination' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1523 |
|
| 'networkSecurityPerimeters' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1553 |
|
| 'QueryNSPObj' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1562 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: NspAssociationGet Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L784 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: NspAssociationPut Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L827 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: NspAssociationDelete Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L853 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: NspAssociationList Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L904 |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| The resource 'PerimeterAssociableResource' does not have get operation, please add it. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1437 |
|
| 'PerimeterBasedAccessRule' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1335 |
|
| 'NspAssociationProperties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L1401 |
|
| The API version:2021-02-01-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json#L6 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
ghost
added
the
|
Hi @kaushal087, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
@kaushal087, could you fix all the linter issues in this PR, for the breaking change, please refer to http://aka.ms/bcforapi for the review. Thanks |
added 2 commits
April 7, 2022 10:31
...ager/Microsoft.Network/preview/2021-02-01-preview/examples/NetworkSecurityPerimeterList.json
Outdated
Show resolved
Hide resolved
.../resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json
Outdated
Show resolved
Hide resolved
.../resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json
Show resolved
Hide resolved
We support both async and sync so these status codes are required. |
|
@raosuhas , thanks for the comments. I have made all the requested changes/provided explanation for the changes. Could you please review and mark these as resolved? |
|
@raosuhas Could you please review and approve it? |
1 similar comment
|
@raosuhas Could you please review and approve it? |
mentat9
reviewed
Jun 1, 2022
.../resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json
Show resolved
Hide resolved
mentat9
reviewed
Jun 1, 2022
.../resource-manager/Microsoft.Network/preview/2021-02-01-preview/networkSecurityPerimeter.json
Show resolved
Hide resolved
|
Signing off with comments from ARM. |
mentat9
added
ARMSignedOff
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
@MikhailTryakhov , this is an extension to the earlier definition of NSP APIs. This is for a preview version. Please take a look at it and approve if looks fine. |
lirenhe
approved these changes
Jun 2, 2022
This was referenced Jun 2, 2022
This was referenced Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.