-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Public private branch 'appplatform/master' #17401
[Hub Generated] Public private branch 'appplatform/master' #17401
Conversation
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/5905 |
Hi, @yuwzho Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
1040 - AddedReadOnlyPropertyInResponse |
The new version has a new read-only property 'actionType' in response that was not found in the old version. New: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L8899:7 Old: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L8899:7 |
️⚠️
LintDiff: 0 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
Per the Noun_Verb convention for Operation Ids, the noun 'BuildService' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L1197 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'BuildService' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L1242 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'RuntimeVersions' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L4937 |
|
Since operation 'ConfigServers_Validate' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L677 |
|
'PUT' operation 'ConfigServers_UpdatePut' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L557 |
|
'PUT' operation 'BuildServiceAgentPool_UpdatePut' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L2362 |
|
'PUT' operation 'MonitoringSettings_UpdatePut' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L2469 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L6676 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L6785 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L6827 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L6873 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L6943 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L7184 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L8928 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L9428 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L9480 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L9523 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L9771 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L9892 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L9952 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L10068 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Property name: storageType Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L8215 |
|
The enum types should have x-ms-enum type extension set with appropriate options. Property name: type Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L8299 |
|
Based on the response model schema, operation 'BuildService_ListSupportedBuildpacks' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L2077 |
|
Based on the response model schema, operation 'BuildService_ListSupportedStacks' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L2170 |
|
Based on the response model schema, operation 'RuntimeVersions_ListRuntimeVersions' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L4932 |
|
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'BuildServiceModel'. Consider using the plural form of 'BuildService' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L1197 |
|
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'BuildServiceModel'. Consider using the plural form of 'BuildService' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L1242 |
|
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'BuildServiceModel'. Consider using the plural form of 'BuildService' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L1287 |
|
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'BuildServiceModel'. Consider using the plural form of 'BuildService' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AppPlatform/preview/2022-01-01-preview/appplatform.json#L1335 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
NewApiVersionRequired reason: |
The breaking change was approved in previous API version, this PR is to apply same s360 fix in this api version. |
Azure#17401) Co-authored-by: swagger-automation <swagger@microsoft.com>
Azure#17401) Co-authored-by: swagger-automation <swagger@microsoft.com>
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.