Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Add Microsoft.AppPlatform/Spring new pricing tier on API version 2022-01-01-preview #17141

Conversation

yuwzho
Copy link
Contributor

@yuwzho yuwzho commented Dec 20, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@yuwzho
Copy link
Contributor Author

yuwzho commented Dec 20, 2021

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/4120

@openapi-workflow-bot
Copy link

Hi, @yuwzho Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @raych1
    Copy link
    Member

    raych1 commented Dec 20, 2021

    @ArcturusZhang @msyyc , the cross version breaking change was approved in associated PR at private repo. Can you approve from SDK perspective?

    @yuwzho yuwzho changed the title [Hub Generated] Public private branch 'yuwzho/appplatform-2021-08-01-preview' [Hub Generated] Add Microsoft.AppPlatform/Spring new pricing tier on API version 2022-01-01-preview Dec 21, 2021
    @raych1 raych1 merged commit 7206f4d into main Dec 22, 2021
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Dec 22, 2021
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    …API version 2022-01-01-preview (Azure#17141)
    
    * copy from last api version
    
    * Add system data and example
    
    * Add availability zones change
    
    * Configuration Service
    
    * Service Registry
    
    * Gateway
    
    * API portal
    
    * App and Deployment
    
    * BuildServices/Builds/Builders/BuildResults
    
    * BuildPackBindings
    
    * fix swagger of build service (Azure#43)
    
    * fix swagger of build service
    
    * fix
    
    * fix: add agentPool in BuildProperties (Azure#44)
    
    * Add fqdn in service resource (Azure#45)
    
    Co-authored-by: Xiaoyun Ding <xiading@microsoft.com>
    
    * Change appName to appResourceId (Azure#46)
    
    * Change appName to appResourceId
    
    * fix
    
    * Add resource id to connect resources
    
    * Change operatorRuntimeState to resourceRequest (Azure#49)
    
    * Change appName to appResourceId
    
    * rename sourceGateways to gatewayIds
    
    * Change operatorRuntimeState to resourceRequest
    
    * feat: update agent pool swagger (Azure#50)
    
    * Update 201 descriptions about header
    
    * add get build (Azure#51)
    
    * Remove 202 for PUT
    
    * List and Get supportedBuildpacks
    
    * set active deployment should be async
    
    * Update setActiveDeployments response body
    
    * ContentCertificateProperties.content should be secret
    
    * Add jvmOptions for Jar type
    
    Co-authored-by: Qingyi Liu <34502364+smile37773@users.noreply.github.com>
    Co-authored-by: Xiaoyun Ding <leonard520@users.noreply.github.com>
    Co-authored-by: Xiaoyun Ding <xiading@microsoft.com>
    Co-authored-by: ninpan-ms <71061174+ninpan-ms@users.noreply.github.com>
    Co-authored-by: zhoufenqin <fenzho@microsoft.com>
    @JackTn JackTn deleted the published/VSChina/azure-rest-api-specs-pr/yuwzho/appplatform-2021-08-01-preview branch June 16, 2022 00:51
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    8 participants