[Hub Generated] Review request for Microsoft.Security to add version preview/2021-07-01-preview #16239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @kerend Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Security/locations/{ascLocation}/ExternalSecuritySolutions' Location: Microsoft.Security/stable/2020-01-01/externalSecuritySolutions.json#L76 |
|
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Security/locations/{ascLocation}/ExternalSecuritySolutions/{externalSecuritySolutionsName}' Location: Microsoft.Security/stable/2020-01-01/externalSecuritySolutions.json#L118 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Security/preview/2017-08-01-preview/securityContacts.json#L185 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Security/preview/2017-08-01-preview/workspaceSettings.json#L216 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Security/preview/2019-01-01-preview/automations.json#L239 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L182 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Security/stable/2021-06-01/assessmentMetadata.json#L248 |
|
The integer type does not have a format, please add it. Location: Microsoft.Security/preview/2017-08-01-preview/compliances.json#L163 |
|
The integer type does not have a format, please add it. Location: Microsoft.Security/preview/2019-01-01-preview/regulatoryCompliance.json#L371 |
|
The integer type does not have a format, please add it. Location: Microsoft.Security/preview/2019-01-01-preview/regulatoryCompliance.json#L376 |
|
The integer type does not have a format, please add it. Location: Microsoft.Security/preview/2019-01-01-preview/regulatoryCompliance.json#L381 |
|
The integer type does not have a format, please add it. Location: Microsoft.Security/preview/2019-01-01-preview/regulatoryCompliance.json#L386 |
|
The integer type does not have a format, please add it. Location: Microsoft.Security/preview/2019-01-01-preview/regulatoryCompliance.json#L470 |
|
The integer type does not have a format, please add it. Location: Microsoft.Security/preview/2019-01-01-preview/regulatoryCompliance.json#L475 |
|
The integer type does not have a format, please add it. Location: Microsoft.Security/preview/2019-01-01-preview/regulatoryCompliance.json#L480 |
|
The integer type does not have a format, please add it. Location: Microsoft.Security/preview/2019-01-01-preview/regulatoryCompliance.json#L573 |
|
The integer type does not have a format, please add it. Location: Microsoft.Security/preview/2019-01-01-preview/regulatoryCompliance.json#L578 |
|
The integer type does not have a format, please add it. Location: Microsoft.Security/preview/2019-01-01-preview/regulatoryCompliance.json#L583 |
|
The integer type does not have a format, please add it. Location: Microsoft.Security/preview/2019-01-01-preview/regulatoryCompliance.json#L588 |
|
The integer type does not have a format, please add it. Location: Microsoft.Security/stable/2020-01-01/adaptiveNetworkHardenings.json#L235 |
|
The integer type does not have a format, please add it. Location: Microsoft.Security/stable/2020-01-01/topologies.json#L242 |
|
The integer type does not have a format, please add it. Location: Microsoft.Security/stable/2020-01-01/jitNetworkAccessPolicies.json#L725 |
|
The integer type does not have a format, please add it. Location: Microsoft.Security/stable/2020-01-01/jitNetworkAccessPolicies.json#L653 |
|
The top-level resource 'ServerVulnerabilityAssessment' does not have list by subscription operation, please add it. Location: Microsoft.Security/stable/2020-01-01/serverVulnerabilityAssessments.json#L324 |
|
The top-level resource 'AdaptiveNetworkHardening' does not have list by subscription operation, please add it. Location: Microsoft.Security/stable/2020-01-01/adaptiveNetworkHardenings.json#L327 |
|
The response schema of operations API '/providers/Microsoft.Security/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Security/preview/2015-06-01-preview/operations.json#L37 |
|
The schema 'ErrorAdditionalInfo' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: resource-manager/common/v1/types.json#L59 |
|
The schema 'ErrorAdditionalInfo' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: resource-manager/common/v1/types.json#L59 |
|
The schema 'ComplianceResultList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Security/stable/2017-08-01/complianceResults.json#L117 |
|
The schema 'ErrorAdditionalInfo' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: resource-manager/common/v1/types.json#L59 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
|
"readme":"security/resource-manager/readme.md", "tag":"package-composite-v1", "details":"Error: Semantic validation failed. There was some errors" |
|
"readme":"security/resource-manager/readme.md", "tag":"package-composite-v2", "details":"Error: Semantic validation failed. There was some errors" |
|
"readme":"security/resource-manager/readme.md", "tag":"package-composite-v3", "details":"Error: Plugin prechecker reported failure." |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
NewApiVersionRequired reason: |
This was referenced Sep 30, 2021
ruowan
approved these changes
Oct 5, 2021
ruowan
added
the
Approved-BreakingChange
This was referenced Oct 5, 2021
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Oct 5, 2021
…urity to add version preview/2021-07-01-preview (#1946) Create to sync Azure/azure-rest-api-specs#16239 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/security?expand=1)
jovannikolov-msft
pushed a commit
to jovannikolov-msft/azure-rest-api-specs
that referenced
this pull request
Dec 1, 2021
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.