[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2021-08-01 #15880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/2021-07-01 to version 2021-08-01
|
Hi, @ayfathim Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/certificates/{certificateName}' Location: Microsoft.RecoveryServices/stable/2021-08-01/registeredidentities.json#L21 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/registeredIdentities/{identityName}' Location: Microsoft.RecoveryServices/stable/2021-08-01/registeredidentities.json#L80 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/replicationUsages' Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L21 |
|
Resource type naming must follow camel case. Path: '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/usages' Location: Microsoft.RecoveryServices/stable/2021-08-01/vaultusages.json#L21 |
|
The response of operation:'VaultExtendedInfo_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-08-01/vaults.json#L548 |
|
The response of operation:'VaultCertificates_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-08-01/registeredidentities.json#L22 |
|
The response of operation:'VaultExtendedInfo_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-08-01/vaults.json#L592 |
|
The response of operation:'VaultExtendedInfo_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-08-01/vaults.json#L648 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2021-08-01/registeredidentities.json#L64 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2021-08-01/registeredidentities.json#L108 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L45 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.RecoveryServices/stable/2021-08-01/vaultusages.json#L45 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.RecoveryServices/stable/2021-08-01/registeredidentities.json#L108 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.RecoveryServices/stable/2021-08-01/vaults.json#L456 |
|
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L70 |
|
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L74 |
|
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L78 |
|
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L88 |
|
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L92 |
|
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L96 |
|
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L100 |
|
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L104 |
|
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L108 |
|
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L126 |
|
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L130 |
|
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L134 |
|
The integer type does not have a format, please add it. Location: Microsoft.RecoveryServices/stable/2021-08-01/replicationusages.json#L138 |
|
The response schema of operations API '/providers/Microsoft.RecoveryServices/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.RecoveryServices/stable/2021-08-01/vaults.json#L231 |
|
The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections/{privateEndpointConnectionName} is missing. Location: Microsoft.RecoveryServices/stable/2021-08-01/vaultusages.json#L20 |
|
The private endpoint API: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/privateEndpointConnections is missing. Location: Microsoft.RecoveryServices/stable/2021-08-01/vaultusages.json#L20 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.9.0)
- current:stable/2021-08-01/registeredidentities.json compared with base:stable/2021-07-01/registeredidentities.json
- current:stable/2021-08-01/replicationusages.json compared with base:stable/2021-07-01/replicationusages.json
- current:stable/2021-08-01/vaults.json compared with base:stable/2021-07-01/vaults.json
- current:stable/2021-08-01/vaultusages.json compared with base:stable/2021-07-01/vaultusages.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"recoveryservices/resource-manager/readme.md",
"tag":"package-2021-08",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"recoveryservices/resource-manager/readme.md",
"tag":"package-2021-08",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"recoveryservices/resource-manager/readme.md",
"tag":"package-2021-08",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
This was referenced Sep 1, 2021
ayfathim
changed the title
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @ayfathim your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
|
@RamyasreeChakka : Please review |
|
No API change from the previous version. |
filizt
added
ARMSignedOff
|
@ayfathim Do we need to hold on for this PR? |
Yes, the deployment for new version is in progress. Once completed, we can merge this PR. I will update here, once we are ready |
ayfathim
changed the title
|
Hi @ayfathim please get |
ayfathim
requested review from
pratimaupadhyay02
and removed request for
deymadhumanti
|
Changes look fine. ADX team, please go ahead and merge the PR. |
pratimaupadhyay02
added
the
Approved-OkToMerge
pratimaupadhyay02
approved these changes
Sep 24, 2021
This was referenced Sep 26, 2021
Merged
Hardell
pushed a commit
to Hardell/azure-rest-api-specs
that referenced
this pull request
Sep 27, 2021
…version stable/2021-08-01 (Azure#15880) * Adds base for updating Microsoft.RecoveryServices from version stable/2021-07-01 to version 2021-08-01 * Updates readme * Updates API version in new specs and examples
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
…version stable/2021-08-01 (Azure#15880) * Adds base for updating Microsoft.RecoveryServices from version stable/2021-07-01 to version 2021-08-01 * Updates readme * Updates API version in new specs and examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.