-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ANM] Remove $ from $Skiptoken and restructure Hub and NetworkGroups #15840
Conversation
This reverts commit 4e07577.
Hi, @yanfa317 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/network/resource-manager/readme.md tag: specification/network/resource-manager/readme.md#tag-package-2021-02-preview |
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌
[Staging] SDK Track2 Validation: 2 Errors, 0 Warnings failed [Detail]
- The following tags are being changed in this PR
Rule | Message |
---|---|
PreCheck/DuplicateSchema |
"readme":"network/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"Duplicate Schema named CloudError -- properties.error.$ref: undefined => "#/components/schemas/schemas:4105" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
PreCheck/DuplicateSchema |
"readme":"network/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"Duplicate Schema named CloudErrorBody -- properties.details.$ref: undefined => "#/components/schemas/schemas:4109" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
💬 AutorestCore/Exception | "readme":"network/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
💬 AutorestCore/Exception | "readme":"network/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
AutorestCore/Exception |
"readme":"network/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"Error: Plugin prechecker reported failure." |
"readme":"network/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"Schema 'NetworkSecurityPerimeter' has a property 'id' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from NetworkSecurityPerimeter" |
|
"readme":"network/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"Schema 'NetworkSecurityPerimeter' has a property 'name' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from NetworkSecurityPerimeter" |
|
"readme":"network/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"Schema 'NetworkSecurityPerimeter' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from NetworkSecurityPerimeter" |
|
"readme":"network/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"Schema 'PerimeterAssociableResource' has a property 'id' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from PerimeterAssociableResource" |
|
"readme":"network/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"Schema 'PerimeterAssociableResource' has a property 'name' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from PerimeterAssociableResource" |
|
"readme":"network/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"Schema 'PerimeterAssociableResource' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from PerimeterAssociableResource" |
|
"readme":"network/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"Schema 'ResourceNavigationLink' has a property 'id' that is already declared the parent schema 'SubResource' but 'readonly' has been changed -- this is not permitted. The property has been removed from ResourceNavigationLink" |
|
"readme":"network/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"Schema 'VpnServerConfiguration' has a property 'name' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from VpnServerConfiguration" |
|
💬 AutorestCore/Exception | "readme":"network/resource-manager/readme.md", "tag":"package-2021-02-preview", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
Rule | Message |
---|---|
RestBuild error |
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=250519&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌
[Staging] SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
️✔️
azure-sdk-for-python-track2 - track2_azure-mgmt-network - 19.0.0️✔️
azure-sdk-for-go - network/mgmt/2021-03-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2021-02-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2020-11-01/network - v57.0.0❌
azure-sdk-for-go - network/mgmt/2020-08-01/network - v57.0.0❌
azure-sdk-for-go - network/mgmt/2020-07-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2020-06-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2020-05-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2020-04-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2020-03-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2019-12-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2019-11-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2019-09-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2019-08-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2019-07-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2019-06-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2019-04-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2019-02-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2018-12-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2018-11-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2018-10-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2018-08-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2018-07-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2018-06-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2018-04-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2018-02-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2018-01-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2017-11-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2017-10-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2017-09-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2017-08-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2017-06-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2017-03-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2016-12-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2016-09-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2016-06-01/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2016-03-30/network - v57.0.0️✔️
azure-sdk-for-go - network/mgmt/2015-06-15/network - v57.0.0️✔️
azure-sdk-for-go - preview/network/mgmt/2015-05-01-preview/network - v57.0.0️🔄
azure-sdk-for-net inProgress [Detail]
️⚠️
azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️
track2_azure-mgmt-network [View full logs] [Release SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Model ServiceTagInformation has a new parameter service_tag_change_number info [Changelog] - Model BastionHost has a new parameter enable_file_copy info [Changelog] - Model BastionHost has a new parameter enable_shareable_link info [Changelog] - Model BastionHost has a new parameter enable_ip_connect info [Changelog] - Model BastionHost has a new parameter enable_tunneling info [Changelog] - Model BastionHost has a new parameter disable_copy_paste info [Changelog] - Model BastionHost has a new parameter scale_units info [Changelog] - Model PrivateEndpoint has a new parameter ip_configurations info [Changelog] - Model PrivateEndpoint has a new parameter custom_network_interface_name info [Changelog] - Model PrivateEndpoint has a new parameter application_security_groups info [Changelog] - Model BgpConnection has a new parameter hub_virtual_network_connection info [Changelog] - Model InboundNatRule has a new parameter frontend_port_range_start info [Changelog] - Model InboundNatRule has a new parameter backend_address_pool info [Changelog] - Model InboundNatRule has a new parameter frontend_port_range_end info [Changelog] - Model ApplicationGatewayRequestRoutingRule has a new parameter load_distribution_policy info [Changelog] - Model ServiceEndpointPolicyDefinition has a new parameter type info [Changelog] - Model ApplicationGatewayUrlPathMap has a new parameter default_load_distribution_policy info [Changelog] - Model VirtualHub has a new parameter kind info [Changelog] - Model NetworkVirtualAppliance has a new parameter ssh_public_key info [Changelog] - Model VnetRoute has a new parameter bgp_connections info [Changelog] - Model DscpConfiguration has a new parameter qos_definition_collection info [Changelog] - Model VpnGateway has a new parameter enable_bgp_route_translation_for_nat info [Changelog] - Model ApplicationGateway has a new parameter global_configuration info [Changelog] - Model ApplicationGateway has a new parameter load_distribution_policies info [Changelog] - Model ApplicationGatewayPathRule has a new parameter load_distribution_policy info [Changelog] - Model FirewallPolicy has a new parameter explicit_proxy_settings info [Changelog] - Model FirewallPolicy has a new parameter sql info [Changelog] - Model ServiceEndpointPolicy has a new parameter service_alias info [Changelog] - Model ServiceEndpointPolicy has a new parameter contextual_service_endpoint_policies info [Changelog] - Added operation BastionHostsOperations.begin_update_tags info [Changelog] - Added operation group ServiceTagInformationOperations
️⚠️
azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-09-01 02:38:41 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-network-generated" cmderr [generate.py] 2021-09-01 02:38:41 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1" cmderr [generate.py] 2021-09-01 02:38:41 INFO autorest --version=3.4.5 --use=@autorest/java@4.0.36 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/network/azure-resourcemanager-network-generated --java.namespace=com.azure.resourcemanager.network.generated --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/network/resource-manager/readme.md cmderr [generate.py] 2021-09-01 02:41:31 INFO [CI][Success] Write to ci.yml cmderr [generate.py] 2021-09-01 02:41:31 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2021-09-01 02:41:31 INFO [POM][Skip] pom already has module azure-resourcemanager-network-generated cmderr [generate.py] 2021-09-01 02:41:31 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2021-09-01 02:41:31 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2021-09-01 02:41:31 INFO [POM][Success] Write to root pom
️✔️
azure-resourcemanager-network-generated [View full logs] [Release SDK Changes]- pom.xml
- azure-resourcemanager-network-generated-1.0.0-beta.1-javadoc.jar
- azure-resourcemanager-network-generated-1.0.0-beta.1-sources.jar
- azure-resourcemanager-network-generated-1.0.0-beta.1.jar
cmderr [Inst] 2021-09-01 02:46:08 DEBUG Got artifact_id: azure-resourcemanager-network-generated cmderr [Inst] 2021-09-01 02:46:08 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-09-01 02:46:08 DEBUG Got artifact: azure-resourcemanager-network-generated-1.0.0-beta.1-javadoc.jar cmderr [Inst] 2021-09-01 02:46:08 DEBUG Got artifact: azure-resourcemanager-network-generated-1.0.0-beta.1-sources.jar cmderr [Inst] 2021-09-01 02:46:08 DEBUG Got artifact: azure-resourcemanager-network-generated-1.0.0-beta.1.jar cmderr [Inst] 2021-09-01 02:46:08 DEBUG Match jar package: azure-resourcemanager-network-generated-1.0.0-beta.1.jar cmderr [Inst] 2021-09-01 02:46:08 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15840/azure-sdk-for-java/azure-resourcemanager-network-generated/azure-resourcemanager-network-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-network-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-network-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-network-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true ```"}
️️✔️
azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️
network/mgmt/2021-03-01/network [View full logs] [Release SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2021-02-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2020-11-01/network [View full logs]info [Changelog] No exported changes
- Only show 4 items here, please refer to log for details.
️✔️
network/mgmt/2020-08-01/network [View full logs] Breaking Change Detectedinfo [Changelog] - New field `Type` in struct `InterfaceIPConfiguration` info [Changelog] info [Changelog] Total 2 breaking change(s), 35 additive change(s). info [Changelog]
- Only show 4 items here, please refer to log for details.
️✔️
network/mgmt/2020-07-01/network [View full logs] Breaking Change Detectedinfo [Changelog] - New field `ResourceGUID` in struct `VirtualNetworkPeeringPropertiesFormat` info [Changelog] info [Changelog] Total 2 breaking change(s), 27 additive change(s). info [Changelog]
️✔️
network/mgmt/2020-06-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2020-05-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2020-04-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2020-03-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2019-12-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2019-11-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2019-09-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2019-08-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2019-07-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2019-06-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2019-04-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2019-02-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2018-12-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2018-11-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2018-10-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2018-08-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2018-07-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2018-06-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2018-04-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2018-02-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2018-01-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2017-11-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2017-10-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2017-09-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2017-08-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2017-06-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2017-03-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2016-12-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2016-09-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2016-06-01/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2016-03-30/network [View full logs]info [Changelog] No exported changes
️✔️
network/mgmt/2015-06-15/network [View full logs]info [Changelog] No exported changes
️✔️
preview/network/mgmt/2015-05-01-preview/network [View full logs]info [Changelog] No exported changes
️🔄
azure-sdk-for-js inProgress [Detail]
️⚠️
azure-resource-manager-schemas warning [Detail]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json warn No file changes detected after generation warn Skip detect changed packages
NewApiVersionRequired reason: |
Hi @yanfa317, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
@yanfa317 This repo's default branch has been updated to main, I have updated the PR to target main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.