Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.BotService to add version preview/2021-05-01-preview #15182

Merged
merged 8 commits into from
Jul 22, 2021
Merged

[Hub Generated] Review request for Microsoft.BotService to add version preview/2021-05-01-preview #15182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b8ef5e3
initial actual changes
Jul 12, 2021
4fa428e
added example
Jul 13, 2021
babcdb7
corrected mistake in previous contract
Jul 13, 2021
5c769c0
fix prettier changes
Jul 13, 2021
b434243
fix model validation errors
Jul 13, 2021
c03f400
fix readonly
Jul 21, 2021
eafdef6
Merge branch 'master' into dev-botservice-Microsoft.BotService-2021-0…
swagatmishra2007 Jul 21, 2021
5a71e15
fix prettier issue
Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...tservice/resource-manager/Microsoft.BotService/preview/2021-05-01-preview/botservice.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1616,6 +1616,14 @@
"schemaTransformationVersion": {
"type": "string",
"description": "The channel schema transformation version for the bot"
},
"privateEndpointConnections": {
"type": "array",
"readOnly": true,
"description": "List of Private Endpoint Connections configured for the bot",
"items": {
"$ref": "./privatelinks.json#/definitions/PrivateEndpointConnection"
}
}
},
"description": "The parameters to provide for the Bot.",
Expand Down
18 changes: 17 additions & 1 deletion ...ice/resource-manager/Microsoft.BotService/preview/2021-05-01-preview/examples/GetBot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,24 @@
"isCmekEnabled": true,
"cmekKeyVaultUrl": "https://myCmekKey",
"isIsolated": false,
"schemaTransformationVersion": "1.0",
"disableLocalAuth": true,
"schemaTransformationVersion": "1.0"
"privateEndpointConnections": [
{
"id": "/subscriptions/subscription-id/resourceGroups/OneResourceGroupName/providers/Microsoft.BotService/botServices/samplebotname/privateEndpointConnections/privatelink",
"properties": {
"provisioningState": "Succeeded",
"privateEndpoint": {
"id": "/subscriptions/subscription-id/resourceGroups/OneResourceGroupName/providers/Microsoft.Network/privateEndpoints/privatelink"
},
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-Approved",
"actionsRequired": "None"
}
}
}
]
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...icrosoft.BotService/preview/2021-05-01-preview/examples/GetPrivateEndpointConnection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-Approved",
"actionRequired": "None"
"actionsRequired": "None"
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions ...rosoft.BotService/preview/2021-05-01-preview/examples/ListPrivateEndpointConnections.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-Approved",
"actionRequired": "None"
"actionsRequired": "None"
}
}
},
Expand All @@ -37,7 +37,7 @@
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-Approved",
"actionRequired": "None"
"actionsRequired": "None"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...icrosoft.BotService/preview/2021-05-01-preview/examples/PutPrivateEndpointConnection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-Approved",
"actionRequired": "None"
"actionsRequired": "None"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...ervice/resource-manager/Microsoft.BotService/preview/2021-05-01-preview/privatelinks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
"type": "string",
"description": "The reason for approval/rejection of the connection."
},
"actionRequired": {
"actionsRequired": {
swagatmishra2007 marked this conversation as resolved.
Show resolved Hide resolved
"type": "string",
"description": "A message indicating if changes on the service provider require any updates on the consumer."
}
Expand Down