Dev desktopvirtualization microsoft.desktop virtualization 2021 05 13 preview #14410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…review/2021-04-01-preview to version 2021-05-13-preview
|
Hi, @datr93 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Since operation 'UpdateValidationOperationResults_Get' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L2004 |
|
| Based on the response model schema, operation 'UpdateValidationOperationResults_Get' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L2000 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: validateOnly Location: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L4425 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: saveOriginalDisk Location: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L4439 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: beforeKickOff Location: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L4483 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: useSessionHostLocalTime Location: Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json#L4827 |
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.11)
- current:preview/2021-05-13-preview/desktopvirtualization.json compared with base:preview/2021-04-01-preview/desktopvirtualization.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"desktopvirtualization/resource-manager/readme.md",
"tag":"package-preview-2021-05",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"desktopvirtualization/resource-manager/readme.md",
"tag":"package-preview-2021-05",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"desktopvirtualization/resource-manager/readme.md",
"tag":"package-preview-2021-05",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @datr93 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @zhenglaizhang |
This was referenced May 13, 2021
datr93
force-pushed
the
dev-desktopvirtualization-Microsoft.DesktopVirtualization-2021-05-13-preview
branch
from
50f8cea
to
ddd8c8f
Compare
datr93
added
the
DoNotMerge
pilor
added
ARMSignedOff
|
@zhenglaizhang can you please take a look |
|
@datr93 All checks are passed, generally it looks good for me. It is better if some guy act as code owner or are familiar with the swagger could add approving review. Currently I cannot merge it as the PR requires 1 approving review. |
datr93
removed
the
DoNotMerge
|
Approved |
sampa-msft
approved these changes
May 18, 2021
...anager/Microsoft.DesktopVirtualization/preview/2021-05-13-preview/desktopvirtualization.json
Show resolved
Hide resolved
datr93
added
DoNotMerge
Ok I changed everything to default! |
chiragg4u
added
ARMSignedOff
|
Reviewed the changes from last approval, it looks good. Please follow the process given @ https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/212/Swagger-PR-Review |
|
@zhenglaizhang can you take a look! |
|
Hi @datr93 pls help fix the LintDiff warning in #14410 (comment), it's generally adviced to fix them fow new API version. |
Warmings isn't applicable |
It makes sense, all LGTM, so if you are fine, I will proceed to merge the PR |
zhenglaizhang
added
the
Approved-OkToMerge
|
@zhenglaizhang please merge!!!! |
This was referenced Jun 16, 2021
asager
pushed a commit
to asager/azure-rest-api-specs
that referenced
this pull request
Jun 24, 2021
… preview (Azure#14410) * Adds base for updating Microsoft.DesktopVirtualization from version preview/2021-04-01-preview to version 2021-05-13-preview * Updates readme * Updates API version in new specs and examples * add SAU and HPUpdate * new routes and sh props, and shc last updated time fix errors update SAU corect name sessionHostConfigurationLastUpdateTime and maintenance alert array add faultType * patch publicNetworkAccess * minor description changes * validate and initiate one endpoint, GET updateStatuses, GET validateStatuses * long running and examples * rename sessionhostconfigurations -> sessionhostconfigurations, hostpoolupdateparameters -> hostpoolupdateconfiguration * make updateStatuses/current endpoint a proxy, updateValidationResults, updateResults * fix system data and variable * pr comments rename updateStatuses to updateDetails and remove unsupported state * make status endpoints current * pageable and list operation more next link more pagination add refs of private link more importing issues undo breaking change remove unused HostPoolUpdateValidationResponseList prettier add description * system data for all examples for all * move shconfig to proxy obj * add cancel message * fix formatting * add parameter * philips pr comments * fix examples * move lastUpdate to shc proxy rename to version * pr comments migrate to update * add object type to private link * remove object type for one * change to default
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
… preview (Azure#14410) * Adds base for updating Microsoft.DesktopVirtualization from version preview/2021-04-01-preview to version 2021-05-13-preview * Updates readme * Updates API version in new specs and examples * add SAU and HPUpdate * new routes and sh props, and shc last updated time fix errors update SAU corect name sessionHostConfigurationLastUpdateTime and maintenance alert array add faultType * patch publicNetworkAccess * minor description changes * validate and initiate one endpoint, GET updateStatuses, GET validateStatuses * long running and examples * rename sessionhostconfigurations -> sessionhostconfigurations, hostpoolupdateparameters -> hostpoolupdateconfiguration * make updateStatuses/current endpoint a proxy, updateValidationResults, updateResults * fix system data and variable * pr comments rename updateStatuses to updateDetails and remove unsupported state * make status endpoints current * pageable and list operation more next link more pagination add refs of private link more importing issues undo breaking change remove unused HostPoolUpdateValidationResponseList prettier add description * system data for all examples for all * move shconfig to proxy obj * add cancel message * fix formatting * add parameter * philips pr comments * fix examples * move lastUpdate to shc proxy rename to version * pr comments migrate to update * add object type to private link * remove object type for one * change to default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.