Adding support for analytical storage schema types #14255

tomswedlund · 2021-05-05T19:56:06Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-05-05T19:56:10Z

Hi, @tomswedlund Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

ghost · 2021-05-05T19:56:10Z

Thank you for your contribution tomswedlund! We will review the pull request and get back to you soon.

openapi-pipeline-app · 2021-05-05T19:56:10Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 1 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- cosmos-db/resource-manager/readme.md tag:package-2021-05
Linted configuring files (Based on target branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- cosmos-db/resource-manager/readme.md tag:default

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ R4021 - DescriptionAndTitleMissing	'schemaType' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.DocumentDB/stable/2021-05-15/cosmos-db.json#L8374

The following errors/warnings exist before current PR submission:

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` R2026 - AvoidAnonymousTypes	Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.DocumentDB/stable/2021-05-15/cosmos-db.json#L7802
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.DocumentDB/stable/2021-05-15/cosmos-db.json#L402
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.DocumentDB/stable/2021-05-15/cosmos-db.json#L451
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.DocumentDB/stable/2021-05-15/notebook.json#L68
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.DocumentDB/stable/2021-05-15/notebook.json#L113
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.DocumentDB/stable/2021-05-15/notebook.json#L166
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.DocumentDB/stable/2021-05-15/notebook.json#L210
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.DocumentDB/stable/2021-05-15/notebook.json#L260
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.DocumentDB/stable/2021-05-15/notebook.json#L306
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.DocumentDB/stable/2021-05-15/notebook.json#L352

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ CIRCULAR_REFERENCE	The JSON file has a circular reference. readme: specification/cosmos-db/resource-manager/readme.md json: Microsoft.DocumentDB/stable/2021-05-15/privateEndpointConnection.json

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️❌Cross-Version Breaking Changes: 49 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.9)
- current:stable/2021-05-15/cosmos-db.json compared with base:preview/2021-04-01-preview/cosmos-db.json
- current:stable/2021-05-15/notebook.json compared with base:preview/2021-04-01-preview/notebook.json
- current:stable/2021-05-15/privateEndpointConnection.json compared with base:preview/2021-04-01-preview/privateEndpointConnection.json
- current:stable/2021-05-15/privateLinkResources.json compared with base:preview/2021-04-01-preview/privateLinkResources.json
- current:stable/2021-05-15/rbac.json compared with base:preview/2021-04-01-preview/rbac.json
- current:stable/2021-05-15/cosmos-db.json compared with base:stable/2021-04-15/cosmos-db.json
- current:stable/2021-05-15/notebook.json compared with base:stable/2021-04-15/notebook.json
- current:stable/2021-05-15/privateEndpointConnection.json compared with base:stable/2021-04-15/privateEndpointConnection.json
- current:stable/2021-05-15/privateLinkResources.json compared with base:stable/2021-04-15/privateLinkResources.json
- current:stable/2021-05-15/rbac.json compared with base:stable/2021-04-15/rbac.json

The following breaking changes are detected by comparison with latest preview version:

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DocumentDB/locations/{location}/restorableDatabaseAccounts' removed or restructured? Old: Microsoft.DocumentDB/preview/2021-04-01-preview/cosmos-db.json#L5040:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DocumentDB/restorableDatabaseAccounts' removed or restructured? Old: Microsoft.DocumentDB/preview/2021-04-01-preview/cosmos-db.json#L5079:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DocumentDB/locations' removed or restructured? Old: Microsoft.DocumentDB/preview/2021-04-01-preview/cosmos-db.json#L5115:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DocumentDB/locations/{location}' removed or restructured? Old: Microsoft.DocumentDB/preview/2021-04-01-preview/cosmos-db.json#L5151:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DocumentDB/locations/{location}/restorableDatabaseAccounts/{instanceId}' removed or restructured? Old: Microsoft.DocumentDB/preview/2021-04-01-preview/cosmos-db.json#L5187:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/{accountName}/sqlDatabases/{databaseName}/containers/{containerName}/retrieveContinuousBackupInformation' removed or restructured? Old: Microsoft.DocumentDB/preview/2021-04-01-preview/cosmos-db.json#L5226:5
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'DefaultRequestDatabaseAccountCreateUpdateProperties' removed or renamed? New: Microsoft.DocumentDB/stable/2021-05-15/cosmos-db.json#L5050:3 Old: Microsoft.DocumentDB/preview/2021-04-01-preview/cosmos-db.json#L5279:3
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'RestoreReqeustDatabaseAccountCreateUpdateProperties' removed or renamed? New: Microsoft.DocumentDB/stable/2021-05-15/cosmos-db.json#L5050:3 Old: Microsoft.DocumentDB/preview/2021-04-01-preview/cosmos-db.json#L5279:3
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'CreateMode' removed or renamed? New: Microsoft.DocumentDB/stable/2021-05-15/cosmos-db.json#L5050:3 Old: Microsoft.DocumentDB/preview/2021-04-01-preview/cosmos-db.json#L5279:3
`❌` 1006 - RemovedDefinition	The new version is missing a definition that was found in the old version. Was 'ContinuousBackupRestoreLocation' removed or renamed? New: Microsoft.DocumentDB/stable/2021-05-15/cosmos-db.json#L5050:3 Old: Microsoft.DocumentDB/preview/2021-04-01-preview/cosmos-db.json#L5279:3

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

cosmos-db/resource-manager/readme.md#package-2021-05

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"cosmos-db/resource-manager/readme.md",
"tag":"package-2021-05",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"cosmos-db/resource-manager/readme.md",
"tag":"package-2021-05",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"cosmos-db/resource-manager/readme.md",
"tag":"package-2021-05",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-05-05T19:56:11Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-05-05T19:56:11Z

Swagger Generation Artifacts

️❌[Staging] ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` RestBuild error	"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=219172&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 "

️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-cosmosdb - 6.3.0

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 98786a3. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-cosmosdb [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model DatabaseAccountGetResults has a new parameter analytical_storage_configuration
info	[Changelog]   - Model DatabaseAccountUpdateParameters has a new parameter analytical_storage_configuration
info	[Changelog]   - Model DatabaseAccountCreateUpdateParameters has a new parameter analytical_storage_configuration

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 98786a3. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-05-28 07:50:01 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-cosmos-generated"
cmderr	[generate.py] 2021-05-28 07:50:01 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-05-28 07:50:01 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.29 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/cosmos/azure-resourcemanager-cosmos-generated --java.namespace=com.azure.resourcemanager.cosmos.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/cosmos-db/resource-manager/readme.md
cmderr	[generate.py] 2021-05-28 07:50:54 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-05-28 07:50:54 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-05-28 07:50:54 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-05-28 07:50:54 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-05-28 07:50:54 INFO [POM][Skip] pom already has module sdk/cosmos
cmderr	[generate.py] 2021-05-28 07:50:54 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-cosmos-generated [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-05-28 07:54:34 DEBUG Got artifact_id: azure-resourcemanager-cosmos-generated
cmderr	[Inst] 2021-05-28 07:54:34 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-05-28 07:54:34 DEBUG Got artifact: azure-resourcemanager-cosmos-generated-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-05-28 07:54:34 DEBUG Got artifact: azure-resourcemanager-cosmos-generated-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-05-28 07:54:34 DEBUG Got artifact: azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-05-28 07:54:34 DEBUG Match jar package: azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-05-28 07:54:34 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14255/azure-sdk-for-java/azure-resourcemanager-cosmos-generated/azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-cosmos-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-cosmos-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 98786a3. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️cosmos-db/mgmt/2021-04-15/documentdb [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
```
️✔️cosmos-db/mgmt/2021-03-15/documentdb [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️cosmos-db/mgmt/2021-01-15/documentdb [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️cosmos-db/mgmt/2019-08-01/documentdb [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️cosmos-db/mgmt/2015-04-08/documentdb [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️✔️preview/cosmos-db/mgmt/2021-04-01-preview/documentdb [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 10 items here, please refer to log for details.

info	[Changelog] - New const `ConsistentPrefix`
info	[Changelog] - New const `Hash`
info	[Changelog] - New const `Point`
info	[Changelog] - New const `LastWriterWins`
info	[Changelog] - New const `ServiceTypeDataTransferServiceResourceProperties`
info	[Changelog] - New const `Deleting`
info	[Changelog] - New const `Number`
info	[Changelog]
info	[Changelog] Total 92 breaking change(s), 90 additive change(s).
info	[Changelog]

️✔️preview/cosmos-db/mgmt/2021-03-01-preview/documentdb [View full logs] [Release SDK Changes]

Only show 10 items here, please refer to log for details.

info	[Changelog] - New function `BaseClient.LocationGetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `BaseClient.LocationGetPreparer(context.Context, string) (*http.Request, error)`
info	[Changelog] - New function `BaseClient.LocationGetResponder(*http.Response) (LocationGetResult, error)`
info	[Changelog] - New function `BaseClient.LocationListPreparer(context.Context) (*http.Request, error)`
info	[Changelog] - New struct `LocationGetResult`
info	[Changelog] - New struct `LocationListResult`
info	[Changelog] - New struct `LocationProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 15 additive change(s).
info	[Changelog]

️✔️preview/cosmos-db/mgmt/2020-09-01-preview/documentdb [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️✔️preview/cosmos-db/mgmt/2020-06-01-preview/documentdb [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 10 items here, please refer to log for details.

info	[Changelog]
info	[Changelog] - New const `Zone`
info	[Changelog] - New const `Geo`
info	[Changelog] - New const `Local`
info	[Changelog] - New function `PossibleBackupStorageRedundancyValues() []BackupStorageRedundancy`
info	[Changelog] - New struct `CloudError`
info	[Changelog] - New field `BackupStorageRedundancy` in struct `PeriodicModeProperties`
info	[Changelog]
info	[Changelog] Total 7 breaking change(s), 7 additive change(s).
info	[Changelog]

️✔️preview/cosmos-db/mgmt/2020-04-01-preview/documentdb [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/cosmos-db/mgmt/2020-03-01-preview/documentdb [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/cosmos-db/mgmt/2019-12-12-preview/documentdb [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/cosmos-db/mgmt/2019-08-01-preview/documentdb [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 98786a3. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/cosmos-db/resource-manager/readme.md

️✔️@azure/arm-cosmosdb [View full logs] [Release SDK Changes]

azure-arm-cosmosdb-13.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/cosmosDBManagementClient.js → ./dist/arm-cosmosdb.js...
cmderr	[npmPack] created ./dist/arm-cosmosdb.js in 904ms

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 98786a3. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️cosmos-db [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-05-05T19:56:14Z

Hi, @tomswedlund your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @

ghost · 2021-05-05T19:56:18Z

All CLA requirements met.

openapi-workflow-bot · 2021-05-05T19:58:14Z

Hi @tomswedlund, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

mentat9 · 2021-05-07T15:49:56Z

Note: although this PR is labeled as WaitForArmReview, it won't be reviewed by ARM reviewers until it is promoted from Draft.

...anager/Microsoft.DocumentDB/stable/2021-05-15/examples/CosmosDBDatabaseAccountCreateMax.json

tomswedlund · 2021-05-26T15:17:09Z

Hi Ray,
Looks like some of the PR's build is queued but not making progress. Can this be merged?
Thanks,
Tom

raych1 · 2021-05-27T01:19:52Z

/azp run

azure-pipelines · 2021-05-27T01:20:03Z

Azure Pipelines successfully started running 1 pipeline(s).

raych1 · 2021-05-27T01:22:49Z

@ArcturusZhang , can you have a look at the potential breaking change for GO SDK?

raych1 · 2021-05-27T01:37:06Z

Hi Ray,
Looks like some of the PR's build is queued but not making progress. Can this be merged?
Thanks,
Tom

Checks result look good now.

tomswedlund · 2021-05-27T11:21:30Z

Hi Ray,
Looks like some of the PR's build is queued but not making progress. Can this be merged?
Thanks,
Tom

Checks result look good now.

Can it be merged now?

raych1 · 2021-05-27T13:56:59Z

It needs @ArcturusZhang to check the potential breaking change for GO SDK.

ArcturusZhang · 2021-05-27T23:48:46Z

The breaking changes are accumulated by previous PRs

* introducing new api version 2021-05-15 * updating api versions * adding definitions & examples for AnalyticalStorageConfiguration * adding a forgotten entry to an example json file * fixing bug * adding swagger files to readme * fixing spelling error Co-authored-by: Tom Swedlund <toswedlu@microsoft.com>

toswedlu added 3 commits May 5, 2021 15:15

introducing new api version 2021-05-15

6836fc2

updating api versions

2081950

adding definitions & examples for AnalyticalStorageConfiguration

4143441

ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label May 5, 2021

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 5, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label May 5, 2021

openapi-pipeline-app bot added CI-BreakingChange-Go and removed CI-FixRequiredOnFailure labels May 5, 2021

tomswedlund marked this pull request as ready for review May 10, 2021 18:01

tomswedlund requested review from MehaKaushik and shurd as code owners May 10, 2021 18:01

openapi-assignment-bot bot assigned raych1 May 10, 2021

pilor self-requested a review May 10, 2021 23:14

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 10, 2021

MehaKaushik added the DoNotMerge <valid label in PR review process> use to hold merge after approval label May 11, 2021

MehaKaushik reviewed May 11, 2021

View reviewed changes

...anager/Microsoft.DocumentDB/stable/2021-05-15/examples/CosmosDBDatabaseAccountCreateMax.json Show resolved Hide resolved

raych1 approved these changes May 28, 2021

View reviewed changes

raych1 merged commit 98786a3 into Azure:master May 28, 2021

heaths mentioned this pull request Jun 16, 2021

Initial 2021-05-01-preview version #14855

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding support for analytical storage schema types #14255

Adding support for analytical storage schema types #14255

tomswedlund commented May 5, 2021

openapi-workflow-bot bot commented May 5, 2021

ghost commented May 5, 2021

openapi-pipeline-app bot commented May 5, 2021 •

edited

Loading

openapi-workflow-bot bot commented May 5, 2021

openapi-pipeline-app bot commented May 5, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented May 5, 2021

ghost commented May 5, 2021 •

edited by ghost

Loading

openapi-workflow-bot bot commented May 5, 2021

mentat9 commented May 7, 2021

tomswedlund commented May 26, 2021

raych1 commented May 27, 2021

azure-pipelines bot commented May 27, 2021

raych1 commented May 27, 2021

raych1 commented May 27, 2021

tomswedlund commented May 27, 2021

raych1 commented May 27, 2021

ArcturusZhang commented May 27, 2021

Adding support for analytical storage schema types #14255

Adding support for analytical storage schema types #14255

Conversation

tomswedlund commented May 5, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented May 5, 2021

ghost commented May 5, 2021

openapi-pipeline-app bot commented May 5, 2021 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented May 5, 2021

openapi-pipeline-app bot commented May 5, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented May 5, 2021

ghost commented May 5, 2021 • edited by ghost Loading

openapi-workflow-bot bot commented May 5, 2021

mentat9 commented May 7, 2021

tomswedlund commented May 26, 2021

raych1 commented May 27, 2021

azure-pipelines bot commented May 27, 2021

raych1 commented May 27, 2021

raych1 commented May 27, 2021

tomswedlund commented May 27, 2021

raych1 commented May 27, 2021

ArcturusZhang commented May 27, 2021

openapi-pipeline-app bot commented May 5, 2021 •

edited

Loading

openapi-pipeline-app bot commented May 5, 2021 •

edited

Loading

ghost commented May 5, 2021 •

edited by ghost

Loading