[Hub Generated] Review request for Microsoft.KeyVault to add version stable/2019-09-01 #13196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @jiacheng-L Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The read only property has changed from 'false' to 'true'. New: Microsoft.KeyVault/stable/2019-09-01/keys.json#L446:9 Old: Microsoft.KeyVault/stable/2019-09-01/keys.json#L446:9 |
|
The read only property has changed from 'false' to 'true'. New: Microsoft.KeyVault/stable/2019-09-01/keys.json#L467:9 Old: Microsoft.KeyVault/stable/2019-09-01/keys.json#L466:9 |
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 138 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"keyvault/resource-manager/readme.md", "tag":"package-preview-2020-04", "details":"The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"keyvault/resource-manager/readme.md", "tag":"package-preview-2020-04", "details":"The schema 'CloudErrorBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"keyvault/resource-manager/readme.md", "tag":"package-preview-2020-04", "details":"The schema 'Sku' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"keyvault/resource-manager/readme.md", "tag":"package-preview-2020-04", "details":"The schema 'AccessPolicyEntry' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"keyvault/resource-manager/readme.md", "tag":"package-preview-2020-04", "details":"The schema 'Permissions' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"keyvault/resource-manager/readme.md", "tag":"package-preview-2020-04", "details":"The schema 'VaultProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"keyvault/resource-manager/readme.md", "tag":"package-preview-2020-04", "details":"The schema 'VaultPatchProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"keyvault/resource-manager/readme.md", "tag":"package-preview-2020-04", "details":"The schema 'VaultAccessPolicyProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"keyvault/resource-manager/readme.md", "tag":"package-preview-2020-04", "details":"The schema 'DeletedVaultProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"keyvault/resource-manager/readme.md", "tag":"package-preview-2020-04", "details":"The schema 'VaultCreateOrUpdateParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Hi @jiacheng-L, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Feb 28, 2021
This was referenced Feb 28, 2021
jiacheng-L
requested review from
heaths,
jlichwa and
RandalliLama
as code owners
|
In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki Window to Fix Broken for more details. |
raych1
reviewed
Mar 1, 2021
| @@ -1299,7 +1304,8 @@ | |||
| "x-ms-enum": { | |||
| "name": "CreateMode", | |||
| "modelAsString": false | |||
| } | |||
| }, | |||
| "x-ms-secret": true | |||
There was a problem hiding this comment.
createMode doesn't seem to be a secret?
There was a problem hiding this comment.
It is for fixing this swagger error: https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=6412D966-7158-4823-A942-17403BA9635C. Based on the document here, write-only or secret-carrier can marked with "x-ms-secret"
There was a problem hiding this comment.
write-only and secret is different things, please use "x-ms-mutability": ["create", "update"] for write-only annotation.
There was a problem hiding this comment.
@jiacheng-L , can you make this change?
|
@jiacheng-L , can you please add the link to s360 work items? |
Sure. For createMode: For key properties: |
raych1
added
the
Reviewed-ChangesRequested
jlichwa
approved these changes
Mar 8, 2021
raych1
removed
the
Reviewed-ChangesRequested
|
@ArcturusZhang , can you confirm if this PR has breaking change for GO SDK? |
|
@raych1 The breaking changes are introduced long ago because we have not received any release request on keyvault for a long time. |
raych1
added
the
Approved-BreakingChange
This was referenced Mar 11, 2021
|
@ArcturusZhang Thanks for the info. I will do it soon. |
MirzaSikander
pushed a commit
to MirzaSikander/azure-rest-api-specs
that referenced
this pull request
Mar 22, 2021
…stable/2019-09-01 (Azure#13196) * Add missing property and annotation * Fix typo * Address PR comment * Prettier Check
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…stable/2019-09-01 (Azure#13196) * Add missing property and annotation * Fix typo * Address PR comment * Prettier Check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.