Microsoft.Compute: Add new stable API version 2021-03-01 for CloudServices resource #13155

stephenhou · 2021-02-25T01:13:49Z

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-02-25T01:13:51Z

Hi, @stephenhou Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-02-25T01:13:52Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 133 Warnings warning [Detail]

Only 10 items are listed, please refer to log for more details.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- compute/resource-manager/readme.md tag:package-2021-03-01
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- compute/resource-manager/readme.md tag:default

Rule	Message
⚠️ R1006 - PutInOperationName	'PUT' operation 'CloudServicesUpdateDomain_WalkUpdateDomain' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Compute/stable/2021-03-01/cloudService.json#L1295
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Compute/stable/2021-03-01/cloudService.json#L1884
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Compute/stable/2021-03-01/cloudService.json#L1963
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Compute/stable/2021-03-01/cloudService.json#L2089
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Compute/stable/2021-03-01/cloudService.json#L2126
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Compute/stable/2021-03-01/cloudService.json#L2221
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Compute/stable/2021-03-01/cloudService.json#L2320
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Compute/stable/2021-03-01/cloudService.json#L2525
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Compute/stable/2021-03-01/cloudService.json#L2621
⚠️ R2004 - NonApplicationJsonType	Only 'application/json' content-type is supported by ARM. Location: Microsoft.Compute/stable/2021-03-01/cloudService.json#L433

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2021-03-01

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 6 Warnings warning [Detail]

Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2020-10-01-preview/cloudService.json <---> new: stable/2021-03-01/cloudService.json

Rule	Message
⚠️ 1034 - AddedRequiredProperty	The new version has new required property 'name, properties' that was not found in the old version. New: Microsoft.Compute/stable/2021-03-01/cloudService.json#L2105:11 Old: Microsoft.Compute/preview/2020-10-01-preview/cloudService.json#L1785:11
⚠️ 1034 - AddedRequiredProperty	The new version has new required property 'frontendIPConfigurations' that was not found in the old version. New: Microsoft.Compute/stable/2021-03-01/cloudService.json#L2126:9 Old: Microsoft.Compute/preview/2020-10-01-preview/cloudService.json#L1799:9
⚠️ 1034 - AddedRequiredProperty	The new version has new required property 'name, properties' that was not found in the old version. New: Microsoft.Compute/stable/2021-03-01/cloudService.json#L2143:11 Old: Microsoft.Compute/preview/2020-10-01-preview/cloudService.json#L1811:11
⚠️ 1034 - AddedRequiredProperty	The new version has new required property 'name, properties' that was not found in the old version. New: Microsoft.Compute/stable/2021-03-01/cloudService.json#L2082:5 Old: Microsoft.Compute/preview/2020-10-01-preview/cloudService.json#L1768:5
⚠️ 1034 - AddedRequiredProperty	The new version has new required property 'frontendIPConfigurations' that was not found in the old version. New: Microsoft.Compute/stable/2021-03-01/cloudService.json#L2099:5 Old: Microsoft.Compute/preview/2020-10-01-preview/cloudService.json#L1779:5
⚠️ 1034 - AddedRequiredProperty	The new version has new required property 'name, properties' that was not found in the old version. New: Microsoft.Compute/stable/2021-03-01/cloudService.json#L2114:5 Old: Microsoft.Compute/preview/2020-10-01-preview/cloudService.json#L1791:5

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️❌[Staging] SDK Track2 Validation: 8 Errors, 9280 Warnings failed [Detail]

Only 10 items are listed, please refer to log for more details.

The following tags are being changed in this PR

Rule	Message
`❌` PreCheck/DuplicateSchema	"readme":"compute/resource-manager/readme.md", "tag":"package-2020-12-01", "details":"Duplicate Schema named PurchasePlan -- properties.promotionCode: undefined => "description":"The Offer Promotion Code.", "$ref":"#/components/schemas/schemas:1246" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` AutorestCore/Exception	"readme":"compute/resource-manager/readme.md", "tag":"package-2020-12-01", "details":"Error: Plugin prechecker reported failure."
`❌` PreCheck/DuplicateSchema	"readme":"compute/resource-manager/readme.md", "tag":"package-2020-10-01-preview", "details":"Duplicate Schema named PurchasePlan -- properties.promotionCode: undefined => "description":"The Offer Promotion Code.", "$ref":"#/components/schemas/schemas:1168" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` AutorestCore/Exception	"readme":"compute/resource-manager/readme.md", "tag":"package-2020-10-01-preview", "details":"Error: Plugin prechecker reported failure."
`❌` PreCheck/DuplicateSchema	"readme":"compute/resource-manager/readme.md", "tag":"package-2020-09-30", "details":"Duplicate Schema named PurchasePlan -- properties.promotionCode: undefined => "description":"The Offer Promotion Code.", "$ref":"#/components/schemas/schemas:1168" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` AutorestCore/Exception	"readme":"compute/resource-manager/readme.md", "tag":"package-2020-09-30", "details":"Error: Plugin prechecker reported failure."
`❌` PreCheck/DuplicateSchema	"readme":"compute/resource-manager/readme.md", "tag":"package-2021-03-01", "details":"Duplicate Schema named PurchasePlan -- properties.promotionCode: undefined => "description":"The Offer Promotion Code.", "$ref":"#/components/schemas/schemas:1246" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` AutorestCore/Exception	"readme":"compute/resource-manager/readme.md", "tag":"package-2021-03-01", "details":"Error: Plugin prechecker reported failure."
⚠️ PreCheck/SchemaMissingType	"readme":"compute/resource-manager/readme.md", "tag":"package-2020-12-01", "details":"The schema 'ComputeOperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"compute/resource-manager/readme.md", "tag":"package-2020-12-01", "details":"The schema 'ComputeOperationValue' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-02-25T01:13:53Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 7b19bbd. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️profiles/2020-09-01/compute/mgmt/compute [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2017-01-31/containerservice [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2016-09-30/containerservice [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️containerservice/mgmt/2016-03-30/containerservice [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️✔️compute/mgmt/2020-12-01/compute [View full logs] [Release SDK Changes]