-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[Hub Generated] Review request for Microsoft.Resources to add version stable/2021-01-01" #13128
Merged
raych1
merged 1 commit into
master
from
revert-13000-dev-resources-Microsoft.Resources-2021-01-01
Feb 24, 2021
Merged
Revert "[Hub Generated] Review request for Microsoft.Resources to add version stable/2021-01-01" #13128
raych1
merged 1 commit into
master
from
revert-13000-dev-resources-Microsoft.Resources-2021-01-01
Feb 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, @shenglol Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Swagger Generation Artifacts
|
This was referenced Feb 24, 2021
raych1
approved these changes
Feb 24, 2021
This was referenced Feb 24, 2021
This was referenced Feb 24, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
… version stable/2021-01-01 (Azure#13000)" (Azure#13128) This reverts commit 231d094.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #13000
Our backend is not ready yet and #13000 was merged by accident. We need #13000 to be approved to unblock our back-end PR, but we didn't meant to get it merged.
Also Microsoft.Resources/templateSpecs does not have any plan to support 2021-01-01 as one of our collogues pointed out. I'll send out a new PR to partially update
resources.json
once this is merged.