Adding recoveryservices swagger for api-version 2021-01-01 #13110

amchandn · 2021-02-23T08:59:19Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-02-23T08:59:22Z

Hi, @amchandn Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-02-23T08:59:23Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- recoveryservices/resource-manager/readme.md tag:package-2021-01
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- recoveryservices/resource-manager/readme.md tag:default

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2020-10-01/registeredidentities.json <---> new: stable/2021-01-01/registeredidentities.json
- original: stable/2020-10-01/replicationusages.json <---> new: stable/2021-01-01/replicationusages.json
- original: stable/2020-10-01/vaults.json <---> new: stable/2021-01-01/vaults.json
- original: stable/2020-10-01/vaultusages.json <---> new: stable/2021-01-01/vaultusages.json

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 4 Warnings warning [Detail]

The following tags are being changed in this PR

recoveryservices/resource-manager/readme.md#package-2021-01

Rule	Message
⚠️ PreCheck/SchemaMissingType	"readme":"recoveryservices/resource-manager/readme.md", "tag":"package-2021-01", "details":"The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"recoveryservices/resource-manager/readme.md", "tag":"package-2021-01", "details":"The schema 'Error' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"recoveryservices/resource-manager/readme.md", "tag":"package-2021-01", "details":"The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/CheckDuplicateSchemas	"readme":"recoveryservices/resource-manager/readme.md", "tag":"package-2021-01", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail."

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-02-23T08:59:24Z

Swagger Generation Artifacts

️🔄[Staging] ApiDocPreview inProgress [Detail]

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs] Generate from 184bebee7636a21a8ac18a7841e817a6cfff1a9a. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/recoveryservices/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/resources/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.RecoveryServices [View full logs] [Preview SDK Changes]

cmdout	[msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Generated/RecoveryServicesClient.cs(29,90): error CS0535: 'RecoveryServicesClient' does not implement interface member 'IRecoveryServicesClient.GetOperationResultWithHttpMessagesAsync(string, string, string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Microsoft.Azure.Management.RecoveryServices.csproj]
cmdout	[msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Generated/RecoveryServicesClient.cs(29,90): error CS0535: 'RecoveryServicesClient' does not implement interface member 'IRecoveryServicesClient.GetOperationResultWithHttpMessagesAsync(string, string, string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Microsoft.Azure.Management.RecoveryServices.csproj]
cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Generated/RecoveryServicesClient.cs(29,90): error CS0535: 'RecoveryServicesClient' does not implement interface member 'IRecoveryServicesClient.GetOperationResultWithHttpMessagesAsync(string, string, string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Microsoft.Azure.Management.RecoveryServices.csproj]
cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Generated/RecoveryServicesClient.cs(29,90): error CS0535: 'RecoveryServicesClient' does not implement interface member 'IRecoveryServicesClient.GetOperationResultWithHttpMessagesAsync(string, string, string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Microsoft.Azure.Management.RecoveryServices.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Generated/RecoveryServicesClient.cs(29,90): error CS0535: 'RecoveryServicesClient' does not implement interface member 'IRecoveryServicesClient.GetOperationResultWithHttpMessagesAsync(string, string, string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Microsoft.Azure.Management.RecoveryServices.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Generated/RecoveryServicesClient.cs(29,90): error CS0535: 'RecoveryServicesClient' does not implement interface member 'IRecoveryServicesClient.GetOperationResultWithHttpMessagesAsync(string, string, string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Microsoft.Azure.Management.RecoveryServices.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Generated/RecoveryServicesClient.cs(29,90): error CS0535: 'RecoveryServicesClient' does not implement interface member 'IRecoveryServicesClient.GetOperationResultWithHttpMessagesAsync(string, string, string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Microsoft.Azure.Management.RecoveryServices.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Generated/RecoveryServicesClient.cs(29,90): error CS0535: 'RecoveryServicesClient' does not implement interface member 'IRecoveryServicesClient.GetOperationResultWithHttpMessagesAsync(string, string, string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Microsoft.Azure.Management.RecoveryServices.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️✔️Microsoft.Azure.Management.ResourceManager [View full logs] [Preview SDK Changes]
- Microsoft.Azure.Management.ResourceManager.3.12.1-preview.nupkg
- Microsoft.Azure.Management.ResourceManager.3.12.1-preview.snupkg

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 184bebee7636a21a8ac18a7841e817a6cfff1a9a. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-23 09:05:55 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-recoveryservices;1.0.0-beta.1;1.0.0-beta.2"
cmderr	[generate.py] 2021-02-23 09:05:55 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
cmderr	[generate.py] 2021-02-23 09:05:55 INFO autorest --version=3.0.6369 --use=@autorest/java@4.0.17 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/recoveryservices/azure-resourcemanager-recoveryservices --java.namespace=com.azure.resourcemanager.recoveryservices   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/recoveryservices/resource-manager/readme.md
cmderr	[generate.py] 2021-02-23 09:06:36 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-recoveryservices
cmderr	[generate.py] 2021-02-23 09:06:36 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-23 09:06:36 INFO [POM][Skip] pom already has module azure-resourcemanager-recoveryservices
cmderr	[generate.py] 2021-02-23 09:06:36 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-23 09:06:36 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-23 09:06:36 INFO [POM][Skip] pom already has module sdk/recoveryservices
cmderr	[generate.py] 2021-02-23 09:06:36 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-recoveryservices [View full logs] [Preview SDK Changes]

cmderr	[Inst] 2021-02-23 09:10:30 DEBUG Got artifact_id: azure-resourcemanager-recoveryservices
cmderr	[Inst] 2021-02-23 09:10:30 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-23 09:10:30 DEBUG Got artifact: azure-resourcemanager-recoveryservices-1.0.0-beta.2.jar
cmderr	[Inst] 2021-02-23 09:10:30 DEBUG Match jar package: azure-resourcemanager-recoveryservices-1.0.0-beta.2.jar
cmderr	[Inst] 2021-02-23 09:10:30 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13110/azure-sdk-for-java/azure-resourcemanager-recoveryservices/azure-resourcemanager-recoveryservices-1.0.0-beta.2.jar\" -o azure-resourcemanager-recoveryservices-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-recoveryservices -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-recoveryservices-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs] Generate from 4eeb7ae10ab15c2c46fef9dbd80cc67a9a3ec3f3. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-recoveryservices [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Sku has a new parameter tier
info	[Changelog]   - Model VaultProperties has a new parameter encryption
info	[Changelog]   - Model IdentityData has a new parameter user_assigned_identities
info	[Changelog]   - Model TrackedResource has a new parameter etag
info	[Changelog]   - Model Vault has a new parameter etag
info	[Changelog]   - Model Vault has a new parameter system_data
info	[Changelog]   - Model Resource has a new parameter etag
info	[Changelog]   - Model ResourceCertificateAndAadDetails has a new parameter service_resource_id
info	[Changelog]   - Model VaultExtendedInfoResource has a new parameter etag
info	[Changelog]   - Model PatchVault has a new parameter etag
info	[Changelog]   - Model PatchTrackedResource has a new parameter etag
info	[Changelog]   - Added operation group RecoveryServicesClientOperationsMixin
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model TrackedResource no longer has parameter e_tag
info	[Changelog]   - Model Vault no longer has parameter e_tag
info	[Changelog]   - Model Resource no longer has parameter e_tag
info	[Changelog]   - Model VaultExtendedInfoResource no longer has parameter e_tag
info	[Changelog]   - Model PatchVault no longer has parameter e_tag
info	[Changelog]   - Model PatchTrackedResource no longer has parameter e_tag

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 184bebee7636a21a8ac18a7841e817a6cfff1a9a. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️recoveryservices/mgmt/2016-06-01/recoveryservices [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 184bebee7636a21a8ac18a7841e817a6cfff1a9a. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/recoveryservices/resource-manager/readme.md

️✔️@azure/arm-recoveryservices [View full logs] [Preview SDK Changes]

azure-arm-recoveryservices-4.1.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/recoveryServicesClient.js → ./dist/arm-recoveryservices.js...
cmderr	[npmPack] created ./dist/arm-recoveryservices.js in 361ms

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 184bebee7636a21a8ac18a7841e817a6cfff1a9a. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/recoveryservices/resource-manager/readme.md

️✔️recoveryservices [View full logs] [Preview Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-02-23T09:18:00Z

In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki Window to Fix Broken for more details.

openapi-workflow-bot · 2021-02-23T09:19:46Z

Hi, @amchandn your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @chunyu3

RamyasreeChakka · 2021-02-27T00:30:23Z

...r/Microsoft.RecoveryServices/stable/2021-01-01/examples/CheckNameAvailability_Available.json

+  "parameters": {
+    "subscriptionId": "77777777-b0c6-47a2-b37c-d8e65a629c18",
+    "resourceGroupName": "resGroupFoo",
+    "api-version": "2021-01-01",


While adding new version the recommendation is to copy the existing version into new directory structure for first commit and then push new changes for easy review. Please create new branch with this recommendation for faster review.

@RamyasreeChakka , apart from adding the files for new API-version, I've only modified readme.md files to include newer API version and change the default version in the readme files to the latest version.

My apologies @RamyasreeChakka for selecting the tickbox - 'update existing version to fix swagger quality issue in s360'

I dont need to select this checkbox and I've unselected it.

Can you please review this PR?

RamyasreeChakka · 2021-02-27T00:32:54Z

@amchandn From change log, I see your PR addressing below two things...

Adding new API version
Fixing swagger issue for existing version
For faster and easier reviews, please raise separate PRs for 1 & 2.
For 1, While adding new version the recommendation is to copy the existing version into new directory structure for first commit and then push new changes in subsequent commits.

amchandn · 2021-02-27T05:08:09Z

@amchandn From change log, I see your PR addressing below two things...

Adding new API version

Fixing swagger issue for existing version
For faster and easier reviews, please raise separate PRs for 1 & 2.
For 1, While adding new version the recommendation is to copy the existing version into new directory structure for first commit and then push new changes in subsequent commits.

@RamyasreeChakka , I had mistakenly selected the checkbox - 'update existing version to fix swagger quality issue in s360' and I've unselected it now.

My changes only include addition of a new api-version for swagger.

chiragg4u · 2021-03-01T16:27:23Z

While adding new version the recommendation is to copy the existing version into new directory structure for first commit and then push new changes for easy review. Please create new branch with this recommendation for faster review.

amchandn · 2021-03-01T16:56:18Z

While adding new version the recommendation is to copy the existing version into new directory structure for first commit and then push new changes for easy review. Please create new branch with this recommendation for faster review.

@chiragg4u
Please find the new PR created by the process you suggested at -
#13206

Requesting your review of the above PR

Adding swagger for api-version 2021-01-01

2ce6bbf

openapi-assignment-bot bot assigned chunyu3 Feb 23, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Python label Feb 23, 2021

openapi-workflow-bot bot added the FixS360 label Feb 23, 2021

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 23, 2021

RamyasreeChakka reviewed Feb 27, 2021

View reviewed changes

RamyasreeChakka added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 27, 2021

amchandn closed this Mar 1, 2021

amchandn mentioned this pull request Mar 1, 2021

Adding recoveryservices swagger for api-version 2021-01-01 #13206

Merged

25 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding recoveryservices swagger for api-version 2021-01-01 #13110

Adding recoveryservices swagger for api-version 2021-01-01 #13110

amchandn commented Feb 23, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 23, 2021

openapi-pipeline-app bot commented Feb 23, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 23, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 23, 2021

openapi-workflow-bot bot commented Feb 23, 2021

RamyasreeChakka Feb 27, 2021

amchandn Feb 27, 2021

amchandn Feb 27, 2021

RamyasreeChakka commented Feb 27, 2021

amchandn commented Feb 27, 2021

chiragg4u commented Mar 1, 2021

amchandn commented Mar 1, 2021

Adding recoveryservices swagger for api-version 2021-01-01 #13110

Adding recoveryservices swagger for api-version 2021-01-01 #13110

Conversation

amchandn commented Feb 23, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 23, 2021

openapi-pipeline-app bot commented Feb 23, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 23, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Feb 23, 2021

openapi-workflow-bot bot commented Feb 23, 2021

RamyasreeChakka Feb 27, 2021

Choose a reason for hiding this comment

amchandn Feb 27, 2021

Choose a reason for hiding this comment

amchandn Feb 27, 2021

Choose a reason for hiding this comment

RamyasreeChakka commented Feb 27, 2021

amchandn commented Feb 27, 2021

chiragg4u commented Mar 1, 2021

amchandn commented Mar 1, 2021

amchandn commented Feb 23, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 23, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 23, 2021 •

edited

Loading