Adding api-version 2020-10-01 in readme.azureresourceschema.md #13096

amchandn · 2021-02-22T19:29:51Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify: To update azureresourceschema readme files to help auto generate schemas for new apiVersions (fixes Microsoft.RecoveryServices is missing azureresourceschema configuration for API version 2020-10-01 #13093 )
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-02-22T19:29:53Z

Hi, @amchandn Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-02-22T19:29:53Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-02-22T19:29:54Z

Swagger Generation Artifacts

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from a978363. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/recoveryservices/resource-manager/readme.md

️✔️recoveryservices [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from a978363. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/recoveryservices/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.RecoveryServices [View full logs] [Release SDK Changes]

cmdout	[msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Generated/RecoveryServicesClient.cs(29,90): error CS0535: 'RecoveryServicesClient' does not implement interface member 'IRecoveryServicesClient.GetOperationResultWithHttpMessagesAsync(string, string, string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Microsoft.Azure.Management.RecoveryServices.csproj]
cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Generated/RecoveryServicesClient.cs(29,90): error CS0535: 'RecoveryServicesClient' does not implement interface member 'IRecoveryServicesClient.GetOperationResultWithHttpMessagesAsync(string, string, string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Microsoft.Azure.Management.RecoveryServices.csproj]
cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Generated/RecoveryServicesClient.cs(29,90): error CS0535: 'RecoveryServicesClient' does not implement interface member 'IRecoveryServicesClient.GetOperationResultWithHttpMessagesAsync(string, string, string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Microsoft.Azure.Management.RecoveryServices.csproj]
cmdout	[msbuild]      2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Generated/RecoveryServicesClient.cs(29,90): error CS0535: 'RecoveryServicesClient' does not implement interface member 'IRecoveryServicesClient.GetOperationResultWithHttpMessagesAsync(string, string, string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Microsoft.Azure.Management.RecoveryServices.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Generated/RecoveryServicesClient.cs(29,90): error CS0535: 'RecoveryServicesClient' does not implement interface member 'IRecoveryServicesClient.GetOperationResultWithHttpMessagesAsync(string, string, string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Microsoft.Azure.Management.RecoveryServices.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Generated/RecoveryServicesClient.cs(29,90): error CS0535: 'RecoveryServicesClient' does not implement interface member 'IRecoveryServicesClient.GetOperationResultWithHttpMessagesAsync(string, string, string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Microsoft.Azure.Management.RecoveryServices.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Generated/RecoveryServicesClient.cs(29,90): error CS0535: 'RecoveryServicesClient' does not implement interface member 'IRecoveryServicesClient.GetOperationResultWithHttpMessagesAsync(string, string, string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Microsoft.Azure.Management.RecoveryServices.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Generated/RecoveryServicesClient.cs(29,90): error CS0535: 'RecoveryServicesClient' does not implement interface member 'IRecoveryServicesClient.GetOperationResultWithHttpMessagesAsync(string, string, string, Dictionary<string, List<string>>, CancellationToken)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices/Microsoft.Azure.Management.RecoveryServices/src/Microsoft.Azure.Management.RecoveryServices.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from a978363. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-recoveryservices [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Sku has a new parameter tier
info	[Changelog]   - Model ResourceCertificateAndAadDetails has a new parameter service_resource_id
info	[Changelog]   - Model VaultExtendedInfoResource has a new parameter etag
info	[Changelog]   - Model TrackedResource has a new parameter etag
info	[Changelog]   - Model PatchTrackedResource has a new parameter etag
info	[Changelog]   - Model Vault has a new parameter etag
info	[Changelog]   - Model Vault has a new parameter system_data
info	[Changelog]   - Model PatchVault has a new parameter etag
info	[Changelog]   - Model VaultProperties has a new parameter encryption
info	[Changelog]   - Model IdentityData has a new parameter user_assigned_identities
info	[Changelog]   - Model Resource has a new parameter etag
info	[Changelog]   - Added operation group RecoveryServicesClientOperationsMixin
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model VaultExtendedInfoResource no longer has parameter e_tag
info	[Changelog]   - Model TrackedResource no longer has parameter e_tag
info	[Changelog]   - Model PatchTrackedResource no longer has parameter e_tag
info	[Changelog]   - Model Vault no longer has parameter e_tag
info	[Changelog]   - Model PatchVault no longer has parameter e_tag
info	[Changelog]   - Model Resource no longer has parameter e_tag

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from a978363. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-23 01:50:14 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-recoveryservices;1.0.0-beta.1;1.0.0-beta.2"
cmderr	[generate.py] 2021-02-23 01:50:14 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
cmderr	[generate.py] 2021-02-23 01:50:14 INFO autorest --version=3.0.6369 --use=@autorest/java@4.0.17 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/recoveryservices/azure-resourcemanager-recoveryservices --java.namespace=com.azure.resourcemanager.recoveryservices   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/recoveryservices/resource-manager/readme.md
cmderr	[generate.py] 2021-02-23 01:50:53 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-recoveryservices
cmderr	[generate.py] 2021-02-23 01:50:53 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-23 01:50:53 INFO [POM][Skip] pom already has module azure-resourcemanager-recoveryservices
cmderr	[generate.py] 2021-02-23 01:50:53 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-23 01:50:53 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-23 01:50:53 INFO [POM][Skip] pom already has module sdk/recoveryservices
cmderr	[generate.py] 2021-02-23 01:50:53 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-recoveryservices [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-02-23 01:54:16 DEBUG Got artifact_id: azure-resourcemanager-recoveryservices
cmderr	[Inst] 2021-02-23 01:54:16 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-23 01:54:16 DEBUG Got artifact: azure-resourcemanager-recoveryservices-1.0.0-beta.2.jar
cmderr	[Inst] 2021-02-23 01:54:16 DEBUG Match jar package: azure-resourcemanager-recoveryservices-1.0.0-beta.2.jar
cmderr	[Inst] 2021-02-23 01:54:16 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13096/azure-sdk-for-java/azure-resourcemanager-recoveryservices/azure-resourcemanager-recoveryservices-1.0.0-beta.2.jar\" -o azure-resourcemanager-recoveryservices-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-recoveryservices -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-recoveryservices-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from a978363. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️recoveryservices/mgmt/2016-06-01/recoveryservices [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from a978363. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/recoveryservices/resource-manager/readme.md

️✔️@azure/arm-recoveryservices [View full logs] [Release SDK Changes]

azure-arm-recoveryservices-4.1.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/recoveryServicesClient.js → ./dist/arm-recoveryservices.js...
cmderr	[npmPack] created ./dist/arm-recoveryservices.js in 375ms

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

anthony-c-martin

Looks good! Thanks for fixing.

Adding 2020-10-01 in readme.azureresourceschema.md

e2da863

openapi-assignment-bot bot assigned ChenTanyi Feb 22, 2021

amchandn mentioned this pull request Feb 22, 2021

Microsoft.RecoveryServices is missing azureresourceschema configuration for API version 2020-10-01 #13093

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python label Feb 22, 2021

anthony-c-martin added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Feb 22, 2021

anthony-c-martin approved these changes Feb 22, 2021

View reviewed changes

ChenTanyi approved these changes Feb 23, 2021

View reviewed changes

ChenTanyi merged commit a978363 into Azure:master Feb 23, 2021

mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021

Adding 2020-10-01 in readme.azureresourceschema.md (Azure#13096)

f188711

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding api-version 2020-10-01 in readme.azureresourceschema.md #13096

Adding api-version 2020-10-01 in readme.azureresourceschema.md #13096

amchandn commented Feb 22, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 22, 2021

openapi-pipeline-app bot commented Feb 22, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 22, 2021 •

edited

Loading

anthony-c-martin left a comment

Adding api-version 2020-10-01 in readme.azureresourceschema.md #13096

Adding api-version 2020-10-01 in readme.azureresourceschema.md #13096

Conversation

amchandn commented Feb 22, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 22, 2021

openapi-pipeline-app bot commented Feb 22, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 22, 2021 • edited Loading

Swagger Generation Artifacts

anthony-c-martin left a comment

Choose a reason for hiding this comment

amchandn commented Feb 22, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 22, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 22, 2021 •

edited

Loading