Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding resource property to decision model in access review APIs #13026

Merged
merged 2 commits into from
Feb 24, 2021
Merged

Adding resource property to decision model in access review APIs #13026

merged 2 commits into from
Feb 24, 2021

Conversation

shubhamguptacal
Copy link
Contributor

@shubhamguptacal shubhamguptacal commented Feb 18, 2021 •
edited
Loading

Context

Today, we have existing APIs exposed for access reviews with version 2018-05-01-preview. We now want to make enhancements to these APIs to allow support of new scenarios. We're doing so by introducing a new version 2021-03-01-preview which is cloned from 2018-05-01-preview. There are two commits in this PR - the first commit is just a clone of the existing version and the second commit includes changes in model between these two versions.

In access reviews, today, most of the scenarios revolve around reviewing access of a user to a single role. We're working on new scenarios where one can review all roles in a single review. We also want to be able to more scenarios in the future where we can review combination of "principal" and "resources". To do so, we're augmenting the decision model to allow support for "resource" property in the decision model. In addition to this change, we're also renaming "target" to "principal" to clarify the intent here.

The following illustration helps showcase the Before and After changes in model :

image

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @shubhamguptacal Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 18, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️LintDiff: 34 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ R1006 - PutInOperationName 'PUT' operation 'AccessReviewDefaultSettings_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L655
    ⚠️ R1007 - PatchInOperationName 'PATCH' operation 'AccessReviewInstanceMyDecisions_Patch' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L972
    ⚠️ R2017 - PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'AccessReviewScheduleDefinitions_CreateOrUpdateById' Request Model: 'AccessReviewScheduleDefinitionProperties' Response Model: 'AccessReviewScheduleDefinition'
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L188
    ⚠️ R2017 - PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'AccessReviewDefaultSettings_Put' Request Model: 'AccessReviewScheduleSettings' Response Model: 'AccessReviewDefaultSettings'
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L651
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'AccessReviewInstanceModel'. Consider using the plural form of 'AccessReviewInstance' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L380
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'AccessReviewInstanceModel'. Consider using the plural form of 'AccessReviewInstance' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L427
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'AccessReviewInstanceModel'. Consider using the plural form of 'AccessReviewInstance' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L474
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'AccessReviewInstanceModel'. Consider using the plural form of 'AccessReviewInstance' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L521
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'AccessReviewDefaultSettingsModel'. Consider using the plural form of 'AccessReviewDefaultSettings' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L621
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'AccessReviewDefaultSettingsModel'. Consider using the plural form of 'AccessReviewDefaultSettings' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L655
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 2 Warnings warning [Detail]

    Rule Message
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AccessReviewDecisionTarget' removed or renamed?
    New: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1031:3
    Old: Microsoft.Authorization/preview/2018-05-01-preview/authorization-AccessReviewCalls.json#L1031:3
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'target' renamed or removed?
    New: Microsoft.Authorization/preview/2021-03-01-preview/authorization-AccessReviewCalls.json#L1442:7
    Old: Microsoft.Authorization/preview/2018-05-01-preview/authorization-AccessReviewCalls.json#L1434:7
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 400 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ PreCheck/SchemaMissingType "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"The schema 'RoleAssignmentScheduleFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"The schema 'RoleAssignmentScheduleProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"The schema 'RoleAssignmentSchedule' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"The schema 'RoleAssignmentScheduleListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"The schema 'CloudErrorBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"The schema 'RoleAssignmentScheduleInstanceFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"The schema 'RoleAssignmentScheduleInstanceProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"The schema 'RoleAssignmentScheduleInstance' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"The schema 'RoleAssignmentScheduleInstanceListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 18, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d5996cb. Schema Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
cmdout	[Autorest] WARNING: Skipping path '/{roleId}': Unable to locate '/providers/' segment
cmdout	[Autorest] WARNING: Skipping path '/{roleId}': Unable to locate '/providers/' segment
cmdout	[Autorest] WARNING: Skipping path '/{roleId}': Unable to locate '/providers/' segment
cmdout	[Autorest] WARNING: Skipping path '/{roleAssignmentId}': Unable to locate '/providers/' segment
cmdout	[Autorest] WARNING: Skipping path '/{roleAssignmentId}': Unable to locate '/providers/' segment
    • ️✔️authorization [View full logs]  [Release Schema Changes] 
      cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️🔄 azure-sdk-for-net inProgress [Detail]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d5996cb. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model RoleAssignment has a new parameter delegated_managed_identity_resource_id
info	[Changelog]   - Model RoleAssignment has a new parameter updated_on
info	[Changelog]   - Model RoleAssignment has a new parameter updated_by
info	[Changelog]   - Model RoleAssignment has a new parameter created_on
info	[Changelog]   - Model RoleAssignment has a new parameter created_by
info	[Changelog]   - Added operation group AccessReviewScheduleDefinitionsOperations
info	[Changelog]   - Added operation group AccessReviewInstanceOperations
info	[Changelog]   - Added operation group AccessReviewScheduleDefinitionsAssignedForMyApprovalOperations
info	[Changelog]   - Added operation group AccessReviewInstanceDecisionsOperations
info	[Changelog]   - Added operation group Operations
info	[Changelog]   - Added operation group RoleAssignmentApprovalStepOperations
info	[Changelog]   - Added operation group AccessReviewInstancesAssignedForMyApprovalOperations
info	[Changelog]   - Added operation group RoleAssignmentApprovalOperations
info	[Changelog]   - Added operation group ScopeRoleAssignmentApprovalStepsOperations
info	[Changelog]   - Added operation group AccessReviewInstanceMyDecisionsOperations
info	[Changelog]   - Added operation group ScopeRoleAssignmentApprovalOperations
info	[Changelog]   - Added operation group ScopeRoleAssignmentApprovalStepOperations
info	[Changelog]   - Added operation group AccessReviewDefaultSettingsOperations
info	[Changelog]   - Added operation group AccessReviewInstancesOperations
info	[Changelog]   - Added operation group RoleAssignmentApprovalStepsOperations
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d5996cb. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
    • ️✔️@azure/arm-authorization [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/authorizationManagementClient.js → ./dist/arm-authorization.js...
cmderr	[npmPack] created ./dist/arm-authorization.js in 210ms
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d5996cb. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-24 02:53:05 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-authorization-generated"
cmderr	[generate.py] 2021-02-24 02:53:05 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-02-24 02:53:05 INFO autorest --version=3.0.6369 --use=@autorest/java@4.0.17 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/authorization/azure-resourcemanager-authorization-generated --java.namespace=com.azure.resourcemanager.authorization.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
cmderr	[generate.py] 2021-02-24 02:53:47 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-02-24 02:53:47 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-24 02:53:47 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-24 02:53:47 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-24 02:53:47 INFO [POM][Skip] pom already has module sdk/authorization
cmderr	[generate.py] 2021-02-24 02:53:47 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-authorization-generated [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-02-24 02:56:48 DEBUG Got artifact_id: azure-resourcemanager-authorization-generated
cmderr	[Inst] 2021-02-24 02:56:48 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-24 02:56:48 DEBUG Got artifact: azure-resourcemanager-authorization-generated-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-02-24 02:56:48 DEBUG Got artifact: azure-resourcemanager-authorization-generated-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-02-24 02:56:48 DEBUG Got artifact: azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-24 02:56:48 DEBUG Match jar package: azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-24 02:56:48 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13026/azure-sdk-for-java/azure-resourcemanager-authorization-generated/azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-authorization-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d5996cb. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️authorization/mgmt/2015-07-01/authorization [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `ProviderOperationsMetadataClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.List` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.Get` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 6 additive change(s).
info	[Changelog]
    • ️✔️preview/authorization/mgmt/2020-04-01-preview/authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/authorization/mgmt/2018-09-01-preview/authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
info	[Changelog]
    • ️✔️preview/authorization/mgmt/2018-07-01-preview/authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
info	[Changelog]
    • ️✔️preview/authorization/mgmt/2018-01-01-preview/authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
info	[Changelog]
    • ️✔️preview/authorization/mgmt/2017-10-01-preview/authorization [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `ProviderOperationsMetadataClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.List` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.Get` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 6 additive change(s).
info	[Changelog]
    ️🔄[Staging] ApiDocPreview inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @shubhamguptacal shubhamguptacal changed the title Adding resource property to decision model Adding resource property to decision model in access review APIs Feb 18, 2021
    @openapi-workflow-bot
    Copy link

    Hi @shubhamguptacal, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
     If you need further help, please feedback via swagger feedback."

    This was referenced Feb 18, 2021
    Closed
    Closed
    Closed
    Closed
    @majastrz majastrz added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Feb 18, 2021
    majastrz
    majastrz approved these changes Feb 18, 2021
    View reviewed changes
    Copy link
    Member

    @majastrz majastrz left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Signed off from ARM side.

    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Feb 23, 2021
    Closed
    @qianwens qianwens merged commit d5996cb into master Feb 24, 2021
    This was referenced Feb 24, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @shubhamguptacal @mkarmark
    Adding resource property to decision model in access review APIs (Azu…
    279de1b 
    …re#13026)

* Cloning version 2021-03-01-preview from version 2018-05-01-preview

* Added resource property to decision model
    @JackTn JackTn deleted the shugup/accessReviews branch August 17, 2021 06:08
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @majastrz majastrz majastrz approved these changes

    @filizt filizt Awaiting requested review from filizt

    @ChenTanyi ChenTanyi Awaiting requested review from ChenTanyi

    @jsntcy jsntcy Awaiting requested review from jsntcy

    @msyyc msyyc Awaiting requested review from msyyc msyyc is a code owner

    @stankovski stankovski Awaiting requested review from stankovski stankovski is a code owner

    Assignees

    @qianwens qianwens

    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @shubhamguptacal @majastrz @qianwens