Api Management fixes for Additional Properties in s360 report #12891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hi, @solankisamir Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| "readme":"apimanagement/resource-manager/readme.md", "tag":"package-preview-2020-06", "details":"The schema 'ErrorFieldContract' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"apimanagement/resource-manager/readme.md", "tag":"package-preview-2020-06", "details":"The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"apimanagement/resource-manager/readme.md", "tag":"package-preview-2020-06", "details":"The schema 'ErrorResponseBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"apimanagement/resource-manager/readme.md", "tag":"package-preview-2020-06", "details":"The schema 'RegionContract' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"apimanagement/resource-manager/readme.md", "tag":"package-preview-2020-06", "details":"The schema 'RegionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"apimanagement/resource-manager/readme.md", "tag":"package-preview-2020-06", "details":"The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"apimanagement/resource-manager/readme.md", "tag":"package-preview-2020-06", "details":"The schema 'ResourceSkuResults' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"apimanagement/resource-manager/readme.md", "tag":"package-preview-2020-06", "details":"The schema 'ResourceSkuResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"apimanagement/resource-manager/readme.md", "tag":"package-preview-2020-06", "details":"The schema 'ResourceSkuCapacity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"apimanagement/resource-manager/readme.md", "tag":"package-preview-2020-06", "details":"The schema 'ResourceSku' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki [Window to Fix Broken]( Window to Fix Broken - Overview (azure.com)) for more details. |
This was referenced Feb 8, 2021
solankisamir
force-pushed
the
apim/s360-part2
branch
from
d5daeaa
to
84cdb94
Compare
|
@allenjzhang can you take a look at this? |
allenjzhang
reviewed
Feb 10, 2021
| @@ -78,6 +78,10 @@ | |||
| "$ref": "#/definitions/ErrorFieldContract" | |||
| }, | |||
| "description": "The list of invalid fields send in request, in case of validation error." | |||
| }, | |||
There was a problem hiding this comment.
Question. Typically details is an array of ErrorResponseBody (see common-type/resource-manager/v1/types.json). It come thru well in SDK such as for .NET as Exception.InnerExcpetions. Why intorudce another object as innerError like this? Should snap to the common error response.
There was a problem hiding this comment.
Thanks, reverted this change. We will fix this in the service.
|
@allenjzhang addressed review comments. please take a look again. Thanks |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
vfedonkin
approved these changes
Feb 11, 2021
|
/azp run CredScan |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Command 'reset' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@allenjzhang the pipelines are still not running for some reason. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@allenjzhang we have not published any SDK for this api-version. |
|
@allenjzhang can you please take a look. We need to get this in, to start working on the next api-version, which we are targeting for Build in April. Thanks' |
|
@allenjzhang if you can take a look at this PR also? Thanks |
allenjzhang
approved these changes
Feb 21, 2021
allenjzhang
added
the
Approved-BreakingChange
This was referenced Feb 21, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…12891) * missing count property * missing count property example * product description fix * inner error * updated dns changes * revert innererror change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Fixes - https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/Semantic-and-Model-Violations-Reference.md#OBJECT_ADDITIONAL_PROPERTIES
https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/Semantic-and-Model-Violations-Reference.md#MIN_LENGTH
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.