-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package for publishing OperationalInsights SDK #12886
Conversation
IsTroubleshootingAllowed, IsTroubleshootingEnabled, IsTroubleshootingEnabledLastActivation.
…oubleshootingAllowed from body of example
Hi, @dabenhamMic Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/operationalinsights/resource-manager/readme.md tag: specification/operationalinsights/resource-manager/readme.md#tag-package-2020-10 |
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌
[Staging] SDK Track2 Validation: 2 Errors, 71 Warnings failed [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
Rule | Message |
---|---|
PreCheck/DuplicateSchema |
"readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"Duplicate Schema named ErrorResponse -- title: undefined => "Error response", properties.code: "description":"The error code.", "readOnly":true, "$ref":"#/components/schemas/schemas:291" =>, properties.message: "description":"The error message.", "readOnly":true, "$ref":"#/components/schemas/schemas:292" =>, properties.target: "description":"The error target.", "readOnly":true, "$ref":"#/components/schemas/schemas:293" =>, properties.details: "description":"The error details.", "readOnly":true, "$ref":"#/components/schemas/schemas:294" =>, properties.additionalInfo: "description":"The error additional info.", "readOnly":true, "$ref":"#/components/schemas/schemas:295" =>, properties.error: undefined => "description":"The error object.", "$ref":"#/components/schemas/schemas:371" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
AutorestCore/Exception |
"readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"Error: Plugin prechecker reported failure." |
"readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DataExport' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DataExportListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DataExportProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'Destination' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DestinationMetaData' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DataSource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DataSourceFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"operationalinsights/resource-manager/readme.md", "tag":"package-2020-10", "details":"The schema 'DataSourceListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
Duplicate Schema named ErrorResponse is defined in files of package-2020-10 |
@kairu-ms can we merge and close this pr? |
You should fix CI issues first. |
Hi @msyyc, Python Track2 SDK CI failed, can you have a look? |
Hi @ArcturusZhang Go SDK CI failed. Can you have a look? |
All the SDK failures are complaining the same thing: we must have defined two different model of |
@ArcturusZhang I've created a new PR with the fixes that you mentioned: |
Sorry but I do not have the permission to approve a swagger breaking change. I left some comment for context and maybe Arthur could help on this, because this is not a real breaking change in swagger. |
Hi, @dabenhamMic. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.