Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2021 package to go.md #12830

Merged
merged 4 commits into from
Feb 4, 2021
Merged

Add 2021 package to go.md #12830

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
073176c
Add 2021 package to go.md
roytan-microsoft Feb 4, 2021
5c40040
fix missed package
roytan-microsoft Feb 4, 2021
9744a7e
change output folder
roytan-microsoft Feb 4, 2021
52ebbcb
fix typo
roytan-microsoft Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions specification/mixedreality/resource-manager/readme.go.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,20 @@ go:

``` yaml $(go) && $(multiapi)
batch:
- tag: package-2021-01
- tag: package-2020-05
- tag: package-2019-02-preview
```

### Tag: package-2021-01 and go

These settings apply only when `--tag=package-2021-01 --go` is specified on the command line.
Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.

``` yaml $(tag) == 'package-2020-01' && $(go)
output-folder: $(go-sdk-folder)/services/preview/$(namespace)/mgmt/2021-01-01/$(namespace)
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we make a typo here? The tag name here is different from the one in batch

And also we cannot put this package in preview subdirectory, because all of the swaggers in this tag are stable

Suggested change
``` yaml $(tag) == 'package-2020-01' && $(go)
output-folder: $(go-sdk-folder)/services/preview/$(namespace)/mgmt/2021-01-01/$(namespace)
```
``` yaml $(tag) == 'package-2021-01' && $(go)
output-folder: $(go-sdk-folder)/services/$(namespace)/mgmt/2021-01-01/$(namespace)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the typo. I wasn't sure about the folder structure, does the new one work?


### Tag: package-2020-05 and go

These settings apply only when `--tag=package-2020-05 --go` is specified on the command line.
Expand Down