Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for TargetVmSize as input for VMWare to Azure and Hyper-V to Azure replications in Site Recovery Service #12785

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Support for TargetVmSize as input for VMWare to Azure and Hyper-V to Azure replications in Site Recovery Service #12785

merged 1 commit into from
Feb 4, 2021

Conversation

vidyadharijami
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify -> Target Vm size input property is missed in both VMWare to Azure and Hyper-V to Azure replications in Site Recovery Service. It's not a new feature.
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet. - The service is already GA.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.- [06-02-2021]
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @vidyadharijami Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 2, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 2, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b107981. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-04 02:39:40 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-recoveryservicessiterecovery"
cmderr	[generate.py] 2021-02-04 02:39:40 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-02-04 02:39:40 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/recoveryservicessiterecovery/azure-resourcemanager-recoveryservicessiterecovery --java.namespace=com.azure.resourcemanager.recoveryservicessiterecovery   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/recoveryservicessiterecovery/resource-manager/readme.md
cmderr	[generate.py] 2021-02-04 02:40:51 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-02-04 02:40:51 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-04 02:40:51 INFO [POM][Skip] pom already has module azure-resourcemanager-recoveryservicessiterecovery
cmderr	[generate.py] 2021-02-04 02:40:51 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-04 02:40:51 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-04 02:40:51 INFO [POM][Success] Write to root pom
cmderr	[generate.py] 2021-02-04 02:42:48 ERROR [COMPILE] Maven build fail
    • ️✔️azure-resourcemanager-recoveryservicessiterecovery [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-02-04 02:43:54 DEBUG Got artifact_id: azure-resourcemanager-recoveryservicessiterecovery
cmderr	[Inst] 2021-02-04 02:43:54 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-04 02:43:54 DEBUG Got artifact: azure-resourcemanager-recoveryservicessiterecovery-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-04 02:43:54 DEBUG Match jar package: azure-resourcemanager-recoveryservicessiterecovery-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-04 02:43:54 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12785/azure-sdk-for-java/azure-resourcemanager-recoveryservicessiterecovery/azure-resourcemanager-recoveryservicessiterecovery-1.0.0-beta.1.jar\" -o azure-resourcemanager-recoveryservicessiterecovery-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-recoveryservicessiterecovery -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-recoveryservicessiterecovery-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️❌ azure-sdk-for-net failed [Detail]
    • ❌Failed [Logs]Release - Generate from b107981. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/recoveryservicessiterecovery/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ❌Microsoft.Azure.Management.RecoveryServices.SiteRecovery [View full logs]  [Release SDK Changes] 
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices-siterecovery/Microsoft.Azure.Management.RecoveryServices.SiteRecovery/tests/ScenarioTests/ASRTests.cs(1230,47): error CS0029: Cannot implicitly convert type 'Microsoft.Azure.Management.RecoveryServices.SiteRecovery.Models.HyperVReplicaAzureFailoverProviderInput' to 'Microsoft.Azure.Management.RecoveryServices.SiteRecovery.Models.TestFailoverProviderSpecificInput' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices-siterecovery/Microsoft.Azure.Management.RecoveryServices.SiteRecovery/tests/Microsoft.Azure.Management.RecoveryServices.SiteRecovery.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices-siterecovery/Microsoft.Azure.Management.RecoveryServices.SiteRecovery/tests/ScenarioTests/ASRTests.cs(1334,47): error CS0029: Cannot implicitly convert type 'Microsoft.Azure.Management.RecoveryServices.SiteRecovery.Models.HyperVReplicaAzureFailoverProviderInput' to 'Microsoft.Azure.Management.RecoveryServices.SiteRecovery.Models.UnplannedFailoverProviderSpecificInput' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices-siterecovery/Microsoft.Azure.Management.RecoveryServices.SiteRecovery/tests/Microsoft.Azure.Management.RecoveryServices.SiteRecovery.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices-siterecovery/Microsoft.Azure.Management.RecoveryServices.SiteRecovery/tests/ScenarioTests/ASRTests.cs(1230,47): error CS0029: Cannot implicitly convert type 'Microsoft.Azure.Management.RecoveryServices.SiteRecovery.Models.HyperVReplicaAzureFailoverProviderInput' to 'Microsoft.Azure.Management.RecoveryServices.SiteRecovery.Models.TestFailoverProviderSpecificInput' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices-siterecovery/Microsoft.Azure.Management.RecoveryServices.SiteRecovery/tests/Microsoft.Azure.Management.RecoveryServices.SiteRecovery.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices-siterecovery/Microsoft.Azure.Management.RecoveryServices.SiteRecovery/tests/ScenarioTests/ASRTests.cs(1334,47): error CS0029: Cannot implicitly convert type 'Microsoft.Azure.Management.RecoveryServices.SiteRecovery.Models.HyperVReplicaAzureFailoverProviderInput' to 'Microsoft.Azure.Management.RecoveryServices.SiteRecovery.Models.UnplannedFailoverProviderSpecificInput' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/recoveryservices-siterecovery/Microsoft.Azure.Management.RecoveryServices.SiteRecovery/tests/Microsoft.Azure.Management.RecoveryServices.SiteRecovery.Tests.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b107981. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
cmderr	[automation_init.sh]   Failed building wheel for yarl
cmderr	[automation_init.sh]   Failed building wheel for wrapt
cmderr	[automation_init.sh]   Failed building wheel for multidict
cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmdout	[automation_generate.sh] [Autorest]../azure-sdk-for-python_tmp/generateOutput.json does not exist!!!
warn	File azure-sdk-for-python_tmp/generateOutput.json not found to read
warn	No file changes detected after generation
warn	No package detected after generation
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b107981. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/recoveryservicessiterecovery/resource-manager/readme.md
    • ️✔️@azure/arm-recoveryservices-siterecovery [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/siteRecoveryManagementClient.js → ./dist/arm-recoveryservices-siterecovery.js...
cmderr	[npmPack] created ./dist/arm-recoveryservices-siterecovery.js in 1.3s
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b107981. Schema Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/recoveryservicessiterecovery/resource-manager/readme.md
    • ️✔️recoveryservicessiterecovery [View full logs]  [Release Schema Changes] 
      cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b107981. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️recoveryservices/mgmt/2018-07-10/siterecovery [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `ResourceTypeBasicRecoveryVirtualNetworkCustomDetailsResourceTypeNew`
info	[Changelog] - New function `NewRecoveryVirtualNetwork.AsRecoveryVirtualNetworkCustomDetails() (*RecoveryVirtualNetworkCustomDetails, bool)`
info	[Changelog] - New function `NewRecoveryVirtualNetwork.AsNewRecoveryVirtualNetwork() (*NewRecoveryVirtualNetwork, bool)`
info	[Changelog] - New function `ExistingRecoveryVirtualNetwork.AsNewRecoveryVirtualNetwork() (*NewRecoveryVirtualNetwork, bool)`
info	[Changelog] - New function `RecoveryVirtualNetworkCustomDetails.AsNewRecoveryVirtualNetwork() (*NewRecoveryVirtualNetwork, bool)`
info	[Changelog] - New function `NewRecoveryVirtualNetwork.AsBasicRecoveryVirtualNetworkCustomDetails() (BasicRecoveryVirtualNetworkCustomDetails, bool)`
info	[Changelog] - New function `NewRecoveryVirtualNetwork.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `NewRecoveryVirtualNetwork.AsExistingRecoveryVirtualNetwork() (*ExistingRecoveryVirtualNetwork, bool)`
info	[Changelog] - New struct `NewRecoveryVirtualNetwork`
info	[Changelog] - New field `TargetVMSize` in struct `HyperVReplicaAzureEnableProtectionInput`
info	[Changelog] - New field `TargetAvailabilitySetID` in struct `HyperVReplicaAzureEnableProtectionInput`
info	[Changelog] - New field `TargetAvailabilitySetID` in struct `InMageAzureV2EnableProtectionInput`
info	[Changelog] - New field `TargetVMSize` in struct `InMageAzureV2EnableProtectionInput`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 13 additive change(s).
info	[Changelog]
    • ️✔️recoveryservices/mgmt/2018-01-10/siterecovery [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️recoveryservices/mgmt/2016-08-10/siterecovery [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    Posted by Swagger Pipeline | How to fix these errors?

    This was referenced Feb 2, 2021
    Closed
    Closed
    Closed
    Closed
    @vidyadharijami
    Copy link
    Contributor Author

    @njuCZ Can you please look into this PR

    @njuCZ
    Copy link
    Contributor

    njuCZ commented Feb 3, 2021

    @vidyadharijami do you mean this field already exist in the rest api, but only missed in the swagger?

    @vidyadharijami
    Copy link
    Contributor Author

    @vidyadharijami do you mean this field already exist in the rest api, but only missed in the swagger?

    Yes.

    @njuCZ njuCZ merged commit b107981 into Azure:master Feb 4, 2021
    This was referenced Feb 4, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @vidyadharijami @mkarmark
    Adding TargetVmSize for Vmware to azure and HyperV to Azure scenarios (…
    9f4d73e 
    …Azure#12785)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @njuCZ njuCZ njuCZ approved these changes

    Assignees

    @njuCZ njuCZ

    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @vidyadharijami @njuCZ