Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor issues in policy exemptions #12636

Merged
merged 4 commits into from
Feb 2, 2021
Merged

Fix minor issues in policy exemptions #12636

merged 4 commits into from
Feb 2, 2021

Conversation

robga
Copy link
Contributor

@robga robga commented Jan 26, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?

    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify 1. changed parameter order; 2. move subscriptionId from method parameter to client. (SDK hasn't been generated yet.)
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
    N/A

  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
    ASAP

  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.

    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR, the SDK for policy exemption hasn't been generated yet.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @robga Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 26, 2021

    Swagger Validation Report

    ️❌BreakingChange: 9 Errors, 6 Warnings failed [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'error' renamed or removed?
    New: common-types/resource-management/v1/types.json#L280:7
    Old: common-types/resource-management/v2/types.json#L316:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'error' renamed or removed?
    New: common-types/resource-management/v1/types.json#L280:7
    Old: common-types/resource-management/v2/types.json#L316:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'error' renamed or removed?
    New: common-types/resource-management/v1/types.json#L280:7
    Old: common-types/resource-management/v2/types.json#L316:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'error' renamed or removed?
    New: common-types/resource-management/v1/types.json#L280:7
    Old: common-types/resource-management/v2/types.json#L316:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'error' renamed or removed?
    New: common-types/resource-management/v1/types.json#L280:7
    Old: common-types/resource-management/v2/types.json#L316:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'error' renamed or removed?
    New: common-types/resource-management/v1/types.json#L280:7
    Old: common-types/resource-management/v2/types.json#L316:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'error' renamed or removed?
    New: common-types/resource-management/v1/types.json#L280:7
    Old: common-types/resource-management/v2/types.json#L316:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'error' renamed or removed?
    New: common-types/resource-management/v1/types.json#L280:7
    Old: common-types/resource-management/v2/types.json#L316:7
    1042 - ChangedParameterOrder The order of parameter 'parameters' was changed.
    New: Microsoft.Authorization/preview/2020-07-01-preview/policyExemptions.json#L88:9
    Old: Microsoft.Authorization/preview/2020-07-01-preview/policyExemptions.json#L88:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Authorization/preview/2020-07-01-preview/policyExemptions.json#L102:13
    Old: Microsoft.Authorization/preview/2020-07-01-preview/policyExemptions.json#L93:13
    ️⚠️LintDiff: 18 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ R4021 - DescriptionAndTitleMissing 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    New: Microsoft.Authorization/preview/2020-07-01-preview/policyExemptions.json#L381
    ⚠️ R4021 - DescriptionAndTitleMissing 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    New: Microsoft.Authorization/preview/2020-07-01-preview/policyExemptions.json#L381
    ⚠️ R4021 - DescriptionAndTitleMissing 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    New: Microsoft.Authorization/preview/2020-07-01-preview/policyExemptions.json#L381
    ⚠️ R4021 - DescriptionAndTitleMissing 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    New: Microsoft.Authorization/preview/2020-07-01-preview/policyExemptions.json#L381
    ⚠️ R4021 - DescriptionAndTitleMissing 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    New: Microsoft.Authorization/preview/2020-07-01-preview/policyExemptions.json#L381
    ⚠️ R4021 - DescriptionAndTitleMissing 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    New: Microsoft.Authorization/preview/2020-07-01-preview/policyExemptions.json#L381
    ⚠️ R4021 - DescriptionAndTitleMissing 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    New: Microsoft.Authorization/preview/2020-07-01-preview/policyExemptions.json#L381
    ⚠️ R4021 - DescriptionAndTitleMissing 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    New: Microsoft.Authorization/preview/2020-07-01-preview/policyExemptions.json#L381
    ⚠️ R4021 - DescriptionAndTitleMissing 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    New: Microsoft.Authorization/preview/2020-07-01-preview/policyExemptions.json#L381
    ⚠️ R4021 - DescriptionAndTitleMissing 'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    New: Microsoft.Authorization/preview/2020-07-01-preview/policyExemptions.json#L381
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 26, 2021

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 76fb4a0. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/resources/resource-manager/readme.md
    • ️✔️@azure/arm-features [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/featureClient.js → ./dist/arm-features.js...
      cmderr	[npmPack] created ./dist/arm-features.js in 128ms
    • ️✔️@azure/arm-links [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/managementLinkClient.js → ./dist/arm-links.js...
      cmderr	[npmPack] created ./dist/arm-links.js in 125ms
    • ️✔️@azure/arm-locks [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/managementLockClient.js → ./dist/arm-locks.js...
      cmderr	[npmPack] created ./dist/arm-locks.js in 155ms
    • ️✔️@azure/arm-managedapplications [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/applicationClient.js → ./dist/arm-managedapplications.js...
      cmderr	[npmPack] created ./dist/arm-managedapplications.js in 237ms
    • ️✔️@azure/arm-policy [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/policyClient.js → ./dist/arm-policy.js...
      cmderr	[npmPack] created ./dist/arm-policy.js in 282ms
    • ️✔️@azure/arm-resources [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/resourceManagementClient.js → ./dist/arm-resources.js...
      cmderr	[npmPack] created ./dist/arm-resources.js in 438ms
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 76fb4a0. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
      cmderr	[automation_init.sh]   Failed building wheel for wrapt
      cmderr	[automation_init.sh]   Failed building wheel for yarl
      cmderr	[automation_init.sh]   Failed building wheel for multidict
      cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
      cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-resource [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model DeploymentProperties has a new parameter expression_evaluation_options
      info	[Changelog]   - Model TemplateSpec has a new parameter versions
      info	[Changelog]   - Model ParameterDefinitionsValueMetadata has a new parameter strong_type
      info	[Changelog]   - Model ParameterDefinitionsValueMetadata has a new parameter assign_permissions
      info	[Changelog]   - Model TemplateLink has a new parameter query_string
      info	[Changelog]   - Model DeploymentWhatIfProperties has a new parameter expression_evaluation_options
      info	[Changelog]   - Model ProviderResourceType has a new parameter location_mappings
      info	[Changelog]   - Model PolicyAssignment has a new parameter non_compliance_messages
      info	[Changelog]   - Added operation PolicyDefinitionsOperations.list_by_management_group
      info	[Changelog]   - Added operation ProvidersOperations.register_at_management_group_scope
      info	[Changelog]   - Added operation ApplicationDefinitionsOperations.get_by_id
      info	[Changelog]   - Added operation ApplicationDefinitionsOperations.begin_create_or_update_by_id
      info	[Changelog]   - Added operation ApplicationDefinitionsOperations.begin_delete_by_id
      info	[Changelog]   - Added operation PolicySetDefinitionsOperations.list_by_management_group
      info	[Changelog]   - Added operation group ApplicationClientOperationsMixin
      info	[Changelog]   - Added operation group ProviderResourceTypesOperations
      info	[Changelog]   - Added operation group DataPolicyManifestsOperations
      info	[Changelog]   - Added operation group PolicyExemptionsOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation PolicyAssignmentsOperations.list has a new signature
      info	[Changelog]   - Operation PolicyAssignmentsOperations.list_for_management_group has a new signature
      info	[Changelog]   - Operation PolicyAssignmentsOperations.list_for_resource has a new signature
      info	[Changelog]   - Operation PolicyAssignmentsOperations.list_for_resource_group has a new signature
      info	[Changelog]   - Operation TemplateSpecsOperations.get has a new signature
      info	[Changelog]   - Operation TemplateSpecsOperations.list_by_resource_group has a new signature
      info	[Changelog]   - Operation TemplateSpecsOperations.list_by_subscription has a new signature
      info	[Changelog]   - Model PolicyAssignment no longer has parameter sku
      info	[Changelog]   - Operation PolicyDefinitionsOperations.list_built_in has a new signature
      info	[Changelog]   - Operation PolicyDefinitionsOperations.list has a new signature
      info	[Changelog]   - Operation PolicySetDefinitionsOperations.list_built_in has a new signature
      info	[Changelog]   - Operation PolicySetDefinitionsOperations.list has a new signature
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 76fb4a0. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-02-02 01:35:21 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-resources-generated"
      cmderr	[generate.py] 2021-02-02 01:35:21 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-02-02 01:35:21 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/resources/azure-resourcemanager-resources-generated --java.namespace=com.azure.resourcemanager.resources.generated --tag=package-resources-2020-10  --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/resources/resource-manager/readme.md
      cmderr	[generate.py] 2021-02-02 01:36:16 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-02-02 01:36:16 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-02-02 01:36:16 INFO [POM][Skip] pom already has module azure-resourcemanager-resources-generated
      cmderr	[generate.py] 2021-02-02 01:36:16 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-02-02 01:36:16 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-02-02 01:36:16 INFO [POM][Success] Write to root pom
      cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
      cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
      cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
      cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
      cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
    • ️✔️azure-resourcemanager-resources-generated [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-02-02 01:39:51 DEBUG Got artifact_id: azure-resourcemanager-resources-generated
      cmderr	[Inst] 2021-02-02 01:39:51 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-02-02 01:39:51 DEBUG Got artifact: azure-resourcemanager-resources-generated-1.0.0-beta.1-javadoc.jar
      cmderr	[Inst] 2021-02-02 01:39:51 DEBUG Got artifact: azure-resourcemanager-resources-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-02-02 01:39:51 DEBUG Match jar package: azure-resourcemanager-resources-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-02-02 01:39:51 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12636/azure-sdk-for-java/azure-resourcemanager-resources-generated/azure-resourcemanager-resources-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-resources-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-resources-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-resources-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 76fb4a0. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/resources/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.ResourceManager [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 76fb4a0. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
      cmderr	[automation_init.sh]   Failed building wheel for wrapt
      cmderr	[automation_init.sh]   Failed building wheel for yarl
      cmderr	[automation_init.sh]   Failed building wheel for multidict
      cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
      cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-resource [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group PolicyExemptionsOperations
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 76fb4a0. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/resources/resource-manager/readme.md
      cmdout	[Autorest] WARNING: Skipping path '/{applicationId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.Solutions/applicationDefinitions. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Solutions/applicationDefinitions/{applicationDefinitionName}?disambiguation_dummy'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.Solutions/applicationDefinitions. Using definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Solutions/applicationDefinitions/{applicationDefinitionName}'.
      cmdout	[Autorest] WARNING: Skipping path '/{applicationId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.Solutions/applicationDefinitions. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Solutions/applicationDefinitions/{applicationDefinitionName}?disambiguation_dummy'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.Solutions/applicationDefinitions. Using definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Solutions/applicationDefinitions/{applicationDefinitionName}'.
      cmdout	[Autorest] WARNING: Skipping path '/{applicationId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.Solutions/applicationDefinitions. Skipping definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Solutions/applicationDefinitions/{applicationDefinitionName}?disambiguation_dummy'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.Solutions/applicationDefinitions. Using definition with path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Solutions/applicationDefinitions/{applicationDefinitionName}'.
      cmdout	[Autorest] WARNING: Skipping path '/{applicationId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/{applicationDefinitionId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/{applianceId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/{applianceDefinitionId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{parentResourcePath}/{resourceType}/{resourceName}': Unable to process parameterized provider namespace '{resourceProviderNamespace}'
      cmdout	[Autorest] WARNING: Skipping path '/{resourceId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}/tagValues/{tagValue}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{parentResourcePath}/{resourceType}/{resourceName}': Unable to process parameterized provider namespace '{resourceProviderNamespace}'
      cmdout	[Autorest] WARNING: Skipping path '/{resourceId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}/tagValues/{tagValue}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{parentResourcePath}/{resourceType}/{resourceName}': Unable to process parameterized provider namespace '{resourceProviderNamespace}'
      cmdout	[Autorest] WARNING: Skipping path '/{resourceId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}/tagValues/{tagValue}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{parentResourcePath}/{resourceType}/{resourceName}': Unable to process parameterized provider namespace '{resourceProviderNamespace}'
      cmdout	[Autorest] WARNING: Skipping path '/{resourceId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}/tagValues/{tagValue}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{parentResourcePath}/{resourceType}/{resourceName}': Unable to process parameterized provider namespace '{resourceProviderNamespace}'
      cmdout	[Autorest] WARNING: Skipping path '/{resourceId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}/tagValues/{tagValue}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{parentResourcePath}/{resourceType}/{resourceName}': Unable to process parameterized provider namespace '{resourceProviderNamespace}'
      cmdout	[Autorest] WARNING: Skipping path '/{resourceId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}/tagValues/{tagValue}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{parentResourcePath}/{resourceType}/{resourceName}': Unable to process parameterized provider namespace '{resourceProviderNamespace}'
      cmdout	[Autorest] WARNING: Skipping path '/{resourceId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}/tagValues/{tagValue}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{parentResourcePath}/{resourceType}/{resourceName}': Unable to process parameterized provider namespace '{resourceProviderNamespace}'
      cmdout	[Autorest] WARNING: Skipping path '/{resourceId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}/tagValues/{tagValue}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{parentResourcePath}/{resourceType}/{resourceName}': Unable to process parameterized provider namespace '{resourceProviderNamespace}'
      cmdout	[Autorest] WARNING: Skipping path '/{resourceId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}/tagValues/{tagValue}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{parentResourcePath}/{resourceType}/{resourceName}': Unable to process parameterized provider namespace '{resourceProviderNamespace}'
      cmdout	[Autorest] WARNING: Skipping path '/{resourceId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}/tagValues/{tagValue}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{parentResourcePath}/{resourceType}/{resourceName}': Unable to process parameterized provider namespace '{resourceProviderNamespace}'
      cmdout	[Autorest] WARNING: Skipping path '/{resourceId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}/tagValues/{tagValue}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/{linkId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{parentResourcePath}/{resourceType}/{resourceName}': Unable to process parameterized provider namespace '{resourceProviderNamespace}'
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}/tagValues/{tagValue}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{parentResourcePath}/{resourceType}/{resourceName}': Unable to process parameterized provider namespace '{resourceProviderNamespace}'
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}/tagValues/{tagValue}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{parentResourcePath}/{resourceType}/{resourceName}': Unable to process parameterized provider namespace '{resourceProviderNamespace}'
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}/tagValues/{tagValue}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/subscriptions/{subscriptionId}/tagNames/{tagName}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/{policyAssignmentId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/{policyAssignmentId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/{policyAssignmentId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/{policyAssignmentId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/{policyAssignmentId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/{policyAssignmentId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/{policyAssignmentId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/{policyAssignmentId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/{policyAssignmentId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/{policyAssignmentId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/{policyAssignmentId}': Unable to locate '/providers/' segment
      cmdout	[Autorest] WARNING: Skipping path '/{policyAssignmentId}': Unable to locate '/providers/' segment
    • ️✔️resources [View full logs]  [Release Schema Changes]
      cmderr	[resource-manager] node-pre-gyp
      cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
      cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
      cmderr	[resource-manager]  optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
      cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
      cmderr	[resource-manager] npm ERR! code ELIFECYCLE
      cmderr	[resource-manager] npm ERR! errno 39
      cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 test: `mocha -r ts-node/register tests.ts`
      cmderr	[resource-manager] npm ERR! Exit status 39
      cmderr	[resource-manager] npm ERR!
      cmderr	[resource-manager] npm ERR! Failed at the template-schema-validation-tools@1.0.0 test script.
      cmderr	[resource-manager] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
      cmderr	[resource-manager]  A complete log of this run can be found in:
      cmderr	[resource-manager] npm ERR!     /home/vsts/.npm/_logs/2021-02-02T01_37_15_376Z-debug.log
      cmderr	[resource-manager] Error: Command failed: npm run test --prefix tools
      cmderr	[resource-manager]     at checkExecSyncError (child_process.js:635:11)
      cmderr	[resource-manager]     at Object.execSync (child_process.js:671:15)
      cmderr	[resource-manager]     at Object.<anonymous> (/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas/sdkauto_afterscript.js:13:28)
      cmderr	[resource-manager]     at Module._compile (internal/modules/cjs/loader.js:999:30)
      cmderr	[resource-manager]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
      cmderr	[resource-manager]     at Module.load (internal/modules/cjs/loader.js:863:32)
      cmderr	[resource-manager]     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
      cmderr	[resource-manager]     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
      cmderr	[resource-manager]     at internal/main/run_main_module.js:17:47 {
      cmderr	[resource-manager]   status: 39,
      cmderr	[resource-manager]   signal: null,
      cmderr	[resource-manager]   output: [ null, null, null ],
      cmderr	[resource-manager]   pid: 3170,
      cmderr	[resource-manager]   stdout: null,
      cmderr	[resource-manager]   stderr: null
      cmderr	[resource-manager] }
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    Posted by Swagger Pipeline | How to fix these errors?

    @robga
    Copy link
    Contributor Author

    robga commented Jan 26, 2021

    @pilor The SDK for policy exemption is not checked in yet. I update the parameter order for the API to be consistent with other policy artifacts API.

    @raych1
    Copy link
    Member

    raych1 commented Jan 26, 2021

    @ArcturusZhang @msyyc , can you check if there's SDK breaking change? Thanks.

    @pilor pilor self-requested a review January 26, 2021 17:30
    @pilor pilor added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jan 26, 2021
    @pilor
    Copy link
    Contributor

    pilor commented Jan 26, 2021

    No ARM API impact in this PR

    @robga
    Copy link
    Contributor Author

    robga commented Jan 27, 2021

    @raych1 sorry, please hold to merge. I found more issues when generating SDK. I will sync with @pilor offline and update this PR

    @ArcturusZhang
    Copy link
    Member

    Well, this PR does introduce some breaking changes to go SDK - a change of parameter order will change the signature of the corresponding SDK functions. The removal of x-ms-parameter-location will also cause signature changes.

    I am OK these two breaking changes, since both of them are improving the SDK's consistency

    @openapi-workflow-bot
    Copy link

    Hi @robga, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    This was referenced Feb 2, 2021
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    * Fix minor issues in policy exemptions
    
    * Address some issues regarding SDK gen
    
    * Addessed the comment
    
    * Fixed go SDK generation error
    @robga robga deleted the robga/exemption branch September 30, 2021 23:49
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants