[Hub Generated] Review request for Microsoft.MixedReality to add version stable/2021-01-01 #12627

roytan-microsoft · 2021-01-25T23:00:05Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…20-04-06-preview to version 2021-01-01

openapi-workflow-bot · 2021-01-25T23:00:08Z

Hi, @roytan-microsoft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-01-25T23:00:08Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2021-01-01/common.json <---> new: stable/2021-01-01/common.json

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- mixedreality/resource-manager/readme.md tag:default
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- mixedreality/resource-manager/readme.md tag:default

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-01-25T23:00:08Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 138759b. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/mixedreality/mgmt/2020-05-01-preview/mixedreality [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `CheckNameAvailabilityResponse.NameAvailable` has been changed from `NameAvailability` to `*bool`
info	[Changelog] - Const `False` has been removed
info	[Changelog] - Const `True` has been removed
info	[Changelog] - Function `PossibleNameAvailabilityValues` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `Identity` in struct `SpatialAnchorsAccount`
info	[Changelog] - New field `IsDataAction` in struct `Operation`
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 2 additive change(s).
info	[Changelog]

️✔️preview/mixedreality/mgmt/2019-02-28/mixedreality [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 138759b. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/mixedreality/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.MixedReality [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.MixedReality.1.0.0.nupkg
- Microsoft.Azure.Management.MixedReality.1.0.0.snupkg

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 138759b. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
cmderr	[automation_init.sh]   Failed building wheel for wrapt
cmderr	[automation_init.sh]   Failed building wheel for yarl
cmderr	[automation_init.sh]   Failed building wheel for multidict
cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-mixedreality [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Operation has a new parameter properties
info	[Changelog]   - Model Operation has a new parameter origin
info	[Changelog]   - Model Operation has a new parameter is_data_action
info	[Changelog]   - Model RemoteRenderingAccount has a new parameter storage_account_name
info	[Changelog]   - Model RemoteRenderingAccount has a new parameter system_data
info	[Changelog]   - Model RemoteRenderingAccount has a new parameter sku
info	[Changelog]   - Model RemoteRenderingAccount has a new parameter kind
info	[Changelog]   - Model RemoteRenderingAccount has a new parameter plan
info	[Changelog]   - Model SpatialAnchorsAccount has a new parameter storage_account_name
info	[Changelog]   - Model SpatialAnchorsAccount has a new parameter system_data
info	[Changelog]   - Model SpatialAnchorsAccount has a new parameter identity
info	[Changelog]   - Model SpatialAnchorsAccount has a new parameter sku
info	[Changelog]   - Model SpatialAnchorsAccount has a new parameter kind
info	[Changelog]   - Model SpatialAnchorsAccount has a new parameter plan
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation SpatialAnchorsAccountsOperations.update has a new signature
info	[Changelog]   - Operation SpatialAnchorsAccountsOperations.create has a new signature

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 138759b. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-30 01:03:59 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-mixedreality"
cmderr	[generate.py] 2021-01-30 01:03:59 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-01-30 01:03:59 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/mixedreality/azure-resourcemanager-mixedreality --java.namespace=com.azure.resourcemanager.mixedreality   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/mixedreality/resource-manager/readme.md
cmderr	[generate.py] 2021-01-30 01:04:34 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-01-30 01:04:34 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-30 01:04:34 INFO [POM][Skip] pom already has module azure-resourcemanager-mixedreality
cmderr	[generate.py] 2021-01-30 01:04:34 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-30 01:04:34 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-30 01:04:34 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release

️✔️azure-resourcemanager-mixedreality [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-01-30 01:06:56 DEBUG Got artifact_id: azure-resourcemanager-mixedreality
cmderr	[Inst] 2021-01-30 01:06:56 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-30 01:06:56 DEBUG Got artifact: azure-resourcemanager-mixedreality-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-01-30 01:06:56 DEBUG Got artifact: azure-resourcemanager-mixedreality-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-01-30 01:06:56 DEBUG Got artifact: azure-resourcemanager-mixedreality-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-30 01:06:56 DEBUG Match jar package: azure-resourcemanager-mixedreality-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-30 01:06:56 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12627/azure-sdk-for-java/azure-resourcemanager-mixedreality/azure-resourcemanager-mixedreality-1.0.0-beta.1.jar\" -o azure-resourcemanager-mixedreality-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-mixedreality -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-mixedreality-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 138759b. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/mixedreality/resource-manager/readme.md

️✔️@azure/arm-mixedreality [View full logs] [Release SDK Changes]

azure-arm-mixedreality-2.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/mixedRealityClient.js → ./dist/arm-mixedreality.js...
cmderr	[npmPack] created ./dist/arm-mixedreality.js in 272ms

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 138759b. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/mixedreality/resource-manager/readme.md

️✔️mixedreality [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

…21-01-01

azure-pipelines · 2021-01-26T02:24:38Z

Azure Pipelines successfully started running 2 pipeline(s).

roytan-microsoft · 2021-01-28T18:02:16Z

@leni-msft Please approve this additional change to address swagger correctness issues. Thanks!

…ion stable/2021-01-01 (Azure#12627) * Adds base for updating Microsoft.MixedReality from version preview/2020-04-06-preview to version 2021-01-01 * Updates readme * Updates API version in new specs and examples * update proxy and remote rendering * add description * add security definitions * revert security definitions * add systemdata * run prettier * move systemdata to remote-rendering.json * switch to use v1 types * add spatial anchors accounts * add x-ms-secret to dev keys * replace values with *** * suppress secret_property * add storageAccountName to accountProperties

roytan-microsoft and others added 16 commits January 8, 2021 09:26

Adds base for updating Microsoft.MixedReality from version preview/20…

1dc6b11

…20-04-06-preview to version 2021-01-01

Updates readme

ed00127

Updates API version in new specs and examples

067bc41

update proxy and remote rendering

522a0e6

add description

f12a286

add security definitions

0aff155

revert security definitions

2d62786

add systemdata

002e607

run prettier

5afe096

move systemdata to remote-rendering.json

2694734

switch to use v1 types

1a11e52

add spatial anchors accounts

6b0cffa

add x-ms-secret to dev keys

5f09c3c

replace values with ***

6fed256

suppress secret_property

05fd44f

add storageAccountName to accountProperties

3c9593a

Merge branch 'master' into dev-mixedreality-Microsoft.MixedReality-20…

97e00e6

…21-01-01

openapi-pipeline-app bot added CI-BreakingChange-Python CI-BreakingChange-Go labels Jan 25, 2021

roytan-microsoft marked this pull request as ready for review January 26, 2021 02:21

openapi-assignment-bot bot assigned leni-msft Jan 26, 2021

openapi-workflow-bot bot added the FixS360 label Jan 26, 2021

leni-msft approved these changes Jan 30, 2021

View reviewed changes

leni-msft merged commit 138759b into Azure:master Jan 30, 2021

roytan-microsoft mentioned this pull request Feb 10, 2021

mixed reality csharp sdk for 2021-01-01 API Azure/azure-sdk-for-net#18448

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.MixedReality to add version stable/2021-01-01 #12627

[Hub Generated] Review request for Microsoft.MixedReality to add version stable/2021-01-01 #12627

roytan-microsoft commented Jan 25, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 25, 2021

openapi-pipeline-app bot commented Jan 25, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 25, 2021 •

edited

Loading

azure-pipelines bot commented Jan 26, 2021

roytan-microsoft commented Jan 28, 2021

[Hub Generated] Review request for Microsoft.MixedReality to add version stable/2021-01-01 #12627

[Hub Generated] Review request for Microsoft.MixedReality to add version stable/2021-01-01 #12627

Conversation

roytan-microsoft commented Jan 25, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 25, 2021

openapi-pipeline-app bot commented Jan 25, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 25, 2021 • edited Loading

Swagger Generation Artifacts

azure-pipelines bot commented Jan 26, 2021

roytan-microsoft commented Jan 28, 2021

roytan-microsoft commented Jan 25, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 25, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 25, 2021 •

edited

Loading