-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding required for api swagger for azure resource mover #12470
Conversation
Hi, @dukum Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L965:5 |
️⚠️
LintDiff: 1 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
Rule | Message |
---|---|
Based on the response model schema, operation 'MoveCollections_ListRequiredFor' might be pageable. Consider adding the x-ms-pageable extension. New: Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json#L966 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
NewApiVersionRequired reason: |
Hi @dukum, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi, @dukum your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @ChenTanyi |
This PR is marked as DoNotMerge, please let us know if is ready so we can review it. |
Please do the review as it is ready. We added the label internally and will remove once the service side changes are deployed. |
Hi @dukum, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
...r/resource-manager/Microsoft.Migrate/preview/2019-10-01-preview/resourcemovercollection.json
Show resolved
Hide resolved
Please, consider following ARM RPC for GET calls as indicated here, I'll approve the PR because you already have other GET calls using the same approach, but the recommendation is to end a GET api with either a resource name (single result), resource type (list) or a singleton (/default). |
|
@msyyc to help check why python SDK generation fail |
For python, the failure is fake and please ignore it |
Please let me know when it ready to merge. |
We will remove the DoNotMerge tag and let you know when the service changes are deployed. thanks. |
hi @ChenTanyi. can you please help to merge this. we have removed the DoNotMerge tag. thanks. |
* adding required for api changes * fixing npmpretty checks and lint issues * linting fixes 2 Co-authored-by: Durgesh Kumar <dukum@microsoft.com>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.