Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing swagger correctness issues for Resource Mover Service #12398

Merged
merged 2 commits into from
Jan 18, 2021
Merged

Fixing swagger correctness issues for Resource Mover Service #12398

merged 2 commits into from
Jan 18, 2021

Conversation

dukum
Copy link
Member

@dukum dukum commented Jan 12, 2021 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

This PR contains changes for fixing some of the swagger correctness issues that were flagged by the tool. As our service is marching towards GA we are also fixing issues in swagger which are not impacting users.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @dukum Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 12, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 12, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2d75ec5. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/resourcemover/resource-manager/readme.md
    • ⚠️azure-mgmt-resourcemover [View full logs]  [Release SDK Changes] 
      cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-resourcemover
cmderr	[buildConf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-resourcemover
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-resourcemover
cmderr	[buildPackage] /home/vsts/work/1/s/azure-sdk-for-python_tmp/venv/lib/python3.6/site-packages/setuptools/dist.py:461: UserWarning: Normalizing '0.1.0-preview' to '0.1.0rc0'
cmderr	[buildPackage]   warnings.warn(tmpl.format(**locals()))
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[buildPackage] /home/vsts/work/1/s/azure-sdk-for-python_tmp/venv/lib/python3.6/site-packages/setuptools/dist.py:461: UserWarning: Normalizing '0.1.0-preview' to '0.1.0rc0'
cmderr	[buildPackage]   warnings.warn(tmpl.format(**locals()))
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.resourcemover
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.resourcemover
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.resourcemover
cmderr	[changelogReport] INFO:__main__:Report written to sdk/resourcemover/azure-mgmt-resourcemover/code_reports/latest/report.json
cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-resourcemover on PyPI
cmderr	[changelogReportLatest] INFO:__main__:Got ['1.0.1b1']
cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
cmderr	[changelogReportLatest] Traceback (most recent call last):
cmderr	[changelogReportLatest]   File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
cmderr	[changelogReportLatest]     "__main__", mod_spec)
cmderr	[changelogReportLatest]   File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
cmderr	[changelogReportLatest]     exec(code, run_globals)
cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 399, in <module>
cmderr	[changelogReportLatest]     main(args.package_name, args.version, args.no_venv, args.pypi, args.last_pypi, args.output)
cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 268, in main
cmderr	[changelogReportLatest]     versions = [versions[-1]]
cmderr	[changelogReportLatest] IndexError: list index out of range
warn	Script return with result [warning] code [1] signal [null] cwd [azure-sdk-for-python]: python
warn	Not exact 2 reports found:
warn		code_reports/latest/report.json
warn	Not generating changelog.
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2d75ec5. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=3.0.6272 --use=@autorest/python@5.4.3 --python --python-mode=update --multiapi --track2 --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/resourcemover/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'MoveResourceProperties-moveStatus' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'MoveResourceProperties-errors' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'MoveCollectionProperties-errors' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'SubnetReference' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'LoadBalancerBackendAddressPoolReference' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'LoadBalancerNatRuleReference' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'SqlServerResourceSettings' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'ResourceGroupResourceSettings' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceProperties-moveStatus' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceProperties-errors' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveCollectionProperties-errors' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceFilterProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'MoveResourceErrorBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudErrorBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
    • ⚠️track2_azure-mgmt-resourcemover [View full logs]  [Release SDK Changes] 
      cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-resourcemover
cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-resourcemover
cmderr	[buildPackage] /home/vsts/work/1/s/azure-sdk-for-python_tmp/venv/lib/python3.6/site-packages/setuptools/dist.py:461: UserWarning: Normalizing '0.1.0-preview' to '0.1.0rc0'
cmderr	[buildPackage]   warnings.warn(tmpl.format(**locals()))
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[buildPackage] /home/vsts/work/1/s/azure-sdk-for-python_tmp/venv/lib/python3.6/site-packages/setuptools/dist.py:461: UserWarning: Normalizing '0.1.0-preview' to '0.1.0rc0'
cmderr	[buildPackage]   warnings.warn(tmpl.format(**locals()))
cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] INFO:__main__:Building code report of azure-mgmt-resourcemover for version None in default folder (False/False/False)
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.resourcemover
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.resourcemover
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.resourcemover
cmderr	[changelogReport] INFO:__main__:Report written to sdk/resourcemover/azure-mgmt-resourcemover/code_reports/latest/report.json
cmderr	[changelogReportLatest] INFO:__main__:Building code report of azure-mgmt-resourcemover for version None in default folder (False/False/True)
cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-resourcemover on PyPI
cmderr	[changelogReportLatest] INFO:__main__:Got ['1.0.1b1']
cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
cmderr	[changelogReportLatest] INFO:__main__:Installing version 1.0.1b1 of azure-mgmt-resourcemover in a venv
cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
cmderr	[changelogReportLatest] INFO:__main__:Building code report of azure-mgmt-resourcemover for version 1.0.1b1 in default folder (True/False/False)
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.resourcemover
cmderr	[changelogReportLatest] Traceback (most recent call last):
cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 267, in find_autorest_generated_folder
cmderr	[changelogReportLatest]     model_module = importlib.import_module(".models", module_prefix)
cmderr	[changelogReportLatest]   File "/usr/lib/python3.6/importlib/__init__.py", line 126, in import_module
cmderr	[changelogReportLatest]     return _bootstrap._gcd_import(name[level:], package, level)
cmderr	[changelogReportLatest]   File "<frozen importlib._bootstrap>", line 994, in _gcd_import
cmderr	[changelogReportLatest]   File "<frozen importlib._bootstrap>", line 971, in _find_and_load
cmderr	[changelogReportLatest]   File "<frozen importlib._bootstrap>", line 941, in _find_and_load_unlocked
cmderr	[changelogReportLatest]   File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
cmderr	[changelogReportLatest]   File "<frozen importlib._bootstrap>", line 994, in _gcd_import
cmderr	[changelogReportLatest]   File "<frozen importlib._bootstrap>", line 971, in _find_and_load
cmderr	[changelogReportLatest]   File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
cmderr	[changelogReportLatest]   File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
cmderr	[changelogReportLatest]   File "<frozen importlib._bootstrap_external>", line 678, in exec_module
cmderr	[changelogReportLatest]   File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/tmp_nluyv1v/lib/python3.6/site-packages/azure/mgmt/resourcemover/__init__.py", line 9, in <module>
cmderr	[changelogReportLatest]     from ._resource_mover_service_api import ResourceMoverServiceAPI
cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/tmp_nluyv1v/lib/python3.6/site-packages/azure/mgmt/resourcemover/_resource_mover_service_api.py", line 11, in <module>
cmderr	[changelogReportLatest]     from azure.mgmt.core import ARMPipelineClient
cmderr	[changelogReportLatest] ModuleNotFoundError: No module named 'azure.mgmt.core'
cmderr	[changelogReportLatest] During handling of the above exception, another exception occurred:
cmderr	[changelogReportLatest] Traceback (most recent call last):
cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 327, in <module>
cmderr	[changelogReportLatest]     main(args.package_name, args.version, args.no_venv, args.pypi, args.last_pypi, args.output, args.metadata)
cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 208, in main
cmderr	[changelogReportLatest]     modules = find_autorest_generated_folder(module_name)
cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 275, in find_autorest_generated_folder
cmderr	[changelogReportLatest]     prefix_module = importlib.import_module(module_prefix)
cmderr	[changelogReportLatest]   File "/usr/lib/python3.6/importlib/__init__.py", line 126, in import_module
cmderr	[changelogReportLatest]     return _bootstrap._gcd_import(name[level:], package, level)
cmderr	[changelogReportLatest]   File "<frozen importlib._bootstrap>", line 994, in _gcd_import
cmderr	[changelogReportLatest]   File "<frozen importlib._bootstrap>", line 971, in _find_and_load
cmderr	[changelogReportLatest]   File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
cmderr	[changelogReportLatest]   File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
cmderr	[changelogReportLatest]   File "<frozen importlib._bootstrap_external>", line 678, in exec_module
cmderr	[changelogReportLatest]   File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/tmp_nluyv1v/lib/python3.6/site-packages/azure/mgmt/resourcemover/__init__.py", line 9, in <module>
cmderr	[changelogReportLatest]     from ._resource_mover_service_api import ResourceMoverServiceAPI
cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/tmp_nluyv1v/lib/python3.6/site-packages/azure/mgmt/resourcemover/_resource_mover_service_api.py", line 11, in <module>
cmderr	[changelogReportLatest]     from azure.mgmt.core import ARMPipelineClient
cmderr	[changelogReportLatest] ModuleNotFoundError: No module named 'azure.mgmt.core'
cmderr	[changelogReportLatest] WARNING:__main__:Version 1.0.1b1 seems to be too old to build a report (probably not Autorest based)
cmderr	[changelogReportLatest] Traceback (most recent call last):
cmderr	[changelogReportLatest]   File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
cmderr	[changelogReportLatest]     "__main__", mod_spec)
cmderr	[changelogReportLatest]   File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
cmderr	[changelogReportLatest]     exec(code, run_globals)
cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 327, in <module>
cmderr	[changelogReportLatest]     main(args.package_name, args.version, args.no_venv, args.pypi, args.last_pypi, args.output, args.metadata)
cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 204, in main
cmderr	[changelogReportLatest]     with open(metadata_path, "r") as metadata_fd:
cmderr	[changelogReportLatest] FileNotFoundError: [Errno 2] No such file or directory: '/home/vsts/work/1/s/azure-sdk-for-python_tmp/tmpwdh53a67/metadata.json'
warn	Script return with result [warning] code [1] signal [null] cwd [azure-sdk-for-python]: python
warn	Not exact 2 reports found:
warn		code_reports/latest/report.json
warn	Not generating changelog.
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2d75ec5. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-18 08:17:36 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-resourcemover"
cmderr	[generate.py] 2021-01-18 08:17:36 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-01-18 08:17:36 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.9 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/resourcemover/azure-resourcemanager-resourcemover --java.namespace=com.azure.resourcemanager.resourcemover   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/resourcemover/resource-manager/readme.md
cmderr	[generate.py] 2021-01-18 08:18:15 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-01-18 08:18:15 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-18 08:18:15 INFO [POM][Skip] pom already has module azure-resourcemanager-resourcemover
cmderr	[generate.py] 2021-01-18 08:18:15 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-18 08:18:15 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-18 08:18:15 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
    • ️✔️azure-resourcemanager-resourcemover [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-01-18 08:20:39 DEBUG Got artifact_id: azure-resourcemanager-resourcemover
cmderr	[Inst] 2021-01-18 08:20:39 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-01-18 08:20:39 DEBUG Got artifact: azure-resourcemanager-resourcemover-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-01-18 08:20:39 DEBUG Got artifact: azure-resourcemanager-resourcemover-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-01-18 08:20:39 DEBUG Got artifact: azure-resourcemanager-resourcemover-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-18 08:20:39 DEBUG Match jar package: azure-resourcemanager-resourcemover-1.0.0-beta.1.jar
cmderr	[Inst] 2021-01-18 08:20:39 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12398/azure-sdk-for-java/azure-resourcemanager-resourcemover/azure-resourcemanager-resourcemover-1.0.0-beta.1.jar\" -o azure-resourcemanager-resourcemover-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-resourcemover -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-resourcemover-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2d75ec5. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️preview/resourcemover/mgmt/2019-10-01-preview/resourcemover [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ## Breaking Changes
info	[Changelog]
info	[Changelog] - Struct `SummaryItem` has been removed
info	[Changelog] - Field `Summary` of struct `MoveResourceCollection` has been removed
info	[Changelog]
info	[Changelog] ## New Content
info	[Changelog]
info	[Changelog] - New const `ResourceMoveCompleted`
info	[Changelog] - New const `DeleteSourcePending`
info	[Changelog] - New function `MoveCollectionProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `MoveResourceCollection.MarshalJSON() ([]byte, error)`
info	[Changelog] - New struct `MoveCollectionPropertiesErrors`
info	[Changelog] - New struct `Summary`
info	[Changelog] - New struct `SummaryCollection`
info	[Changelog] - New field `IsResolveRequired` in struct `MoveResourceProperties`
info	[Changelog] - New field `Etag` in struct `MoveCollection`
info	[Changelog] - New field `Errors` in struct `MoveCollectionProperties`
info	[Changelog] - New field `SummaryCollection` in struct `MoveResourceCollection`
info	[Changelog] - New field `TotalCount` in struct `MoveResourceCollection`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 14 additive change(s).
info	[Changelog]
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2d75ec5. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/resourcemover/resource-manager/readme.md
warn	No file changes detected after generation
warn	No package detected after generation
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2d75ec5. Schema Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/resourcemover/resource-manager/readme.md
    • ️✔️resourcemover [View full logs]  [Release Schema Changes] 
      cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @dukum, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jan 12, 2021
    Closed
    This was referenced Jan 12, 2021
    Closed
    Closed
    Closed
    @dukum dukum marked this pull request as ready for review January 14, 2021 16:38
    @dukum
    Copy link
    Member Author

    dukum commented Jan 16, 2021

    hi @xccc-msft. can you please help merge this change. thanks.

    @xseeseesee
    Copy link
    Contributor

    @dukum I don't have access to merge before breaking change review gets approved.

    @dukum
    Copy link
    Member Author

    dukum commented Jan 18, 2021

    Hi @xccc-msft. removed the changes which were coming off as breaking change. the label is removed now. thanks.

    @xseeseesee xseeseesee merged commit 2d75ec5 into Azure:master Jan 18, 2021
    This was referenced Jan 18, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @dukum @mkarmark
    Fixing swagger correctness issues for Resource Mover Service (Azure#1…
    900f9a9 
    …2398)

* correctness issues

* adding tragetId back again

Co-authored-by: Durgesh Kumar <dukum@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @xseeseesee xseeseesee xseeseesee approved these changes

    @innosam innosam innosam approved these changes

    Assignees

    @xseeseesee xseeseesee

    Labels
    CI-BreakingChange-Go
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @dukum @xseeseesee @innosam