Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NetAppFiles] Anf 9085 update swagger rest api to 2020 11 01 #12388

Merged

Conversation

audunn
Copy link
Member

@audunn audunn commented Jan 12, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@audunn audunn requested a review from lirenhe as a code owner January 12, 2021 16:01
@openapi-workflow-bot
Copy link

Hi, @audunn Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 12, 2021

    Swagger Validation Report

    ️❌BreakingChange: 12 Errors, 0 Warnings failed [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'eventTime' renamed or removed?
    New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L5557:7
    Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L5557:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'queryStartTime' renamed or removed?
    New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L5557:7
    Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L5557:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'queryEndTime' renamed or removed?
    New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L5557:7
    Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L5557:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'edges' renamed or removed?
    New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L5642:11
    Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L5657:11
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'eventTime' renamed or removed?
    New: Microsoft.SecurityInsights/stable/2020-01-01/SecurityInsights.json#L1818:7
    Old: Microsoft.SecurityInsights/stable/2020-01-01/SecurityInsights.json#L1818:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'queryStartTime' renamed or removed?
    New: Microsoft.SecurityInsights/stable/2020-01-01/SecurityInsights.json#L1818:7
    Old: Microsoft.SecurityInsights/stable/2020-01-01/SecurityInsights.json#L1818:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'queryEndTime' renamed or removed?
    New: Microsoft.SecurityInsights/stable/2020-01-01/SecurityInsights.json#L1818:7
    Old: Microsoft.SecurityInsights/stable/2020-01-01/SecurityInsights.json#L1818:7
    1034 - AddedRequiredProperty The new version has new required property 'incidentId, severity, title, relationName' that was not found in the old version.
    New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L5601:9
    Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L5616:9
    1034 - AddedRequiredProperty The new version has new required property 'incidentId, severity, title, relationName' that was not found in the old version.
    New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L8064:9
    Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L8099:9
    1034 - AddedRequiredProperty The new version has new required property 'incidentId, severity, title, relationName' that was not found in the old version.
    New: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L11257:5
    Old: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json#L11292:5
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️❌[Staging] SDK Track2 Validation: 8 Errors, 62 Warnings failed [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    PreCheck/DuplicateSchema "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2019-01-preview-only",
    "details":"Duplicate Schema named AggregationsKind -- properties: "kind":"description":"The kind of the setting",
    "$ref":"#/components/schemas/AggregationsKind" =>,
    type: undefined => "string",
    required: ["kind"] =>,
    enum: undefined => ["CasesAggregation"],
    x-ms-enum: undefined => "modelAsString":true,
    "name":"AggregationsKind" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    PreCheck/DuplicateSchema "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2019-01-preview-only",
    "details":"Duplicate Schema named AlertRuleKind -- properties: "kind":"description":"The kind of the alert rule",
    "$ref":"#/components/schemas/AlertRuleKind" =>,
    type: undefined => "string",
    required: ["kind"] =>,
    enum: undefined => ["Scheduled",
    "MicrosoftSecurityIncidentCreation",
    "Fusion",
    "MLBehaviorAnalytics",
    "ThreatIntelligence",
    "Anomaly"],
    x-ms-enum: undefined => "modelAsString":true,
    "name":"AlertRuleKind",
    "values":["value":"Scheduled",
    "value":"MicrosoftSecurityIncidentCreation",
    "value":"Fusion",
    "value":"MLBehaviorAnalytics",
    "value":"ThreatIntelligence",
    "value":"Anomaly"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    PreCheck/DuplicateSchema "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2019-01-preview-only",
    "details":"Duplicate Schema named DataConnectorKind -- properties: "kind":"description":"The kind of the data connector",
    "$ref":"#/components/schemas/DataConnectorKind" =>,
    type: undefined => "string",
    required: ["kind"] =>,
    enum: undefined => ["AzureActiveDirectory",
    "AzureSecurityCenter",
    "MicrosoftCloudAppSecurity",
    "ThreatIntelligence",
    "ThreatIntelligenceTaxii",
    "Office365",
    "OfficeATP",
    "AmazonWebServicesCloudTrail",
    "AzureAdvancedThreatProtection",
    "MicrosoftDefenderAdvancedThreatProtection",
    "Dynamics365"],
    x-ms-enum: undefined => "modelAsString":true,
    "name":"DataConnectorKind",
    "values":["value":"AzureActiveDirectory",
    "value":"AzureSecurityCenter",
    "value":"MicrosoftCloudAppSecurity",
    "value":"ThreatIntelligence",
    "value":"ThreatIntelligenceTaxii",
    "value":"Office365",
    "value":"OfficeATP",
    "value":"AmazonWebServicesCloudTrail",
    "value":"AzureAdvancedThreatProtection",
    "value":"MicrosoftDefenderAdvancedThreatProtection",
    "value":"Dynamics365"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    PreCheck/DuplicateSchema "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2019-01-preview-only",
    "details":"Duplicate Schema named EntityKind -- properties: "kind":"description":"The kind of the entity.",
    "$ref":"#/components/schemas/EntityKind" =>,
    type: undefined => "string",
    required: ["kind"] =>,
    enum: undefined => ["Account",
    "Host",
    "File",
    "AzureResource",
    "CloudApplication",
    "DnsResolution",
    "FileHash",
    "Ip",
    "Malware",
    "Process",
    "RegistryKey",
    "RegistryValue",
    "SecurityGroup",
    "Url",
    "IoTDevice",
    "SecurityAlert",
    "Bookmark",
    "Mailbox",
    "MailCluster",
    "MailMessage",
    "SubmissionMail"],
    x-ms-enum: undefined => "modelAsString":true,
    "name":"EntityKind",
    "values":["description":"Entity represents account in the system.",
    "value":"Account",
    "description":"Entity represents host in the system.",
    "value":"Host",
    "description":"Entity represents file in the system.",
    "value":"File",
    "description":"Entity represents azure resource in the system.",
    "value":"AzureResource",
    "description":"Entity represents cloud application in the system.",
    "value":"CloudApplication",
    "description":"Entity represents dns resolution in the system.",
    "value":"DnsResolution",
    "description":"Entity represents file hash in the system.",
    "value":"FileHash",
    "description":"Entity represents ip in the system.",
    "value":"Ip",
    "description":"Entity represents malware in the system.",
    "value":"Malware",
    "description":"Entity represents process in the system.",
    "value":"Process",
    "description":"Entity represents registry key in the system.",
    "value":"RegistryKey",
    "description":"Entity represents registry value in the system.",
    "value":"RegistryValue",
    "description":"Entity represents security group in the system.",
    "value":"SecurityGroup",
    "description":"Entity represents url in the system.",
    "value":"Url",
    "description":"Entity represents IoT device in the system.",
    "value":"IoTDevice",
    "description":"Entity represents security alert in the system.",
    "value":"SecurityAlert",
    "description":"Entity represents bookmark in the system.",
    "value":"Bookmark",
    "description":"Entity represents mail cluster in the system.",
    "value":"MailCluster",
    "description":"Entity represents mail message in the system.",
    "value":"MailMessage",
    "description":"Entity represents mailbox in the system.",
    "value":"Mailbox",
    "description":"Entity represents submission mail in the system.",
    "value":"SubmissionMail"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    PreCheck/DuplicateSchema "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2019-01-preview-only",
    "details":"Duplicate Schema named EntityQueryKind -- properties: "kind":"description":"The kind of the entity query",
    "$ref":"#/components/schemas/EntityQueryKind" =>,
    type: undefined => "string",
    required: ["kind"] =>,
    enum: undefined => ["Expansion",
    "Insight"],
    x-ms-enum: undefined => "modelAsString":true,
    "name":"EntityQueryKind",
    "values":["value":"Expansion",
    "value":"Insight"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    PreCheck/DuplicateSchema "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2019-01-preview-only",
    "details":"Duplicate Schema named ThreatIntelligenceResourceKind -- properties: "kind":"description":"The kind of the entity.",
    "$ref":"#/components/schemas/ThreatIntelligenceResourceKind" =>,
    type: undefined => "string",
    required: ["kind"] =>,
    enum: undefined => ["indicator"],
    x-ms-enum: undefined => "modelAsString":true,
    "name":"ThreatIntelligenceResourceKind",
    "values":["description":"Entity represents threat intelligence indicator in the system.",
    "value":"indicator"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    PreCheck/DuplicateSchema "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2019-01-preview-only",
    "details":"Duplicate Schema named ThreatIntelligenceSortingCriteria -- properties: "itemKey":"description":"Column name",
    "$ref":"#/components/schemas/schemas:802",
    "sortOrder":"description":"Sorting order (ascending/descending/unsorted).",
    "$ref":"#/components/schemas/ThreatIntelligenceSortingCriteria" =>,
    type: undefined => "string",
    enum: undefined => ["unsorted",
    "ascending",
    "descending"],
    x-ms-enum: undefined => "modelAsString":true,
    "name":"ThreatIntelligenceSortingCriteria",
    "values":["value":"unsorted",
    "value":"ascending",
    "value":"descending"] ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    AutorestCore/Exception "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-2019-01-preview-only",
    "details":"Error: Plugin prechecker reported failure."
    ⚠️ PreCheck/SchemaMissingType "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-composite-v1",
    "details":"The schema 'ActionsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"securityinsights/resource-manager/readme.md",
    "tag":"package-composite-v1",
    "details":"The schema 'AlertRuleTemplatesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 12, 2021

    Swagger Generation Artifacts

    ️❌[Staging] ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    RestBuild error "logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=192991&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b",
    "detail":"Run.ps1 failed with exit code 128 "
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 288628a. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/netapp/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.NetApp [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 288628a. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/netapp/resource-manager/readme.md
    • ️✔️netapp [View full logs]  [Release Schema Changes]
      cmderr	[resource-manager] node-pre-gyp
      cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
      cmderr	[resource-manager]  WARN template-schema-validation-tools@1.0.0 No repository field.
      cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
      cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 288628a. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
      cmderr	[automation_init.sh]   Failed building wheel for yarl
      cmderr	[automation_init.sh]   Failed building wheel for wrapt
      cmderr	[automation_init.sh]   Failed building wheel for multidict
      cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
      cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-netapp [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model ActiveDirectory has a new parameter ldap_over_tls
      info	[Changelog]   - Model NetAppAccount has a new parameter encryption
      info	[Changelog]   - Model NetAppAccount has a new parameter system_data
      info	[Changelog]   - Model NetAppAccountPatch has a new parameter encryption
      info	[Changelog]   - Model Volume has a new parameter name1
      info	[Changelog]   - Model Volume has a new parameter encryption_key_source
      info	[Changelog]   - Model BackupPatch has a new parameter failure_reason
      info	[Changelog]   - Model Backup has a new parameter failure_reason
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 288628a. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
      cmderr	[automation_init.sh]   Failed building wheel for wrapt
      cmderr	[automation_init.sh]   Failed building wheel for yarl
      cmderr	[automation_init.sh]   Failed building wheel for multidict
      cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
      cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-netapp [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model NetAppAccountList has a new parameter next_link
      info	[Changelog]   - Model BackupPatch has a new parameter failure_reason
      info	[Changelog]   - Model NetAppAccountPatch has a new parameter encryption
      info	[Changelog]   - Model Volume has a new parameter smb_encryption
      info	[Changelog]   - Model Volume has a new parameter smb_continuously_available
      info	[Changelog]   - Model Volume has a new parameter name_properties_name
      info	[Changelog]   - Model Volume has a new parameter encryption_key_source
      info	[Changelog]   - Model NetAppAccount has a new parameter encryption
      info	[Changelog]   - Model NetAppAccount has a new parameter system_data
      info	[Changelog]   - Model Backup has a new parameter failure_reason
      info	[Changelog]   - Model VolumeList has a new parameter next_link
      info	[Changelog]   - Model ActiveDirectory has a new parameter ldap_over_tls
      info	[Changelog]   - Model ActiveDirectory has a new parameter security_operators
      info	[Changelog]   - Model CapacityPoolList has a new parameter next_link
      info	[Changelog]   - Added operation SnapshotPoliciesOperations.begin_update
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation SnapshotPoliciesOperations.update
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 288628a. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-02-04 08:22:18 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-netapp"
      cmderr	[generate.py] 2021-02-04 08:22:18 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-02-04 08:22:18 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/netapp/azure-resourcemanager-netapp --java.namespace=com.azure.resourcemanager.netapp   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/netapp/resource-manager/readme.md
      cmderr	[generate.py] 2021-02-04 08:23:10 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-02-04 08:23:10 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-02-04 08:23:10 INFO [POM][Skip] pom already has module azure-resourcemanager-netapp
      cmderr	[generate.py] 2021-02-04 08:23:10 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-02-04 08:23:10 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-02-04 08:23:10 INFO [POM][Success] Write to root pom
      cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
      cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
      cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
      cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
      cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
    • ️✔️azure-resourcemanager-netapp [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-02-04 08:27:16 DEBUG Got artifact_id: azure-resourcemanager-netapp
      cmderr	[Inst] 2021-02-04 08:27:16 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-02-04 08:27:16 DEBUG Got artifact: azure-resourcemanager-netapp-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-02-04 08:27:16 DEBUG Match jar package: azure-resourcemanager-netapp-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-02-04 08:27:16 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12388/azure-sdk-for-java/azure-resourcemanager-netapp/azure-resourcemanager-netapp-1.0.0-beta.1.jar\" -o azure-resourcemanager-netapp-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-netapp -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-netapp-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 288628a. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/netapp/resource-manager/readme.md
    • ️✔️@azure/arm-netapp [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/azureNetAppFilesManagementClient.js → ./dist/arm-netapp.js...
      cmderr	[npmPack] created ./dist/arm-netapp.js in 572ms
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 12, 2021
    @openapi-workflow-bot
    Copy link

    Hi, @audunn your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @yungezz

    @openapi-workflow-bot
    Copy link

    Hi @audunn, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @j5lim j5lim added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jan 15, 2021
    @audunn
    Copy link
    Member Author

    audunn commented Feb 3, 2021

    @yungezz can we move forward with this?

    @yungezz yungezz merged commit 288628a into Azure:master Feb 4, 2021
    This was referenced Feb 4, 2021
    @00Kai0
    Copy link
    Contributor

    00Kai0 commented Feb 4, 2021

    /azp run

    @audunn
    Copy link
    Member Author

    audunn commented Feb 4, 2021

    @yungezz can we move forward with this issue that was found just after this was merged #12852? No SDK's have been created or released yet.

    @yungezz
    Copy link
    Member

    yungezz commented Feb 4, 2021

    @yungezz can we move forward with this issue that was found just after this was merged #12852? No SDK's have been created or released yet.

    add @jianyexi to help on #12852

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants