Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANF-8872 Fix examples for integers #12367

Merged
merged 11 commits into from
Feb 19, 2021
Merged

ANF-8872 Fix examples for integers #12367

merged 11 commits into from
Feb 19, 2021

Conversation

audunn
Copy link
Member

@audunn audunn commented Jan 11, 2021 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

updating existing version to fix swagger quality issue in s360

This is to address S360 findings, SDK will be generated based on upcoming 2020-11-01 api-version that will also contain same fixes where applicable.

@xccc-msft This is in relation to the Window to Fix Broken https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/405/Window-to-Fix-Broken

Issues
https://msit.powerbi.com/groups/me/apps/7f17babe-3e24-447d-91de-796f85555eb4/reports/17c7b280-b27a-4f7f-b24f-f23f80e7ee3e/ReportSection766c23df8ea11acbcf28

Changelog

updating existing version to fix swagger quality issue in s360

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @audunn Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 11, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 56 Errors, 0 Warnings failed [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ❌ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/stable/2019-11-01/netapp.json#L1759:9
    Old: Microsoft.NetApp/stable/2019-11-01/netapp.json#L1759:9
    ❌ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/stable/2020-02-01/netapp.json#L1766:9
    Old: Microsoft.NetApp/stable/2020-02-01/netapp.json#L1766:9
    ❌ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/stable/2020-02-01/netapp.json#L1795:9
    Old: Microsoft.NetApp/stable/2020-02-01/netapp.json#L1794:9
    ❌ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/stable/2020-02-01/netapp.json#L2267:9
    Old: Microsoft.NetApp/stable/2020-02-01/netapp.json#L2256:9
    ❌ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/stable/2020-02-01/netapp.json#L2244:9
    Old: Microsoft.NetApp/stable/2020-02-01/netapp.json#L2234:9
    ❌ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/stable/2020-03-01/netapp.json#L1766:9
    Old: Microsoft.NetApp/stable/2020-03-01/netapp.json#L1766:9
    ❌ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/stable/2020-03-01/netapp.json#L1795:9
    Old: Microsoft.NetApp/stable/2020-03-01/netapp.json#L1794:9
    ❌ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/stable/2020-03-01/netapp.json#L2260:9
    Old: Microsoft.NetApp/stable/2020-03-01/netapp.json#L2257:9
    ❌ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/stable/2020-05-01/netapp.json#L2869:9
    Old: Microsoft.NetApp/stable/2020-05-01/netapp.json#L2869:9
    ❌ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.NetApp/stable/2020-05-01/netapp.json#L2901:9
    Old: Microsoft.NetApp/stable/2020-05-01/netapp.json#L2900:9
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 123 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ PreCheck/SchemaMissingType "readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-09-01",
    "details":"The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-09-01",
    "details":"The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-09-01",
    "details":"The schema 'OperationProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-09-01",
    "details":"The schema 'ServiceSpecification' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-09-01",
    "details":"The schema 'MetricSpecification' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-09-01",
    "details":"The schema 'Dimension' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-09-01",
    "details":"The schema 'volumeProperties-exportPolicy' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-09-01",
    "details":"The schema 'volumeProperties-dataProtection' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-09-01",
    "details":"The schema 'volumePatchProperties-exportPolicy' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"netapp/resource-manager/readme.md",
    "tag":"package-netapp-2020-09-01",
    "details":"The schema 'volumePatchProperties-dataProtection' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 11, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d418224. Schema Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/netapp/resource-manager/readme.md
    • ️✔️netapp [View full logs]  [Release Schema Changes] 
      cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d418224. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️netapp/mgmt/2020-11-01/netapp [View full logs]  [Release SDK Changes] 
      info	[Changelog] This is a new package
    • ️✔️netapp/mgmt/2020-09-01/netapp [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️netapp/mgmt/2020-08-01/netapp [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️netapp/mgmt/2020-07-01/netapp [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️netapp/mgmt/2020-06-01/netapp [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️netapp/mgmt/2020-05-01/netapp [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️netapp/mgmt/2020-03-01/netapp [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️netapp/mgmt/2020-02-01/netapp [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `UsedBytes` in struct `VolumeProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2019-11-01/netapp [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `UsedBytes` in struct `VolumeProperties`
info	[Changelog] - New field `Name` in struct `PoolProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 2 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2019-10-01/netapp [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `UsedBytes` in struct `VolumeProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2019-08-01/netapp [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `UsedBytes` in struct `VolumeProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2019-07-01/netapp [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `Name` in struct `PoolProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
info	[Changelog]
    • ️✔️netapp/mgmt/2019-06-01/netapp [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️netapp/mgmt/2019-05-01/netapp [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/netapp/mgmt/2017-08-15/netapp [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d418224. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-netapp [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation BackupsOperations.begin_update
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model Volume no longer has parameter name_properties_name
info	[Changelog]   - Removed operation BackupsOperations.update
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d418224. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-netapp [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model BackupPatch has a new parameter failure_reason
info	[Changelog]   - Model ActiveDirectory has a new parameter ldap_over_tls
info	[Changelog]   - Model Volume has a new parameter encryption_key_source
info	[Changelog]   - Model Backup has a new parameter failure_reason
info	[Changelog]   - Model NetAppAccountPatch has a new parameter encryption
info	[Changelog]   - Model NetAppAccount has a new parameter encryption
info	[Changelog]   - Model NetAppAccount has a new parameter system_data
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d418224. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/netapp/resource-manager/readme.md
    • ️✔️@azure/arm-netapp [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/azureNetAppFilesManagementClient.js → ./dist/arm-netapp.js...
cmderr	[npmPack] created ./dist/arm-netapp.js in 478ms
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d418224. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/netapp/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.NetApp [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d418224. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-19 02:47:35 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-netapp"
cmderr	[generate.py] 2021-02-19 02:47:35 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-02-19 02:47:35 INFO autorest --version=3.0.6369 --use=@autorest/java@4.0.16 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/netapp/azure-resourcemanager-netapp --java.namespace=com.azure.resourcemanager.netapp   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/netapp/resource-manager/readme.md
cmderr	[generate.py] 2021-02-19 02:48:16 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-02-19 02:48:16 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-19 02:48:16 INFO [POM][Skip] pom already has module azure-resourcemanager-netapp
cmderr	[generate.py] 2021-02-19 02:48:16 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-19 02:48:16 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-19 02:48:16 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-netapp [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-02-19 02:50:51 DEBUG Got artifact_id: azure-resourcemanager-netapp
cmderr	[Inst] 2021-02-19 02:50:51 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-19 02:50:51 DEBUG Got artifact: azure-resourcemanager-netapp-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-02-19 02:50:51 DEBUG Got artifact: azure-resourcemanager-netapp-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-19 02:50:51 DEBUG Match jar package: azure-resourcemanager-netapp-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-19 02:50:51 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12367/azure-sdk-for-java/azure-resourcemanager-netapp/azure-resourcemanager-netapp-1.0.0-beta.1.jar\" -o azure-resourcemanager-netapp-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-netapp -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-netapp-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️🔄[Staging] ApiDocPreview inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    This was referenced Jan 11, 2021
    Closed
    Closed
    @audunn audunn requested a review from pilor January 11, 2021 12:31
    This was referenced Jan 11, 2021
    Closed
    Closed
    @openapi-workflow-bot
    Copy link

    Hi @audunn, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
     If you need further help, please feedback via swagger feedback."

    @openapi-workflow-bot
    Copy link

    Hi @audunn, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    This was referenced Jan 19, 2021
    Closed
    Draft
    This was referenced Feb 19, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Merged
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    greenms pushed a commit to greenms/azure-rest-api-specs that referenced this pull request Feb 19, 2021
    @audunn @greenms
    ANF-8872 Fix examples for integers (Azure#12367)
    e410a41 
    * ANF-8872 Fix examples for ints

* S360 findings

* S360 findings remove response code

* Fix authenticationid, protocoltypes

* Fix authenticationid, protocoltypes other versions

* Fix snapshotpolicy

* Fix snapshotpolicy update

* Fix snapshotpolicy update 3

* Fix protocoltype

* Fix protocoltype 07

* Remove name from volume properties, removed from service response

Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
    @mikhailshilkov mikhailshilkov mentioned this pull request Feb 22, 2021
    Closed
    @audunn audunn mentioned this pull request Feb 22, 2021
    Merged
    25 tasks
    jianyexi pushed a commit that referenced this pull request Mar 2, 2021
    @greenms @vl8163264128
    @WodansSon @worldhello126 @sofisa16 @jdhms @pratimaupadhyay02 @tonykjose @Juliehzl @shubhamguptacal @yangyuan @nivats @taliesins @alexandra142 @ahermas @bquantump @audunn @yungezz @a-santamaria @cataggar
    Update redisenterprise readme files for Azure CLI (#13083)
    a95864b 
    * Add ADLS Gen2 data source type (#12277)

* add adlsgen2

* add adlsgen2

* add custom word 'adlsgen'

Co-authored-by: Victor Liu <victliu@microsoft.com>

* add missing packages to readme.go.md (#13008)

* Correct output folder for code generation (#13022)

* [Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2021-03-01 (#12825)

* update response code from 204 to 201 for start operation

* update

* Revert "Update PR Assignment for CNY (#12850)" (#13025)

This reverts commit 827de60.

* Adding value array to Tag. (#12555)

* Add 2020-03-01-preview version to Authorization (#12691)

* authorization init 2020-03-01-preview

* authorization 2020-03-01-preview apply common types always, update examples, language

* trigger ci

* mark properties as readonly where appropriate

* fix format

* trigger ci

* Consolidating APIs in latest version[s360] (#12888)

* Consolidating APIs in latest version[s360]

* fixing additional correctness issue

* Fixing prettier

* Update

* Fixing semantic validation

Co-authored-by: Pratima Upadhyay <prupadhy@microsoft.com>

* [Microsoft.Storage] Add Jan21 api-version. (#12807)

* [Microsoft.Storage] Copy Aug20 preview version into new api-version Jan21.

* [Microsoft.Storage] Add Jan21 api-version new API changes.

* Fix api-version in swagger spec.

* Remove encryption.identity.type as it is read-only.

* Addressing PR comments.

* fix prettier check

* Add suppression for R4009. Fix remaining linter blockers.

* Re-attempt suppression on R4009.

* Suppress 4009.

* Addressing comments and fixing lintdiff syntax issue on suppression.

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Exposing RoleAssignmentApproval APIs (#12108)

* Add descriptions for errors (#11789)

* {storage} Add new api version in readme (#13034)

* add api

* refine

* [Hub Generated] Review request for Microsoft.ImportExport to add version preview/2021-01-01 (#12490)

* Adds base for updating Microsoft.ImportExport from version stable/2020-08-01 to version 2021-01-01

* Updates readme

* Updates API version in new specs and examples

* making changes to swagger for upgraded version

* prettier fix

* Incorrect tag specified assume it was a copy and paste error (#13018)

* Fix content-type in examples for ACS AUTH REST API version 2020-07-20-preview2 and 2021-03-07 (#13036)

Co-authored-by: Alexandra Lamiova Pistrakova <apistrak@microsoft.com>

* fix linter errors on x-ms-enum names (#13040)

* Correcting azure-arm to be false (#13023)

* Correcting azure-arm to be false

* Update readme.csharp.md

* Update based on comments

* Update readme.md

* ANF-8872 Fix examples for integers (#12367)

* ANF-8872 Fix examples for ints

* S360 findings

* S360 findings remove response code

* Fix authenticationid, protocoltypes

* Fix authenticationid, protocoltypes other versions

* Fix snapshotpolicy

* Fix snapshotpolicy update

* Fix snapshotpolicy update 3

* Fix protocoltype

* Fix protocoltype 07

* Remove name from volume properties, removed from service response

Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>

* fix readme (#13032)

* [Service Fabric Managed Clusters] Adding missing property ClusterUpgradeCadence (#12858)

* adding missing property ClusterUpgradeCadence

* change createdByType and lastModifiedAt to strings

* remove duplicate operations path

* fix sdk-net path typo

* commit to rerun automation

* remove x-ms-client-flatten for ServiceResource

* remove after_scripts automation was failing

* rename _Create to _CreateOrUpdate in apps

Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>

* AVS 2021-01-01-preview (#12879)

* use 2020-07-17-preview as base api

* 2021-01-01-preview API changes

* fix Java namespace & output-folder

* add body to Datastores_Create

* remove x-ms-azure-resource & properties suffix

* fix Datastores_Create responses

* "2021-01-01" to "2021-01-01-preview"

* Second round of updates for Azure CLI code generation

Co-authored-by: Victor Liu <vl8163264128@hotmail.com>
Co-authored-by: Victor Liu <victliu@microsoft.com>
Co-authored-by: WS <20408400+WodansSon@users.noreply.github.com>
Co-authored-by: worldhello126 <49164775+worldhello126@users.noreply.github.com>
Co-authored-by: Phoenix He <tih@microsoft.com>
Co-authored-by: Sofía Isadora Padilla Muñoz <sofisa16@gmail.com>
Co-authored-by: jdhms <77470403+jdhms@users.noreply.github.com>
Co-authored-by: Pratima Upadhyay <pratima.upadhyay02@gmail.com>
Co-authored-by: Pratima Upadhyay <prupadhy@microsoft.com>
Co-authored-by: Anthony Kunnel Jose <antjo@microsoft.com>
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Co-authored-by: Shubham Gupta <shugup@microsoft.com>
Co-authored-by: Yang Yuan <yangyuan@users.noreply.github.com>
Co-authored-by: nivats <41890611+nivats@users.noreply.github.com>
Co-authored-by: Taliesin Sisson <taliesins@yahoo.com>
Co-authored-by: alexandra142 <alex.pistrakova@gmail.com>
Co-authored-by: Alexandra Lamiova Pistrakova <apistrak@microsoft.com>
Co-authored-by: ahermas <68354927+ahermas@users.noreply.github.com>
Co-authored-by: bquantump <53361486+bquantump@users.noreply.github.com>
Co-authored-by: Auðunn <audunn@netapp.com>
Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
Co-authored-by: Yunge Zhu <yungez@microsoft.com>
Co-authored-by: Alfredo Santamaria <chino.sebastian@gmail.com>
Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>
Co-authored-by: Cameron Taggart <cameron.taggart@microsoft.com>
    xiangyan99 added a commit that referenced this pull request Mar 5, 2021
    @xiangyan99 @Shamkh
    @frrossms @deyaaeldeen @changlong-liu @hunngu-ms @yoramsinger @dhawal777 @david-msft @NarayanThiru @masenol @aelij @iscai-msft @shuyangmsft @maririos @sukodava @orkayam @sudeepmsft @trask @dpokluda @ruowan @greenms @srinivaas-ganesan @Pacodel @abatishchev @ArcturusZhang @kdonthineni @audunn @00Kai0 @melihmutlu @TimLovellSmith @lwang2016 @allencal @vl8163264128 @WodansSon @worldhello126 @sofisa16 @jdhms @pratimaupadhyay02 @tonykjose @Juliehzl @shubhamguptacal @yangyuan @nivats @taliesins @alexandra142 @ahermas @bquantump @yungezz @a-santamaria @cataggar @AlahmadiQ8 @rikogeln @kristapratico @renuka-raju @karthikku-2020 @omrodrig @suhas92 @zhizhoualan @furkansahin @MikhailTryakhov @nikhilpadhye1 @saisujithreddym @nimaller @richajain @abhi7860 @harics24 @Nilambari @wdehrich @Kawilki-M @wangxu724 @irrogozh @akshatkale @litchiyangMSFT @zhenglaizhang @neethirshetty @bowgong @vikrampraveen @tamilmani1989 @jianghaolu @dsgouda @yew @zhangyan133 @leni-msft
    latest master (#13300)
    493a68b 
    * Users/shamkh/feature send sms changes  for removing default for required property. (#13185)

* SettingFolder Structure.

* Updating SMS communication Swagger json for 1:N , customer content feature.

* Updating with review comments.

* adding Idempotency header.

* Updating name for Idempodency field.

* Merging N:1 Changes

* fixing integer issue

* Updating Read me

* fixing lint issue.

* Reverting change

* Fixing Model issue.

* Updating Case for repeatablity header.

* Example update in sendjson.

* Review comments.

* camelCase issue in Send.json.

* Fixing example Model.

* Model issue fix.

* apiversion param issue

* Model issue

* Model validation.

* Review comments.

* Addressing API review comments: consolidating to 202Accepted response.

* review comments.

* review comments

* placing response header at right place.

* review comments

* Modifying wire objects to format [Resource][Method] and adding a flag to response

* Review comments

* Fixing swagger validations.

* review comments.

* review comments.

* review comments.

* review comments.

* Swagger validation.

* review comments.

* review comments

* Fix Avocado

* Fixing endpoint stuff

* review comments

* review comments

* fix spell

* fixes

* prettierfix

* fix

* Revert "fix"

This reverts commit 341eaf6.

* review comments

* review comments

* removing acs

* Updating swagger for require EnableDelivery report option.

* prettier run.

Co-authored-by: Ankita Mathur <ankitam@microsoft.com>

* Initial API spec for managed Cassandra project in CosmosDB (#12861)

* Move to a new API version.

* added changes from stable apiVersion

* Add nova.json

* Add parameters to repair method on cassandraClusters.

* Change fetchNodeStatus to be async POST

There appears to be no way to document the results of an async POST operation actually completing.

* Add 200 status code to fetchNodeStatus to see if it will make the Python SDK properly generate polling.

* Fixed the fetchNodeStatus endpoint. It was actually missing x-ms-long-running-operation.

Removed the 200 status result I had put in before.

* Add async response path for fetchNodeStatus.

* Make linter happy.

* Rename nova.json to managedCassandra.json

* Rename operationIds to be plural. Change status code for repair disabled to 412 (Precondition not met)

* Fix javaScript SDK build (which is broken by have */ in descriptions)

* added changes from stable apiVersion

* Added lenient deduplication to make linter happy

* Move fetchNodeStatus back since apparently the SDK generation handles this.

* Fix inconsistencies between GA and preview previous API versions for cosmos-db.json.

* Add response body to PATCH for clusters and datacenters.

* Add provisioningState, to dc examples, remove 412 code, fix a couple descriptions.

Co-authored-by: Meha Kaushik <mekaushi@microsoft.com>

* [Graph RBAC] Add top to users op (#13045)

* [Graph RBAC] Add top to users op

* make it optional

* adding x-ms-parameter-location: method

* update python config guide (#11542)

* update python config guide

* track1 and track2

* Fix Threat Intelligence Swagger Correctness S360 (#13043)

* Fix Threat Intelligence Swagger Correctness S360

* Add custom word

* Workspaces: Swagger correctness (#12730)

* Swagger correctness for Workspaces

* Workspaces 2020-08-01

* Introducing System data (#13113)

* Swagger correctness issue fix(Additional Property not allowed)

* Added custom-word

* Removing unused properrty

* Ignored Tera

* Reverting not related changes

* RoundTrip additional property and object additional property S360 fix by adding defaults and renaming respectively

* Removed default

* Removing some default in older version

* Fixed model validation errors and added few more defaults

* Fixed Sementic errors

* Lint fix

* Updated systemData

* Description Fix

* Fixed spell check

* Spell check fix

* PowerBIDedicated - Add new API Version (#12244)

* Copy existing version to new directory

* Update API Version

* Introduce new SKU tier enum values

* Fix linting issue - introduce required new default property SystemData

* Update Readme.md

(cherry picked from commit c434161)

* update api version to right format

* renamed folder

* Add swagger file for new resource type Microsoft.PowerBIDedicated/autoScaleVCores

* Update powerbidedicated.json

Add Mode property

* Update powerbidedicated.json

Fix words

Co-authored-by: Shane Zou <xinzo@microsoft.com>

* [Hub Generated] Review request for Microsoft.KubernetesConfiguration to add version preview/2020-07-01-preview (#9805)

* This field ended up out of sync between the resource provider and the Swagger we checked in on Friday. (#13200)

* [Quantum] Addressing swagger completeness and correctness errors (#13150)

* [Quantum] Addressing swagger completeness and correctness errors

* Fixing errors in SpellCheck and PrettierCheck

* ADP: fix cli codegen (#13172)

* ADP: fix cli codegen

* Move directive

* fix pii entity categories (#13122)

* Add DocumentExtractionSkill (#13003)

* Add DocumentExtractionSkill

* Fix braces

* Update searchservice.json

* Add DocumentExtractionSkill to 2020-06-03

* Update searchservice.json

* Update searchservice.json

* Update searchservice.json

* Update enum name for StringIndexType (#13209)

* Added new disk storageAccountTypes (#12958)

* Add sites, sensors and onPremiseSensors resources (#12991)

* Add Microsoft.IoTSecurity provider

* Run prettier

* Add MD

* rename files

* update MD

* resolve the Avocado

* Remove unused files

* Add operations API

* update operations.json

* update markdown

* remove dot

* re-use types

* remove comma

* Remove duplicated common types

* Use ProxyResource

* Remove IoT prefix

* Add example

* undo changes

* Run prettier

* Use capital letter

* run prettier

* Add sites, sensors and onPremiseSensors resources

* update markdowns

* run prettier

* Fix broken parameter

* Re-trigger Validations

* Add systemData

* Run prettier

* add systemData

* Run prettier

* Align changes

* Undo Microsoft.Security changes

* Add systemData to example

* Fix PR comments

* Update example

Co-authored-by: Orel Kayam <orkayam@microsoft.com>

* [Hub Generated] Review request for Microsoft.Devices to add version stable/2020-01-01 (#12912)

* fixing swagger correctness for OBJECT_ADDITIONAL_PROPERTIES,
INVALID_TYPE

* resolving validation error - Swagger Correctness fix

* correcting validation error - swagger corretness fix

* reverting back changes - swagger correctness

* reverting some changes as it might require new versioning

* changing example and bringing api specs to parity

* fixing the comments in PR and added the recommendation plus some
validation fixes

* prettier fix

* model validation fix

* model validation fix

* fixing lintdiff error

* removing the package lock file

* Revert "removing the package lock file"

This reverts commit 1548442.

* reverting previous commit
i Please enter the commit message for your changes. Lines starting

* [Hub Generated] Review request for Microsoft.Devices to add version stable/2020-03-01 (#12914)

* fixing existing api version swagger correctness

* fixing the example

* fixing arm error in validation - reverting changes as needs to be
included in new version

* moving the breaking changes to new version

* changing example file and bringing api spec in parity with the existing
api functionality

* adding prettier check validation fix

* fixing model validation

* cert or pem content is byte format

* prettier validation fix

* removing lintdiff errors

* adding a format type for cert

* Fix comment (#12919)

* [Hub Generated] Review request for Microsoft.DeviceUpdate to add version preview/2020-09-01 (#13213)

* New Readme Config File

* New Go Language Readme Config File

* New Azure AZ Readme Config File

* New Azure CLI Readme Config File

* New Typescript Language Readme Config File

* New Python Language Readme Config File

* New C# Language Readme Config File

* New AzureResourceSchema Readme Config File

* New Swagger Spec File

* New Swagger Example Spec File

* Release of Device Update for IoT Hub data plane specification.

* Fixing prettier issues.

* Fixing spellcheck issues.

* Fixing spellcheck in spec examples.

Co-authored-by: David Pokluda <david.pokluda@microsoft.com>

* fix window closed. remove s360 comments. (#13205)

* Revert default tag to latest package intended for use by customers (#13210)

* Add SystemData (#13184)

* Add SystemData

* Make systemdata readonly

* Fix typo

Co-authored-by: Srinivaas Ganesan <srganesa@microsoft.com>

* [DataFactory] Add UAMI to Identity (#13174)

* [DataFactory]: Add CMK Properties

* Prettier validation

* Model Identity Type as string

* RemoveEnumChanges

* Add UAMI to Identity

* [Hub Generated] Review request for Microsoft.DeviceUpdate to add version preview/2020-03-01-preview (#13215)

* New Readme Config File

* New Go Language Readme Config File

* New Azure AZ Readme Config File

* New Azure CLI Readme Config File

* New Typescript Language Readme Config File

* New Python Language Readme Config File

* New C# Language Readme Config File

* New AzureResourceSchema Readme Config File

* New Swagger Spec File

* New Swagger Example Spec File

* Release of Device Update for IoT Hub control plane specification.

* Fixing prettier issues.

* Updating control plane swagger

* Update deviceupdate.json

* Update deviceupdate.json

* Update deviceupdate.json

* Update deviceupdate.json

* add the multiapi section

* Update Accounts_Delete.json

* Update Instances_Delete.json

Co-authored-by: David Pokluda <david.pokluda@microsoft.com>
Co-authored-by: Alexander Batishchev <abatishchev@gmail.com>
Co-authored-by: ArcturusZhang <dapzhang@microsoft.com>

* [Iothub]  Added new routing source [version 2021-02-01-preview] (#13069)

* Adds base for updating Microsoft.Devices from version preview/2020-08-31-preview to version 2021-02-01-preview

* Updates readme

* Updates API version in new specs and examples

* Update iothub.json

Added new Routing Source: DeviceConnectionStateEvents

* Update iothub.json

Review Comments

* Update iothub.json

changing modelAsString to false for ResourceIdentityType

* Remove name from pool (#13094)

Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>

* Update python track2 sdk for deviceupdate (#13223)

* Update python track2 sdk for deviceupdate

* fix

* Added subscriptionId and resourceGroupName in Server properties (#13059)

* Added subscriptionId and resourceGroupName in properties to enable cross-sub restore

* fix for preview version

* Update readme.azureresourceschema.md (#13221)

Unreference 2020-10-01-preview from readme.azureresourceschema.md because it is a deprecated API version for redisEnterprise.

* Fix swagger KPI issue on additional property "tenantId" in deployment script with api-version 2020-10-01 (#13120)

* Update deploymentScripts.json

Mark environment variable secureValue as secret

* Update deploymentScripts.json

Fix a bug in Microsoft.Resources/deploymentScripts where tenantId property is missed from ManagedServiceIdentity.

* Fix swagger KPI issue on additional property "tenantId" in deployment script with api-version 2020-10-01

* Update deploymentScripts.json

* update retentionInterval description.

* S360 - insert missing API version. (#13126)

* S360 - insert missing API version.

Baseline commit, copy of 2018-04-01.

* Changes on top of 2018-04-01 baseline

Changes on top of 2018-04-01 baseline

* Update trafficmanager.json

Add minChildEndpointsIPv4 and minChildEndpointsIPv6 to2018-08-01

* Add nested endpoint example

Add nested endpoint example

* Correct folder for Profile-PUT-WithNestedEndpoints.json

Correct folder for Profile-PUT-WithNestedEndpoints.json

* Update Profile-PUT-WithNestedEndpoints.json

Prettier fix - whitespace

* Update Profile-PUT-WithNestedEndpoints.json

Fix missing curly brackets.

* Validation fixes

Add references to examples, remove body from 204 responses.

* Update trafficmanager.json

Model Validation Fix  - allowed endpoint record type added.

* Update redisenterprise readme files for Azure CLI (#13083)

* Add ADLS Gen2 data source type (#12277)

* add adlsgen2

* add adlsgen2

* add custom word 'adlsgen'

Co-authored-by: Victor Liu <victliu@microsoft.com>

* add missing packages to readme.go.md (#13008)

* Correct output folder for code generation (#13022)

* [Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2021-03-01 (#12825)

* update response code from 204 to 201 for start operation

* update

* Revert "Update PR Assignment for CNY (#12850)" (#13025)

This reverts commit 827de60.

* Adding value array to Tag. (#12555)

* Add 2020-03-01-preview version to Authorization (#12691)

* authorization init 2020-03-01-preview

* authorization 2020-03-01-preview apply common types always, update examples, language

* trigger ci

* mark properties as readonly where appropriate

* fix format

* trigger ci

* Consolidating APIs in latest version[s360] (#12888)

* Consolidating APIs in latest version[s360]

* fixing additional correctness issue

* Fixing prettier

* Update

* Fixing semantic validation

Co-authored-by: Pratima Upadhyay <prupadhy@microsoft.com>

* [Microsoft.Storage] Add Jan21 api-version. (#12807)

* [Microsoft.Storage] Copy Aug20 preview version into new api-version Jan21.

* [Microsoft.Storage] Add Jan21 api-version new API changes.

* Fix api-version in swagger spec.

* Remove encryption.identity.type as it is read-only.

* Addressing PR comments.

* fix prettier check

* Add suppression for R4009. Fix remaining linter blockers.

* Re-attempt suppression on R4009.

* Suppress 4009.

* Addressing comments and fixing lintdiff syntax issue on suppression.

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Exposing RoleAssignmentApproval APIs (#12108)

* Add descriptions for errors (#11789)

* {storage} Add new api version in readme (#13034)

* add api

* refine

* [Hub Generated] Review request for Microsoft.ImportExport to add version preview/2021-01-01 (#12490)

* Adds base for updating Microsoft.ImportExport from version stable/2020-08-01 to version 2021-01-01

* Updates readme

* Updates API version in new specs and examples

* making changes to swagger for upgraded version

* prettier fix

* Incorrect tag specified assume it was a copy and paste error (#13018)

* Fix content-type in examples for ACS AUTH REST API version 2020-07-20-preview2 and 2021-03-07 (#13036)

Co-authored-by: Alexandra Lamiova Pistrakova <apistrak@microsoft.com>

* fix linter errors on x-ms-enum names (#13040)

* Correcting azure-arm to be false (#13023)

* Correcting azure-arm to be false

* Update readme.csharp.md

* Update based on comments

* Update readme.md

* ANF-8872 Fix examples for integers (#12367)

* ANF-8872 Fix examples for ints

* S360 findings

* S360 findings remove response code

* Fix authenticationid, protocoltypes

* Fix authenticationid, protocoltypes other versions

* Fix snapshotpolicy

* Fix snapshotpolicy update

* Fix snapshotpolicy update 3

* Fix protocoltype

* Fix protocoltype 07

* Remove name from volume properties, removed from service response

Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>

* fix readme (#13032)

* [Service Fabric Managed Clusters] Adding missing property ClusterUpgradeCadence (#12858)

* adding missing property ClusterUpgradeCadence

* change createdByType and lastModifiedAt to strings

* remove duplicate operations path

* fix sdk-net path typo

* commit to rerun automation

* remove x-ms-client-flatten for ServiceResource

* remove after_scripts automation was failing

* rename _Create to _CreateOrUpdate in apps

Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>

* AVS 2021-01-01-preview (#12879)

* use 2020-07-17-preview as base api

* 2021-01-01-preview API changes

* fix Java namespace & output-folder

* add body to Datastores_Create

* remove x-ms-azure-resource & properties suffix

* fix Datastores_Create responses

* "2021-01-01" to "2021-01-01-preview"

* Second round of updates for Azure CLI code generation

Co-authored-by: Victor Liu <vl8163264128@hotmail.com>
Co-authored-by: Victor Liu <victliu@microsoft.com>
Co-authored-by: WS <20408400+WodansSon@users.noreply.github.com>
Co-authored-by: worldhello126 <49164775+worldhello126@users.noreply.github.com>
Co-authored-by: Phoenix He <tih@microsoft.com>
Co-authored-by: Sofía Isadora Padilla Muñoz <sofisa16@gmail.com>
Co-authored-by: jdhms <77470403+jdhms@users.noreply.github.com>
Co-authored-by: Pratima Upadhyay <pratima.upadhyay02@gmail.com>
Co-authored-by: Pratima Upadhyay <prupadhy@microsoft.com>
Co-authored-by: Anthony Kunnel Jose <antjo@microsoft.com>
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Co-authored-by: Shubham Gupta <shugup@microsoft.com>
Co-authored-by: Yang Yuan <yangyuan@users.noreply.github.com>
Co-authored-by: nivats <41890611+nivats@users.noreply.github.com>
Co-authored-by: Taliesin Sisson <taliesins@yahoo.com>
Co-authored-by: alexandra142 <alex.pistrakova@gmail.com>
Co-authored-by: Alexandra Lamiova Pistrakova <apistrak@microsoft.com>
Co-authored-by: ahermas <68354927+ahermas@users.noreply.github.com>
Co-authored-by: bquantump <53361486+bquantump@users.noreply.github.com>
Co-authored-by: Auðunn <audunn@netapp.com>
Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
Co-authored-by: Yunge Zhu <yungez@microsoft.com>
Co-authored-by: Alfredo Santamaria <chino.sebastian@gmail.com>
Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>
Co-authored-by: Cameron Taggart <cameron.taggart@microsoft.com>

* [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 (#13097)

* Fix validation errors for UsageDetails_List

* fix linting errors in 2019-10-01/consumption.json

* remove newlly added error code

* don't change meterId description

Co-authored-by: Mohammad Mohammad <mmohammad@microsoft.com>

* Azure Remote REST API 2021-01-01  (#13239)

* copy of unchanged 2021-01-01-preview

* rename folder 2021-01-01-preview to 2021-01-01

* promote 2021-01-01-preview to 2021-01-01

* [deviceupdate] make changes to readme in time for first release (#13240)

* make changes to readme in time for first release

* remove specification of 'sdk'  in path

* update swagger reviews for translator text (#13246)

* Update Device Update for IoT Hub control plane autorest file for C# with correct namespace and output folder (#13251)

Co-authored-by: David Pokluda <david.pokluda@microsoft.com>

* Peering new api version 2021-01-01 (#12855)

* Peering new api version 2021-01-01

* Adding previous api version for diff

* Updating swagger and examples for new api

* Adding new parameters to the end of the resource model

* Ensure parameter ordering for PeeringServiceProperties

Co-authored-by: Renuka Raju <rraju@microsoft.com>

* fix web python.md (#13162)

* fix web python.md

* fix

* [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 (#12822)

* consumption spec updates

* Reverted casing on the etag Property

* Added Swagger Doc for Settings API (#13241)

* Update Certainty enum (#13247)

* [Hub Generated] Review request for Face to add version stable/v1.0 (#12739)

* Update face specs for recognition 04, detection 03, and mask attribute.

* Refine descriptions

* Add missing recognition_04

* Add mask attribute in detect description

Co-authored-by: Zhi Zhou <zhizho@microsoft.com>

* Update credential scope for Python. (#13263)

* Fix parent class of ClusterResource and DataCenterResource in .NET SDK (#13244)

* Fix parent class of ClusterResource and DataCenterResource in .NET SDK

Removed x-ms-azure-resource from ClusterResource and DataCenterResource. x-ms-azure-resource is already set on the ProxyResource and TrackedResource definitions that ClusterResource and DataCenterResource, and when it's applied it on ClusterResource or DataCenterResource directly, it forces the parent class to be IResource in the .NET SDK and loses the location, type, id, etc. parameters.

* Switched to CosmosDB's ARM resource parents.

The types.json ones throw errors. In particular, I can't use TrackedResource because it sets location to be required, and the same field is not found by the linter.

* Remove required properties since they are forbidden for PATCH.

* Remove x-ms-client-flatten to avoid breaking changes.

* read replica added (#12567)

* Network november release (#13224)

* Adds base for updating Microsoft.Network from version stable/2020-08-01 to version 2020-11-01

* Updates readme

* Updates API version in new specs and examples

* No snat firewall policy (#12505)

* Adding No SNAT feature support to firewall policy

* committing prettier-fix

* adding period at end of description to prevent failure for checks

* Insights on Firewall Policy (#12509)

* Adds base for updating Microsoft.Network from version stable/2020-07-01 to version 2020-08-01

* Updates readme

* Updates API version in new specs and examples

* add patch operation for express route gateway (#11553)

* add patch

* fix example

* Added new cloud service NIC and PIP APIs (#11650)

Co-authored-by: Richa Jain <ricjain@microsoft.com>

* Adding support for Vpn Link Connection Mode (#11574)

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* Reverting the changes made for address space update as the changes in service code are not in yet (#11754)

Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>

* VPN NAT for Virtual WAN feature changes (#11815)

* VPN NAT for Virtual WAN feature changes

* PrettierCheck fixes

* Incorporate review comments and update examples

* Add edge zone parameters for networking resources and add extendedLocation property to customIpPrefix (#11933)

* Add extendedLocation property to customIpPrefix

* Fix the directory

* Address linting errors

* Fix another linting error

* Add edge zone parameter for network interfaces

* Looks like edgeZone parameter is working when creating network interfaces

* EdgeZone parameter for load balancer

* Add edge zone parameter for public IP address

* Add edge zone parameter for public IP prefix

* Add edgeZone parameter for virtual networks

* Add edge zone parameter for custom IP prefix

Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>

* Add location parameter to Loadbalancer Backend Address Pool Properties Format (#11919)

* adding location parameter to backendaddresspoolpropertiesformat

* ran prettier

* Support for Listing IKE Security Associations for Virtual Network Gateway Connections (#11572)

* Support to List IKE SAs on VNG Connection

* Updating GetIkeSas

* Update virtualNetworkGateway.json

* Added location headers

* Update virtualNetworkGateway.json

* Prettier fix

* Update custom-words.txt

* Update virtualNetworkGateway.json

* Update custom-words.txt

* Update virtualNetworkGateway.json

* Update virtualNetworkGateway.json

* Update virtualNetworkGateway.json

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* [Fix] GetIkeSas returns result as string (#12225)

* Removing IkeSaParameters

* Update custom-words.txt

* Update virtualNetworkGateway.json

* Update virtualNetworkGateway.json

* Update VirtualNetworkGatewayConnectionGetIkeSas.json

* Update virtualNetworkGateway.json

* Update VirtualNetworkGatewayConnectionGetIkeSas.json

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* Add extended location properties for private link service and private endpoints and remove edge zone properties (#12039)

* Remove edge zone parameter

* Add extended location for private endpoint and private link service

* Add examples

* Capitalization

* Prettier

Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>

* Add missing properties of SecurityRule, Route and RouteTable (#12215)

* Add missing properties of SecurityRule Route and RouteTable

* Set resourceGuid field to be read only

Co-authored-by: Xu Wang <wax@microsoft.com>

* Added placeholder instead of password (#12299)

* resolving conflicts

* resolving conflicts

* new api version

* resolving conflicts

* fixing network validation

* running prettier

* fixing network valdiation

* fixing network valdiation

Co-authored-by: Mikhail <mitryakh@microsoft.com>
Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
Co-authored-by: Richa Jain <richa.jain1912@gmail.com>
Co-authored-by: Richa Jain <ricjain@microsoft.com>
Co-authored-by: Abhishek Shah <shah.abhi7860@gmail.com>
Co-authored-by: Abhishek Shah <shabhis@microsoft.com>
Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com>
Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
Co-authored-by: Nilambari <nilamd@microsoft.com>
Co-authored-by: William Ehrich <wdehrich@gmail.com>
Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>
Co-authored-by: Kayden Wilkinson <69224099+Kawilki-M@users.noreply.github.com>
Co-authored-by: Xu Wang <wangxu724@gmail.com>
Co-authored-by: Xu Wang <wax@microsoft.com>

* Firewall Policy Insights with region (#12711)

* Adds base for updating Microsoft.Network from version stable/2020-07-01 to version 2020-08-01

* Updates readme

* Updates API version in new specs and examples

* add patch operation for express route gateway (#11553)

* add patch

* fix example

* Added new cloud service NIC and PIP APIs (#11650)

Co-authored-by: Richa Jain <ricjain@microsoft.com>

* Adding support for Vpn Link Connection Mode (#11574)

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* Reverting the changes made for address space update as the changes in service code are not in yet (#11754)

Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>

* VPN NAT for Virtual WAN feature changes (#11815)

* VPN NAT for Virtual WAN feature changes

* PrettierCheck fixes

* Incorporate review comments and update examples

* Add edge zone parameters for networking resources and add extendedLocation property to customIpPrefix (#11933)

* Add extendedLocation property to customIpPrefix

* Fix the directory

* Address linting errors

* Fix another linting error

* Add edge zone parameter for network interfaces

* Looks like edgeZone parameter is working when creating network interfaces

* EdgeZone parameter for load balancer

* Add edge zone parameter for public IP address

* Add edge zone parameter for public IP prefix

* Add edgeZone parameter for virtual networks

* Add edge zone parameter for custom IP prefix

Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>

* Add location parameter to Loadbalancer Backend Address Pool Properties Format (#11919)

* adding location parameter to backendaddresspoolpropertiesformat

* ran prettier

* Support for Listing IKE Security Associations for Virtual Network Gateway Connections (#11572)

* Support to List IKE SAs on VNG Connection

* Updating GetIkeSas

* Update virtualNetworkGateway.json

* Added location headers

* Update virtualNetworkGateway.json

* Prettier fix

* Update custom-words.txt

* Update virtualNetworkGateway.json

* Update custom-words.txt

* Update virtualNetworkGateway.json

* Update virtualNetworkGateway.json

* Update virtualNetworkGateway.json

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* [Fix] GetIkeSas returns result as string (#12225)

* Removing IkeSaParameters

* Update custom-words.txt

* Update virtualNetworkGateway.json

* Update virtualNetworkGateway.json

* Update VirtualNetworkGatewayConnectionGetIkeSas.json

* Update virtualNetworkGateway.json

* Update VirtualNetworkGatewayConnectionGetIkeSas.json

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* Add extended location properties for private link service and private endpoints and remove edge zone properties (#12039)

* Remove edge zone parameter

* Add extended location for private endpoint and private link service

* Add examples

* Capitalization

* Prettier

Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>

* Add missing properties of SecurityRule, Route and RouteTable (#12215)

* Add missing properties of SecurityRule Route and RouteTable

* Set resourceGuid field to be read only

Co-authored-by: Xu Wang <wax@microsoft.com>

* Added placeholder instead of password (#12299)

* resolving conflicts

* resolving conflicts

* new api version

* resolving conflicts

* fixing network validation

* running prettier

* fixing network valdiation

* fixing network valdiation

* Passing in the regions to backend

* changed the reference definition

Co-authored-by: Mikhail <mitryakh@microsoft.com>
Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
Co-authored-by: Richa Jain <richa.jain1912@gmail.com>
Co-authored-by: Richa Jain <ricjain@microsoft.com>
Co-authored-by: Abhishek Shah <shah.abhi7860@gmail.com>
Co-authored-by: Abhishek Shah <shabhis@microsoft.com>
Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com>
Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
Co-authored-by: Nilambari <nilamd@microsoft.com>
Co-authored-by: William Ehrich <wdehrich@gmail.com>
Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>
Co-authored-by: Kayden Wilkinson <69224099+Kawilki-M@users.noreply.github.com>
Co-authored-by: Xu Wang <wangxu724@gmail.com>
Co-authored-by: Xu Wang <wax@microsoft.com>

* Support for Listing IKE Security Associations for VPN Link Connections (#12305)

* Adds base for updating Microsoft.Network from version stable/2020-07-01 to version 2020-08-01

* Updates readme

* Updates API version in new specs and examples

* add patch operation for express route gateway (#11553)

* add patch

* fix example

* Added new cloud service NIC and PIP APIs (#11650)

Co-authored-by: Richa Jain <ricjain@microsoft.com>

* Adding support for Vpn Link Connection Mode (#11574)

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* Reverting the changes made for address space update as the changes in service code are not in yet (#11754)

Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>

* VPN NAT for Virtual WAN feature changes (#11815)

* VPN NAT for Virtual WAN feature changes

* PrettierCheck fixes

* Incorporate review comments and update examples

* Add edge zone parameters for networking resources and add extendedLocation property to customIpPrefix (#11933)

* Add extendedLocation property to customIpPrefix

* Fix the directory

* Address linting errors

* Fix another linting error

* Add edge zone parameter for network interfaces

* Looks like edgeZone parameter is working when creating network interfaces

* EdgeZone parameter for load balancer

* Add edge zone parameter for public IP address

* Add edge zone parameter for public IP prefix

* Add edgeZone parameter for virtual networks

* Add edge zone parameter for custom IP prefix

Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>

* Add location parameter to Loadbalancer Backend Address Pool Properties Format (#11919)

* adding location parameter to backendaddresspoolpropertiesformat

* ran prettier

* Support for Listing IKE Security Associations for Virtual Network Gateway Connections (#11572)

* Support to List IKE SAs on VNG Connection

* Updating GetIkeSas

* Update virtualNetworkGateway.json

* Added location headers

* Update virtualNetworkGateway.json

* Prettier fix

* Update custom-words.txt

* Update virtualNetworkGateway.json

* Update custom-words.txt

* Update virtualNetworkGateway.json

* Update virtualNetworkGateway.json

* Update virtualNetworkGateway.json

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* [Fix] GetIkeSas returns result as string (#12225)

* Removing IkeSaParameters

* Update custom-words.txt

* Update virtualNetworkGateway.json

* Update virtualNetworkGateway.json

* Update VirtualNetworkGatewayConnectionGetIkeSas.json

* Update virtualNetworkGateway.json

* Update VirtualNetworkGatewayConnectionGetIkeSas.json

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* Add extended location properties for private link service and private endpoints and remove edge zone properties (#12039)

* Remove edge zone parameter

* Add extended location for private endpoint and private link service

* Add examples

* Capitalization

* Prettier

Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>

* Add missing properties of SecurityRule, Route and RouteTable (#12215)

* Add missing properties of SecurityRule Route and RouteTable

* Set resourceGuid field to be read only

Co-authored-by: Xu Wang <wax@microsoft.com>

* Added placeholder instead of password (#12299)

* Adding getikesas for vpn link connections

* pretty fix

* Naming

* Update VpnSiteLinkConnectionGetIkeSas.json

* Update VpnSiteLinkConnectionGetIkeSas.json

* Changing API version

* Update readme.md

* Updating API version

* Removing changes from older API

* Update virtualWan.json

Co-authored-by: Mikhail <mitryakh@microsoft.com>
Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
Co-authored-by: Richa Jain <richa.jain1912@gmail.com>
Co-authored-by: Richa Jain <ricjain@microsoft.com>
Co-authored-by: Abhishek Shah <shabhis@microsoft.com>
Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com>
Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
Co-authored-by: Nilambari <nilamd@microsoft.com>
Co-authored-by: William Ehrich <wdehrich@gmail.com>
Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>
Co-authored-by: Kayden Wilkinson <69224099+Kawilki-M@users.noreply.github.com>
Co-authored-by: Xu Wang <wangxu724@gmail.com>
Co-authored-by: Xu Wang <wax@microsoft.com>

* Added 'Subnet' property to LoadBalancerBackendAddress (#12625)

* Support for ResetConnection for VNG and VPN Link connections (#12715)

* fix the name mismatch (#12826)

* Add support for Traffic selector param in VpnConnection for virtualWan (#12903)

* Add support for Traffic selector param in Connection - initial changes

* Add trafficSelectorPolicies list in responses

* Add trafficSelectorPolicies list in Get and List connection

* cleanup stostools (#12699)

* Revert "Merge branch 'network-november-release' into ak-traffic-selector"

This reverts commit 1a8f61e, reversing
changes made to 3c90ff8.

Co-authored-by: Zhenglai Zhang <darinzh@microsoft.com>

* Revert "Add support for Traffic selector param in VpnConnection for virtualWan" (#13088)

* Revert "Add support for Traffic selector param in VpnConnection for virtualWan (#12903)"

This reverts commit 34dcf04.

* cleanup stostools (#12699)

Co-authored-by: Zhenglai Zhang <darinzh@microsoft.com>

* Re - Add support for Traffic selector param in VpnConnection for virtualWan (#13103)

* Add support for Traffic selector param in Connection - initial changes

* Add trafficSelectorPolicies list in responses

* Add trafficSelectorPolicies list in Get and List connection

* add auth type property to vng config (#13183)

* added reverted by mistake api version

* fixed mistyping

* Fix name mismatch for virtual network local gateway (#13266)

* fix the name mismatch

* fix name mismatch in nov

Co-authored-by: nikhilpadhye1 <68977752+nikhilpadhye1@users.noreply.github.com>
Co-authored-by: Sai Sujith Reddy Mankala <samankal@microsoft.com>
Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
Co-authored-by: Richa Jain <richa.jain1912@gmail.com>
Co-authored-by: Richa Jain <ricjain@microsoft.com>
Co-authored-by: Abhishek Shah <shah.abhi7860@gmail.com>
Co-authored-by: Abhishek Shah <shabhis@microsoft.com>
Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com>
Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
Co-authored-by: Nilambari <nilamd@microsoft.com>
Co-authored-by: William Ehrich <wdehrich@gmail.com>
Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>
Co-authored-by: Kayden Wilkinson <69224099+Kawilki-M@users.noreply.github.com>
Co-authored-by: Xu Wang <wangxu724@gmail.com>
Co-authored-by: Xu Wang <wax@microsoft.com>
Co-authored-by: irrogozh <irrogozh@microsoft.com>
Co-authored-by: Akshat Kale <kaleakshat@gmail.com>
Co-authored-by: litchiyangMSFT <64560090+litchiyangMSFT@users.noreply.github.com>
Co-authored-by: Zhenglai Zhang <darinzh@microsoft.com>
Co-authored-by: neethirshetty <75816269+neethirshetty@users.noreply.github.com>

* init MetricsAdvisor (#10862)

* init MetricsAdvisor

* fix errors and add readme.md

* fix errors

* fix warnings and add cSpell

* rename to custom-words.txt and fix warnings

* try to mitigate spell issue

* try to mitigate spell issue

* fix api version in swagger

* Update MetricsAdvisor.json

* Update MetricsAdvisor.json

* try to fix swagger validation issue

* try to fix validation issue

* add examples

* fix version

* validate'

* remove examples in main spec

* update examples

* rename request body param name in examples

* revert renaming req body name param in examples

* Update MetricsAdvisor.json

* fix x-ms-examples

* trigger validation

* fix examples

* fix examples

* Update getAnomalyAlertingConfiguration.json

* Update getActiveSeriesCount.json

* Update MetricsAdvisor.json

* Update MetricsAdvisor.json

* Update MetricsAdvisor.json

* Update MetricsAdvisor.json

* fix validation

* fix examples

* fix discriminator

* fix custom word

* fix custom word

Co-authored-by: Xiang Yan <xiangsjtu@gmail.com>

* Fix typo (#13281)

Co-authored-by: Vikram Praveen Kumar <vipravee@microsoft.com>

* add force delete query parameter for delegatedSubnets resource (#13004)

* add force delete query parameter

* prettier fix

* added "x-ms-parameter-location" field

* updated erroresponse and errordefintion names to avoid duplication error

* fixed spellcheck

* updated desc

* fixed warnings

* fixed warnings

* Fixed errors

* include common.json

* fixed errors

* lint fix

* Use common CloudError & CloudErrorBody (#13286)

* Renaming operations to fix s360 violations (#13236)

* Update pull_request_assignment.yml (#13292)

* Consumption Correctness Updates (#13280)

* Add authHeaders to HTTP/REST/OData Linked Service, add MultiFactor to SFTP authenticationType (#13204)

* Add authHeaders to HTTP/REST/OData Linked Service, add MultiFactor to SFTP authenticationType

* Fix PrettierCheck error

* add a version in readmepython (#13295)

Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com>

* Update CODEOWNERS (#13293)

* Update CODEOWNERS

* Update CODEOWNERS

Co-authored-by: Lei Ni <7233663+leni-msft@users.noreply.github.com>

Co-authored-by: Shamkh <shamkh@microsoft.com>
Co-authored-by: Ankita Mathur <ankitam@microsoft.com>
Co-authored-by: frrossms <71098903+frrossms@users.noreply.github.com>
Co-authored-by: Meha Kaushik <mekaushi@microsoft.com>
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Co-authored-by: changlong-liu <59815250+changlong-liu@users.noreply.github.com>
Co-authored-by: hunngu-ms <63322431+hunngu-ms@users.noreply.github.com>
Co-authored-by: Yoram Singer <37076505+yoramsinger@users.noreply.github.com>
Co-authored-by: Dhawal Jain <41853104+dhawal777@users.noreply.github.com>
Co-authored-by: David Han <76010854+david-msft@users.noreply.github.com>
Co-authored-by: Shane Zou <xinzo@microsoft.com>
Co-authored-by: NarayanThiru <nanthi@microsoft.com>
Co-authored-by: masenol <54191670+masenol@users.noreply.github.com>
Co-authored-by: Eli Arbel <aelij@arbel.net>
Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com>
Co-authored-by: Shuyang Zhang <62564394+shuyangmsft@users.noreply.github.com>
Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>
Co-authored-by: sukodava <78733210+sukodava@users.noreply.github.com>
Co-authored-by: orkayam <68549999+orkayam@users.noreply.github.com>
Co-authored-by: Orel Kayam <orkayam@microsoft.com>
Co-authored-by: sudeepmsft <74932610+sudeepmsft@users.noreply.github.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: David Pokluda <46501915+dpokluda@users.noreply.github.com>
Co-authored-by: David Pokluda <david.pokluda@microsoft.com>
Co-authored-by: Ruoxuan Wang <52271048+ruowan@users.noreply.github.com>
Co-authored-by: andrew <69653137+greenms@users.noreply.github.com>
Co-authored-by: srinivaas-ganesan <srinivaasganesan@gmail.com>
Co-authored-by: Srinivaas Ganesan <srganesa@microsoft.com>
Co-authored-by: Pacodel <pacodel@microsoft.com>
Co-authored-by: Alexander Batishchev <abatishchev@gmail.com>
Co-authored-by: ArcturusZhang <dapzhang@microsoft.com>
Co-authored-by: kdonthineni <79338123+kdonthineni@users.noreply.github.com>
Co-authored-by: Auðunn <audunn@netapp.com>
Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
Co-authored-by: Kaihui (Kerwin) Sun <sunkaihuisos@gmail.com>
Co-authored-by: Melih <m.melihmutlu@gmail.com>
Co-authored-by: Tim Lovell-Smith <tilovell@microsoft.com>
Co-authored-by: lwang2016 <lewang@microsoft.com>
Co-authored-by: allencal <31420469+allencal@users.noreply.github.com>
Co-authored-by: Victor Liu <vl8163264128@hotmail.com>
Co-authored-by: Victor Liu <victliu@microsoft.com>
Co-authored-by: WS <20408400+WodansSon@users.noreply.github.com>
Co-authored-by: worldhello126 <49164775+worldhello126@users.noreply.github.com>
Co-authored-by: Phoenix He <tih@microsoft.com>
Co-authored-by: Sofía Isadora Padilla Muñoz <sofisa16@gmail.com>
Co-authored-by: jdhms <77470403+jdhms@users.noreply.github.com>
Co-authored-by: Pratima Upadhyay <pratima.upadhyay02@gmail.com>
Co-authored-by: Pratima Upadhyay <prupadhy@microsoft.com>
Co-authored-by: Anthony Kunnel Jose <antjo@microsoft.com>
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Co-authored-by: Shubham Gupta <shugup@microsoft.com>
Co-authored-by: Yang Yuan <yangyuan@users.noreply.github.com>
Co-authored-by: nivats <41890611+nivats@users.noreply.github.com>
Co-authored-by: Taliesin Sisson <taliesins@yahoo.com>
Co-authored-by: alexandra142 <alex.pistrakova@gmail.com>
Co-authored-by: Alexandra Lamiova Pistrakova <apistrak@microsoft.com>
Co-authored-by: ahermas <68354927+ahermas@users.noreply.github.com>
Co-authored-by: bquantump <53361486+bquantump@users.noreply.github.com>
Co-authored-by: Yunge Zhu <yungez@microsoft.com>
Co-authored-by: Alfredo Santamaria <chino.sebastian@gmail.com>
Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>
Co-authored-by: Cameron Taggart <cameron.taggart@microsoft.com>
Co-authored-by: Mohammad Asad Mohammad <mmohammadq8@outlook.com>
Co-authored-by: Mohammad Mohammad <mmohammad@microsoft.com>
Co-authored-by: rikogeln <40666347+rikogeln@users.noreply.github.com>
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
Co-authored-by: renuka-raju <rrenu1016@gmail.com>
Co-authored-by: Renuka Raju <rraju@microsoft.com>
Co-authored-by: Karthik Kunjithapatham <77180268+karthikku-2020@users.noreply.github.com>
Co-authored-by: Omar Rodriguez <73562205+omrodrig@users.noreply.github.com>
Co-authored-by: Suhas Mehta <suhas.mehta@microsoft.com>
Co-authored-by: Zhi Zhou <alan.zhizhou@gmail.com>
Co-authored-by: Zhi Zhou <zhizho@microsoft.com>
Co-authored-by: Furkan Sahin <sahinffurkan@gmail.com>
Co-authored-by: Mikhail <mitryakh@microsoft.com>
Co-authored-by: nikhilpadhye1 <68977752+nikhilpadhye1@users.noreply.github.com>
Co-authored-by: Sai Sujith Reddy Mankala <samankal@microsoft.com>
Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
Co-authored-by: Richa Jain <richa.jain1912@gmail.com>
Co-authored-by: Richa Jain <ricjain@microsoft.com>
Co-authored-by: Abhishek Shah <shah.abhi7860@gmail.com>
Co-authored-by: Abhishek Shah <shabhis@microsoft.com>
Co-authored-by: Hari Prasad Perabattula <harics24@users.noreply.github.com>
Co-authored-by: Hari Prasad Perabattula <haperaba@microsoft.com>
Co-authored-by: Nilambari <nilamd@microsoft.com>
Co-authored-by: William Ehrich <wdehrich@gmail.com>
Co-authored-by: Will Ehrich <william.ehrich@microsoft.com>
Co-authored-by: Kayden Wilkinson <69224099+Kawilki-M@users.noreply.github.com>
Co-authored-by: Xu Wang <wangxu724@gmail.com>
Co-authored-by: Xu Wang <wax@microsoft.com>
Co-authored-by: irrogozh <irrogozh@microsoft.com>
Co-authored-by: Akshat Kale <kaleakshat@gmail.com>
Co-authored-by: litchiyangMSFT <64560090+litchiyangMSFT@users.noreply.github.com>
Co-authored-by: Zhenglai Zhang <darinzh@microsoft.com>
Co-authored-by: neethirshetty <75816269+neethirshetty@users.noreply.github.com>
Co-authored-by: bowgong <56386108+bowgong@users.noreply.github.com>
Co-authored-by: vikrampraveen <vikram.praveen@outlook.com>
Co-authored-by: Vikram Praveen Kumar <vipravee@microsoft.com>
Co-authored-by: tamilmani1989 <tamilmani1989@gmail.com>
Co-authored-by: Jianghao Lu <jianghaolu@users.noreply.github.com>
Co-authored-by: Deepak Shankargouda <deshank@microsoft.com>
Co-authored-by: Guosen Wang <guoswang@microsoft.com>
Co-authored-by: zhangyan133 <77086185+zhangyan133@users.noreply.github.com>
Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com>
Co-authored-by: Lei Ni <7233663+leni-msft@users.noreply.github.com>
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @audunn @mkarmark
    ANF-8872 Fix examples for integers (Azure#12367)
    93078f2 
    * ANF-8872 Fix examples for ints

* S360 findings

* S360 findings remove response code

* Fix authenticationid, protocoltypes

* Fix authenticationid, protocoltypes other versions

* Fix snapshotpolicy

* Fix snapshotpolicy update

* Fix snapshotpolicy update 3

* Fix protocoltype

* Fix protocoltype 07

* Remove name from volume properties, removed from service response

Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @greenms @vl8163264128
    @WodansSon @worldhello126 @sofisa16 @jdhms @pratimaupadhyay02 @tonykjose @Juliehzl @shubhamguptacal @yangyuan @nivats @taliesins @alexandra142 @ahermas @bquantump @audunn @yungezz @a-santamaria @cataggar @mkarmark
    Update redisenterprise readme files for Azure CLI (Azure#13083)
    15d0f78 
    * Add ADLS Gen2 data source type (Azure#12277)

* add adlsgen2

* add adlsgen2

* add custom word 'adlsgen'

Co-authored-by: Victor Liu <victliu@microsoft.com>

* add missing packages to readme.go.md (Azure#13008)

* Correct output folder for code generation (Azure#13022)

* [Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2021-03-01 (Azure#12825)

* update response code from 204 to 201 for start operation

* update

* Revert "Update PR Assignment for CNY (Azure#12850)" (Azure#13025)

This reverts commit 827de60.

* Adding value array to Tag. (Azure#12555)

* Add 2020-03-01-preview version to Authorization (Azure#12691)

* authorization init 2020-03-01-preview

* authorization 2020-03-01-preview apply common types always, update examples, language

* trigger ci

* mark properties as readonly where appropriate

* fix format

* trigger ci

* Consolidating APIs in latest version[s360] (Azure#12888)

* Consolidating APIs in latest version[s360]

* fixing additional correctness issue

* Fixing prettier

* Update

* Fixing semantic validation

Co-authored-by: Pratima Upadhyay <prupadhy@microsoft.com>

* [Microsoft.Storage] Add Jan21 api-version. (Azure#12807)

* [Microsoft.Storage] Copy Aug20 preview version into new api-version Jan21.

* [Microsoft.Storage] Add Jan21 api-version new API changes.

* Fix api-version in swagger spec.

* Remove encryption.identity.type as it is read-only.

* Addressing PR comments.

* fix prettier check

* Add suppression for R4009. Fix remaining linter blockers.

* Re-attempt suppression on R4009.

* Suppress 4009.

* Addressing comments and fixing lintdiff syntax issue on suppression.

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Exposing RoleAssignmentApproval APIs (Azure#12108)

* Add descriptions for errors (Azure#11789)

* {storage} Add new api version in readme (Azure#13034)

* add api

* refine

* [Hub Generated] Review request for Microsoft.ImportExport to add version preview/2021-01-01 (Azure#12490)

* Adds base for updating Microsoft.ImportExport from version stable/2020-08-01 to version 2021-01-01

* Updates readme

* Updates API version in new specs and examples

* making changes to swagger for upgraded version

* prettier fix

* Incorrect tag specified assume it was a copy and paste error (Azure#13018)

* Fix content-type in examples for ACS AUTH REST API version 2020-07-20-preview2 and 2021-03-07 (Azure#13036)

Co-authored-by: Alexandra Lamiova Pistrakova <apistrak@microsoft.com>

* fix linter errors on x-ms-enum names (Azure#13040)

* Correcting azure-arm to be false (Azure#13023)

* Correcting azure-arm to be false

* Update readme.csharp.md

* Update based on comments

* Update readme.md

* ANF-8872 Fix examples for integers (Azure#12367)

* ANF-8872 Fix examples for ints

* S360 findings

* S360 findings remove response code

* Fix authenticationid, protocoltypes

* Fix authenticationid, protocoltypes other versions

* Fix snapshotpolicy

* Fix snapshotpolicy update

* Fix snapshotpolicy update 3

* Fix protocoltype

* Fix protocoltype 07

* Remove name from volume properties, removed from service response

Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>

* fix readme (Azure#13032)

* [Service Fabric Managed Clusters] Adding missing property ClusterUpgradeCadence (Azure#12858)

* adding missing property ClusterUpgradeCadence

* change createdByType and lastModifiedAt to strings

* remove duplicate operations path

* fix sdk-net path typo

* commit to rerun automation

* remove x-ms-client-flatten for ServiceResource

* remove after_scripts automation was failing

* rename _Create to _CreateOrUpdate in apps

Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>

* AVS 2021-01-01-preview (Azure#12879)

* use 2020-07-17-preview as base api

* 2021-01-01-preview API changes

* fix Java namespace & output-folder

* add body to Datastores_Create

* remove x-ms-azure-resource & properties suffix

* fix Datastores_Create responses

* "2021-01-01" to "2021-01-01-preview"

* Second round of updates for Azure CLI code generation

Co-authored-by: Victor Liu <vl8163264128@hotmail.com>
Co-authored-by: Victor Liu <victliu@microsoft.com>
Co-authored-by: WS <20408400+WodansSon@users.noreply.github.com>
Co-authored-by: worldhello126 <49164775+worldhello126@users.noreply.github.com>
Co-authored-by: Phoenix He <tih@microsoft.com>
Co-authored-by: Sofía Isadora Padilla Muñoz <sofisa16@gmail.com>
Co-authored-by: jdhms <77470403+jdhms@users.noreply.github.com>
Co-authored-by: Pratima Upadhyay <pratima.upadhyay02@gmail.com>
Co-authored-by: Pratima Upadhyay <prupadhy@microsoft.com>
Co-authored-by: Anthony Kunnel Jose <antjo@microsoft.com>
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Co-authored-by: Shubham Gupta <shugup@microsoft.com>
Co-authored-by: Yang Yuan <yangyuan@users.noreply.github.com>
Co-authored-by: nivats <41890611+nivats@users.noreply.github.com>
Co-authored-by: Taliesin Sisson <taliesins@yahoo.com>
Co-authored-by: alexandra142 <alex.pistrakova@gmail.com>
Co-authored-by: Alexandra Lamiova Pistrakova <apistrak@microsoft.com>
Co-authored-by: ahermas <68354927+ahermas@users.noreply.github.com>
Co-authored-by: bquantump <53361486+bquantump@users.noreply.github.com>
Co-authored-by: Auðunn <audunn@netapp.com>
Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com>
Co-authored-by: Yunge Zhu <yungez@microsoft.com>
Co-authored-by: Alfredo Santamaria <chino.sebastian@gmail.com>
Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>
Co-authored-by: Cameron Taggart <cameron.taggart@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @xseeseesee xseeseesee xseeseesee approved these changes

    @pilor pilor Awaiting requested review from pilor

    Assignees

    @xseeseesee xseeseesee

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 FixS360
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @audunn @xseeseesee @akning-ms