Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.MixedReality to add version stable/2021-01-01 #12337

Conversation

roytan-microsoft
Copy link
Contributor

@roytan-microsoft roytan-microsoft commented Jan 8, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @roytan-microsoft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 8, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 1 Warnings warning [Detail]

    Rule Message
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    New: Microsoft.MixedReality/stable/2021-01-01/proxy.json#L179
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 12 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MixedReality/spatialAnchorsAccounts/{accountName}/keys' removed or restructured?
    Old: Microsoft.MixedReality/preview/2019-12-02-preview/spatial-anchors.json#L293:5
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.MixedReality/stable/2021-01-01/spatial-anchors.json#L67:13
    Old: Microsoft.MixedReality/preview/2019-12-02-preview/spatial-anchors.json#L67:13
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.MixedReality/stable/2021-01-01/spatial-anchors.json#L109:13
    Old: Microsoft.MixedReality/preview/2019-12-02-preview/spatial-anchors.json#L109:13
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.MixedReality/stable/2021-01-01/spatial-anchors.json#L154:13
    Old: Microsoft.MixedReality/preview/2019-12-02-preview/spatial-anchors.json#L154:13
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.MixedReality/stable/2021-01-01/spatial-anchors.json#L194:13
    Old: Microsoft.MixedReality/preview/2019-12-02-preview/spatial-anchors.json#L194:13
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.MixedReality/stable/2021-01-01/spatial-anchors.json#L237:13
    Old: Microsoft.MixedReality/preview/2019-12-02-preview/spatial-anchors.json#L237:13
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: Microsoft.MixedReality/stable/2021-01-01/spatial-anchors.json#L286:13
    Old: Microsoft.MixedReality/preview/2019-12-02-preview/spatial-anchors.json#L286:13
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.MixedReality/stable/2021-01-01/remote-rendering.json#L396:9
    Old: Microsoft.MixedReality/preview/2020-04-06-preview/remote-rendering.json#L391:9
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'message' renamed or removed?
    New: Microsoft.MixedReality/stable/2021-01-01/common.json#L60:7
    Old: Microsoft.MixedReality/preview/2019-12-02-preview/common.json#L63:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'code' renamed or removed?
    New: Microsoft.MixedReality/stable/2021-01-01/common.json#L60:7
    Old: Microsoft.MixedReality/preview/2019-12-02-preview/common.json#L63:7
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.

    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 8, 2021

    Swagger Generation Artifacts

    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ecafa64. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-01-20 07:37:36 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-mixedreality"
      cmderr	[generate.py] 2021-01-20 07:37:36 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-01-20 07:37:36 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/mixedreality/azure-resourcemanager-mixedreality --java.namespace=com.azure.resourcemanager.mixedreality   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/mixedreality/resource-manager/readme.md
      cmderr	[generate.py] 2021-01-20 07:38:10 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-01-20 07:38:10 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-01-20 07:38:10 INFO [POM][Skip] pom already has module azure-resourcemanager-mixedreality
      cmderr	[generate.py] 2021-01-20 07:38:10 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-01-20 07:38:10 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-01-20 07:38:10 INFO [POM][Success] Write to root pom
      cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
      cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
      cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
      cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
      cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
    • ️✔️azure-resourcemanager-mixedreality [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-01-20 07:40:33 DEBUG Got artifact_id: azure-resourcemanager-mixedreality
      cmderr	[Inst] 2021-01-20 07:40:33 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-01-20 07:40:33 DEBUG Got artifact: azure-resourcemanager-mixedreality-1.0.0-beta.1-javadoc.jar
      cmderr	[Inst] 2021-01-20 07:40:33 DEBUG Got artifact: azure-resourcemanager-mixedreality-1.0.0-beta.1-sources.jar
      cmderr	[Inst] 2021-01-20 07:40:33 DEBUG Got artifact: azure-resourcemanager-mixedreality-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-01-20 07:40:33 DEBUG Match jar package: azure-resourcemanager-mixedreality-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-01-20 07:40:33 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12337/azure-sdk-for-java/azure-resourcemanager-mixedreality/azure-resourcemanager-mixedreality-1.0.0-beta.1.jar\" -o azure-resourcemanager-mixedreality-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-mixedreality -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-mixedreality-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ecafa64. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/mixedreality/resource-manager/readme.md
    • ️✔️@azure/arm-mixedreality [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/mixedRealityClient.js → ./dist/arm-mixedreality.js...
      cmderr	[npmPack] created ./dist/arm-mixedreality.js in 273ms
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ecafa64. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️preview/mixedreality/mgmt/2020-05-01-preview/mixedreality [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ## Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `CheckNameAvailabilityResponse.NameAvailable` has been changed from `NameAvailability` to `*bool`
      info	[Changelog] - Const `True` has been removed
      info	[Changelog] - Const `False` has been removed
      info	[Changelog] - Function `PossibleNameAvailabilityValues` has been removed
      info	[Changelog]
      info	[Changelog] ## New Content
      info	[Changelog]
      info	[Changelog] - New field `IsDataAction` in struct `Operation`
      info	[Changelog] - New field `Identity` in struct `SpatialAnchorsAccount`
      info	[Changelog]
      info	[Changelog] Total 4 breaking change(s), 2 additive change(s).
      info	[Changelog]
    • ️✔️preview/mixedreality/mgmt/2019-02-28/mixedreality [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ecafa64. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/mixedreality/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.MixedReality [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ecafa64. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	python3 -m venv venv
      command	pip install --upgrade setuptools wheel pip
      command	pip install pathlib jinja2 msrestazure
      command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/mixedreality/resource-manager/readme.md
    • ️✔️azure-mgmt-mixedreality [View full logs]  [Release SDK Changes] Breaking Change Detected
      cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-mixedreality
      cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-mixedreality
      cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
      cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.mixedreality
      cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.mixedreality
      cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.mixedreality
      cmderr	[changelogReport] INFO:__main__:Report written to sdk/mixedreality/azure-mgmt-mixedreality/code_reports/latest/report.json
      cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-mixedreality on PyPI
      cmderr	[changelogReportLatest] INFO:__main__:Got ['0.1.0', '0.2.0', '1.0.0b1']
      cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
      cmderr	[changelogReportLatest] INFO:__main__:Installing version 0.2.0 of azure-mgmt-mixedreality in a venv
      cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
      cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.mixedreality
      cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.mixedreality
      cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.mixedreality
      cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/mixedreality/azure-mgmt-mixedreality/code_reports/0.2.0/report.json
      cmdout	[Changelog] Size of delta 28.894% size of original (original: 19236 chars, delta: 5558 chars)
      cmdout	[Changelog] **Features**
      cmdout	[Changelog]   - Model RemoteRenderingAccount has a new parameter sku
      cmdout	[Changelog]   - Model RemoteRenderingAccount has a new parameter kind
      cmdout	[Changelog]   - Model RemoteRenderingAccount has a new parameter plan
      cmdout	[Changelog]   - Model RemoteRenderingAccount has a new parameter system_data
      cmdout	[Changelog]   - Model Operation has a new parameter is_data_action
      cmdout	[Changelog]   - Model Operation has a new parameter properties
      cmdout	[Changelog]   - Model Operation has a new parameter origin
      cmdout	[Changelog]   - Model SpatialAnchorsAccount has a new parameter sku
      cmdout	[Changelog]   - Model SpatialAnchorsAccount has a new parameter identity
      cmdout	[Changelog]   - Model SpatialAnchorsAccount has a new parameter kind
      cmdout	[Changelog]   - Model SpatialAnchorsAccount has a new parameter plan
      cmdout	[Changelog]   - Model SpatialAnchorsAccount has a new parameter system_data
      cmdout	[Changelog] **Breaking changes**
      cmdout	[Changelog]   - Operation SpatialAnchorsAccountsOperations.update has a new signature
      cmdout	[Changelog]   - Operation SpatialAnchorsAccountsOperations.create has a new signature
      warn	Breaking change found in changelog
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ecafa64. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/mixedreality/resource-manager/readme.md
    • ️✔️mixedreality [View full logs]  [Release Schema Changes]
      cmderr	[resource-manager] node-pre-gyp
      cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
      cmderr	[resource-manager]  WARN template-schema-validation-tools@1.0.0 No repository field.
      cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
      cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @roytan-microsoft, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @roytan-microsoft
    Copy link
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @roytan-microsoft
    Copy link
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    Copy link
    Contributor

    @j5lim j5lim left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Approving from ARM side.

    @j5lim j5lim added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 15, 2021
    @roytan-microsoft
    Copy link
    Contributor Author

    @lirenhe do I also need your PR approval? I'm not sure I understand what needs to be done to fix the go sdk

    @leni-msft
    Copy link
    Contributor

    @ArcturusZhang pls help check the go sdk generation failure

    @ArcturusZhang
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 2 pipeline(s).

    @ArcturusZhang
    Copy link
    Member

    @leni-msft the failure has been fixed. And the breaking changes are introduced in some other PRs

    @leni-msft leni-msft merged commit ecafa64 into Azure:master Jan 20, 2021
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Jan 20, 2021
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 10, 2021
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    …ion stable/2021-01-01 (Azure#12337)
    
    * Adds base for updating Microsoft.MixedReality from version preview/2020-04-06-preview to version 2021-01-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * update proxy and remote rendering
    
    * add description
    
    * add security definitions
    
    * revert security definitions
    
    * add systemdata
    
    * run prettier
    
    * move systemdata to remote-rendering.json
    
    * switch to use v1 types
    
    * add spatial anchors accounts
    
    * add x-ms-secret to dev keys
    
    * replace values with ***
    
    * suppress secret_property
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-Python
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants