-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.MixedReality to add version stable/2021-01-01 #12337
[Hub Generated] Review request for Microsoft.MixedReality to add version stable/2021-01-01 #12337
Conversation
…20-04-06-preview to version 2021-01-01
Hi, @roytan-microsoft Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
Consider using x-ms-client-flatten to provide a better end user experience New: Microsoft.MixedReality/stable/2021-01-01/proxy.json#L179 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️
[Staging] Cross Version BreakingChange (Base on preview version): 12 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2020-04-06-preview/common.json <---> new: stable/2021-01-01/common.json
- original: preview/2020-04-06-preview/proxy.json <---> new: stable/2021-01-01/proxy.json
- original: preview/2020-04-06-preview/remote-rendering.json <---> new: stable/2021-01-01/remote-rendering.json
- original: preview/2019-12-02-preview/spatial-anchors.json <---> new: stable/2021-01-01/spatial-anchors.json
️️✔️
[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2020-05-01/common.json <---> new: stable/2021-01-01/common.json
- original: stable/2020-05-01/proxy.json <---> new: stable/2021-01-01/proxy.json
- original: stable/2020-05-01/spatial-anchors.json <---> new: stable/2021-01-01/spatial-anchors.json
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
Hi @roytan-microsoft, Your PR has some issues. Please fix the CI sequentially by following the order of
|
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving from ARM side.
@lirenhe do I also need your PR approval? I'm not sure I understand what needs to be done to fix the go sdk |
@ArcturusZhang pls help check the go sdk generation failure |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
@leni-msft the failure has been fixed. And the breaking changes are introduced in some other PRs |
….MixedReality to add version stable/2021-01-01 (#1472) Create to sync Azure/azure-rest-api-specs#12337 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/master...AzureSDKAutomation:sdkAuto/mixedreality?expand=1)
…ion stable/2021-01-01 (Azure#12337) * Adds base for updating Microsoft.MixedReality from version preview/2020-04-06-preview to version 2021-01-01 * Updates readme * Updates API version in new specs and examples * update proxy and remote rendering * add description * add security definitions * revert security definitions * add systemdata * run prettier * move systemdata to remote-rendering.json * switch to use v1 types * add spatial anchors accounts * add x-ms-secret to dev keys * replace values with *** * suppress secret_property
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.