Supporting User MSI and CMK in RS Vault CRUD Operation #12248

asmaskar · 2020-12-29T08:32:43Z

…D (#1)

Supporting User Assigned Identity and CMK.
Indentation fixes
Added Examples for CRUD with CMK
Added more fields to the Operation Resource

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

#1) * Supporting User Assigned Identity and CMK. * Indentation fixes * Added Examples for CRUD with CMK * Added more fields to the Operation Resource

openapi-workflow-bot · 2020-12-29T08:32:45Z

Hi, @asmaskar Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2020-12-29T08:32:47Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 8 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- recoveryservices/resource-manager/readme.md tag:package-2020-02
Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- recoveryservices/resource-manager/readme.md tag:default

Rule	Message
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'operationStatus' with immediate parent 'Vault', must have a list by immediate parent operation. New: Microsoft.RecoveryServices/stable/2020-02-02/vaultusages.json#L65
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'operationResults' with immediate parent 'Vault', must have a list by immediate parent operation. New: Microsoft.RecoveryServices/stable/2020-02-02/vaultusages.json#L65
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: useSystemAssignedIdentity New: Microsoft.RecoveryServices/stable/2020-02-02/vaults.json#L1504
⚠️ R4000 - ParameterDescriptionRequired	'operationId' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. New: Microsoft.RecoveryServices/stable/2020-02-02/vaults.json#L725
⚠️ R4000 - ParameterDescriptionRequired	'operationId' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. New: Microsoft.RecoveryServices/stable/2020-02-02/vaults.json#L776
⚠️ R4021 - DescriptionAndTitleMissing	'keyVaultProperties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.RecoveryServices/stable/2020-02-02/vaults.json#L1253
⚠️ R4021 - DescriptionAndTitleMissing	'kekIdentity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.RecoveryServices/stable/2020-02-02/vaults.json#L1256
⚠️ R4021 - DescriptionAndTitleMissing	'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.RecoveryServices/stable/2020-02-02/vaults.json#L1549

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 14 Warnings warning [Detail]

Only 10 items are listed, please refer to log for more details.

Compared Swaggers (Based on Oad v0.8.5)
- original: stable/2016-06-01/registeredidentities.json <---> new: stable/2020-02-02/registeredidentities.json
- original: stable/2016-06-01/replicationusages.json <---> new: stable/2020-02-02/replicationusages.json
- original: stable/2016-06-01/vaults.json <---> new: stable/2020-02-02/vaults.json
- original: stable/2016-06-01/vaultusages.json <---> new: stable/2020-02-02/vaultusages.json

Rule	Message
⚠️ 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.RecoveryServices/stable/2020-02-02/vaults.json#L52:11
⚠️ 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.RecoveryServices/stable/2020-02-02/vaults.json#L108:11
⚠️ 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.RecoveryServices/stable/2020-02-02/vaults.json#L170:11
⚠️ 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.RecoveryServices/stable/2020-02-02/vaults.json#L212:11
⚠️ 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.RecoveryServices/stable/2020-02-02/vaults.json#L253:11
⚠️ 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.RecoveryServices/stable/2020-02-02/vaults.json#L300:11
⚠️ 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.RecoveryServices/stable/2020-02-02/vaults.json#L350:11
⚠️ 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.RecoveryServices/stable/2020-02-02/vaults.json#L412:11
⚠️ 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.RecoveryServices/stable/2020-02-02/vaults.json#L460:11
⚠️ 1011 - AddingResponseCode	The new version adds a response code '202'. New: Microsoft.RecoveryServices/stable/2020-02-02/vaults.json#L516:11

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2020-12-29T08:32:48Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1d1b920. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/recoveryservices/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.RecoveryServices [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.RecoveryServices.4.3.1-preview.nupkg
- Microsoft.Azure.Management.RecoveryServices.4.3.1-preview.snupkg

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 1d1b920. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/recoveryservices/resource-manager/readme.md
warn	No file changes detected after generation
warn	No package detected after generation

️❌ azure-sdk-for-java failed [Detail]

❌Failed [Logs]Release - Generate from 1d1b920. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-01-11 07:16:13 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-recoveryservices;1.0.0-beta.1;1.0.0-beta.2"
cmderr	[generate.py] 2021-01-11 07:16:13 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
cmderr	[generate.py] 2021-01-11 07:16:13 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.8 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/recoveryservices/azure-resourcemanager-recoveryservices --java.namespace=com.azure.resourcemanager.recoveryservices  --package-version=1.0.0-beta.2 --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/recoveryservices/resource-manager/readme.md
cmderr	[generate.py] 2021-01-11 07:16:53 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-recoveryservices
cmderr	[generate.py] 2021-01-11 07:16:53 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-01-11 07:16:53 INFO [POM][Skip] pom already has module azure-resourcemanager-recoveryservices
cmderr	[generate.py] 2021-01-11 07:16:53 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-01-11 07:16:53 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-01-11 07:16:53 INFO [POM][Skip] pom already has module sdk/recoveryservices
cmderr	[generate.py] 2021-01-11 07:16:53 INFO [POM][Success] Write to root pom
cmderr	[generate.py] Traceback (most recent call last):
cmderr	[generate.py]   File "./eng/mgmt/automation/generate.py", line 609, in <module>
cmderr	[generate.py]     main()
cmderr	[generate.py]   File "./eng/mgmt/automation/generate.py", line 560, in main
cmderr	[generate.py]     return sdk_automation(args['config'][0], args['config'][1])
cmderr	[generate.py]   File "./eng/mgmt/automation/generate.py", line 523, in sdk_automation
cmderr	[generate.py]     tag = tag)
cmderr	[generate.py]   File "./eng/mgmt/automation/generate.py", line 327, in set_or_increase_version_and_generate
cmderr	[generate.py]     generate(sdk_root, service, version = current_version, **kwargs)
cmderr	[generate.py]   File "./eng/mgmt/automation/generate.py", line 72, in generate
cmderr	[generate.py]     update_version(sdk_root, service)
cmderr	[generate.py]   File "./eng/mgmt/automation/generate.py", line 228, in update_version
cmderr	[generate.py]     stderr = sys.stderr)
cmderr	[generate.py]   File "/usr/lib/python3.6/subprocess.py", line 423, in run
cmderr	[generate.py]     with Popen(*popenargs, **kwargs) as process:
cmderr	[generate.py]   File "/usr/lib/python3.6/subprocess.py", line 729, in __init__
cmderr	[generate.py]     restore_signals, start_new_session)
cmderr	[generate.py]   File "/usr/lib/python3.6/subprocess.py", line 1364, in _execute_child
cmderr	[generate.py]     raise child_exception_type(errno_num, err_msg, err_filename)
cmderr	[generate.py] FileNotFoundError: [Errno 2] No such file or directory: 'python3 eng/versioning/update_versions.py --ut library --bt client --sr': 'python3 eng/versioning/update_versions.py --ut library --bt client --sr'
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-java]: ./eng/mgmt/automation/generate.py
warn	Skip package processing as generation is failed

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1d1b920. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️recoveryservices/mgmt/2016-06-01/recoveryservices [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1d1b920. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/recoveryservices/resource-manager/readme.md

️✔️@azure/arm-recoveryservices [View full logs] [Release SDK Changes]

azure-arm-recoveryservices-4.1.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/recoveryServicesClient.js → ./dist/arm-recoveryservices.js...
cmderr	[npmPack] created ./dist/arm-recoveryservices.js in 349ms

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1d1b920. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/recoveryservices/resource-manager/readme.md

️✔️recoveryservices [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2020-12-29T08:34:07Z

Hi, @asmaskar your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @xccc-msft

openapi-workflow-bot · 2020-12-29T09:00:01Z

Hi @asmaskar, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

openapi-workflow-bot · 2020-12-29T09:00:01Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

jorgecotillo · 2020-12-29T22:51:04Z

...n/recoveryservices/resource-manager/Microsoft.RecoveryServices/stable/2016-06-01/vaults.json

-            "schema": {
-              "$ref": "#/definitions/Vault"
-            }
+          "202": {


What's the reason behind updating the response code?

The reason is that 201 was not being used from the service side. The next reason is that the synchronous call has been made Asynchronous so 202 is added as per the ARM guidelines

Good, I realized it after looking at the new operationStatus endpoints but it wasn't clear from the PR description nor from the title.

Sorry for the confusion.

jorgecotillo · 2020-12-30T19:43:29Z

From ARM side, this PR looks ok but contains new properties to an existing api-version. Please follow the breaking change process and get an approval.

filizt · 2021-01-04T21:01:18Z

...n/recoveryservices/resource-manager/Microsoft.RecoveryServices/stable/2016-06-01/vaults.json

+            "$ref": "#/parameters/ApiVersion"
+          }
+        ],
+        "responses": {


Missing deafult response model. Consider using error models defined in types.json in common-types folder: https://github.com/Azure/azure-rest-api-specs/tree/master/specification/common-types/resource-management Also, an example reference can be found here:

azure-rest-api-specs/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/alerts.json

Line 73 in 44ec11c

"default": {

Yeah, this is actually an issue on a lot of the responses in this swagger.

In reply to: 551566447 [](ancestors = 551566447)

filizt · 2021-01-04T21:11:35Z

    "responses": {

Missing error response model here and in other updated paths.

Refers to: specification/recoveryservices/resource-manager/Microsoft.RecoveryServices/stable/2016-06-01/vaults.json:455 in 4fe5b9a. [](commit_id = 4fe5b9a, deletion_comment = False)

filizt · 2021-01-06T19:48:35Z

Added a few comments - please update the PR when ready.

openapi-workflow-bot · 2021-01-07T13:31:58Z

Hi @asmaskar, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

asmaskar · 2021-01-07T13:34:21Z

Hi,
In this iteration, I have incorporated the feedback by the reviewers and also made the changes in a new api-version.
I have kept the older version without any changes.
Please let me know in case of any issues

asmaskar · 2021-01-08T07:32:09Z

@filizt Can you please review this and let me know if there are any concerns around the PR

filizt · 2021-01-08T16:08:05Z

@filizt Can you please review this and let me know if there are any concerns around the PR

I'll take a look. Could you also mark all the checkboxes that apply to your changes on the PR?

filizt · 2021-01-08T17:22:58Z

...n/recoveryservices/resource-manager/Microsoft.RecoveryServices/stable/2020-02-02/vaults.json

+          },
+          "202": {
+            "description": "Accepted"
+          },


Please mark as long running operation

filizt · 2021-01-08T20:00:09Z

@asmaskar there is only one comment waiting (#12248 (comment)). If it's addressed, we should be able to approve today.

asmaskar · 2021-01-08T23:02:02Z

@filizt I have addressed the comment provided. Thanks

asmaskar · 2021-01-09T00:10:54Z

@xccc-msft can you please let me know if there are any more changes to be made in the pr. If it seems fine, can you please approve it

xseeseesee · 2021-01-11T02:42:53Z

@asmaskar Please let me know when it's ready to merge. Thanks.

asmaskar · 2021-01-11T06:57:47Z

@xccc-msft please go ahead and merge it. Thanks

…CRUD Operation (#1332) Create to sync Azure/azure-rest-api-specs#12248 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/master...AzureSDKAutomation:sdkAuto/recoveryservices?expand=1)

Changes for supporting User Assigned Identity and CMK in Resource CRUD (

0133baa

#1) * Supporting User Assigned Identity and CMK. * Indentation fixes * Added Examples for CRUD with CMK * Added more fields to the Operation Resource

openapi-assignment-bot bot assigned xseeseesee Dec 29, 2020

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 29, 2020

Fixing Examples

b887e86

openapi-pipeline-app bot added BreakingChangeReviewRequired labels Dec 29, 2020

openapi-pipeline-app bot added the CI-BreakingChange-Go label Dec 29, 2020

openapi-sdkautomation bot mentioned this pull request Dec 29, 2020

[AutoPR @azure/arm-recoveryservices] Supporting User MSI and CMK in RS Vault CRUD Operation AzureSDKAutomation/azure-sdk-for-js#3080

Closed

Fix for the Prettier check validation

4fe5b9a

jorgecotillo reviewed Dec 29, 2020

View reviewed changes

filizt reviewed Jan 4, 2021

View reviewed changes

Added new Api-version for the changes

936c80f

asmaskar requested a review from lirenhe as a code owner January 7, 2021 13:30

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jan 7, 2021

openapi-pipeline-app bot removed CI-FixRequiredOnFailure BreakingChangeReviewRequired labels Jan 7, 2021

openapi-pipeline-app bot removed the NewApiVersionRequired label Jan 7, 2021

openapi-pipeline-app bot removed the CI-BreakingChange-Go label Jan 7, 2021

Fixed the api-version in json files

09dd999

filizt reviewed Jan 8, 2021

View reviewed changes

Marked operation result as long running.

347fac1

filizt added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 8, 2021

xseeseesee approved these changes Jan 11, 2021

View reviewed changes

xseeseesee merged commit 1d1b920 into Azure:master Jan 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Supporting User MSI and CMK in RS Vault CRUD Operation #12248

Supporting User MSI and CMK in RS Vault CRUD Operation #12248

asmaskar commented Dec 29, 2020 •

edited

Loading

openapi-workflow-bot bot commented Dec 29, 2020

openapi-pipeline-app bot commented Dec 29, 2020 •

edited

Loading

openapi-pipeline-app bot commented Dec 29, 2020 •

edited

Loading

openapi-workflow-bot bot commented Dec 29, 2020

openapi-workflow-bot bot commented Dec 29, 2020

openapi-workflow-bot bot commented Dec 29, 2020

jorgecotillo Dec 29, 2020

asmaskar Dec 30, 2020

jorgecotillo Dec 30, 2020

asmaskar Dec 31, 2020

jorgecotillo commented Dec 30, 2020

filizt Jan 4, 2021 •

edited

Loading

majastrz Jan 4, 2021

filizt commented Jan 4, 2021

filizt commented Jan 6, 2021

openapi-workflow-bot bot commented Jan 7, 2021

asmaskar commented Jan 7, 2021

asmaskar commented Jan 8, 2021

filizt commented Jan 8, 2021

filizt Jan 8, 2021

filizt commented Jan 8, 2021

asmaskar commented Jan 8, 2021

asmaskar commented Jan 9, 2021

xseeseesee commented Jan 11, 2021

asmaskar commented Jan 11, 2021

Supporting User MSI and CMK in RS Vault CRUD Operation #12248

Supporting User MSI and CMK in RS Vault CRUD Operation #12248

Conversation

asmaskar commented Dec 29, 2020 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Dec 29, 2020

openapi-pipeline-app bot commented Dec 29, 2020 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Dec 29, 2020 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Dec 29, 2020

openapi-workflow-bot bot commented Dec 29, 2020

openapi-workflow-bot bot commented Dec 29, 2020

jorgecotillo Dec 29, 2020

Choose a reason for hiding this comment

asmaskar Dec 30, 2020

Choose a reason for hiding this comment

jorgecotillo Dec 30, 2020

Choose a reason for hiding this comment

asmaskar Dec 31, 2020

Choose a reason for hiding this comment

jorgecotillo commented Dec 30, 2020

filizt Jan 4, 2021 • edited Loading

Choose a reason for hiding this comment

majastrz Jan 4, 2021

Choose a reason for hiding this comment

filizt commented Jan 4, 2021

filizt commented Jan 6, 2021

openapi-workflow-bot bot commented Jan 7, 2021

asmaskar commented Jan 7, 2021

asmaskar commented Jan 8, 2021

filizt commented Jan 8, 2021

filizt Jan 8, 2021

Choose a reason for hiding this comment

filizt commented Jan 8, 2021

asmaskar commented Jan 8, 2021

asmaskar commented Jan 9, 2021

xseeseesee commented Jan 11, 2021

asmaskar commented Jan 11, 2021

asmaskar commented Dec 29, 2020 •

edited

Loading

openapi-pipeline-app bot commented Dec 29, 2020 •

edited

Loading

openapi-pipeline-app bot commented Dec 29, 2020 •

edited

Loading

filizt Jan 4, 2021 •

edited

Loading