Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 #12212

Conversation

sofisa16
Copy link
Contributor

@sofisa16 sofisa16 commented Dec 23, 2020

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @sofisa16 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 23, 2020

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

    Rule Message
    1011 - AddingResponseCode The new version adds a response code '204'.
    New: Microsoft.CostManagement/stable/2019-11-01/costmanagement.json#L851:11
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Dec 23, 2020

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 71aa792. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/cost-management/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.CostManagement [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 71aa792. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	python3 -m venv venv
      command	pip install --upgrade setuptools wheel pip
      command	pip install pathlib jinja2 msrestazure
      command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/cost-management/resource-manager/readme.md
    • ️✔️azure-mgmt-costmanagement [View full logs]  [Release SDK Changes] Breaking Change Detected
      cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-costmanagement
      cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-costmanagement
      cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
      cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
      cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
      cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
      cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
      cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.costmanagement
      cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.costmanagement
      cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.costmanagement
      cmderr	[changelogReport] INFO:__main__:Report written to sdk/costmanagement/azure-mgmt-costmanagement/code_reports/latest/report.json
      cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-costmanagement on PyPI
      cmderr	[changelogReportLatest] INFO:__main__:Got ['0.1.0', '0.2.0', '1.0.0b1']
      cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
      cmderr	[changelogReportLatest] INFO:__main__:Installing version 0.2.0 of azure-mgmt-costmanagement in a venv
      cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
      cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.costmanagement
      cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.costmanagement
      cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.costmanagement
      cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/costmanagement/azure-mgmt-costmanagement/code_reports/0.2.0/report.json
      cmdout	[Changelog] Size of delta 65.127% size of original (original: 34284 chars, delta: 22328 chars)
      cmdout	[Changelog] **Features**
      cmdout	[Changelog]   - Model ExportExecution has a new parameter error
      cmdout	[Changelog]   - Model ExportExecution has a new parameter e_tag
      cmdout	[Changelog]   - Model CommonExportProperties has a new parameter run_history
      cmdout	[Changelog]   - Model CommonExportProperties has a new parameter next_run_time_estimate
      cmdout	[Changelog]   - Model Export has a new parameter run_history
      cmdout	[Changelog]   - Model Export has a new parameter next_run_time_estimate
      cmdout	[Changelog]   - Model Export has a new parameter e_tag
      cmdout	[Changelog]   - Added operation QueryOperations.usage_by_external_cloud_provider_type
      cmdout	[Changelog]   - Added operation DimensionsOperations.by_external_cloud_provider_type
      cmdout	[Changelog]   - Added operation group ViewsOperations
      cmdout	[Changelog]   - Added operation group ForecastOperations
      cmdout	[Changelog]   - Added operation group AlertsOperations
      cmdout	[Changelog] **Breaking changes**
      cmdout	[Changelog]   - Operation ExportsOperations.get has a new signature
      cmdout	[Changelog]   - Operation ExportsOperations.list has a new signature
      cmdout	[Changelog]   - Model ExportExecution no longer has parameter tags
      cmdout	[Changelog]   - Model Export no longer has parameter tags
      warn	Breaking change found in changelog
    ️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 71aa792. Azure CLI Automation 14.0.0
      Only show 120 items here, please refer to log for details.
      cmderr	[Autorest]     - name: /Alerts/get/BillingAccountAlerts
      cmderr	[Autorest]     - name: /Alerts/get/BillingProfileAlerts
      cmderr	[Autorest]     - name: /Alerts/get/DepartmentAlerts
      cmderr	[Autorest]     - name: /Alerts/get/EnrollmentAccountAlerts
      cmderr	[Autorest]     - name: /Alerts/get/ExternalBillingAccountAlerts
      cmderr	[Autorest]     - name: /Alerts/get/ExternalSubscriptionAlerts
      cmderr	[Autorest]     - name: /Alerts/get/InvoiceSectionAlerts
      cmderr	[Autorest]     - name: /Alerts/get/ResourceGroupAlerts
      cmderr	[Autorest]     - name: /Alerts/get/ResourceGroupAlerts
      cmderr	[Autorest]     - name: /Alerts/get/SubscriptionAlerts
      cmderr	[Autorest]     - name: /Alerts/get/SubscriptionAlerts
      cmderr	[Autorest]     - name: /Alerts/patch/ResourceGroupAlerts
      cmderr	[Autorest]     - name: /Alerts/patch/SubscriptionAlerts
      cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsList-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsList-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsListExpandAndTop-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsListExpandAndTop-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsListWithFilter-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/BillingAccountDimensionsListWithFilter-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/BillingProfileDimensionsList-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/BillingProfileDimensionsListExpandAndTop-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/BillingProfileDimensionsListWithFilter-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/CustomerDimensionsList-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/CustomerDimensionsListExpandAndTop-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/CustomerDimensionsListWithFilter-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/DepartmentDimensionsList-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/DepartmentDimensionsListExpandAndTop-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/DepartmentDimensionsListWithFilter-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/EnrollmentAccountDimensionsList-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/EnrollmentAccountDimensionsListExpandAndTop-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/EnrollmentAccountDimensionsListWithFilter-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/ExternalBillingAccountDimensionList
      cmderr	[Autorest]     - name: /Dimensions/get/ExternalSubscriptionDimensionList
      cmderr	[Autorest]     - name: /Dimensions/get/InvoiceSectionDimensionsList-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/InvoiceSectionDimensionsListExpandAndTop-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/InvoiceSectionDimensionsListWithFilter-Modern
      cmderr	[Autorest]     - name: /Dimensions/get/ManagementGroupDimensionsList-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/ManagementGroupDimensionsListExpandAndTop-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/ManagementGroupDimensionsListWithFilter-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/ResourceGroupDimensionsList-Legacy
      cmderr	[Autorest]     - name: /Dimensions/get/SubscriptionDimensionsList-Legacy
      cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateByBillingAccount
      cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateByDepartment
      cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateByEnrollmentAccount
      cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateByManagementGroup
      cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateByResourceGroup
      cmderr	[Autorest]     - name: /Exports/put/ExportCreateOrUpdateBySubscription
      cmderr	[Autorest]     - name: /Exports/get/ExportGetByBillingAccount
      cmderr	[Autorest]     - name: /Exports/get/ExportGetByDepartment
      cmderr	[Autorest]     - name: /Exports/get/ExportGetByEnrollmentAccount
      cmderr	[Autorest]     - name: /Exports/get/ExportGetByManagementGroup
      cmderr	[Autorest]     - name: /Exports/get/ExportGetByResourceGroup
      cmderr	[Autorest]     - name: /Exports/get/ExportGetBySubscription
      cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetByBillingAccount
      cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetByDepartment
      cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetByEnrollmentAccount
      cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetByManagementGroup
      cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetByResourceGroup
      cmderr	[Autorest]     - name: /Exports/get/ExportRunHistoryGetBySubscription
      cmderr	[Autorest]     - name: /Exports/get/ExportsGetByBillingAccount
      cmderr	[Autorest]     - name: /Exports/get/ExportsGetByDepartment
      cmderr	[Autorest]     - name: /Exports/get/ExportsGetByEnrollmentAccount
      cmderr	[Autorest]     - name: /Exports/get/ExportsGetByManagementGroup
      cmderr	[Autorest]     - name: /Exports/get/ExportsGetByResourceGroup
      cmderr	[Autorest]     - name: /Exports/get/ExportsGetBySubscription
      cmderr	[Autorest]     - name: /Exports/post/ExportRunByBillingAccount
      cmderr	[Autorest]     - name: /Exports/post/ExportRunByDepartment
      cmderr	[Autorest]     - name: /Exports/post/ExportRunByEnrollmentAccount
      cmderr	[Autorest]     - name: /Exports/post/ExportRunByManagementGroup
      cmderr	[Autorest]     - name: /Exports/post/ExportRunByResourceGroup
      cmderr	[Autorest]     - name: /Exports/post/ExportRunBySubscription
      cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteByBillingAccount
      cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteByDepartment
      cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteByEnrollmentAccount
      cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteByManagementGroup
      cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteByResourceGroup
      cmderr	[Autorest]     - name: /Exports/delete/ExportDeleteBySubscription
      cmderr	[Autorest]     - name: /Forecast/post/BillingAccountForecast
      cmderr	[Autorest]     - name: /Forecast/post/BillingProfileForecast
      cmderr	[Autorest]     - name: /Forecast/post/DepartmentForecast
      cmderr	[Autorest]     - name: /Forecast/post/EnrollmentAccountForecast
      cmderr	[Autorest]     - name: /Forecast/post/ExternalBillingAccountForecast
      cmderr	[Autorest]     - name: /Forecast/post/ExternalSubscriptionForecast
      cmderr	[Autorest]     - name: /Forecast/post/InvoiceSectionForecast
      cmderr	[Autorest]     - name: /Forecast/post/ResourceGroupForecast
      cmderr	[Autorest]     - name: /Forecast/post/SubscriptionForecast
      cmderr	[Autorest]     - name: /Query/post/BillingAccountQuery-Legacy
      cmderr	[Autorest]     - name: /Query/post/BillingAccountQuery-Modern
      cmderr	[Autorest]     - name: /Query/post/BillingAccountQueryGrouping-Legacy
      cmderr	[Autorest]     - name: /Query/post/BillingAccountQueryGrouping-Modern
      cmderr	[Autorest]     - name: /Query/post/BillingProfileQuery-Modern
      cmderr	[Autorest]     - name: /Query/post/BillingProfileQueryGrouping-Modern
      cmderr	[Autorest]     - name: /Query/post/CustomerQuery-Modern
      cmderr	[Autorest]     - name: /Query/post/CustomerQueryGrouping-Modern
      cmderr	[Autorest]     - name: /Query/post/DepartmentQuery-Legacy
      cmderr	[Autorest]     - name: /Query/post/DepartmentQueryGrouping-Legacy
      cmderr	[Autorest]     - name: /Query/post/EnrollmentAccountQuery-Legacy
      cmderr	[Autorest]     - name: /Query/post/EnrollmentAccountQueryGrouping-Legacy
      cmderr	[Autorest]     - name: /Query/post/ExternalBillingAccountQueryList
      cmderr	[Autorest]     - name: /Query/post/ExternalSubscriptionsQuery
      cmderr	[Autorest]     - name: /Query/post/InvoiceSectionQuery-Modern
      cmderr	[Autorest]     - name: /Query/post/InvoiceSectionQueryGrouping-Modern
      cmderr	[Autorest]     - name: /Query/post/ManagementGroupQuery-Legacy
      cmderr	[Autorest]     - name: /Query/post/ManagementGroupQueryGrouping-Legacy
      cmderr	[Autorest]     - name: /Query/post/ResourceGroupQuery-Legacy
      cmderr	[Autorest]     - name: /Query/post/ResourceGroupQueryGrouping-Legacy
      cmderr	[Autorest]     - name: /Query/post/SubscriptionQuery-Legacy
      cmderr	[Autorest]     - name: /Query/post/SubscriptionQueryGrouping-Legacy
      cmderr	[Autorest]     - name: /Views/put/CreateOrUpdatePrivateView
      cmderr	[Autorest]     - name: /Views/put/ResourceGroupCreateOrUpdateView
      cmderr	[Autorest]     - name: /Views/get/PrivateView
      cmderr	[Autorest]     - name: /Views/get/PrivateViewList
      cmderr	[Autorest]     - name: /Views/get/ResourceGroupView
      cmderr	[Autorest]     - name: /Views/get/ResourceGroupViewList
      cmderr	[Autorest]     - name: /Views/delete/DeletePrivateView
      cmderr	[Autorest]     - name: /Views/delete/ResourceGroupDeleteView
      cmderr	[Autorest] --------------------------------------------------------
      cmderr	[Autorest] /bin/sh: 1: cd: can't cd to home/vsts/work/1/s/azure-rest-api-specs
      cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git
      cmderr	[Autorest] fatal: not a git repository (or any of the parent directories): .git
    • ️✔️costmanagement [View full logs]  [Release Azure CLI Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 71aa792. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️costmanagement/mgmt/2019-10-01/costmanagement [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/costmanagement/mgmt/2019-03-01/costmanagement [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️costmanagement/mgmt/2019-01-01/costmanagement [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/costmanagement/mgmt/2018-08-01-preview/costmanagement [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️costmanagement/mgmt/2018-05-31/costmanagement [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 71aa792. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/cost-management/resource-manager/readme.md
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.CostManagement/reports. Skipping definition with path '/providers/Microsoft.Billing/departments/{departmentId}/providers/Microsoft.CostManagement/reports/{reportName}'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.CostManagement/reports. Using definition with path '/providers/Microsoft.Billing/billingAccounts/{billingAccountId}/providers/Microsoft.CostManagement/reports/{reportName}'.
    • ️✔️cost-management [View full logs]  [Release Schema Changes]
      cmderr	[resource-manager] node-pre-gyp
      cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
      cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
      cmderr	[resource-manager]  optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
      cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
      cmderr	[resource-manager]  ERR! code ELIFECYCLE
      cmderr	[resource-manager] npm ERR! errno 9
      cmderr	[resource-manager] ERR! template-schema-validation-tools@1.0.0 test: `mocha -r ts-node/register tests.ts`
      cmderr	[resource-manager] npm ERR! Exit status 9
      cmderr	[resource-manager] npm ERR!
      cmderr	[resource-manager] npm ERR! Failed at the template-schema-validation-tools@1.0.0 test script.
      cmderr	[resource-manager] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
      cmderr	[resource-manager]  A complete log of this run can be found in:
      cmderr	[resource-manager] npm ERR!     /home/vsts/.npm/_logs/2021-01-08T08_29_55_378Z-debug.log
      cmderr	[resource-manager] Error: Command failed: npm run test --prefix tools
      cmderr	[resource-manager]     at checkExecSyncError (child_process.js:635:11)
      cmderr	[resource-manager]     at Object.execSync (child_process.js:671:15)
      cmderr	[resource-manager]     at Object.<anonymous> (/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas/sdkauto_afterscript.js:13:28)
      cmderr	[resource-manager]     at Module._compile (internal/modules/cjs/loader.js:999:30)
      cmderr	[resource-manager]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
      cmderr	[resource-manager]     at Module.load (internal/modules/cjs/loader.js:863:32)
      cmderr	[resource-manager]     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
      cmderr	[resource-manager]     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
      cmderr	[resource-manager]     at internal/main/run_main_module.js:17:47 {
      cmderr	[resource-manager]   status: 9,
      cmderr	[resource-manager]   signal: null,
      cmderr	[resource-manager]   output: [ null, null, null ],
      cmderr	[resource-manager]   pid: 3096,
      cmderr	[resource-manager]   stdout: null,
      cmderr	[resource-manager]   stderr: null
      cmderr	[resource-manager] }
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @sofisa16, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

    @zhenglaizhang
    Copy link
    Contributor

    Hi @sofisa16 can you tell which s360 item you are fixing?

    @sofisa16
    Copy link
    Contributor Author

    Copy link
    Member

    @JeffreyRichter JeffreyRichter left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I approved this PR as per S360 KPIs

    @zhenglaizhang
    Copy link
    Contributor

    Hi @sofisa16 I have seen you added the label CI-BreakingChange-Go, could you help explain why?

    @zhenglaizhang
    Copy link
    Contributor

    Hi @msyyc it looks like the python breaking change doesn't relate with this PR change?

    @msyyc
    Copy link
    Member

    msyyc commented Dec 30, 2020

    Hi @msyyc Yuchao Yan FTE it looks like the python breaking change doesn't relate with this PR change?

    The breaking is caused by #11753, not this one.

    @sofisa16
    Copy link
    Contributor Author

    sofisa16 commented Jan 5, 2021

    Hi @sofisa16 I have seen you added the label CI-BreakingChange-Go, could you help explain why?

    It is not a breaking change. I misunderstood the concept. I will remove the flag.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants