-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Red Hat OpenShift 2021 01 31 preview API #12144
Azure Red Hat OpenShift 2021 01 31 preview API #12144
Conversation
Hi, @mjudeikis Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
OperationId should contain the verb: 'listadmincredentials' in:'OpenShiftClusters_ListAdminKubeconfig'. Consider updating the operationId New: Microsoft.RedHatOpenShift/preview/2021-01-31-preview/redhatopenshift.json#L361 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.5)
- original: stable/2020-04-30/redhatopenshift.json <---> new: preview/2021-01-31-preview/redhatopenshift.json
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
Hi, @mjudeikis Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Generation Artifacts
|
Hi, @mjudeikis your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @ |
076b1ac
to
219b0d3
Compare
@chunyu3 Hey! Can you please help us with the review on this. This is new API for Azure Red hat OpenShift service, joint engineering with Microsoft and RedHat. We are mostly modeling our APIS following AKS, but I see failure with missing Thanks and appreciate the time! |
SDK azure-sdk-for-go failed. @ArcturusZhang please help to check it. And please look at the 'Swagger LintDiff' issue. @mjudeikis Thanks. |
Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`. | ||
|
||
``` yaml $(tag) == 'package-2021-01-31-preview' && $(go) | ||
output-folder: $(go-sdk-folder)/services/$(namespace)/mgmt/2021-01-31-preview/$(namespace) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A preview package must be placed in the preview
subdirectory
output-folder: $(go-sdk-folder)/services/$(namespace)/mgmt/2021-01-31-preview/$(namespace) | |
output-folder: $(go-sdk-folder)/services/preview/$(namespace)/mgmt/2021-01-31-preview/$(namespace) |
f074f88
to
14f0fee
Compare
Hi @mjudeikis, Your PR has some issues. Please fix the CI sequentially by following the order of
|
@ArcturusZhang @chunyu3 addressed the change. Chan you please advise on Avocado failures? Not sure where they are coming from |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
This reverts commit 561bb28.
…Azure#12387) This reverts commit 561bb28.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Target is to start testing in canary early next year, and go to production Beginning of march 2021
Together with going live
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.