Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update v2/types.json to align with v1/types.json #12048

Merged
merged 5 commits into from
Dec 10, 2020
Merged

Update v2/types.json to align with v1/types.json #12048

merged 5 commits into from
Dec 10, 2020

Conversation

jianyexi
Copy link
Contributor

@jianyexi jianyexi commented Dec 10, 2020 •
edited by ruowan
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 10, 2020 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand] 
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
There are no breaking changes.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 10, 2020 •
edited
Loading

Swagger Generation Artifacts

️❌[Staging] ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]
Rule Message
❌ RestBuild error "logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=180782&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b",
"detail":"Run.ps1 failed with exit code 128 "
Posted by Swagger Pipeline | How to fix these errors?

@jianyexi jianyexi assigned akning-ms and unassigned xseeseesee Dec 10, 2020
@openapi-workflow-bot
Copy link

Hi, @jianyexi Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    akning-ms
    akning-ms reviewed Dec 10, 2020
    View reviewed changes
    specification/common-types/resource-management/v2/types.json Outdated
    @@ -123,7 +127,7 @@
    "create",
    "update"
    ],
    "description": "The fully qualified resource ID of the resource that manages this resource. Indicates if this resource is managed by another Azure resource. If this is present, complete mode deployment will not delete the resource if it is removed from the template since it is managed by another resource."
    "description": "The fully qualified resource ID of the resource that manages this resource. Indicates if this resource is managed by another azure resource. If this is present, complete mode deployment will not delete the resource if it is removed from the template since it is managed by another resource."
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Azure --> azure is not need here

    @akning-ms akning-ms merged commit 482bb06 into master Dec 10, 2020
    DeMale pushed a commit to DeMale/azure-rest-api-specs that referenced this pull request Dec 11, 2020
    @jianyexi @DeMale
    Update v2/types.json to align with v1/types.json (Azure#12048)
    676a649 
    * Update types.json

* Update types.json

* Update types.json

* Update types.json

* Update types.json
    dabenhamMic pushed a commit to dabenhamMic/azure-rest-api-specs that referenced this pull request Dec 14, 2020
    @jianyexi @dabenhamMic
    Update v2/types.json to align with v1/types.json (Azure#12048)
    efb4d86 
    * Update types.json

* Update types.json

* Update types.json

* Update types.json

* Update types.json
    @jianyexi jianyexi deleted the jianyexi-patch-6 branch December 18, 2020 07:27
    giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020
    @jianyexi
    Update v2/types.json to align with v1/types.json (Azure#12048)
    9f4087c 
    * Update types.json

* Update types.json

* Update types.json

* Update types.json

* Update types.json
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @akning-ms akning-ms akning-ms left review comments

    Assignees

    @akning-ms akning-ms

    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @jianyexi @akning-ms @xseeseesee