-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove AVS 2019-08-09-preview #12041
Conversation
Swagger Validation Report
|
Swagger Generation Artifacts
|
@ctaggart , removing APIs are breaking changes, have you gotten approval per Breaking Change Policy |
Hi @ctaggart, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
@erich-wang, the breaking change for removing this preview API version was approved today. |
@ctaggart , we may also consider the impact for the SDK released previously which is based on this API version. do yo have the data for the SDK version which is using this API version? |
based on breaking change policy for preview version, we should have one year announce time to retire it. |
The current versions of all SDKs are using the 2020-03-20 GA API. The 2019-08-09-preview was not being used and can no longer be used.
The breaking change policy for retirement of previews is 90 days. This process was followed and approved. |
@ctaggart , I'm closing this PR, please raise request for new version of SDK. |
This removes the AVS 2019-08-09-preview API. It was removed from ARM a few days ago:
https://armmanifest.visualstudio.com/One/_git/Manifest/pullrequest/2608?_a=overview
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.