Modifying list of json files under package-2020-10-01-preview to keep package-2020-06-30 files #11950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… package-2020-06-30 files
ashvermamsft
requested review from
dkulkarni-ms,
grizzlytheodore,
haagha,
hyonholee,
madewithsmiles,
MS-syh2qs and
Sandido
as code owners
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2020-10-01-preview |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
|
@markcowl @grizzlytheodore please help in review and merge. |
This was referenced Dec 4, 2020
This was referenced Dec 4, 2020
|
hi @msyyc could you pls confirm the impact to Python SDK? thanks |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
@PhoenixHe-msft can you please confirm about the python SDK impact and fix. We need this PR to be merged so that .NET SDK can be generated. Let me know if any action is needed from my side. |
|
@ashvermamsft Now python sdk passes. OK to merge now. |
@yungezz can you please help in merging this PR. Thanks |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
hi @Sandido could you pls have a look at this PR? |
yungezz
reviewed
Jan 15, 2021
|
|
||
| ``` yaml $(tag) == 'package-2020-10-01-preview' | ||
| input-file: | ||
| - Microsoft.Compute/stable/2020-06-01/compute.json | ||
| - Microsoft.Compute/stable/2020-06-01/runCommands.json | ||
| - Microsoft.Compute/stable/2019-04-01/skus.json | ||
| - Microsoft.Compute/stable/2020-06-30/disk.json | ||
| - Microsoft.Compute/preview/2020-09-30/gallery.json | ||
| - Microsoft.Compute/preview/2020-09-30/sharedGallery.json |
There was a problem hiding this comment.
removing these swagger from existing tag might cause SDK breaking, need SDK owner confirming.
|
hi @ashvermamsft could you pls rebase from master? |
|
hi @ashvermamsft could you pls rebase this PR? thanks |
|
Closing this PR, since the changes have already been taken care by #12452 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in continuation of the PR #11704 . We are keeping the json files as they are present in tag package-2020-06-30, since this is the published api version.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.