Marketplace miberezi 2020

[MiriBerezin]

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

1. What's the purpose of the update?
   • new service onboarding
   • new API version
   • update existing version for new feature
   • update existing version to fix swagger quality issue in s360
   • Other, please clarify
2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
   • SDK of .NET (need service team to ensure code readiness)
   • SDK of Python
   • SDK of Java
   • SDK of Js
   • SDK of Go
   • PowerShell
   • CLI
   • Terraform
   • No, no need to refresh for updates in this PR

Contribution checklist:

• I commit to follow the Breaking Change Policy of “no breaking changes
• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

• Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

  • Adding new API(s)
  • Adding a new API version
  • Adding a new service

• Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

• If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

• Removing API(s) in stable version
• Removing properties in stable version
• Removing API version(s) in stable version
• Updating API in stable version with Breaking Change Validation errors
• Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

[openapi-pipeline-app]

Swagger pipeline can not start as the pull request has merge conflicts.

[openapi-pipeline-app]

Swagger pipeline can not start as the pull request has merge conflicts.

[openapi-pipeline-app]

Swagger Validation Report

️❌BreakingChange: 6 Errors, 0 Warnings failed [Detail]

• Compared Swaggers (Based on Oad v0.8.1)
  • original: stable/2020-01-01/Marketplace.json <---> new: stable/2020-01-01/Marketplace.json

Rule	Message
❌ 1021 - AddedAdditionalProperties	The new version adds an 'additionalProperties' element. New: Microsoft.Marketplace/stable/2020-01-01/Marketplace.json#L744:9 Old: Microsoft.Marketplace/stable/2020-01-01/Marketplace.json#L744:9
❌ 1021 - AddedAdditionalProperties	The new version adds an 'additionalProperties' element. New: Microsoft.Marketplace/stable/2020-01-01/Marketplace.json#L744:9 Old: Microsoft.Marketplace/stable/2020-01-01/Marketplace.json#L744:9
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'iconKind' renamed or removed? New: azure-rest-api-specs/blob/ae3b2d16c273227289a64c537283a0eab5630d08/ Old: Microsoft.Marketplace/stable/2020-01-01/Marketplace.json#L747:11
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'uri' renamed or removed? New: azure-rest-api-specs/blob/ae3b2d16c273227289a64c537283a0eab5630d08/ Old: Microsoft.Marketplace/stable/2020-01-01/Marketplace.json#L747:11
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'iconKind' renamed or removed? New: azure-rest-api-specs/blob/ae3b2d16c273227289a64c537283a0eab5630d08/ Old: Microsoft.Marketplace/stable/2020-01-01/Marketplace.json#L747:11
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'uri' renamed or removed? New: azure-rest-api-specs/blob/ae3b2d16c273227289a64c537283a0eab5630d08/ Old: Microsoft.Marketplace/stable/2020-01-01/Marketplace.json#L747:11

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

• Linted configuring files (Based on source branch, openapi-validator v1.5.0 , classic-openapi-validator v1.1.4 )
  • marketplace/resource-manager/readme.md tag:package-2020-01-01
• Linted configuring files (Based on target branch, openapi-validator v1.5.0 , classic-openapi-validator v1.1.4 )
  • marketplace/resource-manager/readme.md tag:package-2020-01-01

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Swagger Generation Artifacts

️🔄 azure-sdk-for-net inProgress [Detail]

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

• ️✔️Succeeded [Logs]Release - Generate from d0a2935. Schema Automation 14.0.0

  warn	Skip initScript due to not configured
  command	npx n 12
  command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/w/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/marketplace/resource-manager/readme.md

• ️✔️marketplace [View full logs]  [Release Schema Changes]

  cmderr	[resource-manager] node-pre-gyp
  cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
  cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 No repository field.
  cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.2 (node_modules/fsevents):
  cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account. 

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-workflow-bot]

Hi @MiriBerezin, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

[MiriBerezin]

regarding the breaking changes please look at previous PRs with all the explanations:
#11652

To make a long story short:

I already got approval for those breaking changes. Shortly, We are in Public preview since July and those changes were done in May while the service was still in development mode

Please look at the attached email thread to see the discussion on that. Thanks!
FW Review request for Microsoft#11279).zip

Still S369 issue