Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move QueryPacks to OperationalInsights #11785

Merged
merged 9 commits into from
Dec 13, 2020

Conversation

tofriedl
Copy link
Contributor

@tofriedl tofriedl commented Nov 23, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 23, 2020

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️LintDiff: 7 Warnings warning [Detail]

Rule Message
⚠️ R1003 - ListInOperationName Since operation 'Queries_Search' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
New: Microsoft.OperationalInsights/preview/2019-09-01-preview/QueryPackQueries_API.json#L91
⚠️ R1006 - PutInOperationName 'PUT' operation 'Queries_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
New: Microsoft.OperationalInsights/preview/2019-09-01-preview/QueryPackQueries_API.json#L191
⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
New: Microsoft.OperationalInsights/preview/2019-09-01-preview/QueryPackQueries_API.json#L529
⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'queries' with immediate parent 'LogAnalyticsQueryPack', must have a list by immediate parent operation.
New: Microsoft.OperationalInsights/preview/2019-09-01-preview/QueryPackQueries_API.json#L329
⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
New: Microsoft.OperationalInsights/preview/2019-09-01-preview/QueryPacks_API.json#L523
⚠️ R4024 - PreviewVersionOverOneYear The API version:2019-09-01-preview having been in a preview state over one year , please move it to GA or retire.
New: Microsoft.OperationalInsights/preview/2019-09-01-preview/QueryPackQueries_API.json#L6
⚠️ R4024 - PreviewVersionOverOneYear The API version:2019-09-01-preview having been in a preview state over one year , please move it to GA or retire.
New: Microsoft.OperationalInsights/preview/2019-09-01-preview/QueryPacks_API.json#L6
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 23, 2020

Swagger Generation Artifacts

️⚠️ azure-sdk-for-net warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from e2f0283. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	sudo apt-get install -y dotnet-sdk-5.0
    command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/operationalinsights/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.ApplicationInsights [View full logs]  [Release SDK Changes]
  • ️✔️Microsoft.Azure.Management.OperationalInsights [View full logs]  [Release SDK Changes]
️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from e2f0283. Schema Automation 14.0.0
    warn	Skip initScript due to not configured
    command	npx n 12
    command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md
    command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/operationalinsights/resource-manager/readme.md
  • ️✔️applicationinsights [View full logs]  [Release Schema Changes]
    cmderr	[resource-manager] node-pre-gyp
    cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
    cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 No repository field.
    cmderr	[resource-manager] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.2 (node_modules/fsevents):
    cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    cmderr	[resource-manager]  ERR! code ELIFECYCLE
    cmderr	[resource-manager] npm ERR! errno 16
    cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 test: `mocha -r ts-node/register tests.ts`
    cmderr	[resource-manager] npm ERR! Exit status 16
    cmderr	[resource-manager] npm ERR!
    cmderr	[resource-manager] npm ERR! Failed at the template-schema-validation-tools@1.0.0 test script.
    cmderr	[resource-manager] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
    cmderr	[resource-manager]  A complete log of this run can be found in:
    cmderr	[resource-manager] npm ERR!     /home/vsts/.npm/_logs/2020-12-13T12_27_02_587Z-debug.log
    cmderr	[resource-manager] Error: Command failed: npm run test --prefix tools
    cmderr	[resource-manager]     at checkExecSyncError (child_process.js:635:11)
    cmderr	[resource-manager]     at Object.execSync (child_process.js:671:15)
    cmderr	[resource-manager]     at Object.<anonymous> (/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas/sdkauto_afterscript.js:13:28)
    cmderr	[resource-manager]     at Module._compile (internal/modules/cjs/loader.js:999:30)
    cmderr	[resource-manager]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    cmderr	[resource-manager]     at Module.load (internal/modules/cjs/loader.js:863:32)
    cmderr	[resource-manager]     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    cmderr	[resource-manager]     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
    cmderr	[resource-manager]     at internal/main/run_main_module.js:17:47 {
    cmderr	[resource-manager]   status: 16,
    cmderr	[resource-manager]   signal: null,
    cmderr	[resource-manager]   output: [ null, null, null ],
    cmderr	[resource-manager]   pid: 3026,
    cmderr	[resource-manager]   stdout: null,
    cmderr	[resource-manager]   stderr: null
    cmderr	[resource-manager] }
    cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 No repository field.
    cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.2 (node_modules/fsevents):
    cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    cmderr	[resource-manager]  ERR! code ELIFECYCLE
    cmderr	[resource-manager] npm ERR! errno 16
    cmderr	[resource-manager] ERR! template-schema-validation-tools@1.0.0 test: `mocha -r ts-node/register tests.ts`
    cmderr	[resource-manager] npm ERR! Exit status 16
    cmderr	[resource-manager] npm ERR!
    cmderr	[resource-manager] npm ERR! Failed at the template-schema-validation-tools@1.0.0 test script.
    cmderr	[resource-manager] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
    cmderr	[resource-manager]  A complete log of this run can be found in:
    cmderr	[resource-manager] npm ERR!     /home/vsts/.npm/_logs/2020-12-13T12_27_55_564Z-debug.log
    cmderr	[resource-manager] Error: Command failed: npm run test --prefix tools
    cmderr	[resource-manager]     at checkExecSyncError (child_process.js:635:11)
    cmderr	[resource-manager]     at Object.execSync (child_process.js:671:15)
    cmderr	[resource-manager]     at Object.<anonymous> (/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas/sdkauto_afterscript.js:13:28)
    cmderr	[resource-manager]     at Module._compile (internal/modules/cjs/loader.js:999:30)
    cmderr	[resource-manager]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    cmderr	[resource-manager]     at Module.load (internal/modules/cjs/loader.js:863:32)
    cmderr	[resource-manager]     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    cmderr	[resource-manager]     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
    cmderr	[resource-manager]     at internal/main/run_main_module.js:17:47 {
    cmderr	[resource-manager]   status: 16,
    cmderr	[resource-manager]   signal: null,
    cmderr	[resource-manager]   output: [ null, null, null ],
    cmderr	[resource-manager]   pid: 3156,
    cmderr	[resource-manager]   stdout: null,
    cmderr	[resource-manager]   stderr: null
    cmderr	[resource-manager] }
️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from e2f0283. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	npx n 12
    command	python3 -m venv venv
    command	pip install --upgrade setuptools wheel pip
    command	pip install pathlib jinja2 msrestazure
    command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md
    command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/operationalinsights/resource-manager/readme.md
  • ️✔️azure-mgmt-applicationinsights [View full logs]  [Release SDK Changes] Breaking Change Detected
    Only show 120 items here, please refer to log for details.
    cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.applicationinsights.v2020_03_01_preview
    cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/applicationinsights/azure-mgmt-applicationinsights/code_reports/1.0.0b1/v2020_03_01_preview.json
    cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.applicationinsights.v2020_06_02_preview
    cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/applicationinsights/azure-mgmt-applicationinsights/code_reports/1.0.0b1/v2020_06_02_preview.json
    cmderr	[changelogReportLatest] INFO:__main__:Merged report written to sdk/applicationinsights/azure-mgmt-applicationinsights/code_reports/1.0.0b1/merged_report.json
    cmdout	[Changelog] Size of delta 30.343% size of original (original: 76247 chars, delta: 23136 chars)
    cmdout	[Changelog] **Features**
    cmdout	[Changelog]   - Model Workbook has a new parameter workbook_tags
    cmdout	[Changelog]   - Model WorkbookUpdateParameters has a new parameter tags1
    cmdout	[Changelog]   - Model MyWorkbook has a new parameter my_workbook_tags
    cmdout	[Changelog]   - Model ApplicationInsightsComponentProactiveDetectionConfiguration has a new parameter name1
    cmdout	[Changelog]   - Added operation Operations.list
    cmdout	[Changelog] **Breaking changes**
    cmdout	[Changelog]   - Parameter application_type of model ApplicationInsightsComponent is now required
    cmdout	[Changelog]   - Parameter workspace_resource_id of model ApplicationInsightsComponent is now required
    cmdout	[Changelog]   - Parameter galleries of model WorkbookTemplateUpdateParameters is now required
    cmdout	[Changelog]   - Parameter template_data of model WorkbookTemplateUpdateParameters is now required
    cmdout	[Changelog]   - Parameter web_test_name of model WebTest is now required
    cmdout	[Changelog]   - Parameter synthetic_monitor_id of model WebTest is now required
    cmdout	[Changelog]   - Parameter locations of model WebTest is now required
    cmdout	[Changelog]   - Parameter category of model Workbook is now required
    cmdout	[Changelog]   - Parameter display_name of model Workbook is now required
    cmdout	[Changelog]   - Parameter serialized_data of model Workbook is now required
    cmdout	[Changelog]   - Parameter galleries of model WorkbookTemplate is now required
    cmdout	[Changelog]   - Parameter template_data of model WorkbookTemplate is now required
    cmdout	[Changelog]   - Parameter category of model MyWorkbook is now required
    cmdout	[Changelog]   - Parameter display_name of model MyWorkbook is now required
    cmdout	[Changelog]   - Parameter serialized_data of model MyWorkbook is now required
    cmdout	[Changelog]   - Parameter web_test_kind of model WebTest is now required
    cmdout	[Changelog]   - Operation WorkbooksOperations.update has a new signature
    cmdout	[Changelog]   - Operation WorkbooksOperations.list_by_resource_group has a new signature
    cmdout	[Changelog]   - Operation WorkbooksOperations.get has a new signature
    cmdout	[Changelog]   - Operation WorkbooksOperations.delete has a new signature
    cmdout	[Changelog]   - Operation WorkbooksOperations.create_or_update has a new signature
    cmdout	[Changelog]   - Operation WorkbookTemplatesOperations.update has a new signature
    cmdout	[Changelog]   - Operation WorkbookTemplatesOperations.list_by_resource_group has a new signature
    cmdout	[Changelog]   - Operation WorkbookTemplatesOperations.get has a new signature
    cmdout	[Changelog]   - Operation WorkbookTemplatesOperations.delete has a new signature
    cmdout	[Changelog]   - Operation WorkbookTemplatesOperations.create_or_update has a new signature
    cmdout	[Changelog]   - Operation WorkItemConfigurationsOperations.update_item has a new signature
    cmdout	[Changelog]   - Operation WorkItemConfigurationsOperations.list has a new signature
    cmdout	[Changelog]   - Operation WorkItemConfigurationsOperations.get_item has a new signature
    cmdout	[Changelog]   - Operation WorkItemConfigurationsOperations.get_default has a new signature
    cmdout	[Changelog]   - Operation WorkItemConfigurationsOperations.delete has a new signature
    cmdout	[Changelog]   - Operation WorkItemConfigurationsOperations.create has a new signature
    cmdout	[Changelog]   - Operation WebTestsOperations.list_by_resource_group has a new signature
    cmdout	[Changelog]   - Operation WebTestsOperations.list_by_component has a new signature
    cmdout	[Changelog]   - Operation WebTestsOperations.get has a new signature
    cmdout	[Changelog]   - Operation WebTestsOperations.delete has a new signature
    cmdout	[Changelog]   - Operation WebTestsOperations.create_or_update has a new signature
    cmdout	[Changelog]   - Operation WebTestLocationsOperations.list has a new signature
    cmdout	[Changelog]   - Operation ProactiveDetectionConfigurationsOperations.update has a new signature
    cmdout	[Changelog]   - Operation ProactiveDetectionConfigurationsOperations.list has a new signature
    cmdout	[Changelog]   - Operation ProactiveDetectionConfigurationsOperations.get has a new signature
    cmdout	[Changelog]   - Operation MyWorkbooksOperations.update has a new signature
    cmdout	[Changelog]   - Operation MyWorkbooksOperations.list_by_subscription has a new signature
    cmdout	[Changelog]   - Operation MyWorkbooksOperations.list_by_resource_group has a new signature
    cmdout	[Changelog]   - Operation MyWorkbooksOperations.get has a new signature
    cmdout	[Changelog]   - Operation MyWorkbooksOperations.delete has a new signature
    cmdout	[Changelog]   - Operation MyWorkbooksOperations.create_or_update has a new signature
    cmdout	[Changelog]   - Operation FavoritesOperations.update has a new signature
    cmdout	[Changelog]   - Operation FavoritesOperations.list has a new signature
    cmdout	[Changelog]   - Operation FavoritesOperations.get has a new signature
    cmdout	[Changelog]   - Operation FavoritesOperations.delete has a new signature
    cmdout	[Changelog]   - Operation FavoritesOperations.add has a new signature
    cmdout	[Changelog]   - Operation ExportConfigurationsOperations.update has a new signature
    cmdout	[Changelog]   - Operation ExportConfigurationsOperations.list has a new signature
    cmdout	[Changelog]   - Operation ExportConfigurationsOperations.get has a new signature
    cmdout	[Changelog]   - Operation ExportConfigurationsOperations.delete has a new signature
    cmdout	[Changelog]   - Operation ExportConfigurationsOperations.create has a new signature
    cmdout	[Changelog]   - Operation ComponentsOperations.list_by_resource_group has a new signature
    cmdout	[Changelog]   - Operation ComponentsOperations.get_purge_status has a new signature
    cmdout	[Changelog]   - Operation ComponentsOperations.get has a new signature
    cmdout	[Changelog]   - Operation ComponentsOperations.delete has a new signature
    cmdout	[Changelog]   - Operation ComponentsOperations.create_or_update has a new signature
    cmdout	[Changelog]   - Operation ComponentQuotaStatusOperations.get has a new signature
    cmdout	[Changelog]   - Operation ComponentFeatureCapabilitiesOperations.get has a new signature
    cmdout	[Changelog]   - Operation ComponentCurrentPricingPlanOperations.update has a new signature
    cmdout	[Changelog]   - Operation ComponentCurrentPricingPlanOperations.get has a new signature
    cmdout	[Changelog]   - Operation ComponentCurrentPricingPlanOperations.create_and_update has a new signature
    cmdout	[Changelog]   - Operation ComponentCurrentBillingFeaturesOperations.get has a new signature
    cmdout	[Changelog]   - Operation ComponentAvailableFeaturesOperations.get has a new signature
    cmdout	[Changelog]   - Operation AnnotationsOperations.list has a new signature
    cmdout	[Changelog]   - Operation AnnotationsOperations.get has a new signature
    cmdout	[Changelog]   - Operation AnnotationsOperations.delete has a new signature
    cmdout	[Changelog]   - Operation AnnotationsOperations.create has a new signature
    cmdout	[Changelog]   - Operation AnalyticsItemsOperations.put has a new signature
    cmdout	[Changelog]   - Operation AnalyticsItemsOperations.list has a new signature
    cmdout	[Changelog]   - Operation AnalyticsItemsOperations.get has a new signature
    cmdout	[Changelog]   - Operation AnalyticsItemsOperations.delete has a new signature
    cmdout	[Changelog]   - Operation APIKeysOperations.list has a new signature
    cmdout	[Changelog]   - Operation APIKeysOperations.get has a new signature
    cmdout	[Changelog]   - Operation APIKeysOperations.delete has a new signature
    cmdout	[Changelog]   - Operation APIKeysOperations.create has a new signature
    cmdout	[Changelog]   - Model AzureResourceProperties no longer has parameter system_data
    cmdout	[Changelog]   - Model Workbook no longer has parameter tags_properties_tags
    cmdout	[Changelog]   - Model WorkbookUpdateParameters no longer has parameter tags_properties_tags
    cmdout	[Changelog]   - Model OperationDisplay no longer has parameter description
    cmdout	[Changelog]   - Model MyWorkbook no longer has parameter tags_properties_tags
    cmdout	[Changelog]   - Model ApplicationInsightsComponentProactiveDetectionConfiguration no longer has parameter name_properties_name
    cmdout	[Changelog]   - Model Operation no longer has parameter origin
    cmdout	[Changelog]   - Model Operation no longer has parameter is_data_action
    cmdout	[Changelog]   - Operation ComponentCurrentBillingFeaturesOperations.update has a new signature
    cmdout	[Changelog]   - Operation ComponentLinkedStorageAccountsOperations.get has a new signature
    cmdout	[Changelog]   - Operation ComponentLinkedStorageAccountsOperations.delete has a new signature
    cmdout	[Changelog]   - Operation ComponentLinkedStorageAccountsOperations.update has a new signature
    cmdout	[Changelog]   - Operation ComponentLinkedStorageAccountsOperations.create_and_update has a new signature
    cmdout	[Changelog]   - Operation WebTestsOperations.list has a new signature
    cmdout	[Changelog]   - Operation WebTestsOperations.update_tags has a new signature
    cmdout	[Changelog]   - Operation EASubscriptionRollbackToLegacyPricingModelOperations.post has a new signature
    cmdout	[Changelog]   - Operation ComponentsOperations.purge has a new signature
    cmdout	[Changelog]   - Operation ComponentsOperations.list has a new signature
    cmdout	[Changelog]   - Operation ComponentsOperations.update_tags has a new signature
    cmdout	[Changelog]   - Operation EASubscriptionMigrateToNewPricingModelOperations.post has a new signature
    cmdout	[Changelog]   - Operation EASubscriptionListMigrationDateOperations.post has a new signature
    cmdout	[Changelog]   - Model LogAnalyticsQueryPackQuery has a new signature
    cmdout	[Changelog]   - Model LogAnalyticsQueryPackQuerySearchProperties has a new signature
    cmdout	[Changelog]   - Removed operation QueriesOperations.update
    cmdout	[Changelog]   - Removed operation group LiveTokenOperations
    warn	Breaking change found in changelog
️❌ azure-sdk-for-java failed [Detail]
  • Failed [Logs]Release - Generate from e2f0283. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    cmderr	[generate.py] 2020-12-13 12:27:19 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-applicationinsights"
    cmderr	[generate.py] 2020-12-13 12:27:19 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
    cmderr	[generate.py] 2020-12-13 12:27:19 INFO autorest --version=3.0.6327 --use=@autorest/java@4.0.5 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/applicationinsights/azure-resourcemanager-applicationinsights --java.namespace=com.azure.resourcemanager.applicationinsights  --package-version=1.0.0-beta.1 --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --pipeline.modelerfour.flatten-payloads=false --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md
    cmderr	[generate.py] 2020-12-13 12:28:07 INFO [CI][Success] Write to ci.yml
    cmderr	[generate.py] 2020-12-13 12:28:07 INFO [POM][Process] dealing with pom.xml
    cmderr	[generate.py] 2020-12-13 12:28:07 INFO [POM][Success] Write to pom.xml
    cmderr	[generate.py] 2020-12-13 12:28:07 INFO [POM][Process] dealing with root pom
    cmderr	[generate.py] 2020-12-13 12:28:07 INFO [POM][Success] Write to root pom
    cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
    cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
    cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
    cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
    cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
    could not find '/home/vsts/work/1/s/azure-sdk-for-java/common/smoke-tests/src/main/java/com/azure/smoketest/App.java' to stat: No such file or directory
    Error: could not find '/home/vsts/work/1/s/azure-sdk-for-java/common/smoke-tests/src/main/java/com/azure/smoketest/App.java' to stat: No such file or directory
  • ️✔️azure-resourcemanager-applicationinsights [View full logs]  [Release SDK Changes]
    cmderr	[Inst] 2020-12-13 12:31:24 DEBUG Got artifact_id: azure-resourcemanager-applicationinsights
    cmderr	[Inst] 2020-12-13 12:31:24 DEBUG Got artifact: pom.xml
    cmderr	[Inst] 2020-12-13 12:31:24 DEBUG Got artifact: azure-resourcemanager-applicationinsights-1.0.0-beta.1.jar
    cmderr	[Inst] 2020-12-13 12:31:24 DEBUG Match jar package: azure-resourcemanager-applicationinsights-1.0.0-beta.1.jar
    cmderr	[Inst] 2020-12-13 12:31:24 DEBUG output: {"full": "curl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/11785/azure-sdk-for-java/azure-resourcemanager-applicationinsights/azure-resourcemanager-applicationinsights-1.0.0-beta.1.jar\" -o azure-resourcemanager-applicationinsights-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-applicationinsights -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-applicationinsights-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true\n"}
  • ️✔️azure-resourcemanager-loganalytics
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from e2f0283. SDK Automation 14.0.0
    command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️operationalinsights/mgmt/2020-10-01/operationalinsights [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
  • ️✔️operationalinsights/mgmt/2020-08-01/operationalinsights [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
  • ️✔️preview/operationalinsights/mgmt/2020-03-01-preview/operationalinsights [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
  • ️✔️preview/operationalinsights/mgmt/2015-11-01-preview/operationalinsights [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
  • ️✔️appinsights/mgmt/2015-05-01/insights [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
  • ️✔️operationalinsights/mgmt/2015-03-20/operationalinsights [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
️❌ azure-sdk-for-js failed [Detail]
  • Failed [Logs]Release - Generate from e2f0283. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/applicationinsights/resource-manager/readme.md
    command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/operationalinsights/resource-manager/readme.md
  • @azure/arm-appinsights [View full logs]  [Release SDK Changes]
    error	Script return with result [failed] code [2] signal [null] cwd [azure-sdk-for-js/azure-sdk-for-js/sdk/applicationinsights/arm-appinsights]: npm pack --silent
️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi, @tofriedl Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 23, 2020
    @openapi-workflow-bot
    Copy link

    Hi, @tofriedl your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @kairu-ms

    @openapi-workflow-bot
    Copy link

    Hi @tofriedl, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

    @JeffreyRichter JeffreyRichter self-requested a review November 30, 2020 18:49
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 30, 2020
    @j5lim j5lim requested review from j5lim and removed request for markwolff December 2, 2020 18:06
    @j5lim j5lim added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 2, 2020
    @kairu-ms kairu-ms merged commit e2f0283 into Azure:master Dec 13, 2020
    This was referenced Dec 13, 2020
    dabenhamMic pushed a commit to dabenhamMic/azure-rest-api-specs that referenced this pull request Dec 14, 2020
    * Move QueryPacks to OperationalInsights
    
    * Some LintDiff fixes
    
    * fix
    
    * next issue
    
    * fix
    
    * fix
    
    * merge
    
    * fix merge
    giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020
    * Move QueryPacks to OperationalInsights
    
    * Some LintDiff fixes
    
    * fix
    
    * next issue
    
    * fix
    
    * fix
    
    * merge
    
    * fix merge
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Python
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants