Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new api version to devops RP #11585

Merged
merged 11 commits into from
Dec 24, 2020
Merged

Adding new api version to devops RP #11585

merged 11 commits into from
Dec 24, 2020

Conversation

suyash691
Copy link
Contributor

@suyash691 suyash691 commented Nov 9, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet. Already live as preview (documentation is pending update hence this PR)
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 9, 2020

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 8 Warnings warning [Detail]

Rule Message
⚠️ 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
New: Microsoft.DevOps/preview/2020-07-13-preview/devops.json#L600:9
Old: Microsoft.DevOps/preview/2019-07-01-preview/devops.json#L597:9
⚠️ 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
New: Microsoft.DevOps/preview/2020-07-13-preview/devops.json#L620:5
Old: Microsoft.DevOps/preview/2019-07-01-preview/devops.json#L612:5
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'organization' renamed or removed?
New: Microsoft.DevOps/preview/2020-07-13-preview/devops.json#L624:7
Old: Microsoft.DevOps/preview/2019-07-01-preview/devops.json#L615:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'project' renamed or removed?
New: Microsoft.DevOps/preview/2020-07-13-preview/devops.json#L624:7
Old: Microsoft.DevOps/preview/2019-07-01-preview/devops.json#L615:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'repository' renamed or removed?
New: Microsoft.DevOps/preview/2020-07-13-preview/devops.json#L734:7
Old: Microsoft.DevOps/preview/2019-07-01-preview/devops.json#L679:7
⚠️ 1034 - AddedRequiredProperty The new version has new required property 'pipelineType' that was not found in the old version.
New: Microsoft.DevOps/preview/2020-07-13-preview/devops.json#L624:7
Old: Microsoft.DevOps/preview/2019-07-01-preview/devops.json#L615:7
⚠️ 1034 - AddedRequiredProperty The new version has new required property 'pipelineType' that was not found in the old version.
New: Microsoft.DevOps/preview/2020-07-13-preview/devops.json#L600:9
Old: Microsoft.DevOps/preview/2019-07-01-preview/devops.json#L597:9
⚠️ 1034 - AddedRequiredProperty The new version has new required property 'pipelineType' that was not found in the old version.
New: Microsoft.DevOps/preview/2020-07-13-preview/devops.json#L620:5
Old: Microsoft.DevOps/preview/2019-07-01-preview/devops.json#L612:5
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 9, 2020

Swagger Generation Artifacts

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from e9ebf9f. Schema Automation 14.0.0
    warn	Skip initScript due to not configured
    command	npx n 12
    command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/devops/resource-manager/readme.md
  • ️✔️devops [View full logs]  [Release Schema Changes]
    cmderr	[resource-manager] node-pre-gyp
    cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
    cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 No repository field.
    cmderr	[resource-manager]  optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
    cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from e9ebf9f. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	sudo apt-get install -y dotnet-sdk-5.0
    command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/devops/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.DevOps [View full logs]  [Release SDK Changes]
    warn	Skip artifact folder because it doesn't exist: artifacts/packages
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from e9ebf9f. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	npx n 12
    command	python3 -m venv venv
    command	pip install --upgrade setuptools wheel pip
    command	pip install pathlib jinja2 msrestazure
    command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/devops/resource-manager/readme.md
  • ⚠️azure-mgmt-devops [View full logs]  [Release SDK Changes]
    cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-devops
    cmderr	[buildConf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-devops
    cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-devops
    cmderr	[buildPackage] /home/vsts/work/1/s/azure-sdk-for-python_tmp/venv/lib/python3.6/site-packages/setuptools/dist.py:470: UserWarning: The version specified ('2020-07-13-preview') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details.
    cmderr	[buildPackage]   "details." % version
    cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
    cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
    cmderr	[buildPackage] /home/vsts/work/1/s/azure-sdk-for-python_tmp/venv/lib/python3.6/site-packages/setuptools/dist.py:470: UserWarning: The version specified ('2020-07-13-preview') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details.
    cmderr	[buildPackage]   "details." % version
    cmderr	[buildPackage] warning: no files found matching '*.py' under directory 'tests'
    cmderr	[buildPackage] warning: no files found matching '*.yaml' under directory 'tests'
    cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.devops
    cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.devops
    cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.devops
    cmderr	[changelogReport] INFO:__main__:Report written to sdk/devops/azure-mgmt-devops/code_reports/latest/report.json
    cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-devops on PyPI
    cmderr	[changelogReportLatest] Traceback (most recent call last):
    cmderr	[changelogReportLatest]   File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    cmderr	[changelogReportLatest]     "__main__", mod_spec)
    cmderr	[changelogReportLatest]   File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
    cmderr	[changelogReportLatest]     exec(code, run_globals)
    cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 390, in <module>
    cmderr	[changelogReportLatest]     main(args.package_name, args.version, args.no_venv, args.pypi, args.last_pypi, args.output)
    cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/packaging_tools/code_report.py", line 254, in main
    cmderr	[changelogReportLatest]     versions = [str(v) for v in client.get_ordered_versions(package_name)]
    cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/pypi_tools/pypi.py", line 40, in get_ordered_versions
    cmderr	[changelogReportLatest]     project = self.project(package_name)
    cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python/tools/azure-sdk-tools/pypi_tools/pypi.py", line 25, in project
    cmderr	[changelogReportLatest]     response.raise_for_status()
    cmderr	[changelogReportLatest]   File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv/lib/python3.6/site-packages/requests/models.py", line 941, in raise_for_status
    cmderr	[changelogReportLatest]     raise HTTPError(http_error_msg, response=self)
    cmderr	[changelogReportLatest] requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://pypi.org/pypi/azure-mgmt-devops/json/
    warn	Script return with result [warning] code [1] signal [null] cwd [azure-sdk-for-python]: python
    warn	Not exact 2 reports found:
    warn		code_reports/latest/report.json
    warn	Not generating changelog.
️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from e9ebf9f. Azure CLI Automation 14.0.0
    warn	Skip initScript due to not configured
    command	npx n 12
    command	python3 -m venv venv
    command	pip install --upgrade setuptools wheel pip
    command	pip install pathlib jinja2 msrestazure
    command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/devops/resource-manager/readme.md
    cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudErrorBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationDisplayValue' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'PipelineListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
    cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
    cmdout	[Autorest] WARNING (): Operation Update has already existed in group! Skip split!
    cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
    cmderr	[Autorest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
    cmderr	[Autorest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
    cmderr	[Autorest] --------------------------------------------------------
    cmderr	[Autorest]   test-scenario:
    cmderr	[Autorest]     - name: /Pipelines/put/Create an Azure pipeline to deploy a sample ASP.Net application to Azure web-app
    cmderr	[Autorest]     - name: /Pipelines/get/Get an existing Azure pipeline
    cmderr	[Autorest]     - name: /Pipelines/get/List all Azure Pipelines under the specified resource group
    cmderr	[Autorest]     - name: /Pipelines/get/List all Azure pipelines under the specified subscription
    cmderr	[Autorest]     - name: /Pipelines/patch/Get an existing Azure pipeline
    cmderr	[Autorest]     - name: /Pipelines/delete/Get an existing Azure pipeline
    cmderr	[Autorest]     - name: /PipelineTemplateDefinitions/get/Get the list of pipeline template definitions
    cmderr	[Autorest] --------------------------------------------------------
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from e9ebf9f. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    cmderr	[generate.py] 2020-12-24 05:17:54 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-devops"
    cmderr	[generate.py] 2020-12-24 05:17:54 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
    cmderr	[generate.py] 2020-12-24 05:17:54 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.6 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/devops/azure-resourcemanager-devops --java.namespace=com.azure.resourcemanager.devops  --package-version=1.0.0-beta.1 --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --pipeline.modelerfour.flatten-payloads=false --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/devops/resource-manager/readme.md
    cmderr	[generate.py] 2020-12-24 05:18:38 INFO [CI][Success] Write to ci.yml
    cmderr	[generate.py] 2020-12-24 05:18:38 INFO [POM][Process] dealing with pom.xml
    cmderr	[generate.py] 2020-12-24 05:18:38 INFO [POM][Success] Write to pom.xml
    cmderr	[generate.py] 2020-12-24 05:18:38 INFO [POM][Process] dealing with root pom
    cmderr	[generate.py] 2020-12-24 05:18:38 INFO [POM][Success] Write to root pom
    cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
    cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
    cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
    cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
    cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
  • ️✔️azure-resourcemanager-devops [View full logs]  [Release SDK Changes]
    cmderr	[Inst] 2020-12-24 05:20:38 DEBUG Got artifact_id: azure-resourcemanager-devops
    cmderr	[Inst] 2020-12-24 05:20:38 DEBUG Got artifact: pom.xml
    cmderr	[Inst] 2020-12-24 05:20:38 DEBUG Got artifact: azure-resourcemanager-devops-1.0.0-beta.1.jar
    cmderr	[Inst] 2020-12-24 05:20:38 DEBUG Match jar package: azure-resourcemanager-devops-1.0.0-beta.1.jar
    cmderr	[Inst] 2020-12-24 05:20:38 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/11585/azure-sdk-for-java/azure-resourcemanager-devops/azure-resourcemanager-devops-1.0.0-beta.1.jar\" -o azure-resourcemanager-devops-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-devops -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-devops-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
    ```"}
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from e9ebf9f. SDK Automation 14.0.0
    command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️preview/devops/mgmt/2020-07-13-preview/devops [View full logs]  [Release SDK Changes]
    info	[Changelog] This is a new package
  • ️✔️preview/devops/mgmt/2019-07-01-preview/devops [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from e9ebf9f. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/devops/resource-manager/readme.md
  • ️✔️@azure/arm-devops [View full logs]  [Release SDK Changes]
    cmderr	[npmPack] loaded rollup.config.js with warnings
    cmderr	[npmPack] (!) Unused external imports
    cmderr	[npmPack] default imported from external module 'rollup' but never used
    cmderr	[npmPack] ./esm/devOpsClient.js → ./dist/arm-devops.js...
    cmderr	[npmPack] created ./dist/arm-devops.js in 247ms
️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@suyash691
Copy link
Contributor Author

Already approved on private branch. Recreated PR as per recommendation from ARM team

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Nov 9, 2020

azure-sdk-for-python

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 0e38886 with merge commit 10f1d36c7dbbd15f4dc8e2eba9b32ebfce15d3eb. SDK Automation 13.0.17.20200918.2
    [azure-mgmt-devops][ChangeLog] WARNING: Failed to generate ChangeLog.
  • ⚠️azure-mgmt-devops [View full logs]  [Preview SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-devops
    [build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-devops
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-devops
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /z/venv/lib/python3.6/site-packages/setuptools/dist.py:406: UserWarning: The version specified ('2020-07-13-preview') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details.
    [build_package]   "details." % self.metadata.version
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /z/venv/lib/python3.6/site-packages/setuptools/dist.py:406: UserWarning: The version specified ('2020-07-13-preview') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details.
    [build_package]   "details." % self.metadata.version
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    Not exact 2 reports found:
    code_reports/latest/report.json
    Not generating changelog.
    [ChangeLog] WARNING: Failed to generate ChangeLog.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Nov 9, 2020

azure-resource-manager-schemas

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 0e38886 with merge commit 10f1d36c7dbbd15f4dc8e2eba9b32ebfce15d3eb. Schema Automation 13.0.17.20200918.2
    [devops][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    [devops][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    [devops][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
  • ️✔️devops [View full logs]  [Preview Schema Changes]
      [after_scripts|node] PostProcessor finished successfully.
      [after_scripts|node]   5826 passing (1m)
      AzureResourceSchema has no registered package commands.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 9, 2020

    azure-sdk-for-go

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 9, 2020

    azure-sdk-for-python-track2

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 9, 2020

    Trenton Generation

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 0e38886 with merge commit 10f1d36c7dbbd15f4dc8e2eba9b32ebfce15d3eb. Trenton Automation 13.0.17.20200918.2
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudErrorBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationDisplayValue' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PipelineListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
      [AutoRest] WARNING (): 'cli.flatten.cli-flatten-set-enabled' is not set to true, skip flattenSetter
      [AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
      [AutoRest] WARNING: cannot find gosdk folder in readme.trenton.md:
      Failed to find any changed packages. Please check the changed file list.
      /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2019-07-01-preview/devops/client.go
      /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2019-07-01-preview/devops/devopsapi/interfaces.go
      /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2019-07-01-preview/devops/enums.go
      /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2019-07-01-preview/devops/models.go
      /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2019-07-01-preview/devops/operations.go
      /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2019-07-01-preview/devops/pipelines.go
      /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2019-07-01-preview/devops/pipelinetemplatedefinitions.go
      /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2019-07-01-preview/devops/version.go
      /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2020-07-13-preview/devops/client.go
      /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2020-07-13-preview/devops/devopsapi/interfaces.go
      /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2020-07-13-preview/devops/enums.go
      /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2020-07-13-preview/devops/models.go
      /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2020-07-13-preview/devops/operations.go
      /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2020-07-13-preview/devops/pipelines.go
      /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2020-07-13-preview/devops/pipelinetemplatedefinitions.go
      /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2020-07-13-preview/devops/version.go

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 9, 2020

    azure-sdk-for-java

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 0e38886 with merge commit 10f1d36c7dbbd15f4dc8e2eba9b32ebfce15d3eb. SDK Automation 13.0.17.20200918.2
      Failed to find any diff after autorest so no changed packages was found.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Nov 9, 2020

    azure-sdk-for-net

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 0e38886 with merge commit 10f1d36c7dbbd15f4dc8e2eba9b32ebfce15d3eb. SDK Automation 13.0.17.20200918.2
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.DevOps [View full logs]  [Preview SDK Changes]
        No Artifact Generated.

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Nov 9, 2020

      azure-sdk-for-js

      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from 0e38886 with merge commit 10f1d36c7dbbd15f4dc8e2eba9b32ebfce15d3eb. SDK Automation 13.0.17.20200918.2
      • ️✔️@azure/arm-devops [View full logs]  [Preview SDK Changes]
        [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
        [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
        [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
        [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
        [npmPack] loaded rollup.config.js with warnings
        [npmPack] (!) Unused external imports
        [npmPack] default imported from external module 'rollup' but never used
        [npmPack] 
        [npmPack] ./esm/devOpsClient.js → ./dist/arm-devops.js...
        [npmPack] created ./dist/arm-devops.js in 249ms
        [npmPack] npm notice 
        [npmPack] npm notice package: @azure/arm-devops@1.0.0
        [npmPack] npm notice === Tarball Contents === 
        [npmPack] npm notice 42.3kB dist/arm-devops.js                                    
        [npmPack] npm notice 13.9kB dist/arm-devops.min.js                                
        [npmPack] npm notice 1.5kB  esm/devOpsClient.js                                   
        [npmPack] npm notice 2.5kB  esm/devOpsClientContext.js                            
        [npmPack] npm notice 263B   esm/models/index.js                                   
        [npmPack] npm notice 372B   esm/operations/index.js                               
        [npmPack] npm notice 14.2kB esm/models/mappers.js                                 
        [npmPack] npm notice 2.2kB  esm/operations/operations.js                          
        [npmPack] npm notice 355B   esm/models/operationsMappers.js                       
        [npmPack] npm notice 1.5kB  esm/models/parameters.js                              
        [npmPack] npm notice 9.6kB  esm/operations/pipelines.js                           
        [npmPack] npm notice 521B   esm/models/pipelinesMappers.js                        
        [npmPack] npm notice 2.4kB  esm/operations/pipelineTemplateDefinitions.js         
        [npmPack] npm notice 435B   esm/models/pipelineTemplateDefinitionsMappers.js      
        [npmPack] npm notice 888B   rollup.config.js                                      
        [npmPack] npm notice 1.6kB  package.json                                          
        [npmPack] npm notice 457B   tsconfig.json                                         
        [npmPack] npm notice 91.1kB dist/arm-devops.js.map                                
        [npmPack] npm notice 13.6kB dist/arm-devops.min.js.map                            
        [npmPack] npm notice 666B   esm/devOpsClient.d.ts.map                             
        [npmPack] npm notice 791B   esm/devOpsClient.js.map                               
        [npmPack] npm notice 491B   esm/devOpsClientContext.d.ts.map                      
        [npmPack] npm notice 1.4kB  esm/devOpsClientContext.js.map                        
        [npmPack] npm notice 5.6kB  esm/models/index.d.ts.map                             
        [npmPack] npm notice 181B   esm/operations/index.d.ts.map                         
        [npmPack] npm notice 126B   esm/models/index.js.map                               
        [npmPack] npm notice 195B   esm/operations/index.js.map                           
        [npmPack] npm notice 991B   esm/models/mappers.d.ts.map                           
        [npmPack] npm notice 8.2kB  esm/models/mappers.js.map                             
        [npmPack] npm notice 1.0kB  esm/operations/operations.d.ts.map                    
        [npmPack] npm notice 1.4kB  esm/operations/operations.js.map                      
        [npmPack] npm notice 202B   esm/models/operationsMappers.d.ts.map                 
        [npmPack] npm notice 215B   esm/models/operationsMappers.js.map                   
        [npmPack] npm notice 445B   esm/models/parameters.d.ts.map                        
        [npmPack] npm notice 1.2kB  esm/models/parameters.js.map                          
        [npmPack] npm notice 3.5kB  esm/operations/pipelines.d.ts.map                     
        [npmPack] npm notice 5.5kB  esm/operations/pipelines.js.map                       
        [npmPack] npm notice 305B   esm/models/pipelinesMappers.d.ts.map                  
        [npmPack] npm notice 318B   esm/models/pipelinesMappers.js.map                    
        [npmPack] npm notice 1.1kB  esm/operations/pipelineTemplateDefinitions.d.ts.map   
        [npmPack] npm notice 1.5kB  esm/operations/pipelineTemplateDefinitions.js.map     
        [npmPack] npm notice 259B   esm/models/pipelineTemplateDefinitionsMappers.d.ts.map
        [npmPack] npm notice 272B   esm/models/pipelineTemplateDefinitionsMappers.js.map  
        [npmPack] npm notice 3.1kB  README.md                                             
        [npmPack] npm notice 1.1kB  esm/devOpsClient.d.ts                                 
        [npmPack] npm notice 1.6kB  src/devOpsClient.ts                                   
        [npmPack] npm notice 860B   esm/devOpsClientContext.d.ts                          
        [npmPack] npm notice 2.3kB  src/devOpsClientContext.ts                            
        [npmPack] npm notice 14.3kB esm/models/index.d.ts                                 
        [npmPack] npm notice 141B   esm/operations/index.d.ts                             
        [npmPack] npm notice 13.7kB src/models/index.ts                                   
        [npmPack] npm notice 340B   src/operations/index.ts                               
        [npmPack] npm notice 1.2kB  esm/models/mappers.d.ts                               
        [npmPack] npm notice 11.3kB src/models/mappers.ts                                 
        [npmPack] npm notice 2.1kB  esm/operations/operations.d.ts                        
        [npmPack] npm notice 4.1kB  src/operations/operations.ts                          
        [npmPack] npm notice 127B   esm/models/operationsMappers.d.ts                     
        [npmPack] npm notice 317B   src/models/operationsMappers.ts                       
        [npmPack] npm notice 481B   esm/models/parameters.d.ts                            
        [npmPack] npm notice 1.6kB  src/models/parameters.ts                              
        [npmPack] npm notice 9.2kB  esm/operations/pipelines.d.ts                         
        [npmPack] npm notice 17.6kB src/operations/pipelines.ts                           
        [npmPack] npm notice 293B   esm/models/pipelinesMappers.d.ts                      
        [npmPack] npm notice 502B   src/models/pipelinesMappers.ts                        
        [npmPack] npm notice 2.3kB  esm/operations/pipelineTemplateDefinitions.d.ts       
        [npmPack] npm notice 4.5kB  src/operations/pipelineTemplateDefinitions.ts         
        [npmPack] npm notice 207B   esm/models/pipelineTemplateDefinitionsMappers.d.ts    
        [npmPack] npm notice 384B   src/models/pipelineTemplateDefinitionsMappers.ts      
        [npmPack] npm notice 1.1kB  LICENSE.txt                                           
        [npmPack] npm notice === Tarball Details === 
        [npmPack] npm notice name:          @azure/arm-devops                       
        [npmPack] npm notice version:       1.0.0                                   
        [npmPack] npm notice filename:      azure-arm-devops-1.0.0.tgz              
        [npmPack] npm notice package size:  42.3 kB                                 
        [npmPack] npm notice unpacked size: 330.1 kB                                
        [npmPack] npm notice shasum:        026123f2127be43d54326f2cf9cc642475835a25
        [npmPack] npm notice integrity:     sha512-42UIziWymw/eQ[...]XPwRRxbyxLknA==
        [npmPack] npm notice total files:   69                                      
        [npmPack] npm notice 

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Nov 9, 2020

      Azure CLI Extension Generation

      • Installation instruction for service devops [Preview Changes]
        curl -L "https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/azure-rest-api-specs/11585/azure-cli-extensions/devops/devops-0.1.0-py3-none-any.whl" -o devops-0.1.0-py3-none-any.whl
        az extension add --source=devops-0.1.0-py3-none-any.whl
        
      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from 0e38886 with merge commit 10f1d36c7dbbd15f4dc8e2eba9b32ebfce15d3eb. Azure CLI Automation 13.0.17.20200918.2
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudErrorBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationDisplayValue' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PipelineListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
        [AutoRest] WARNING (): Operation Update has already existed in group! Skip split!
        [AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
        [AutoRest] 
        [AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
        [AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
        [AutoRest] --------------------------------------------------------
        [AutoRest]   test-scenario:
        [AutoRest]     - name: /Pipelines/put/Create an Azure pipeline to deploy a sample ASP.Net application to Azure web-app
        [AutoRest]     - name: /Pipelines/get/Get an existing Azure pipeline
        [AutoRest]     - name: /Pipelines/get/List all Azure Pipelines under the specified resource group
        [AutoRest]     - name: /Pipelines/get/List all Azure pipelines under the specified subscription
        [AutoRest]     - name: /Pipelines/patch/Get an existing Azure pipeline
        [AutoRest]     - name: /Pipelines/delete/Get an existing Azure pipeline
        [AutoRest]     - name: /PipelineTemplateDefinitions/get/Get the list of pipeline template definitions
        [AutoRest] --------------------------------------------------------

      @suyash691
      Copy link
      Contributor Author

      @chiragg4u Created new PR as per your recommendation here ->
      #11325

      @openapi-workflow-bot
      Copy link

      Hi, @suyash691 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

    • Please ensure to do self-check against checklists in first PR comment.
    • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
    • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

      @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 9, 2020
      @openapi-workflow-bot
      Copy link

      Hi, @suyash691 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @weidongxu-microsoft

      @weidongxu-microsoft
      Copy link
      Member

      @suyash691 Let us know the approved private PR. That will save a lot of time.

      @suyash691
      Copy link
      Contributor Author

      @weidongxu-microsoft
      Copy link
      Member

      weidongxu-microsoft commented Nov 11, 2020

      @suyash691
      Thanks. Let me know when you plan to get this merged.

      @pilor
      This should be same as approved private PR Azure/azure-rest-api-specs-pr#1648 . Let me know if we can skip ARM review on this PR.

      @suyash691
      Copy link
      Contributor Author

      @weidongxu-microsoft The changes in production to support this API are live so whenever @pilor and @bishal-pdMSFT confirm their approval, you can go ahead with the merge

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 2 pipeline(s).

      @suyash691
      Copy link
      Contributor Author

      @weidongxu-microsoft @PhoenixHe-msft I added system data in the latest commit but still it is unable to detect system data in the response

      @weidongxu-microsoft
      Copy link
      Member

      @suyash691
      I've added Jeffrey for guidance on cross api-version change.

      For system data, I think it need to be directly under Pipeline model, not its properties property. E.g. https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-contracts.md#system-metadata-for-all-azure-resources

      @suyash691
      Copy link
      Contributor Author

      suyash691 commented Dec 23, 2020

      @suyash691
      I've added Jeffrey for guidance on cross api-version change.

      For system data, I think it need to be directly under Pipeline model, not its properties property. E.g. https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-contracts.md#system-metadata-for-all-azure-resources

      Fixed the systemData related error
      @weidongxu-microsoft It seems that this time python CI didn't fail. Maybe the CI was has been patched to ignore cross version breaking changes (as it should) or does applying the "breakingchange" tag in the repo cause it to not run completely?

      @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Dec 23, 2020
      @weidongxu-microsoft
      Copy link
      Member

      weidongxu-microsoft commented Dec 24, 2020

      @suyash691

      python CI build fail weeks ago is actually a bug on Swagger team. It is not your fault at all (that was why I pinged Arthur and Phoenix to merge/fix). I figure Swagger team fixed it last week.

      The cross api-version validation is not very reliable (it got some false alerts), hence it reports as warning but not blocks the PR. We just being cautious on any removal of API/parameter/property. Since Jeffrey approved it you are OK to go.

      Let me know when you need it merged.

      @suyash691
      Copy link
      Contributor Author

      suyash691 commented Dec 24, 2020

      You can merge it today, we are ready with the changes on our RP
      @weidongxu-microsoft Thanks for following up on this actively

      @weidongxu-microsoft weidongxu-microsoft merged commit e9ebf9f into Azure:master Dec 24, 2020
      xiangyan99 added a commit that referenced this pull request Jan 5, 2021
      * [Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-06-01 (#11833)
      
      * Changing Swagger file
      
      * Changing examples
      
      * Fixing tags example
      
      * Fixing tags example
      
      * Fixing tags example
      
      * prettier fix for white spaces
      
      * Enable azure-sdk-for-net-track2 (#12169)
      
      * Updating existing CRR APIs with zone restore feature (#12157)
      
      * - Added change for support of cross zone restores.
      
      * - updating example json
      
      * - Fixing prettier
      
      * lastUpdatedDate for templates (#11900)
      
      * lastUpdatedDate for templates
      
      * fix
      
      * [Hub Generated] Review request for Microsoft.AppPlatform to add version preview/2020-11-01-preview (#11823)
      
      * Adds base for updating Microsoft.AppPlatform from version stable/2020-07-01 to version 2020-11-01-preview
      
      * Updates readme
      
      * Updates API version in new specs and examples
      
      * Introduce additional change to 2020-11-01-preview.
      
      * Additional properties to monitoringSettings.
      * Readonly properties to requiredTraffics.
      
      Signed-off-by: Pan Li <panli@microsoft.com>
      
      * Make credscan happy.
      
      Signed-off-by: Pan Li <panli@microsoft.com>
      
      * [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 (#12113)
      
      * Fix linter and swagger warnings
      
      * Fix errors
      
      * Removed unneeded change
      
      * [ASC.Automations] Add new data type "RegulatoryComplianceAssessment" (#12185)
      
      * Add SubAssessment event source type and add more automations examples
      
      * Change Location isReadOnlu to false
      
      * Test
      
      * Add new read/write location and add new type TrackedResourceLocation
      
      * Minor
      
      * minor
      
      * prettier fixes
      
      * Change variable name to TrackedResourceLocation
      
      * Change type name TrackedResourceLocation to AzureTrackedResourceLocation
      
      * Update automations example
      
      * Add SecureScores & SecureScoreControls as new supported datatypes in Automations resource
      
      * [ASC.Automations] add new data type RegulatoryComplianceAssessment
      
      * add datalake store track2 config (#12186)
      
      * cleanup old pipeline dependencies (#11889)
      
      * cleanup pipeline deps
      
      * add rest-api-specs-scripts
      
      * Extending recovery network input in replication intent API to support new network creation (#12191)
      
      * [Hub Generated] Review request for Microsoft.Maps to add version preview/2020-02-01-preview (#12172)
      
      * Adding operations for Maps Creator resource.
      
      * Fixing typo.
      
      * Adds suppression to readme
      
      * Adds suppression to readme
      
      * Adds suppression to readme
      
      * Adds suppression to readme
      
      * Resolving linter errors.
      
      * Minor update.
      
      * Updating all reference to v2 schema.
      
      * Marked private atlas as deprecated in description.
      
      * add operationsmanagement track2 config (#12141)
      
      * Update comment.yml (#12202)
      
      Add ARM traffic query link. When add breakingChangeReviewRequired
      
      * Adding new properties to response body (#12201)
      
      * adding new properties
      
      * updating examples
      
      * prettier fix
      
      * [Hub Generated] Review request for Microsoft.ContainerService to add version stable/2020-12-01 (#12064)
      
      * Add autorest.az configurations for azure monitor control service (#12090)
      
      * add AMCS config for codegen
      
      * reorganize command group
      
      * rename command group
      
      * Codegen modify try to rename DataCollectionRules create parameters
      
      * hide DataCollectionRules Create & Update commands and DataCollectionRuleAssociations Create command
      
      * use alias instand of rename in code-gen
      
      * use monitor-control-service as the extension name
      
      * Update readme.python.md
      
      * add logic track2 config (#12166)
      
      * add alertsmanagement track2 config (#11759)
      
      * Update comment.yml (#12213)
      
      * add mixedreality track2 confi (#12070)
      
      * add signalr track2 config (#11892)
      
      * add cognitiveservice track2 config (#11498)
      
      * add machinglearningservices track2 config (#12183)
      
      * add apimanagement track2 config (#12187)
      
      * add serialconsole track2 config (#12046)
      
      * Update TransparentDataEncryption Group Name (#12160)
      
      * update TransparentDataEncryption Group name
      
      * update reference of TransparentDataEncryption
      
      * Update readme.python.md (#12216)
      
      * Required changes for Azure HealthBot swagger (#12124)
      
      * Fixes for SDK generation files.
      
      * Fixes for SDK generation files.
      
      * Added GO.
      
      * Change Healthcare bot to Healthbot.
      
      * 1. Remove unused properties of SKU.
      2. Removed unused CheckNameAvailability.json
      3. Remove subgroup.
      
      * Sku is required.
      
      * [Hub Generated] Review request for Microsoft.IoTCentral to add version stable/2018-09-01 (#12224)
      
      * update to name
      
      * update
      
      * add api-version of guest configuration to go SDK (#12217)
      
      * add api-version for templatespecs (#12197)
      
      * Update specificationRepositoryConfiguration.json (#12218)
      
      * Adding new api version to devops RP (#11585)
      
      * Initial commit as per PR review
      
      * Actual changes to api spec for new version
      
      * Switching to multi-api build for python
      
      * Fix python spec to correct namespaces in multiapi mode
      
      * Revert changes to python generation
      
      * Add systemdata
      
      * Fix the path for sys data reference
      
      * Fix path once more
      
      * remove additional properties after including systemdata
      
      * Remove more addtional properties
      
      * Move system data to root
      
      * Fix wrong output-folder (#12229)
      
      * Remove swagger and examples because the controller will be used for private preview. (#12177)
      
      * Update pull_request_assignment.yml (#12230)
      
      * [Hub Generated] Review request for Microsoft.StorageCache to add version stable/2020-10-01 (#11407)
      
      * Init the next version so diffs can work better.
      
      * Updates readme
      
      * Updates API version in new specs and examples
      
      * Updates to StorageTargetProperties and added examples of cmk, mtu
      
      Add 202 to the storage cache and storage target create/update and update examples
      
      Fix ST no junction example's 202 response.
      
      add properties for nfs extended groups
      
      fix issues with extended groups properties found with autorest
      
      add properties and objects for Active Directory username download
      
      undo unintended change
      
      changes from comments in pull request
      
      AccessPolicy support.
      
      Example fixes for Access Policies.
      
      Fix attribute names to match latest RP.
      
      update to credential properties for LDAP and Active Directory
      
      marking password properties with x-ms-secret tag
      
      minor changes on extended groups and add examples
      
      Added blob NFS and some other validation fixes.
      
      Update required property for domainName from dnsName
      
      Updated blobNfs examples and some kpi fixes.
      
      Correct validation errors in examples.
      
      Added systemdata to resources.
      
      Remove x-ms-secret in keyvault reference due to linter error and common types not using it.
      
      Remove blobNfs from this version.
      
      Remove blobNfs from spec file.
      
      Remove x-ms-secret due to linter errors.
      
      Fix certificate spelling.
      
      Updating prettier and spell check errors.
      
      Used prettier on main spec file.
      
      Readded x-ms-secret that open api hub failed on but the PR pipeline allows.
      
      * Add prettier fix after rebase
      
      * Remove 202 bodies and add systemData to examples.
      
      * Update spec with prettier.
      
      * Address comments on spec for descriptions, readmes, and extendedGroupsEnabled.
      
      * Updating to address addition ldap and pattern comments.
      
      * Update version tag to include 01
      
      * Restore changes that would be considered breaking changes matching 2020-03-01
      
      * Address a few other comments.
      
      * Update netbios field names and some descriptions.
      
      * Fix s360 for missing debugInfo operation.
      
      * Fix credscan error in example file.
      
      * Update required fields, new validator failure on debugInfo return codes, and bindPassword example value.
      
      * Update debug info example with new return codes.
      
      * Update other credscan password errors.
      
      * Update Semantic-and-Model-Violations-Reference.md (#12199)
      
      Adding secret_property code, update some other codes.
      
      * ADP - add system metadata to dataPool (#12179)
      
      * Swagger Linting Fix (#12162)
      
      * Fix Linting Issuing
      
      * no message
      
      * fix description
      
      * add description and object back
      
      * test to resolve model validation test
      
      (cherry picked from commit ab273df)
      
      * [SQL][V20180601] Updating LocationCapabilities spec (#12032)
      
      * [SQL][V20180601] Updating LocationCapabilities spec
      
      * Fill 2020 versions
      
      * Rollback V2018 changes and bump LocationCapabilities in V4 to 2020-08-01-preview
      
      * update order for CI-FixRequiredOnFailure (#12227)
      
      * update rdbms track2 config (#12245)
      
      * ADT: refix path (#12161)
      
      * python track2 configure (#12150)
      
      * Add and remove owner for service principals (#12081)
      
      * [Hub Generated] Review request for Microsoft.MixedReality to add version stable/2020-05-01 (#11810)
      
      * fix spec
      
      * fix prettier
      
      * [Hub Generated] Review request for Microsoft.MixedReality to add version preview/2019-12-02-preview (#11769)
      
      * fix for swagger completeness
      
      * forgot curly brace
      
      * fix example
      
      * Api Management - make /tenant endpoints ARM compliant in 2020-06-01-preview version (#11549)
      
      * Adds base for updating Microsoft.ApiManagement from version stable/2019-12-01 to version 2020-06-01-preview
      
      * Updates readme
      
      * Updates API version in new specs and examples
      
      * Add support in API Management for Availability Zones (#10284)
      
      * apim in azs
      
      * fix prettier check
      
      * PATCH should return 200 OK (#10328)
      
      * add support for PATCH returning 200 OK
      
      * CI fixes
      
      prettier fix
      
      CI fixes part 2
      
      * Password no longer a mandatory property when uploading Certificates
      
      * add missing x-ms-odata extension for filter support
      
      * +gatewayhostnameconfiguration protocol changes (#10292)
      
      * [2020-06-01-preview] Update Oauth Server secrets Contract (#10602)
      
      * Oauth server secrets contract
      
      * fix azureMonitor enum
      
      * API Management Service Deleted Services Resource (#10607)
      
      * API Management Service Deleted Services Resource
      
      * Path fix
      
      * Lint + custom-words fixes
      
      * Location URI parameter for deletedservices Resource
      
      * GET for deletedservices by service name
      
      * Remove resourceGroupName from resource path
      
      * fixes
      
      * schema for purge operation
      
      * perttier applied
      
      * 204 response code added
      
      Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com>
      
      * OperationNameFormat property added to Diagnostic contract (#10641)
      
      * OperationNameFormat property added to Diagnostic contract
      
      * add azuremonitor to update contract
      
      Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com>
      
      * [Microsoft.ApiManagement][2020-06-01-preview] Change Network Status response contract (#10331)
      
      * Change Network Status response contract
      
      * Update examples for network status contract
      
      * ApiManagement - tenant/settings endpoints
      
      * ApiManagement - tenant/settings endpoints fix
      
      * ApiManagement - tenant/settings endpoints fix prettier
      
      * ApiManagement - tenant/settings endpoints fix 3
      
      * ApiManagement - tenant/settings endpoints fix 4
      
      * ApiManagement - tenant/settings endpoints fix 5
      
      Co-authored-by: Samir Solanki <samirsolanki@outlook.com>
      Co-authored-by: maksimkim <maksim.kim@gmail.com>
      Co-authored-by: promoisha <feoktistovgg@gmail.com>
      Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com>
      Co-authored-by: RupengLiu <rliu1211@terpmail.umd.edu>
      Co-authored-by: vfedonkin <vifedo@microsoft.com>
      
      * Add "mail" parameter to UserUpdateParameters in graphrbac (#12127)
      
      This patch adds a single optional field "mail" to UserUpdateParameters
      schema. This makes it possible to update user's e-mail address using
      the (Go) Azure SDK. Currently this is not possible.
      
      I have curled the graphrbac API with the extra body parameter and it
      works as expected.
      
      Addition of the field will make it possible to support the mail property
      on the azuread_user resource in terraform-provider-azuread.
      
      Co-authored-by: David Čepelík <david.cepelik@showmax.com>
      
      * [Hub Generated] Review request for Microsoft.Advisor to add version stable/2020-01-01 (#12262)
      
      * add resourcegraph track2 config (#12122)
      
      * add reservations track2 config (#12027)
      
      * Removing a readonly tag from a property (#12254)
      
      * Fix swagger correctness errors (#12246)
      
      * Fix swagger correctness issues in Security for Iot service
      
      * changed int format from 32 to 64
      
      * Add systemData to iotSecuritySolutions
      
      Co-authored-by: Liran Chen <lirche@microsoft.com>
      
      * [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 (#12196)
      
      * AAS - Swagger Linting and Correctness Fix (#12176)
      
      * Fix R4013 IntegerTypeMustHaveFormat
      
      * Fix R4010 RequiredDefaultResponse
      
      * Fix R4007 DefaultErrorResponseSchema
      
      * removed extra bracket
      
      * fix semantic issue
      
      * add type error
      
      * Fix linting issue
      
      * test to resolve model validation test
      
      * Revert "test to resolve model validation test"
      
      This reverts commit ab273df.
      
      * Resolve Model Validation Issue
      
      * Resolve Model Validation Issue v2
      
      * test - add missing properties
      
      (cherry picked from commit 48ec27c)
      
      * fix format
      
      * set default value
      
      * add x-ms-enum
      
      * fix nit
      
      * Add missing property
      
      * add missing properties
      
      * add missing bracket
      
      * change GatewayListStatusLive type
      
      * add missing "origin" property
      
      * fix model validation
      
      * Revert "change GatewayListStatusLive type"
      
      This reverts commit 4f3fa74.
      
      * Revert "fix model validation"
      
      This reverts commit 945bc23.
      
      * add redhatopenshift track2 config (#12045)
      
      * [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-10-01 (#12194)
      
      * Adding nextLink and previousLink to Tags endpoint properties
      
      * moving properties out
      
      * prettier check fix
      
      Co-authored-by: Jorge Chavez Nieto <jochav@microsoft.com>
      
      * add relay track2 config (#11495)
      
      * update healthbot t2 config (#12269)
      
      * update healthbot t2 config
      
      * fix readme
      
      * add automation track2 config (#11628)
      
      * add automation track2 config
      
      * update config
      
      * Azure Remote Rendering REST API swagger file - for review (#12015)
      
      * Azure Remote Rendering API specifcation
      
      * fix schema issue
      
      * fix examples
      
      * fix request bodies integer values, :stop path
      
      * pointing readme.md to open api spec for ARR
      
      * fix typo, add custom words
      
      * add msvc to custom words
      
      * fix readme.md
      
      * ran prettifier
      
      * fix reference to json
      
      * reference sts from file as well
      
      * fix readme.md
      
      * changes to readme.md
      
      * remove example from error to fix error
      
      * add 200 OK status for retried PUT for conversions and sessiosn
      
      * ran prettier
      
      * make autorest linter not crash
      
      * fix casing of nextLinkName paramter
      
      * factor out conversion list response
      
      * add examples for conversions
      
      * adding examples for sessions, prettify files
      
      * [Hub Generated] Review request for Microsoft.Maps/Microsoft.Maps to add version preview/2.0 (#12175)
      
      * microsoft.imagery 512 not supported
      
      Adding micorosft.imagery to 512 tile not supported list
      
      * Updating Raster Tilesets to Have Max Zoom 22
      
      Certain raster tilesets now support up to zoom level 22.
      
      * minor changes to swagger (#12253)
      
      * minor changes to swagger
      
      * reverting sdk definitions file
      
      * Add addons to AVS 2020-07-17-preview (#12236)
      
      * found missing AVS/privateclouds/addons commit, moving it to 2020-07-17-preview API from PR repo
      
      * fixed prettier errors
      
      * Fixed vladation warnings for x-ms-enum and missing description/title, related to addons
      
      * fixed validation error for missing systemData for addons responses
      
      * fixed prettier errors
      
      * fixed validation error for missing systemData for addons responses
      
      * systemData for any Resource
      
      * make sure systemData is readOnly
      
      * systemData needs to go in a new api version
      
      * suppress systemData error
      
      Co-authored-by: Cameron Taggart <cameron.taggart@microsoft.com>
      
      * Azs api bug fix (#12133)
      
      * Old api version for ComputeOperationResult
      
      * Api Bugfix for Azure Stack Fabric Admin
      
      * Fix for typo in readme
      
      * Add default reponse
      
      * Fix example issue for default error
      
      * Update comment.yml (#12273)
      
      * [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2019-11-01 (#12031)
      
      * fix dataSet typo
      
      * fix dimensions and tags typo
      
      * more dimensions and tags to fix
      
      * one more miss on dimensions and tags
      
      * Add the includeMonetaryCommitment missing field
      
      * fix spell check error
      
      * make property read only
      
      * remove the not operation from query filters
      
      * New backup service api version (#12171)
      
      * Initial commit: adding new api version
      
      * - new api 2020-12-01
      
      * updating the readme.md package reference
      
      * - adding the zone information for new api
      
      * - updating api-version in examples
      - added 'zone' in Get recoverypoint api example json
      
      * Fixing prettier issue
      
      * Revert "- updating api-version in examples"
      
      This reverts commit 80baa9f.
      
      * - adding api-version in examples
      
      * adding new api version in package mds
      
      * [IotHub] Introducing networkRuleSets in IotHubProperties [2020-08-31 : preview and stable ] (#10853)
      
      * Adds base for updating Microsoft.Devices from version preview/2020-07-10-preview to version 2020-08-31-preview
      
      * Updates readme
      
      * Updates API version in new specs and examples
      
      * Adds base for updating Microsoft.Devices from version stable/2020-08-01 to version 2020-08-31
      
      * Updates readme
      
      * Updates API version in new specs and examples
      
      * Adding networkRuleSets support for iothub
      
      * Adding networkRuleSets Support in preview version
      
      * Adding Examples, correcting order in iothub.json
      
      * Updating Readme to have stable and previe versions
      
      * Modifying Tag to package-2020-08-31
      
      * Adding Arm identity properties from 2020-07-010-preview version
      
      * Removing creds
      
      * minor fix
      
      * swagger correctness fix (#12101)
      
      * swagger correctness fix
      
      * update preview version too
      
      * Revert change and add defaults (#12243)
      
      * Remove gallery preview version 2020-09-30 from stable release (#12222)
      
      * add managementpartner track2 config (#12043)
      
      * [Hub Generated] Review request for Microsoft.Insights to add version stable/2019-03-01 (#12232)
      
      * Fixed swagger validations for api version 2019
      
      * reverted error response change and suppress
      
      * removed redundant error details
      
      * renamed suppression rule
      
      * fixed suppression
      
      Co-authored-by: napolish <67951636+napolish@users.noreply.github.com>
      Co-authored-by: Phoenix He <tih@microsoft.com>
      Co-authored-by: arpja <46751982+arpja@users.noreply.github.com>
      Co-authored-by: ShaniFelig <74960756+ShaniFelig@users.noreply.github.com>
      Co-authored-by: Pan Li <Incarnation-p-lee@users.noreply.github.com>
      Co-authored-by: Zach Rathbun <zachra@microsoft.com>
      Co-authored-by: surashed <55134940+surashed@users.noreply.github.com>
      Co-authored-by: Kaihui (Kerwin) Sun <sunkaihuisos@gmail.com>
      Co-authored-by: Zhenglai Zhang <darinzh@microsoft.com>
      Co-authored-by: om-nishant <50401171+om-nishant@users.noreply.github.com>
      Co-authored-by: Ihar Voitka <ihvo@users.noreply.github.com>
      Co-authored-by: Ruoxuan Wang <52271048+ruowan@users.noreply.github.com>
      Co-authored-by: Ju Hee Lee <juhee0202@gmail.com>
      Co-authored-by: xiazhan <allan.zhang76@gmail.com>
      Co-authored-by: kai ru <69238381+kairu-ms@users.noreply.github.com>
      Co-authored-by: Ji Wang <jiwang5@microsoft.com>
      Co-authored-by: Andy Zhang <xiazhang@microsoft.com>
      Co-authored-by: guy-microsoft <50947884+guy-microsoft@users.noreply.github.com>
      Co-authored-by: PoAn (Baron) Chen <chen.baron@hotmail.com>
      Co-authored-by: Arcturus <dapzhang@microsoft.com>
      Co-authored-by: suyash691 <suyash691@github.com>
      Co-authored-by: nemijato <68876730+nemijato@users.noreply.github.com>
      Co-authored-by: brpanask <64860651+brpanask@users.noreply.github.com>
      Co-authored-by: Ray Chen <raychen@microsoft.com>
      Co-authored-by: Eli Arbel <aelij@arbel.net>
      Co-authored-by: David Han <76010854+david-msft@users.noreply.github.com>
      Co-authored-by: Roman Khotsyn <rokhot@microsoft.com>
      Co-authored-by: David R. Williamson <drwill@microsoft.com>
      Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
      Co-authored-by: Xinyi Joffre <xiou@microsoft.com>
      Co-authored-by: roytan-microsoft <73565668+roytan-microsoft@users.noreply.github.com>
      Co-authored-by: Vitaliy Fedonkin <vitaliy.fedonkin@gmail.com>
      Co-authored-by: Samir Solanki <samirsolanki@outlook.com>
      Co-authored-by: maksimkim <maksim.kim@gmail.com>
      Co-authored-by: promoisha <feoktistovgg@gmail.com>
      Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com>
      Co-authored-by: RupengLiu <rliu1211@terpmail.umd.edu>
      Co-authored-by: vfedonkin <vifedo@microsoft.com>
      Co-authored-by: David Čepelík <d@dcepelik.cz>
      Co-authored-by: David Čepelík <david.cepelik@showmax.com>
      Co-authored-by: mudit794 <42189950+mudit794@users.noreply.github.com>
      Co-authored-by: Dhawal Jain <41853104+dhawal777@users.noreply.github.com>
      Co-authored-by: MichalHel <51286657+MichalHel@users.noreply.github.com>
      Co-authored-by: Liran Chen <lirche@microsoft.com>
      Co-authored-by: jochav <75458295+jochav@users.noreply.github.com>
      Co-authored-by: Jorge Chavez Nieto <jochav@microsoft.com>
      Co-authored-by: rikogeln <40666347+rikogeln@users.noreply.github.com>
      Co-authored-by: chgennar <56695749+chgennar@users.noreply.github.com>
      Co-authored-by: hivyas <61890270+hivyas@users.noreply.github.com>
      Co-authored-by: Douglas Lee <65295939+leedouglas@users.noreply.github.com>
      Co-authored-by: Cameron Taggart <cameron.taggart@microsoft.com>
      Co-authored-by: LingyunSu <33764806+LingyunSu@users.noreply.github.com>
      Co-authored-by: elabicha <61994320+elabicha@users.noreply.github.com>
      Co-authored-by: Nikhil Kumar Mengani <62704762+nimengan@users.noreply.github.com>
      Co-authored-by: Junbo Wang <juniwang@microsoft.com>
      Co-authored-by: Daniel Orozco <64658732+dagoroz@users.noreply.github.com>
      Co-authored-by: Adam Sandor <adsandor@microsoft.com>
      Co-authored-by: yashmuel <63585146+yashmuel@users.noreply.github.com>
      josuhazure pushed a commit to josuhazure/azure-rest-api-specs that referenced this pull request Jan 6, 2021
      * Initial commit as per PR review
      
      * Actual changes to api spec for new version
      
      * Switching to multi-api build for python
      
      * Fix python spec to correct namespaces in multiapi mode
      
      * Revert changes to python generation
      
      * Add systemdata
      
      * Fix the path for sys data reference
      
      * Fix path once more
      
      * remove additional properties after including systemdata
      
      * Remove more addtional properties
      
      * Move system data to root
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Labels
      Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      8 participants