CosmosDB Restoreable APIs for SQL and MongoDB database account #11428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The child tracked resource, 'graphs' with immediate parent 'GremlinDatabaseGetResults', must have a list by immediate parent operation. New: Microsoft.DocumentDB/preview/2019-08-01-preview/privateEndpointConnection.json#L215 |
|
| The child tracked resource, 'tables' with immediate parent 'DatabaseAccountGetResults', must have a list by immediate parent operation. New: Microsoft.DocumentDB/preview/2019-08-01-preview/privateEndpointConnection.json#L215 |
|
| The child tracked resource, 'privateLinkResources' with immediate parent 'DatabaseAccountGetResults', must have a list by immediate parent operation. New: Microsoft.DocumentDB/preview/2019-08-01-preview/privateEndpointConnection.json#L215 |
|
| The child tracked resource, 'sqlRoleAssignments' with immediate parent 'DatabaseAccountGetResults', must have a list by immediate parent operation. New: Microsoft.DocumentDB/preview/2019-08-01-preview/privateEndpointConnection.json#L215 |
|
| The child tracked resource, 'sqlRoleDefinitions' with immediate parent 'DatabaseAccountGetResults', must have a list by immediate parent operation. New: Microsoft.DocumentDB/preview/2019-08-01-preview/privateEndpointConnection.json#L215 |
|
| The child tracked resource, 'notebookWorkspaces' with immediate parent 'DatabaseAccountGetResults', must have a list by immediate parent operation. New: Microsoft.DocumentDB/preview/2019-08-01-preview/privateEndpointConnection.json#L215 |
|
| The child tracked resource, 'sqlDatabases' with immediate parent 'DatabaseAccountGetResults', must have a list by immediate parent operation. New: Microsoft.DocumentDB/preview/2019-08-01-preview/privateEndpointConnection.json#L215 |
|
| The child tracked resource, 'containers' with immediate parent 'SqlDatabaseGetResults', must have a list by immediate parent operation. New: Microsoft.DocumentDB/preview/2019-08-01-preview/privateEndpointConnection.json#L215 |
|
| The child tracked resource, 'storedProcedures' with immediate parent 'SqlContainerGetResults', must have a list by immediate parent operation. New: Microsoft.DocumentDB/preview/2019-08-01-preview/privateEndpointConnection.json#L215 |
|
| The child tracked resource, 'userDefinedFunctions' with immediate parent 'SqlContainerGetResults', must have a list by immediate parent operation. New: Microsoft.DocumentDB/preview/2019-08-01-preview/privateEndpointConnection.json#L215 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java
|
azure-sdk-for-go
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js
|
azure-sdk-for-python
- Breaking Change detected in SDK
|
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Oct 28, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Oct 29, 2020
MehaKaushik
reviewed
Dec 3, 2020
| "type": "Microsoft.DocumentDB/locations/restorableDatabaseAccounts/restorableSqlContainers", | ||
| "name": "79609a98-3394-41f8-911f-cfab0c075c86", | ||
| "properties": { | ||
| "resource": { |
There was a problem hiding this comment.
I thought we not returning the original resource object anymore.
MehaKaushik
approved these changes
Dec 3, 2020
There was a problem hiding this comment.
LGTM. Few things:
- Please change the title of the PR.
- Are we having two different behaviors for Mongo Collection and Sql container LIST apis. In Sql we are returning the resource as well, but in Mongo we are not. I would recommend to keep both of the behaviors same.
- For sanity check, please download any one of the SDKs (python, go, java) and have a look at the generated code. If anything is missed or not as expected we can change right away.
vinhms
changed the title
|
Hi, @vinhms Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
vinhms
removed
the
DoNotMerge
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced Dec 11, 2020
DeMale
pushed a commit
to DeMale/azure-rest-api-specs
that referenced
this pull request
Dec 11, 2020
…#11428) * adding new restorable apis * fix some typos * fix validations * fix more validations * prettier * fix name and add apitype * fix casing * add custom word etcd * add mongodb * fix prameter name * fix validations * make read only * remove the word snapshot and make properties readonly * pretty * improved some descriptions * update description and removed mongodb content * fix container property name * fix documentcollection name * make query parameter optional * address Meha's comments * move restorable apis to separate file * move restorable database apis back to cosmos-db.json * remove point read apis * fix avocado
dabenhamMic
pushed a commit
to dabenhamMic/azure-rest-api-specs
that referenced
this pull request
Dec 14, 2020
…#11428) * adding new restorable apis * fix some typos * fix validations * fix more validations * prettier * fix name and add apitype * fix casing * add custom word etcd * add mongodb * fix prameter name * fix validations * make read only * remove the word snapshot and make properties readonly * pretty * improved some descriptions * update description and removed mongodb content * fix container property name * fix documentcollection name * make query parameter optional * address Meha's comments * move restorable apis to separate file * move restorable database apis back to cosmos-db.json * remove point read apis * fix avocado
giromm2ms
pushed a commit
to giromm2ms/azure-rest-api-specs
that referenced
this pull request
Dec 20, 2020
…#11428) * adding new restorable apis * fix some typos * fix validations * fix more validations * prettier * fix name and add apitype * fix casing * add custom word etcd * add mongodb * fix prameter name * fix validations * make read only * remove the word snapshot and make properties readonly * pretty * improved some descriptions * update description and removed mongodb content * fix container property name * fix documentcollection name * make query parameter optional * address Meha's comments * move restorable apis to separate file * move restorable database apis back to cosmos-db.json * remove point read apis * fix avocado
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.