Adding AddBillingRoleAssignment API in 2020-05-01 version #11023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 2, 2020 13:03
Adding AddBillingRoleAssignment API in 2020-05-01 version
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go
|
azure-sdk-for-java
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js
|
azure-sdk-for-net
|
azure-sdk-for-python
- Breaking Change detected in SDK
|
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Oct 2, 2020
markcowl
added
the
WaitForARMFeedback
|
@asarkar84 Since you are adding new API, this requires an ARM review. Also, per the braking changes guidelines, any API change requires an update in the api-version. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
@markcowl Sure, I have updated the version number. Thanks! |
majastrz
reviewed
Oct 3, 2020
| @@ -3460,6 +3460,150 @@ | |||
| } | |||
| } | |||
| }, | |||
| "/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/createBillingRoleAssignment": { | |||
There was a problem hiding this comment.
createBillingRoleAssignment [](start = 71, length = 27)
You are modifying an existing stable API version. As per https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md#versioning, this is not allowed and requires a version bump.
There was a problem hiding this comment.
We have added new apis to same version earlier in past 15 days: #10585
There was a problem hiding this comment.
Yeah I think I will allow it given that we've created an expectation that this is ok.
In reply to: 499105356 [](ancestors = 499105356)
There was a problem hiding this comment.
Thank you! @majastrz
majastrz
added
ARMChangesRequested
majastrz
reviewed
Oct 3, 2020
| } | ||
| } | ||
| }, | ||
| "/providers/Microsoft.Billing/billingAccounts/{billingAccountName}/billingProfiles/{billingProfileName}/invoiceSections/{invoiceSectionName}/createBillingRoleAssignment": { |
There was a problem hiding this comment.
createBillingRoleAssignment [](start = 145, length = 27)
Why are we modeling this as a POST instead of a proper resource with PUT and GET and list?
There was a problem hiding this comment.
The swagger already has the GET and List apis. We are currently adding an action to add the role assignments.
We have introduced this as POST since we rely on an external source to store the role assignments and they do not support PUT (they do not accept any user defined values as of now.) We tried some workarounds at our end to store it locally but it was not working with concurrent updates etc.
There was a problem hiding this comment.
That is the reason we did not publish this api along with other APIs. Our older version of API also has POST.
We were able to introduce PUT apis for other entities but this one could not be done. We tried our best.
majastrz
added
ARMSignedOff
|
@markcowl We got the ARM sign off. Please take a look and merge the PR if it looks good. Thanks! |
|
Added back the breaking changes review label since there's a disagreement regarding their involvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding AddBillingRoleAssignment API in 2020-05-01 version
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.