Updating readme for MySQL and PostgreSQL to include new flexible server namespace #10710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-resource-manager-schemas - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Sep 4, 2020
This was referenced Sep 4, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@qianwens |
…into moljain/flexServerSDK
…into moljain/flexServerSDK
|
No commit pushedDate could be found for PR 10710 in repo Azure/azure-rest-api-specs |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mjain2
changed the title
|
Azure Pipelines successfully started running 1 pipeline(s). |
changlong-liu
suggested changes
Sep 14, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
changlong-liu
approved these changes
Sep 14, 2020
ArcturusZhang
requested changes
Sep 14, 2020
Comment on lines
+27
to
+29
| rpname: mysql | ||
| namespace: mysqlflexibleservers | ||
| output-folder: $(go-sdk-folder)/services/preview/$(rpname)/mgmt/2020-07-01-preview/$(namespace) |
There was a problem hiding this comment.
I am not quite sure if we could add this new variable here... could we just hard code this rpname in? like this:
Suggested change
| rpname: mysql | |
| namespace: mysqlflexibleservers | |
| output-folder: $(go-sdk-folder)/services/preview/$(rpname)/mgmt/2020-07-01-preview/$(namespace) | |
| namespace: mysql | |
| output-folder: $(go-sdk-folder)/services/preview/mysql/mgmt/2020-07-01-preview/mysqlflexibleservers |
ArcturusZhang
approved these changes
Sep 14, 2020
nitegupt
pushed a commit
to nitegupt/azure-rest-api-specs
that referenced
this pull request
Sep 25, 2020
…er namespace (Azure#10710) * Updating readme files to include multi api capability and new namespace * Removing minor addition to cli.md * Revert Csharp changes since multiapi isn't used * Updating PythonSDK namespaces * Removing unnecessary batchapiscript from Python.md * Removing unnecessary package tags Co-authored-by: George Christoglou <gechris@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
This PR is to update MD files for azure.mgmt.rdbms namespace, which includes mysql and postgresql.
Overview of changes:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.