-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expressrouteportauthorization apis #10488
Closed
utbarn-ms
wants to merge
25
commits into
Azure:network-july-release
from
utbarn-ms:expressrouteportauthorization-apis
Closed
Expressrouteportauthorization apis #10488
utbarn-ms
wants to merge
25
commits into
Azure:network-july-release
from
utbarn-ms:expressrouteportauthorization-apis
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>
Co-authored-by: Mytri Ramanathpur Manjunath (MINDTREE LIMITED) <v-myrama@microsoft.com>
* commit 4691c2a Author: Rakesh Kumar <rakku@microsoft.com> Date: Wed Jan 29 17:46:01 2020 -0800 [AzureStack] User Subscription: rename NewSubscription to SubscriptionDefinition (Azure#8257) commit 9e551f0 Author: bganapa <bganapa@microsoft.com> Date: Tue Nov 12 11:44:22 2019 -0800 Reset to Stackadmin2 (Azure#7766) * Fix sub def in example * Address PR comments * Fix model validation error * Fix prettier issue
…ct (Azure#10447) * Add new extraProperties to workspaceinfo properties contract * make extra properties read only Co-authored-by: Prince Gupta <prigupt@microsoft.com>
* Fix issues * Fix
…view ManagedInstance swagger (Azure#10398) * Adding backupStorageRedundancy params to swagger * Fix for backupStorageRedundancy param mutability * Fix example response * Fix for x-ms-mutability for param * revert previous commit, since backupStorageRedundancy is valid only in PUT request Co-authored-by: Perica Trajkov <petrajko@microsoft.com>
* Adds base for updating Microsoft.MachineLearningServices from version preview/2020-05-15-preview to version 2020-09-01-preview * Updates readme * Updates API version in new specs and examples * add new codejob files * update readme with new json * update readme * use common shared type * prettier * move away from shared common type * fix machinelearningservices * use common type and change naming of codejobs * comments * fix examples * prettier * removve required nextlink * make status readonly and add required
1. Support to pass source id in Prepare/Move/Commit/Discard operations. 2. Define the additinal error information schema. 3. Expose the read only source settings. 4. Few fixes in marking the properties readonly/mandatory as appropriate. Co-authored-by: Harkirat Singh <hsingh@microsoft.com>
* Update pull_request_assignment.yml * Update issue_assignment.yml
…on stable/2020-07-01 (Azure#10320) * Fix swagger to add readonly for properties. * Adds base for updating Microsoft.AppPlatform from version preview/2019-05-01-preview to version 2020-07-01 * Updates readme * Updates API version in new specs and examples * Add new stable API version 2020-07-01. * Fix warnings. * Fix Prettier Check. * Fix Prettier Check. * Add multi-api entries in code generation config * Update package tag name * update python namespace * Update specification/appplatform/resource-manager/readme.go.md Remove "perview" term in output path. Co-authored-by: Arcturus <ufo54153@gmail.com> Co-authored-by: Yuwei Zhou <yuwzho@microsoft.com> Co-authored-by: Arcturus <ufo54153@gmail.com>
* Add api-version 2019-07-01-preview of redis to go SDK * Move the packages to preview sub-directory
utbarn-ms
requested review from
ahamad-MS,
ankushbindlish2,
atpham256,
blueww,
dkulkarni-ms and
giakas
as code owners
August 17, 2020 12:42
This was referenced Aug 17, 2020
[AutoPR dns] Expressrouteportauthorization apis
AzureSDKAutomation/azure-resource-manager-schemas#63
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.