-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.DocumentDB to add version stable/2020-04-01 #10430
[Hub Generated] Review request for Microsoft.DocumentDB to add version stable/2020-04-01 #10430
Conversation
Swagger pipeline restarted successfully, please wait for status update in this comment. |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-js
|
azure-sdk-for-java
|
azure-sdk-for-go
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python
|
Can one of the admins verify this patch? |
@markcowl Could you please review this PR? Thanks! |
specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2020-04-01/cosmos-db.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor comment.
@MehaKaushik Could you please answer my questions above? Thanks! |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas
|
@victor-meng This represents a breaking change in a stable API, per the information in PR comments, this will require approval from the API review board |
@markcowl Can you clarify what is breaking? This PR is to align the spec with the responses we are observing in production. |
@southpolesteve Anything checked into the master branch can be shipped as SDKs, so any breaking changes have to follow the breaking change policy that you checked off on above, or libraries shipped to customers will have breaking changes. |
@southpolesteve Here is a link to the breaking change readout: https://github.com/Azure/azure-rest-api-specs/pull/10430/checks?check_run_id=1156818293 |
@markcowl In this case I think the current swagger is incorrect. The type for |
@southpolesteve Please follow the breaking change process here: https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/43942/Policy-for-Breaking-Changes In this case, some languages may be allowing customers to send the correct data. IMO, we should fix the swagger to be correct in this case, but the api review board will make the decision. You will also need to clear the lintdiff error above, as shown in: https://aka.ms/ci-fix |
No pipelines are associated with this pull request. |
Closing this since @MehaKaushik is rolling the change into 2020-09-01 version |
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.