[Hub Generated] Review request for Microsoft.SecurityInsights to add version preview/2019-01-01-preview #10355

hassanchawiche · 2020-08-06T03:35:24Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2020-08-06T03:35:28Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-08-06T03:35:41Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-08-06T03:46:37Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-06T03:46:43Z

Azure CLI Extension Generation - Release

Installation instruction for service securityinsight [Preview Changes]
az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/10355/azure-cli-extensions/Azure/azure-cli-extensions/securityinsight/sentinel-0.1.0-py3-none-any.whl

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 8a0657c with merge commit 8a7b9db. Azure CLI Automation 13.0.17.20200619.4

[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'AwsCloudTrailDataConnectorDataTypes-logs' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-exchange' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'OfficeDataConnectorDataTypes-sharePoint' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'TIDataConnectorDataTypes-indicators' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ActionsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRuleTemplatesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AlertRulesList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BookmarkList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DataConnectorList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentCommentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'IncidentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OfficeConsentList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationsList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceWithEtag' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/PropertyRedeclarationWarning): Schema 'MCASDataConnectorDataTypes' has a property 'alerts' that is already declared the parent schema 'AlertsDataTypeOfDataConnector' but isn't significantly different. The property has been removed from MCASDataConnectorDataTypes
[AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
[AutoRest] 
[AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
[AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
[AutoRest] --------------------------------------------------------
[AutoRest]   test-scenario:
[AutoRest]     - name: /Actions/get/Get all actions of alert rule.
[AutoRest]     - name: /AlertRuleTemplates/get/Get alert rule template by Id.
[AutoRest]     - name: /AlertRuleTemplates/get/Get all alert rule templates.
[AutoRest]     - name: /AlertRules/put/Creates or updates a Fusion alert rule.
[AutoRest]     - name: /AlertRules/put/Creates or updates a MicrosoftSecurityIncidentCreation rule.
[AutoRest]     - name: /AlertRules/put/Creates or updates a Scheduled alert rule.
[AutoRest]     - name: /AlertRules/put/Creates or updates an action of alert rule.
[AutoRest]     - name: /AlertRules/get/Get a Fusion alert rule.
[AutoRest]     - name: /AlertRules/get/Get a MicrosoftSecurityIncidentCreation rule.
[AutoRest]     - name: /AlertRules/get/Get a Scheduled alert rule.
[AutoRest]     - name: /AlertRules/get/Get all alert rules.
[AutoRest]     - name: /AlertRules/get/Get an action of alert rule.
[AutoRest]     - name: /Bookmarks/put/Creates or updates a bookmark.
[AutoRest]     - name: /Bookmarks/get/Get a bookmark.
[AutoRest]     - name: /Bookmarks/get/Get all bookmarks.
[AutoRest]     - name: /DataConnectors/put/Creates or updates an Office365 data connector.
[AutoRest]     - name: /DataConnectors/get/Get a ASC data connector.
[AutoRest]     - name: /DataConnectors/get/Get a MCAS data connector.
[AutoRest]     - name: /DataConnectors/get/Get a MDATP data connector
[AutoRest]     - name: /DataConnectors/get/Get a TI data connector.
[AutoRest]     - name: /DataConnectors/get/Get all data connectors.
[AutoRest]     - name: /DataConnectors/get/Get an AAD data connector.
[AutoRest]     - name: /DataConnectors/get/Get an AATP data connector.
[AutoRest]     - name: /DataConnectors/get/Get an AwsCloudTrail data connector.
[AutoRest]     - name: /DataConnectors/get/Get an Office365 data connector.
[AutoRest]     - name: /IncidentComments/put/Creates an incident comment.
[AutoRest]     - name: /IncidentComments/get/Get all incident comments.
[AutoRest]     - name: /IncidentComments/get/Get an incident comment.
[AutoRest]     - name: /Incidents/put/Creates or updates an incident.
[AutoRest]     - name: /Incidents/get/Get all incidents.
[AutoRest]     - name: /Incidents/get/Get an incident.
[AutoRest]     - name: /AlertRules/delete/Delete an alert rule.
[AutoRest]     - name: /AlertRules/delete/Delete an action of alert rule.
[AutoRest]     - name: /Bookmarks/delete/Delete a bookmark.
[AutoRest]     - name: /DataConnectors/delete/Delete an Office365 data connector.
[AutoRest]     - name: /Incidents/delete/Delete an incident.
[AutoRest] --------------------------------------------------------

️✔️securityinsight [View full logs] [Release Azure CLI Changes]
- sentinel-0.1.0-py3-none-any.whl
- sentinel-0.1.0.zip

openapi-sdkautomation · 2020-08-06T03:47:32Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 8a0657c with merge commit 8a7b9db. SDK Automation 13.0.17.20200619.4
️✔️preview/securityinsight/mgmt/2019-01-01-preview [View full logs] [Release SDK Changes]
- preview.securityinsight.mgmt.2019-01-01-preview.zip
️✔️preview/securityinsight/mgmt/v1.0 [View full logs] [Release SDK Changes]
- preview.securityinsight.mgmt.v1.0.zip

openapi-sdkautomation · 2020-08-06T03:48:07Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 8a0657c with merge commit 8a7b9db. SDK Automation 13.0.17.20200619.4

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.SecurityInsights [View full logs] [Release SDK Changes]
No Artifact Generated.

openapi-sdkautomation · 2020-08-06T03:48:08Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 8a0657c with merge commit 8a7b9db. SDK Automation 13.0.17.20200619.4
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-08-06T03:48:51Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 8a0657c with merge commit 8a7b9db. SDK Automation 13.0.17.20200619.4
```
[azure-mgmt-securityinsight][ChangeLog] WARNING: Failed to generate ChangeLog.
```

⚠️azure-mgmt-securityinsight [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-securityinsight
[build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-securityinsight
[build_conf] INFO:packaging_tools:Template done azure-mgmt-securityinsight
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
Not exact 2 reports found:
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

openapi-sdkautomation · 2020-08-06T03:49:10Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azuresdkci · 2020-08-06T04:14:43Z

Can one of the admins verify this patch?

hassanchawiche · 2020-08-06T04:19:03Z

This PR is identical to https://github.com/Azure/azure-rest-api-specs-pr/pull/1770 where we had ARMSignedOff and Approved-OkToMerge

ruowan · 2020-08-06T05:00:25Z

Hi, Recently, we release a new version linter. So now it reported a new lint error, could you pls fix it?

azure-pipelines · 2020-08-06T16:31:51Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-08-06T16:35:50Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

hassanchawiche · 2020-08-06T16:48:27Z

Hi, Recently, we release a new version linter. So now it reported a new lint error, could you pls fix it?

I've fixed the lint error. Could you pls review the PR ?

Sentinel Watchlist : Added CRUD Operations

723ddb3

openapi-assignment-bot bot assigned ruowan Aug 6, 2020

hassanchawiche added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 6, 2020

Sentinel Watchlist : Added CRUD Operations

8a0657c

ruowan approved these changes Aug 7, 2020

View reviewed changes

ruowan merged commit 8a7b9db into Azure:master Aug 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.SecurityInsights to add version preview/2019-01-01-preview #10355

[Hub Generated] Review request for Microsoft.SecurityInsights to add version preview/2019-01-01-preview #10355

hassanchawiche commented Aug 6, 2020

openapi-pipeline-app bot commented Aug 6, 2020 •

edited

Loading

azure-pipelines bot commented Aug 6, 2020

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

azuresdkci commented Aug 6, 2020

hassanchawiche commented Aug 6, 2020 •

edited

Loading

ruowan commented Aug 6, 2020 •

edited

Loading

azure-pipelines bot commented Aug 6, 2020

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

hassanchawiche commented Aug 6, 2020

[Hub Generated] Review request for Microsoft.SecurityInsights to add version preview/2019-01-01-preview #10355

[Hub Generated] Review request for Microsoft.SecurityInsights to add version preview/2019-01-01-preview #10355

Conversation

hassanchawiche commented Aug 6, 2020

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Aug 6, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Aug 6, 2020

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

Trenton Generation - Release

azuresdkci commented Aug 6, 2020

hassanchawiche commented Aug 6, 2020 • edited Loading

ruowan commented Aug 6, 2020 • edited Loading

azure-pipelines bot commented Aug 6, 2020

openapi-sdkautomation bot commented Aug 6, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

hassanchawiche commented Aug 6, 2020

openapi-pipeline-app bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading

hassanchawiche commented Aug 6, 2020 •

edited

Loading

ruowan commented Aug 6, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 6, 2020 •

edited

Loading